Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r149274508
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java
---
@@ -552,16 +701,22 @@ public void clearParameters()
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r149229998
--- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java
---
@@ -54,7 +55,8 @@
void setQueryTimeout( int milliseconds )
---
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r149274342
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TimeoutTrigger.java ---
@@ -0,0 +1,87 @@
+/**
+ * Licensed to the Apache Software
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r149230118
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -98,6 +103,34 @@ private void throwIfClosed() throws
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r149228776
--- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java
---
@@ -34,11 +35,11 @@
*if connection is closed
*/
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r149273958
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java
---
@@ -201,31 +252,57 @@ public int getQueryTimeout() throws
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r149229229
--- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java
---
@@ -34,11 +35,11 @@
*if connection is closed
*/
Github user kkhatua closed the pull request at:
https://github.com/apache/drill/pull/858
---
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r124068854
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TimeoutTrigger.java ---
@@ -0,0 +1,105 @@
+/**
+ * Licensed to the Apache Software
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123913767
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -98,6 +102,32 @@ private void throwIfClosed() throws
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123872136
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TimeoutTrigger.java ---
@@ -0,0 +1,105 @@
+/**
+ * Licensed to the Apache Software
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123866213
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TimeoutTrigger.java ---
@@ -0,0 +1,105 @@
+/**
+ * Licensed to the Apache Software
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123866148
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -98,6 +102,32 @@ private void throwIfClosed() throws
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123866367
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TimeoutTrigger.java ---
@@ -0,0 +1,105 @@
+/**
+ * Licensed to the Apache Software
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123865940
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -38,8 +44,12 @@
// methods for compatibility.)
class
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123865572
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -64,13 +65,17 @@
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123865562
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -204,7 +276,7 @@ public boolean isClosed() {
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123865524
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -159,24 +230,25 @@ public void cleanUp() {
public int
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123865494
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -38,8 +44,12 @@
// methods for compatibility.)
class
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123865295
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -1384,7 +1402,7 @@ public void updateRowId( String columnLabel,
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123865256
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -125,7 +154,7 @@ protected void cancel() {
// (Not
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123331635
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -125,7 +154,7 @@ protected void cancel() {
// (Not
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123330684
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -422,6 +507,9 @@ public ResultSet getGeneratedKeys() throws
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123330075
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/SqlTimeoutException.java ---
@@ -23,12 +23,17 @@
* Indicates that an operation timed out.
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123329889
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -159,24 +230,25 @@ public void cleanUp() {
public int
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123329682
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -204,7 +276,7 @@ public boolean isClosed() {
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123329050
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -204,7 +276,7 @@ public boolean isClosed() {
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123329155
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -497,14 +594,64 @@ public boolean isPoolable() throws
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123327737
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -159,24 +230,25 @@ public void cleanUp() {
public int
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123327453
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -38,8 +44,12 @@
// methods for compatibility.)
class
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123325595
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -38,8 +44,12 @@
// methods for compatibility.)
class
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123325052
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/SqlTimeoutException.java ---
@@ -23,12 +23,17 @@
* Indicates that an operation timed out. This
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123324366
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -64,13 +65,17 @@
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123303854
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -422,6 +507,9 @@ public ResultSet getGeneratedKeys() throws
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123294533
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -497,14 +594,64 @@ public boolean isPoolable() throws
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123293533
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -204,7 +276,7 @@ public boolean isClosed() {
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123295947
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -125,7 +154,7 @@ protected void cancel() {
// (Not
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123295256
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -64,13 +65,17 @@
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123296355
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -1384,7 +1402,7 @@ public void updateRowId( String columnLabel,
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123292200
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/SqlTimeoutException.java ---
@@ -23,12 +23,17 @@
* Indicates that an operation timed out.
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123294241
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -38,8 +44,12 @@
// methods for compatibility.)
class
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123293197
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -159,24 +230,25 @@ public void cleanUp() {
public int
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/858
DRILL-3640: Support JDBC Statement.setQueryTimeout(int)
Allow for queries to be cancelled if they don't complete within the
stipulated time.
Tests added to test different query timeout
43 matches
Mail list logo
