Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/921
---
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r152361270
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/beans/RpcType.java ---
@@ -25,28 +25,8 @@
HANDSHAKE(0),
ACK(1),
Github user dvjyothsna commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r151246632
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/beans/RpcType.java ---
@@ -25,28 +25,8 @@
HANDSHAKE(0),
ACK(1),
Github user dvjyothsna commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r151201233
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java ---
@@ -165,32 +169,59 @@ public DrillbitContext getContext() {
Github user dvjyothsna commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r151201163
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java ---
@@ -165,32 +169,59 @@ public DrillbitContext getContext() {
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r15078
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java
---
@@ -315,7 +481,12 @@ public int compareTo(DrillbitInfo
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r151110780
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java
---
@@ -58,13 +63,170 @@
@Inject UserAuthEnabled
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r151110657
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java
---
@@ -58,13 +63,170 @@
@Inject UserAuthEnabled
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r15410
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -179,6 +184,98 @@
+
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r151003788
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitContext.java
---
@@ -157,10 +157,29 @@ public DrillConfig getConfig() {
Github user dvjyothsna commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150994906
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -57,19 +57,19 @@
Control Port
Data Port
Github user dvjyothsna commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150993718
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -57,19 +57,19 @@
Control Port
Data Port
Github user dvjyothsna commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150992676
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java ---
@@ -165,32 +169,59 @@ public DrillbitContext getContext() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150985739
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/beans/RpcType.java ---
@@ -25,28 +25,8 @@
HANDSHAKE(0),
ACK(1),
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150985401
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/TestGracefulShutdown.java ---
@@ -0,0 +1,248 @@
+/*
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150981136
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java ---
@@ -165,32 +169,59 @@ public DrillbitContext getContext() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150984396
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -471,6 +471,21 @@ public void close() throws Exception {
}
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150984962
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/TestGracefulShutdown.java ---
@@ -0,0 +1,248 @@
+/*
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150985212
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/TestGracefulShutdown.java ---
@@ -0,0 +1,248 @@
+/*
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150983985
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -78,6 +78,11 @@
${drillbit.getVersion()}
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150982788
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -368,6 +368,13 @@ drill.exec: {
// planning and managing queries. Primarily
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150976659
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitStateManager.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150975172
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitStateManager.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150979320
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
---
@@ -114,11 +117,12 @@
* @param context Bootstrap
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150978597
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java
---
@@ -58,13 +63,170 @@
@Inject UserAuthEnabled
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150977759
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java
---
@@ -58,13 +63,170 @@
@Inject UserAuthEnabled
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150973540
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -176,18 +200,37 @@ public void run() throws Exception {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150978981
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java
---
@@ -315,7 +481,12 @@ public int compareTo(DrillbitInfo
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150984759
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/TestGracefulShutdown.java ---
@@ -0,0 +1,248 @@
+/*
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150978095
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java
---
@@ -58,13 +63,170 @@
@Inject UserAuthEnabled
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150984249
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -471,6 +471,21 @@ public void close() throws Exception {
}
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150972227
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -77,6 +80,24 @@
private final WorkManager manager;
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150980131
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java ---
@@ -165,32 +169,59 @@ public DrillbitContext getContext() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150981324
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java ---
@@ -165,32 +169,59 @@ public DrillbitContext getContext() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150974512
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitContext.java
---
@@ -157,10 +157,29 @@ public DrillConfig getConfig() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150980543
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java ---
@@ -165,32 +169,59 @@ public DrillbitContext getContext() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150983656
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -57,19 +57,19 @@
Control Port
Data Port
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150978855
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java
---
@@ -58,13 +63,170 @@
@Inject UserAuthEnabled
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150974066
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitContext.java
---
@@ -157,10 +157,29 @@ public DrillConfig getConfig() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150972745
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -176,18 +200,37 @@ public void run() throws Exception {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150978228
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java
---
@@ -58,13 +63,170 @@
@Inject UserAuthEnabled
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150973864
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitContext.java
---
@@ -157,10 +157,29 @@ public DrillConfig getConfig() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150983939
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -78,6 +78,11 @@
${drillbit.getVersion()}
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150983296
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -57,19 +57,19 @@
Control Port
Data Port
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150984538
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/TestGracefulShutdown.java ---
@@ -0,0 +1,248 @@
+/*
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150975442
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitStateManager.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150975269
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitStateManager.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150972162
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -77,6 +80,24 @@
private final WorkManager manager;
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150971745
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -200,11 +206,50 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150972546
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -135,8 +157,9 @@ public Drillbit(
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150974323
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitContext.java
---
@@ -157,10 +157,29 @@ public DrillConfig getConfig() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150971276
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -200,11 +206,50 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150971910
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -229,27 +275,42 @@ public DrillbitEndpoint
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150047464
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -348,6 +354,21 @@ public void run() {
*/
}
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r149542196
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -348,6 +354,21 @@ public void run() {
*/
}
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r149541807
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitStateManager.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r149544267
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/TestGracefulShutdown.java ---
@@ -0,0 +1,323 @@
+/*
+ * Licensed to the Apache
Github user dvjyothsna commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r149186970
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/TestGracefulShutdown.java ---
@@ -0,0 +1,323 @@
+/*
+ * Licensed to the Apache
Github user dvjyothsna commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r149186401
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -348,6 +354,21 @@ public void run() {
*/
}
Github user dvjyothsna commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r149185238
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitStateManager.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148868884
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java ---
@@ -165,32 +176,60 @@ public DrillbitContext getContext() {
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148871345
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -251,6 +252,11 @@ public void run() {
final String
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148872536
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -471,6 +471,22 @@ public void close() throws Exception {
}
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148684246
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -70,7 +72,10 @@
private final
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148173100
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -70,7 +72,10 @@
private final
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148682043
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -229,27 +272,52 @@ public DrillbitEndpoint
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148872381
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -348,6 +354,21 @@ public void run() {
*/
}
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148682167
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -229,27 +272,52 @@ public DrillbitEndpoint
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148872633
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -471,6 +471,22 @@ public void close() throws Exception {
}
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148861255
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitStateManager.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148668138
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -229,27 +272,52 @@ public DrillbitEndpoint
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148674083
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/ClusterCoordinator.java
---
@@ -60,7 +61,26 @@
*/
public abstract
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148874640
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/TestGracefulShutdown.java ---
@@ -0,0 +1,323 @@
+/*
+ * Licensed to the Apache
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148171637
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/local/LocalClusterCoordinator.java
---
@@ -85,13 +88,62 @@ public void
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148676672
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -200,11 +206,47 @@ public void
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148686859
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -69,14 +73,30 @@
public final static String
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148685835
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -229,27 +272,52 @@ public DrillbitEndpoint
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148669660
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -229,27 +272,52 @@ public DrillbitEndpoint
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r141981097
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -200,11 +206,47 @@ public void
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r141980790
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/local/LocalClusterCoordinator.java
---
@@ -85,13 +88,62 @@ public void
GitHub user dvjyothsna opened a pull request:
https://github.com/apache/drill/pull/921
DRILL-4286 Graceful shutdown of drillbit
Following is the design document
https://docs.google.com/document/d/1AauIwVCjsBKBSbbU6sQODErrEp7n3IwniMtgK4m09MQ/edit#heading=h.224lbmcaxu2d.
I
81 matches
Mail list logo
