[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-415220804 @arina-ielchiieva @sohami thanks for the detail catch, done. This is an automated

[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-414913778 @arina-ielchiieva done This is an automated message from the Apache Git Service. To

[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-414051224 Thanks for your effort to review this PR @amansinha100 @sohami . It has been rebased onto the master and squashed into one commit.

[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-413782958 @sohami tests have passed by removing the Kind.Integer from the OptionValue. Still keep the `IntegerValidator` to validate the number which should be

[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-413099526 @sohami @parthchandra thanks for the help. I have addressed the comments according to your branch. Btw, I suggest the SV2's `batchActualRecordCount`

[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-412817095 @sohami Since we move the filter logic from `ScanBatch` into the `RuntimeFilterRecordBatch` , I refactor the `RuntimeFilterManager` to move the JPPD

[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-412321059 @sohami this commit has added a `RuntimeFilterRecordBath` to replace the related work of the `ScanBatch`. Please review, thanks.

[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-411604543 ScanBatch’s discussion is on JIRA,please see that @sohami. This is an automated

[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-411444653 @sohami I have changed the logic to generate SV2 in the ScanBatch. It is comparatively easy now. Initially, I worried about the performance of

[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-409220807 @amansinha100 The following JIRAs: DRILL-6573 ,DRILL-6572 would solve what we identified before . @sohami 's comments have been addressed.

[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-408674169 @amansinha100 please review the changes made according to your advices. This is an

[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-408599354 To the cleanup point, I currently think there's no problem. Once the query was canceled, the foreman or the drillbit will run out , the in-flight

[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-407627190 @amansinha100 thanks for your valuable review. Since being on vacation , others will be commented and updated later.

[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-406601421 ping @amansinha100 This is an automated message from the Apache Git Service. To

[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-403284219 @amansinha100 RuntimeFilterManager has changed to support the left deep tree case which you mentioned at the JIRA. Also please see the JRIA reply and

[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-401686350 @amansinha100 The scan node's memory copy logic has removed. Thanks for the knowledge of

[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-401230814 ping @amansinha100 @parthchandra or someone else would be pleased to review this PR.