Re: License Header FYI

pache.org> Sent: Wednesday, April 18, 2018 3:54:36 PM To: dev Subject: Re: License Header FYI mvn license:format (not man license:format ) seems to not do anything. On Wed, Apr 18, 2018 at 3:53 PM, Parth Chandra <par...@apache.org> wrote: man license:format does not seem t be doing anyth

Re: License Header FYI

license.skip=false >>> >>> When I removed the license header on Drillbit.java it was added back >>> again. >>> >>> >>> >>> ____ >>> From: Parth Chandra <par...@apache.org> >>> Sent: Wednesday, April 18, 2018 3:54:3

Re: License Header FYI

emoved the license header on Drillbit.java it was added back again. From: Parth Chandra <par...@apache.org> Sent: Wednesday, April 18, 2018 3:54:36 PM To: dev Subject: Re: License Header FYI mvn license:format (not man license:format ) seems to not do anyth

Re: License Header FYI

> > When I removed the license header on Drillbit.java it was added back again. > > > > > From: Parth Chandra <par...@apache.org> > Sent: Wednesday, April 18, 2018 3:54:36 PM > To: dev > Subject: Re: License Header FYI > > m

Re: License Header FYI

; Sent: Wednesday, April 18, 2018 3:54:36 PM To: dev Subject: Re: License Header FYI mvn license:format (not man license:format ) seems to not do anything. On Wed, Apr 18, 2018 at 3:53 PM, Parth Chandra <par...@apache.org> wrote: > man license:format does not seem t be doing anything. >

Re: License Header FYI

mvn license:format (not man license:format ) seems to not do anything. On Wed, Apr 18, 2018 at 3:53 PM, Parth Chandra wrote: > man license:format does not seem t be doing anything. > Also, IMO it would be a good idea to enable rat checks by default. At the > very least we

Re: License Header FYI

man license:format does not seem t be doing anything. Also, IMO it would be a good idea to enable rat checks by default. At the very least we need to make sure that the license headers are there before we check anything in. On Tue, Apr 17, 2018 at 1:41 PM, Timothy Farkas wrote:

Re: License Header FYI

Yes, until https://github.com/apache/drill/pull/1215 is merged in. On Wed, Apr 18, 2018 at 8:51 AM, Abhishek Girish wrote: > Hey Tim, > > I tried building master and encountered an error: > > mvn clean install -U -Pmapr -Drat.skip=false -Dlicense.skip=false > > ... > >

Re: License Header FYI

Hey Tim, I tried building master and encountered an error: mvn clean install -U -Pmapr -Drat.skip=false -Dlicense.skip=false ... [ERROR] Failed to execute goal com.mycila:license-maven-plugin:3.0:check > (default) on project drill-root: Some files do not have the expected > license header ->

License Header FYI

Hi All, Recently the license formatting checks have become stricter and all the license headers have been reformatted. The main benefit from this is that it is no longer allowed to have license headers in java doc comments. This will help keep our javadocs clean when we publish them. By