Re: Review Request 28496: DRILL-1779: Add unix_timestamp function

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28496/ --- (Updated Dec. 4, 2014, 8:08 p.m.) Review request for drill and Mehant Baid. R

Re: Review Request 28496: DRILL-1779: Add unix_timestamp function

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28496/ --- (Updated Dec. 4, 2014, 8:07 p.m.) Review request for drill and Mehant Baid. C

Re: Review Request 28496: DRILL-1779: Add unix_timestamp function

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28496/#review63780 --- Ship it! Looks good. - Mehant Baid On Dec. 3, 2014, 11:17 p.m.,

Re: Review Request 28496: DRILL-1779: Add unix_timestamp function

> On Dec. 4, 2014, 12:14 a.m., Kannan Rajah wrote: > > exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewDateFunctions.java, > > line 25 > > > > > > Just curious as to why you switched to this new testB

Re: Review Request 28496: DRILL-1779: Add unix_timestamp function

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28496/ --- (Updated Dec. 3, 2014, 11:17 p.m.) Review request for drill and Mehant Baid.

Re: Review Request 28496: DRILL-1779: Add unix_timestamp function

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28496/#review63782 --- exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewD

Re: Review Request 28496: DRILL-1779: Add unix_timestamp function

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28496/#review63799 --- exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewD

Re: Review Request 28496: DRILL-1779: Add unix_timestamp function

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28496/#review63705 --- exec/java-exec/src/test/resources/functions/date/to_unixtimestamp_f

Re: Review Request 28496: DRILL-1779: Add unix_timestamp function

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28496/#review63485 --- Ship it! exec/java-exec/src/main/java/org/apache/drill/exec/expr/f

Re: Review Request 28496: DRILL-1779: Add unix_timestamp function

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28496/ --- (Updated Dec. 2, 2014, 1:56 a.m.) Review request for drill and Mehant Baid. C

Re: Review Request 28496: DRILL-1779: Add unix_timestamp function

> On Nov. 29, 2014, 2:58 a.m., Kannan Rajah wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java, > > line 489 > > > > > > Can we not just use the queryStartDate instead of

Re: Review Request 28496: DRILL-1779: Add unix_timestamp function

> On Nov. 29, 2014, 2:58 a.m., Kannan Rajah wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java, > > line 484 > > > > > > Why we do need to create formatter when it is not

Re: Review Request 28496: DRILL-1779: Add unix_timestamp function

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28496/#review63276 --- exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/Dat

Re: Review Request 28496: DRILL-1779: Add unix_timestamp function

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28496/ --- (Updated Nov. 27, 2014, 8:16 a.m.) Review request for drill and Mehant Baid.

Re: Review Request 28496: DRILL-1779: Add unix_timestamp function

> On Nov. 27, 2014, 4:11 a.m., Mehant Baid wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java, > > line 490 > > > > > > Why are you dividing the milli second value by 100