Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/701#discussion_r102921207
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
---
@@ -140,27 +142,39 @@ public void
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/701#discussion_r102920945
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java
---
@@ -50,13 +47,56 @@
private
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/701#discussion_r102919942
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
---
@@ -260,76 +293,101 @@ public
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/701#discussion_r102920190
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
---
@@ -260,76 +293,101 @@ public
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/701#discussion_r102921712
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
---
@@ -260,76 +293,101 @@ public
GitHub user arina-ielchiieva opened a pull request:
https://github.com/apache/drill/pull/759
DRILL-5255: Remove default temporary workspace check at drillbit starâ¦
â¦t up
Check if default temporary workspace is valid (exists, file-based and
writable) will be performed
GitHub user arina-ielchiieva opened a pull request:
https://github.com/apache/drill/pull/760
DRILL-5274: Exception thrown in Drillbit shutdown in UDF cleanup code
You can merge this pull request into a Git repository by running:
$ git pull
Hi Jinfeng,
please also consider the following Jiras (PR are already open):
* DRILL-4963: Issues when overloading Drill native functions with dynamic
UDFs
* DRILL-5255: Remove default temporary workspace check at drillbit start up
* DRILL-5274: Exception thrown in Drillbit shutdown in UDF cleanup
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103004131
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -179,12 +207,47 @@ public String
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103005037
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -179,12 +207,47 @@ public String
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103000803
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -136,26 +240,60 @@ public String
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/753
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/750
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/754
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/760
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/741
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/759
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/762
Some of us rely on Lilith (SOCKET ref) to view "debug" logs while running
unit tests, any reason to change to "error" level?
---
If your project is set up for it, you can reply to this email
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/756
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/702
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/747
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/752#discussion_r103057839
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/BooleanGen.java
---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/752#discussion_r103057899
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockStorageEngine.java
---
@@ -89,14 +85,30 @@ public boolean supportsRead() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/752#discussion_r103058623
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/package-info.java
---
@@ -60,14 +62,26 @@
* The mode is one of the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/752#discussion_r103058784
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/interp/ExpressionInterpreterTest.java
---
@@ -124,7 +125,7 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r103060381
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/NNStatCountMergedStatistic.java
---
@@ -0,0 +1,98 @@
+/*
+
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/752#discussion_r103057873
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockGroupScanPOP.java
---
@@ -75,20 +76,50 @@
*/
private
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103062066
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -179,12 +207,47 @@ public String
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/752
Thanks for the change. LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103063332
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -35,6 +38,10 @@
public class
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103063526
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -49,58 +51,135 @@ public String getId() {
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/756
@paul-rogers Incorporated all changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
The Project Management Committee (PMC) for Apache Drill has invited Arina
Ielchiieva to become a committer, and we are pleased to announce that she
has accepted.
Arina has a long list of contributions [1] that have touched many aspects
of the product. Her work includes features such as dynamic
Congratulations Arina!
On Fri, Feb 24, 2017 at 9:06 AM, Sudheesh Katkam
wrote:
> The Project Management Committee (PMC) for Apache Drill has invited Arina
> Ielchiieva to become a committer, and we are pleased to announce that she
> has accepted.
>
> Arina has a long list
Congrats Arina!
On Fri, Feb 24, 2017 at 9:42 AM, Julian Hyde wrote:
> Congratulations, and welcome!
>
> On Fri, Feb 24, 2017 at 9:17 AM, Abhishek Girish
> wrote:
> > Congratulations Arina!
> >
> > On Fri, Feb 24, 2017 at 9:06 AM, Sudheesh Katkam
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/758#discussion_r103005063
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -1010,7 +1010,9 @@ public void addToEventQueue(final QueryState
Congratulations, and welcome!
On Fri, Feb 24, 2017 at 9:17 AM, Abhishek Girish wrote:
> Congratulations Arina!
>
> On Fri, Feb 24, 2017 at 9:06 AM, Sudheesh Katkam
> wrote:
>
>> The Project Management Committee (PMC) for Apache Drill has invited Arina
>>
Congratulations, Arina!
From: rahul challapalli
Sent: Friday, February 24, 2017 9:48 AM
To: dev
Subject: Re: [ANNOUNCE] New Committer: Arina Ielchiieva
Congrats Arina!
On Fri, Feb 24, 2017 at 9:42 AM, Julian Hyde
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103003954
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -179,12 +207,47 @@ public String
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103003252
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -136,26 +240,60 @@ public String
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103004451
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -179,12 +207,47 @@ public String
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103004338
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -179,12 +207,47 @@ public String
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103003378
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -136,26 +240,60 @@ public String
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103000425
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -136,26 +240,60 @@ public String
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103004559
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -179,12 +207,47 @@ public String
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103000211
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -35,6 +38,10 @@
public class
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103004076
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -179,12 +207,47 @@ public String
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103000873
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -136,26 +240,60 @@ public String
Github user gparai commented on the issue:
https://github.com/apache/drill/pull/741
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103032276
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -179,12 +207,47 @@ public String
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/762
DRILL-5114: Rationalize use of Logback logging in unit tests
Renamed logback.xml file used for testing to logback-test.xml as per
the Logback documentation. Made logging less detailed in the
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103028479
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -179,12 +207,47 @@ public String
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/761
DRILL-5284: Roll-up of final fixes for managed sort
See subtasks for details.
* Provide detailed, accurate estimate of size consumed by a record batch
* Managed external sort spills
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103030867
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -136,26 +240,60 @@ public String getContent() {
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/753
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/738
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/754
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/759
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/750
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/702
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/578
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/756
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/751
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/741
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/747
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/DRILL-5088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sudheesh Katkam resolved DRILL-5088.
Resolution: Fixed
Fix Version/s: 1.10.0
Fixed in
Chunhui Shi created DRILL-5297:
--
Summary: Print the plan text when plan pattern check fails in unit
tests
Key: DRILL-5297
URL: https://issues.apache.org/jira/browse/DRILL-5297
Project: Apache Drill
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/761#discussion_r103067062
--- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java
---
@@ -238,6 +238,25 @@ public boolean copyFromSafe(int fromIndex, int
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/761#discussion_r103068736
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -948,50 +1027,50 @@ private void
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/761#discussion_r103069029
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -948,50 +1027,50 @@ private void
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/761#discussion_r103066042
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/SpillSet.java
---
@@ -357,9 +393,13 @@ public SpillSet(FragmentContext
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/761#discussion_r103068095
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -765,12 +838,12 @@ private void
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/753
Apart from fixing regex in ProfileParser.java, changes looks good to me.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r103052237
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -138,9 +414,208 @@ public long getMetric(int id) {
}
}
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r103052249
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -138,9 +414,208 @@ public long getMetric(int id) {
}
}
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r103053243
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -179,12 +207,47 @@ public String
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/763
DRILL-5208: Finding path to java executable should be deterministic
See DRILL-5208 for background. Instead of using âfindâ to locate the
java command, we use the any information
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/756
@paul-rogers
Incorporated most changes... except:
https://github.com/apache/drill/pull/756#discussion_r103000211
https://github.com/apache/drill/pull/756#discussion_r103005037
---
If
78 matches
Mail list logo