[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111694492 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/ClientAuthenticatorProvider.java --- @@ -101,4 +101,12 @@ public void close()

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111653841 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/AbstractRemoteConnection.java --- @@ -224,4 +237,67 @@ public void close() { } }

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111652686 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/AbstractRemoteConnection.java --- @@ -224,4 +237,67 @@ public void close() { } }

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111646265 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ConnectionConfig.java --- @@ -21,7 +21,7 @@ import

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111647365 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java --- @@ -135,20 +137,33 @@ public void submitQuery(UserResultsListener

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111646237 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BitConnectionConfig.java --- @@ -46,16 +47,40 @@ protected

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111646955 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationOutcomeListener.java --- @@ -243,4 +247,43 @@ public SaslMessage

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111646424 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlConnectionConfig.java --- @@ -30,6 +33,14 @@ private final

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111651798 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/AbstractRemoteConnection.java --- @@ -224,4 +237,67 @@ public void close() { } }

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111676760 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java --- @@ -335,8 +350,27 @@ public BitToUserHandshake

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111651753 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/SaslBackendWrapper.java --- @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111645872 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/BitConnectionConfig.java --- @@ -46,16 +47,40 @@ protected

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111676608 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java --- @@ -335,8 +350,27 @@ public BitToUserHandshake

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111646493 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationOutcomeListener.java --- @@ -243,4 +247,43 @@ public SaslMessage

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111645862 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/AbstractServerConnection.java --- @@ -110,7 +130,31 @@ public void changeHandlerTo(final

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111694626 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/ServerAuthenticationHandler.java --- @@ -208,8 +207,12 @@ void

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111649193 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/SaslDecryptionHandler.java --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111713766 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/ClientAuthenticatorProvider.java --- @@ -101,4 +101,12 @@ public void close()

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111713801 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/ServerAuthenticationHandler.java --- @@ -208,8 +207,12 @@ void

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111648680 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java --- @@ -61,6 +63,10 @@ public ClusterInfo getClusterInfoJSON() {

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111647100 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/ServerAuthenticationHandler.java --- @@ -251,25 +256,62 @@ void

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111646353 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/ConnectionConfig.java --- @@ -31,4 +31,11 @@ AuthenticatorProvider

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111648824 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/RpcConstants.java --- @@ -22,6 +22,15 @@ private RpcConstants(){} - public

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111645820 --- Diff: common/src/main/java/org/apache/drill/common/config/DrillProperties.java --- @@ -59,6 +60,12 @@ public static final String KEYTAB =

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111710374 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserConnectionConfig.java --- @@ -34,32 +39,81 @@ private final

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111646441 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationOutcomeListener.java --- @@ -120,19 +121,22 @@ public void

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111645849 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -116,6 +116,11 @@ String BIT_AUTHENTICATION_ENABLED =

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111647020 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/SaslProperties.java --- @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111651842 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/security/UserAuthenticatorFactory.java --- @@ -46,6 +46,12 @@ */ public

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111676624 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java --- @@ -335,8 +350,27 @@ public BitToUserHandshake

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111647207 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/kerberos/KerberosFactory.java --- @@ -93,6 +94,7 @@ public UserGroupInformation

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111676528 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/SaslProperties.java --- @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111647280 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java --- @@ -135,20 +137,33 @@ public void submitQuery(UserResultsListener

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111647054 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/SaslProperties.java --- @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111646590 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationOutcomeListener.java --- @@ -243,4 +247,43 @@ public SaslMessage

[GitHub] drill pull request #773: DRILL-4335: Apache Drill should support network enc...

2017-04-17 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/773#discussion_r111713955 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserConnectionConfig.java --- @@ -34,32 +39,81 @@ private final

[HANGOUT] Topics for 04/18/17

2017-04-17 Thread Sudheesh Katkam
Hi drillers, Our bi-weekly hangout is tomorrow (04/18/17, 10 AM PT). If you have any suggestions for hangout topics, you can add them to this thread. We will also ask around at the beginning of the hangout for topics. Hangout link:

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

2017-04-17 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r111867303 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetSchema.java --- @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

2017-04-17 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r111865502 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/DirectRowSet.java --- @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

2017-04-17 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r111865822 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/DirectRowSet.java --- @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

2017-04-17 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r111867385 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetSchema.java --- @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

2017-04-17 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r111868661 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/SchemaBuilder.java --- @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

2017-04-17 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r111867499 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetSchema.java --- @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

2017-04-17 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r111867555 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetSchema.java --- @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

2017-04-17 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r111865207 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/DirectRowSet.java --- @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

2017-04-17 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r111865581 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/DirectRowSet.java --- @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

2017-04-17 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/785#discussion_r111867056 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetBuilder.java --- @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #788: DRILL-5318: Sub-operator test fixture

2017-04-17 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/788#discussion_r111871234 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ConfigBuilder.java --- @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software

[jira] [Created] (DRILL-5437) Ansi format date/time functions fail when escaping double quotes

2017-04-17 Thread Krystal (JIRA)
Krystal created DRILL-5437: -- Summary: Ansi format date/time functions fail when escaping double quotes Key: DRILL-5437 URL: https://issues.apache.org/jira/browse/DRILL-5437 Project: Apache Drill

[jira] [Created] (DRILL-5438) Amazon S3 bucket can't be queried directly at root

2017-04-17 Thread Alon P (JIRA)
Alon P created DRILL-5438: - Summary: Amazon S3 bucket can't be queried directly at root Key: DRILL-5438 URL: https://issues.apache.org/jira/browse/DRILL-5438 Project: Apache Drill Issue Type: Bug

[GitHub] drill issue #783: DRILL-5324: Provide simplified column reader/writer for te...

2017-04-17 Thread amansinha100
Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/783 This PR combines the main changes for simplified column readers/writers with the code cleanup/hygiene changes which made it harder to review. For future, please separate the hygiene changes

[GitHub] drill pull request #783: DRILL-5324: Provide simplified column reader/writer...

2017-04-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/783 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Created] (DRILL-5439) For Kerberos, Support "_host" replacement in "principal" Connection Parameter

2017-04-17 Thread Sudheesh Katkam (JIRA)
Sudheesh Katkam created DRILL-5439: -- Summary: For Kerberos, Support "_host" replacement in "principal" Connection Parameter Key: DRILL-5439 URL: https://issues.apache.org/jira/browse/DRILL-5439

[jira] [Resolved] (DRILL-5433) Authentication failed: Server requires authentication using [kerberos, plain]

2017-04-17 Thread Sudheesh Katkam (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-5433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudheesh Katkam resolved DRILL-5433. Resolution: Not A Problem Fix Version/s: (was: 1.10.0) Closing as "not a