GitHub user arina-ielchiieva opened a pull request:
https://github.com/apache/drill/pull/843
DRILL-5533: Fix flag assignment in FunctionInitializer.checkInit() method
Changes:
1. Fixed DCL in FunctionInitializer.checkInit() method (update flag
parameter when function body is
Arina Ielchiieva created DRILL-5533:
---
Summary: Fix flag assignment in FunctionInitializer.checkInit()
method
Key: DRILL-5533
URL: https://issues.apache.org/jira/browse/DRILL-5533
Project: Apache
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/843#discussion_r118025364
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/ImportGrabber.java
---
@@ -63,9 +62,21 @@ public void
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/843#discussion_r118021745
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionInitializer.java
---
@@ -74,41 +70,43 @@ public String getClassName() {
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/843#discussion_r118021635
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionInitializer.java
---
@@ -31,29 +31,25 @@
import
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/843#discussion_r118022413
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionInitializer.java
---
@@ -119,33 +117,35 @@ private void checkInit() {
Github user eskabetxe commented on the issue:
https://github.com/apache/drill/pull/828
attached
[error.txt](https://github.com/apache/drill/files/1023007/error.txt)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user eskabetxe commented on the issue:
https://github.com/apache/drill/pull/828
`java.lang.IllegalStateException:
com.fasterxml.jackson.databind.JsonMappingException: Could not resolve type id
'maprdb' into a subtype of [simple type, class
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/838
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Rahul Challapalli created DRILL-5534:
Summary: convert_from on a json map with null value produces an NPE
Key: DRILL-5534
URL: https://issues.apache.org/jira/browse/DRILL-5534
Project: Apache
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/822#discussion_r118103592
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -86,6 +92,19 @@
BooleanValidator
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/822#discussion_r118103777
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -86,6 +92,19 @@
BooleanValidator
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/831
It seems to me that others (Ted, Charles) also contributed to this. Would
be nice if the PR acknowledged their contribution.
Also, we should document limitations and what is not (yet)
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/831#discussion_r118108814
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapRecordReader.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/831#discussion_r118107316
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/decoder/Packet.java
---
@@ -0,0 +1,371 @@
+/*
+ * Licensed to the
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/831#discussion_r118097440
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/dto/ColumnDto.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/831#discussion_r118098082
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/pcap/TestPcapDecoder.java
---
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/829#discussion_r117881390
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/AbstractDrillLoginService.java
---
@@ -37,30 +33,10 @@
protected
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/829#discussion_r117882771
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebUserConnection.java
---
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/829#discussion_r118037792
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebUserConnection.java
---
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/829#discussion_r118033483
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/AbstractUserClientConnectionWrapper.java
---
@@ -0,0 +1,101 @@
+/*
+ *
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/829#discussion_r117880322
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java
---
@@ -68,36 +53,49 @@ public String getQueryType() {
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/829#discussion_r117879708
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/UserClientConnection.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/829#discussion_r117879636
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/AbstractUserClientConnectionWrapper.java
---
@@ -0,0 +1,101 @@
+/*
+ *
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/829#discussion_r117883022
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebUserConnection.java
---
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/829#discussion_r117879845
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRestServer.java
---
@@ -91,13 +102,140 @@ protected void configure() {
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/829#discussion_r118057123
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
---
@@ -219,12 +232,43 @@ public void
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/829#discussion_r118035903
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRestServer.java
---
@@ -91,13 +102,140 @@ protected void configure() {
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/829#discussion_r118055934
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/prepare/PreparedStatementProvider.java
---
@@ -59,20 +43,29 @@
import
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/829#discussion_r117880230
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java
---
@@ -68,36 +53,49 @@ public String getQueryType() {
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/829#discussion_r118098241
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebUserConnection.java
---
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/829#discussion_r117880975
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/AbstractUserClientConnectionWrapper.java
---
@@ -0,0 +1,101 @@
+/*
+ *
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/829#discussion_r117881581
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillUserPrincipal.java
---
@@ -18,43 +18,37 @@
package
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/831#discussion_r118109637
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/decoder/Murmur128.java
---
@@ -0,0 +1,161 @@
+/*
--- End diff --
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/831#discussion_r118102624
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/decoder/Packet.java
---
@@ -0,0 +1,371 @@
+/*
+ * Licensed to the
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/822#discussion_r118152042
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractBase.java
---
@@ -99,17 +100,31 @@ public void setCost(double cost) {
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/822#discussion_r118154367
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatch.java ---
@@ -188,6 +188,18 @@
NOT_YET,
/**
+
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/822#discussion_r118148905
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractBase.java
---
@@ -99,17 +100,31 @@ public void setCost(double cost) {
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/822#discussion_r118153400
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/ExternalSort.java
---
@@ -49,12 +49,19 @@ public int getOperatorType() {
39 matches
Mail list logo
