[GitHub] drill issue #1116: DRILL-6140: Correctly list Operators in Profiles Page

Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1116 @arina-ielchiieva please review ---

[GitHub] drill pull request #1108: DRILL-6130: Fix NPE during physical plan submissio...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1108#discussion_r166727342 --- Diff: contrib/storage-opentsdb/src/test/java/org/apache/drill/store/openTSDB/TestOpenTSDBPlugin.java --- @@ -175,9 +175,8 @@ public void

[GitHub] drill pull request #1108: DRILL-6130: Fix NPE during physical plan submissio...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1108#discussion_r166468585 --- Diff: contrib/storage-kudu/src/main/java/org/apache/drill/exec/store/kudu/KuduSubScan.java --- @@ -143,7 +133,7 @@ public String getTableName() {

RE: Test cases for Drill-6104: Added Logfile Reader

How about using the Drill logs as a use case? You have drillbit.out and drillbit_hostname.log to consume. It would be interesting to see how multiline log entries are handled. Logstash does an excellent job IMO, but that's more for parsing. -Original Message- From: Charles Givre

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r19844 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java --- @@ -507,5 +510,52 @@ public static boolean

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166683550 --- Diff: contrib/storage-hive/hive-exec-shade/pom.xml --- @@ -39,23 +39,28 @@ log4j - commons-codec

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166672700 --- Diff: contrib/storage-hive/hive-exec-shade/pom.xml --- @@ -39,23 +39,28 @@ log4j - commons-codec

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166650425 --- Diff: contrib/storage-hive/core/pom.xml --- @@ -58,6 +58,10 @@ commons-codec commons-codec +

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166651052 --- Diff: common/pom.xml --- @@ -45,6 +45,7 @@ org.apache.calcite calcite-core + ${calcite.version} --- End

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r10333 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java --- @@ -507,5 +510,52 @@ public static boolean

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r10444 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java --- @@ -507,5 +510,52 @@ public static boolean

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166651134 --- Diff: contrib/storage-hive/core/pom.xml --- @@ -101,6 +105,7 @@ org.apache.calcite calcite-core +

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166679633 --- Diff: contrib/storage-hive/hive-exec-shade/pom.xml --- @@ -39,23 +39,28 @@ log4j - commons-codec

[jira] [Created] (DRILL-6142) Operator Id and Types are not correctly marked in Minor fragments

Kunal Khatua created DRILL-6142: --- Summary: Operator Id and Types are not correctly marked in Minor fragments Key: DRILL-6142 URL: https://issues.apache.org/jira/browse/DRILL-6142 Project: Apache Drill

[jira] [Created] (DRILL-6143) Queries Fail Due To Aggressive RPC Timeout

Timothy Farkas created DRILL-6143: - Summary: Queries Fail Due To Aggressive RPC Timeout Key: DRILL-6143 URL: https://issues.apache.org/jira/browse/DRILL-6143 Project: Apache Drill Issue

RE: Test cases for Drill-6104: Added Logfile Reader

I think I'm jumping the gun, because I haven’t yet tried out your PR. But to explain why I mentioned LogStash is because the primary challenge (IMO) of creating a log file reader is that the format can be wildly different and there is no standard format. So, what is needed is a good mechanism

Re: Test cases for Drill-6104: Added Logfile Reader

Hi Kunal, As implemented it doesn’t do multiline logfiles. I wrote this for a specific client a while ago and it’s proven VERY useful so I thought I’d contribute it. I would like to get this in there and then add multiline capability. — C > On Feb 7, 2018, at 21:28, Kunal Khatua

Re: Test cases for Drill-6104: Added Logfile Reader

Awesome. I personally think that the only practical solution for multiline logging is mandatory sentencing guidelines at the federal level. On Wed, Feb 7, 2018 at 4:08 PM, Charles Givre wrote: > Hi Kunal, > As implemented it doesn’t do multiline logfiles. I wrote this for

Re: Test cases for Drill-6104: Added Logfile Reader

Hi Kunal, I just don’t know how to craft one with all the Drill internals. Is there an example that I you can point me to? > On Feb 7, 2018, at 18:38, Kunal Khatua wrote: > > How about using the Drill logs as a use case? > > You have drillbit.out and drillbit_hostname.log

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166838809 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java --- @@ -507,5 +512,49 @@ public static boolean

[jira] [Created] (DRILL-6144) Unit tests hang indefinitely

Timothy Farkas created DRILL-6144: - Summary: Unit tests hang indefinitely Key: DRILL-6144 URL: https://issues.apache.org/jira/browse/DRILL-6144 Project: Apache Drill Issue Type: Bug

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166832638 --- Diff: common/pom.xml --- @@ -45,6 +45,7 @@ org.apache.calcite calcite-core + ${calcite.version} --- End diff

[GitHub] drill pull request #1117: DRILL-6089 Removed ordering trait from HashJoin in...

GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/1117 DRILL-6089 Removed ordering trait from HashJoin in planner HashJoin typically does not preserve ordering in most databases. Drill's HashJoin operator technically preserved ordering up to this

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166832879 --- Diff: contrib/storage-hive/core/pom.xml --- @@ -58,6 +58,10 @@ commons-codec commons-codec +

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166842824 --- Diff: contrib/storage-hive/hive-exec-shade/pom.xml --- @@ -39,23 +39,28 @@ log4j - commons-codec

Test cases for Drill-6104: Added Logfile Reader

Hello all, I submitted this PR for a logfile parser for Drill (https://github.com/apache/drill/pull/1114 ) . I need to write unit tests for it, however I really have no idea how to do so. Could someone point me to an example or something so that