[GitHub] drill pull request #1162: DRILL-6005: Fixed TestGracefulShutdown tests to sk...

2018-03-13 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1162#discussion_r174035415 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -640,4 +640,6 @@ public static String bootDefaultFor(String

[jira] [Resolved] (DRILL-4333) tests in Drill2489CallsAfterCloseThrowExceptionsTest fail in Java 8

2018-03-13 Thread Arina Ielchiieva (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva resolved DRILL-4333. - Resolution: Fixed Fix Version/s: (was: Future) 1.13.0 >

[VOTE] Apache Drill release 1.13.0 - RC0

2018-03-13 Thread Parth Chandra
Hi all, I'd like to propose the first release candidate (RC0) of Apache Drill, version 1.13.0. The release candidate covers a total of 113 resolved JIRAs [1]. Thanks to everyone who contributed to this release. The tarball artifacts are hosted at [2] and the maven artifacts are hosted at [3].

[jira] [Resolved] (DRILL-6163) Switch Travis To Java 8

2018-03-13 Thread Arina Ielchiieva (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-6163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva resolved DRILL-6163. - Resolution: Fixed Fixed in dbc95a659c3325e263340f3ec2b913a048163671. > Switch Travis To

[jira] [Resolved] (DRILL-4329) 13 Unit tests are failing with JDK 8

2018-03-13 Thread Arina Ielchiieva (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva resolved DRILL-4329. - Resolution: Fixed Fix Version/s: (was: Future) 1.13.0 > 13

[GitHub] drill pull request #1158: DRILL-6145: Implement Hive MapR-DB JSON handler

2018-03-13 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1158#discussion_r174125821 --- Diff: distribution/pom.xml --- @@ -324,6 +324,14 @@ org.apache.hbase hbase-protocol + ---

[jira] [Created] (DRILL-6238) Batch sizing for operators

2018-03-13 Thread Padma Penumarthy (JIRA)
Padma Penumarthy created DRILL-6238: --- Summary: Batch sizing for operators Key: DRILL-6238 URL: https://issues.apache.org/jira/browse/DRILL-6238 Project: Apache Drill Issue Type: New

batch sizing for operators

2018-03-13 Thread Padma Penumarthy
I have written a small design document explaining the batch sizing work we are doing for operators (other than scan). https://issues.apache.org/jira/browse/DRILL-6238 Some of this work has already been done in 1.13. flatten, merge join and external sort are changed to adhere to batch size

[GitHub] drill pull request #1163: DRILL-6053 & DRILL-6237

2018-03-13 Thread vrozov
GitHub user vrozov opened a pull request: https://github.com/apache/drill/pull/1163 DRILL-6053 & DRILL-6237 - Avoid excessive locking in LocalPersistentStore - Upgrade checkstyle version to 5.9 or above @arina-ielchiieva Please review You can merge this pull request

[GitHub] drill pull request #1158: DRILL-6145: Implement Hive MapR-DB JSON handler

2018-03-13 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1158#discussion_r174285398 --- Diff: distribution/pom.xml --- @@ -324,6 +324,14 @@ org.apache.hbase hbase-protocol + --- End

[GitHub] drill pull request #1164: DRILL-6234: Improved documentation for VariableWid...

2018-03-13 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1164#discussion_r174348633 --- Diff: exec/vector/src/test/java/org/apache/drill/exec/vector/VariableLengthVectorTest.java --- @@ -0,0 +1,152 @@ +/** + * Licensed to the

[GitHub] drill pull request #1164: DRILL-6234: Improved documentation for VariableWid...

2018-03-13 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1164#discussion_r174349801 --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java --- @@ -514,6 +516,22 @@ public boolean isNull(int index){ * The

[GitHub] drill pull request #1164: DRILL-6234: Improved documentation for VariableWid...

2018-03-13 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1164#discussion_r174349826 --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java --- @@ -514,6 +516,22 @@ public boolean isNull(int index){ * The

[GitHub] drill pull request #1164: DRILL-6234: Improved documentation for VariableWid...

2018-03-13 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1164#discussion_r174343151 --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java --- @@ -514,6 +516,22 @@ public boolean isNull(int index){ * The

[GitHub] drill pull request #1164: DRILL-6234: Improved documentation for VariableWid...

2018-03-13 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1164#discussion_r174349707 --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java --- @@ -506,6 +506,8 @@ public boolean isNull(int index){ }

[GitHub] drill pull request #1164: DRILL-6234: Improved documentation for VariableWid...

2018-03-13 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1164#discussion_r174350127 --- Diff: exec/vector/src/test/java/org/apache/drill/exec/vector/VariableLengthVectorTest.java --- @@ -0,0 +1,152 @@ +/** + * Licensed to the

[GitHub] drill issue #1164: DRILL-6234: Improved documentation for VariableWidthVecto...

2018-03-13 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1164 @paul-rogers Applied review comments. ---

[GitHub] drill pull request #1164: DRILL-6234: Improved documentation for VariableWid...

2018-03-13 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1164#discussion_r174349888 --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java --- @@ -514,6 +516,22 @@ public boolean isNull(int index){ * The

[GitHub] drill pull request #1164: DRILL-6234: Improved documentation for VariableWid...

2018-03-13 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1164#discussion_r174349986 --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java --- @@ -514,6 +516,22 @@ public boolean isNull(int index){ * The

[jira] [Created] (DRILL-6240) Operator Overview should show estimated row counts

2018-03-13 Thread Kunal Khatua (JIRA)
Kunal Khatua created DRILL-6240: --- Summary: Operator Overview should show estimated row counts Key: DRILL-6240 URL: https://issues.apache.org/jira/browse/DRILL-6240 Project: Apache Drill Issue

[jira] [Created] (DRILL-6237) Upgrade checkstyle version to 5.9 or above

2018-03-13 Thread Vlad Rozov (JIRA)
Vlad Rozov created DRILL-6237: - Summary: Upgrade checkstyle version to 5.9 or above Key: DRILL-6237 URL: https://issues.apache.org/jira/browse/DRILL-6237 Project: Apache Drill Issue Type: Task

[jira] [Created] (DRILL-6239) Add Build and License Badges to README.md

2018-03-13 Thread Timothy Farkas (JIRA)
Timothy Farkas created DRILL-6239: - Summary: Add Build and License Badges to README.md Key: DRILL-6239 URL: https://issues.apache.org/jira/browse/DRILL-6239 Project: Apache Drill Issue Type:

[GitHub] drill pull request #1165: DRILL-6239: Add build and license badges to README...

2018-03-13 Thread ilooner
GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/1165 DRILL-6239: Add build and license badges to README.md Add nice build and license badges that everyone else has. See a preview of what they look like here:

[GitHub] drill issue #1165: DRILL-6239: Add build and license badges to README.md

2018-03-13 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1165 @arina-ielchiieva ---

[GitHub] drill pull request #1164: DRILL-6234: Improved documentation for VariableWid...

2018-03-13 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1164#discussion_r174328662 --- Diff: exec/vector/src/test/java/org/apache/drill/exec/vector/VariableLengthVectorTest.java --- @@ -0,0 +1,152 @@ +/** + * Licensed to the

[GitHub] drill pull request #1164: DRILL-6234: Improved documentation for VariableWid...

2018-03-13 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1164#discussion_r174327601 --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java --- @@ -514,6 +516,22 @@ public boolean isNull(int index){ * The

[GitHub] drill pull request #1164: DRILL-6234: Improved documentation for VariableWid...

2018-03-13 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1164#discussion_r174328361 --- Diff: exec/vector/src/test/java/org/apache/drill/exec/vector/VariableLengthVectorTest.java --- @@ -0,0 +1,152 @@ +/** + * Licensed to the

[GitHub] drill pull request #1164: DRILL-6234: Improved documentation for VariableWid...

2018-03-13 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1164#discussion_r174327511 --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java --- @@ -514,6 +516,22 @@ public boolean isNull(int index){ * The

[GitHub] drill pull request #1164: DRILL-6234: Improved documentation for VariableWid...

2018-03-13 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1164#discussion_r174327132 --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java --- @@ -514,6 +516,22 @@ public boolean isNull(int index){ * The

[GitHub] drill pull request #1164: DRILL-6234: Improved documentation for VariableWid...

2018-03-13 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1164#discussion_r174327182 --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java --- @@ -514,6 +516,22 @@ public boolean isNull(int index){ * The

[GitHub] drill pull request #1164: DRILL-6234: Improved documentation for VariableWid...

2018-03-13 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1164#discussion_r174327027 --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java --- @@ -506,6 +506,8 @@ public boolean isNull(int index){ }

[GitHub] drill pull request #1164: DRILL-6234: Improved documentation for VariableWid...

2018-03-13 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1164#discussion_r174328025 --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java --- @@ -514,6 +516,22 @@ public boolean isNull(int index){ * The

[GitHub] drill issue #1164: DRILL-6234: Improved documentation for VariableWidthVecto...

2018-03-13 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1164 @paul-rogers ---

[GitHub] drill pull request #1164: DRILL-6234: Improved documentation for VariableWid...

2018-03-13 Thread ilooner
GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/1164 DRILL-6234: Improved documentation for VariableWidthVector mutators I had some confusion about how setValueCount should behave for variable width vectors. I added some documentation and unit tests