[GitHub] drill issue #1227: DRILL-6236: batch sizing for hash join

Github user ppadma commented on the issue: https://github.com/apache/drill/pull/1227 @Ben-Zvi I manually added the PR link to the JIRA. all code review comments are addressed. can you look at the latest changes ? ---

[GitHub] drill pull request #1189: DRILL-6282: Update Drill's Metrics dependencies

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1189#discussion_r184218887 --- Diff: pom.xml --- @@ -1333,6 +1353,12 @@ + --- End diff -- I meant that it can be

[GitHub] drill pull request #1228: DRILL-6307: Handle empty batches in record batch s...

Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1228#discussion_r184236170 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -277,18 +286,29 @@ public boolean isRepeatedList() {

[GitHub] drill issue #1189: DRILL-6282: Update Drill's Metrics dependencies

Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1189 LGTM ---

[GitHub] drill pull request #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] cl...

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/1184#discussion_r184243856 --- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java --- @@ -509,15 +509,15 @@ public long getTwoAsLong(int index) { public

[GitHub] drill issue #1228: DRILL-6307: Handle empty batches in record batch sizer co...

Github user ppadma commented on the issue: https://github.com/apache/drill/pull/1228 @paul-rogers Paul, I addressed code review comments. Can you take a look when you get a chance ? ---

[jira] [Created] (DRILL-6356) batch sizing for union all

Padma Penumarthy created DRILL-6356: --- Summary: batch sizing for union all Key: DRILL-6356 URL: https://issues.apache.org/jira/browse/DRILL-6356 Project: Apache Drill Issue Type:

[GitHub] drill pull request #1228: DRILL-6307: Handle empty batches in record batch s...

Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1228#discussion_r184200281 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -277,18 +286,29 @@ public boolean isRepeatedList() {

[GitHub] drill pull request #1228: DRILL-6307: Handle empty batches in record batch s...

Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1228#discussion_r184202508 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -536,6 +556,11 @@ public ColumnSize getColumn(String name)

[GitHub] drill issue #1237: DRILL-6348: Fixed code so that Unordered Receiver reports...

Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1237 @vrozov, I have implemented the provided suggestions. ---

[GitHub] drill pull request #1144: DRILL-6202: Deprecate usage of IndexOutOfBoundsExc...

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/1144#discussion_r184242257 --- Diff: src/main/resources/checkstyle-config.xml --- @@ -30,10 +30,15 @@ + --- End diff -- So what do you

[GitHub] drill pull request #1189: DRILL-6282: Update Drill's Metrics dependencies

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1189#discussion_r184243564 --- Diff: logical/pom.xml --- @@ -85,14 +85,12 @@ - com.codahale.metrics + io.dropwizard.metrics --- End

[GitHub] drill issue #1238: DRILL-6281: Refactor TimedRunnable

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1238 I had the same question as Arina about the need for this change and I got info from DRILL-5908 about the problem cause and how this change will help fix it. Can you elucidate? ---

<    1   2