[GitHub] weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-07-29 Thread GitBox
weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r205965375 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/BloomFilterCreator.java ## @@ -0,0

[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

2018-07-29 Thread GitBox
weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-408674169 @amansinha100 please review the changes made according to your advices. This is an

[GitHub] weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-07-29 Thread GitBox
weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r204973201 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterManager.java ## @@ -0,0

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-07-29 Thread GitBox
amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r205982746 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/BloomFilterCreator.java ## @@ -0,0

[GitHub] vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField

2018-07-29 Thread GitBox
vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField URL: https://github.com/apache/drill/pull/1383#discussion_r205980707 ## File path: exec/vector/src/main/java/org/apache/drill/exec/record/MaterializedField.java ## @@ -49,39 +54,79

[GitHub] vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField

2018-07-29 Thread GitBox
vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField URL: https://github.com/apache/drill/pull/1383#discussion_r205980354 ## File path: exec/vector/src/main/java/org/apache/drill/exec/record/MaterializedField.java ## @@ -49,39 +54,79

[GitHub] vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField

2018-07-29 Thread GitBox
vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField URL: https://github.com/apache/drill/pull/1383#discussion_r205980599 ## File path: exec/vector/src/main/java/org/apache/drill/exec/record/MaterializedField.java ## @@ -49,39 +54,79

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-07-29 Thread GitBox
amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r205982764 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/BloomFilter.java ## @@ -0,0 +1,176

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-07-29 Thread GitBox
amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r205982971 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/BloomFilter.java ## @@ -0,0 +1,176

[GitHub] vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField

2018-07-29 Thread GitBox
vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField URL: https://github.com/apache/drill/pull/1383#discussion_r205980762 ## File path: exec/vector/src/main/java/org/apache/drill/exec/record/MaterializedField.java ## @@ -49,39 +54,79

[GitHub] sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-07-29 Thread GitBox
sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r205894386 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataRpcConfig.java ## @@ -42,6 +43,7 @@

[GitHub] sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-07-29 Thread GitBox
sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r205962087 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/BloomFilterCreator.java ## @@ -0,0 +1,41

[GitHub] sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-07-29 Thread GitBox
sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r205962033 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/BloomFilter.java ## @@ -0,0 +1,176 @@

[GitHub] sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-07-29 Thread GitBox
sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r205905500 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/RuntimeFilterRequestHandler.java ## @@ -0,0

[GitHub] sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-07-29 Thread GitBox
sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r204136170 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataServerRequestHandler.java ## @@ -44,14

[GitHub] sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-07-29 Thread GitBox
sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r205962243 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterReporter.java ## @@ -0,0

[GitHub] sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-07-29 Thread GitBox
sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r205962226 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/BloomFilterCreator.java ## @@ -0,0 +1,41

[GitHub] sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-07-29 Thread GitBox
sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r205907403 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java ## @@ -528,6

[GitHub] weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-07-29 Thread GitBox
weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r206014055 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/BloomFilterCreator.java ## @@ -0,0

[GitHub] weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-07-29 Thread GitBox
weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r206014664 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/BloomFilter.java ## @@ -0,0 +1,176

[GitHub] weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-07-29 Thread GitBox
weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r206014664 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/BloomFilter.java ## @@ -0,0 +1,176

[GitHub] weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-07-29 Thread GitBox
weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r206015829 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/BloomFilterCreator.java ## @@ -0,0

[GitHub] weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-07-29 Thread GitBox
weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r206017040 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java ## @@