[GitHub] arina-ielchiieva commented on issue #1502: DRILL-6785: DataClient is using RootAllocator in the bootstrap instea…

2018-10-16 Thread GitBox
arina-ielchiieva commented on issue #1502: DRILL-6785: DataClient is using RootAllocator in the bootstrap instea… URL: https://github.com/apache/drill/pull/1502#issuecomment-430195019 @sohami the change seems obvious but could you please highlight what incorrect usage causes and how issue

[GitHub] lushuifeng commented on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-10-16 Thread GitBox
lushuifeng commented on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#issuecomment-430141004 @vvysotskyi All tests have been passed, could you please take a look? thanks!

[GitHub] priteshm commented on issue #1505: DRILL-6797: Fix UntypedNull handling for complex types

2018-10-16 Thread GitBox
priteshm commented on issue #1505: DRILL-6797: Fix UntypedNull handling for complex types URL: https://github.com/apache/drill/pull/1505#issuecomment-430356449 @arina-ielchiieva should the title of PR to match the JIRA?

[GitHub] vdiravka commented on a change in pull request #1503: DRILL-6795: Upgrade Janino compiler from 2.7.6 to 3.0.9

2018-10-16 Thread GitBox
vdiravka commented on a change in pull request #1503: DRILL-6795: Upgrade Janino compiler from 2.7.6 to 3.0.9 URL: https://github.com/apache/drill/pull/1503#discussion_r225618389 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/ModifiedUnparser.java

Re: Topics for Drill Hackathon/Drill Developers Day - 2018!

2018-10-16 Thread Vitalii Diravka
Could you provide the possibility of commenting for the document? It will allow to make suggestions for the topics. On Tue, Oct 16, 2018 at 6:22 AM Hanumath Rao Maduri wrote: > Hello Drill Development Team, > > Thank you all for the interest in attending the Drill Developers Day. > I have

[GitHub] gparai commented on a change in pull request #1466: DRILL-6381: Add support for index based planning and execution

2018-10-16 Thread GitBox
gparai commented on a change in pull request #1466: DRILL-6381: Add support for index based planning and execution URL: https://github.com/apache/drill/pull/1466#discussion_r225675265 ## File path:

[GitHub] amansinha100 commented on a change in pull request #1466: DRILL-6381: Add support for index based planning and execution

2018-10-16 Thread GitBox
amansinha100 commented on a change in pull request #1466: DRILL-6381: Add support for index based planning and execution URL: https://github.com/apache/drill/pull/1466#discussion_r225737406 ## File path:

Re: Topics for Drill Hackathon/Drill Developers Day - 2018!

2018-10-16 Thread Hanumath Rao Maduri
Hello Vitalli, I have given permissions to edit the document. Please let me know if it is fine. Regards, -Hanu On Tue, Oct 16, 2018 at 11:10 AM Vitalii Diravka wrote: > Could you provide the possibility of commenting for the document? > It will allow to make suggestions for the topics. > > On

Re: [HANGOUT] Topics for 10/16/2018

2018-10-16 Thread Sorabh Hamirwasia
Hi All, Thanks for attending the hangout. Meeting Minutes: - There was a question of using WebEx or Zoom to allow more people, but currently with new link we don't see any issue for number of people joining remotely so for now we will keep using hangout link. - Vitalli explained

Re: Topics for Drill Hackathon/Drill Developers Day - 2018!

2018-10-16 Thread Charles Givre
@All, I don’t know if remote folks can host a session, but if so, I’d volunteer. — C > On Oct 16, 2018, at 17:13, Vitalii Diravka wrote: > > Yes, I can edit and post suggestions in the document. > Thank you! > > On Tue, Oct 16, 2018 at 11:50 PM Hanumath Rao Maduri > wrote: > >> Hello

[GitHub] amansinha100 commented on a change in pull request #1466: DRILL-6381: Add support for index based planning and execution

2018-10-16 Thread GitBox
amansinha100 commented on a change in pull request #1466: DRILL-6381: Add support for index based planning and execution URL: https://github.com/apache/drill/pull/1466#discussion_r225721627 ## File path:

[GitHub] kkhatua closed pull request #536: DRILL-4699: Add description column to sys.options table

2018-10-16 Thread GitBox
kkhatua closed pull request #536: DRILL-4699: Add description column to sys.options table URL: https://github.com/apache/drill/pull/536 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] kkhatua commented on issue #536: DRILL-4699: Add description column to sys.options table

2018-10-16 Thread GitBox
kkhatua commented on issue #536: DRILL-4699: Add description column to sys.options table URL: https://github.com/apache/drill/pull/536#issuecomment-430450365 Addressed as part of #1279 . This is an automated message from the

[GitHub] kkhatua edited a comment on issue #1491: DRILL-6084: Show Drill functions in WebUI for autocomplete

2018-10-16 Thread GitBox
kkhatua edited a comment on issue #1491: DRILL-6084: Show Drill functions in WebUI for autocomplete URL: https://github.com/apache/drill/pull/1491#issuecomment-430449367 @arina-ielchiieva made some additional changes: 1. Introduced the boolean `internal` field in the `sys.functions`

[jira] [Created] (DRILL-6798) Planner changes to support semi-join

2018-10-16 Thread Boaz Ben-Zvi (JIRA)
Boaz Ben-Zvi created DRILL-6798: --- Summary: Planner changes to support semi-join Key: DRILL-6798 URL: https://issues.apache.org/jira/browse/DRILL-6798 Project: Apache Drill Issue Type: Sub-task

[GitHub] lushuifeng commented on a change in pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-10-16 Thread GitBox
lushuifeng commented on a change in pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#discussion_r225770061 ## File path:

[GitHub] lushuifeng commented on a change in pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-10-16 Thread GitBox
lushuifeng commented on a change in pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#discussion_r225762550 ## File path:

[GitHub] lushuifeng commented on a change in pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-10-16 Thread GitBox
lushuifeng commented on a change in pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#discussion_r225775240 ## File path:

[GitHub] kkhatua commented on issue #1491: DRILL-6084: Show Drill functions in WebUI for autocomplete

2018-10-16 Thread GitBox
kkhatua commented on issue #1491: DRILL-6084: Show Drill functions in WebUI for autocomplete URL: https://github.com/apache/drill/pull/1491#issuecomment-430449367 @arina-ielchiieva made some additional changes: 1. Introduced the boolean `internal` field in the `sys.functions` table.

[GitHub] lushuifeng commented on a change in pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-10-16 Thread GitBox
lushuifeng commented on a change in pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#discussion_r225764315 ## File path:

[jira] [Created] (DRILL-6800) Simplify packaging of Jdbc-all jar

2018-10-16 Thread Sorabh Hamirwasia (JIRA)
Sorabh Hamirwasia created DRILL-6800: Summary: Simplify packaging of Jdbc-all jar Key: DRILL-6800 URL: https://issues.apache.org/jira/browse/DRILL-6800 Project: Apache Drill Issue Type:

[jira] [Created] (DRILL-6799) Enhance the Hash-Join Operator to perform Anti-Semi-Join

2018-10-16 Thread Boaz Ben-Zvi (JIRA)
Boaz Ben-Zvi created DRILL-6799: --- Summary: Enhance the Hash-Join Operator to perform Anti-Semi-Join Key: DRILL-6799 URL: https://issues.apache.org/jira/browse/DRILL-6799 Project: Apache Drill

[jira] [Created] (DRILL-6803) Remove server protobuf definitions from client protobufs

2018-10-16 Thread Sorabh Hamirwasia (JIRA)
Sorabh Hamirwasia created DRILL-6803: Summary: Remove server protobuf definitions from client protobufs Key: DRILL-6803 URL: https://issues.apache.org/jira/browse/DRILL-6803 Project: Apache Drill

[GitHub] kkhatua closed pull request #668: DRILL-5068: Add a new system table for completed profiles

2018-10-16 Thread GitBox
kkhatua closed pull request #668: DRILL-5068: Add a new system table for completed profiles URL: https://github.com/apache/drill/pull/668 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] kkhatua commented on issue #668: DRILL-5068: Add a new system table for completed profiles

2018-10-16 Thread GitBox
kkhatua commented on issue #668: DRILL-5068: Add a new system table for completed profiles URL: https://github.com/apache/drill/pull/668#issuecomment-430452821 Addressed in #1077 This is an automated message from the Apache

[jira] [Created] (DRILL-6802) Update jdbc-all pom.xml to dependent upon new java-exec client module only not entire java-exec module

2018-10-16 Thread Sorabh Hamirwasia (JIRA)
Sorabh Hamirwasia created DRILL-6802: Summary: Update jdbc-all pom.xml to dependent upon new java-exec client module only not entire java-exec module Key: DRILL-6802 URL:

[jira] [Created] (DRILL-6801) Divide java-exec into separate client, server and common module with separate pom.xml files for each module

2018-10-16 Thread Sorabh Hamirwasia (JIRA)
Sorabh Hamirwasia created DRILL-6801: Summary: Divide java-exec into separate client, server and common module with separate pom.xml files for each module Key: DRILL-6801 URL:

[GitHub] ihuzenko commented on issue #1488: DRILL-786: Allow CROSS JOIN syntax

2018-10-16 Thread GitBox
ihuzenko commented on issue #1488: DRILL-786: Allow CROSS JOIN syntax URL: https://github.com/apache/drill/pull/1488#issuecomment-430249450 > @ihuzenko I have a minor comment about the error message (sorry I just noticed it when I was about to merge your PR). If you can address it, I will

[GitHub] ihuzenko edited a comment on issue #1488: DRILL-786: Allow CROSS JOIN syntax

2018-10-16 Thread GitBox
ihuzenko edited a comment on issue #1488: DRILL-786: Allow CROSS JOIN syntax URL: https://github.com/apache/drill/pull/1488#issuecomment-430249450 > @ihuzenko I have a minor comment about the error message (sorry I just noticed it when I was about to merge your PR). If you can address it,

[GitHub] vvysotskyi commented on a change in pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-10-16 Thread GitBox
vvysotskyi commented on a change in pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#discussion_r225498265 ## File path:

[GitHub] vvysotskyi commented on a change in pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-10-16 Thread GitBox
vvysotskyi commented on a change in pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#discussion_r225499955 ## File path:

[GitHub] vvysotskyi commented on a change in pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-10-16 Thread GitBox
vvysotskyi commented on a change in pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#discussion_r225504704 ## File path:

[GitHub] vvysotskyi commented on a change in pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-10-16 Thread GitBox
vvysotskyi commented on a change in pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#discussion_r225500775 ## File path:

[GitHub] vvysotskyi commented on a change in pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-10-16 Thread GitBox
vvysotskyi commented on a change in pull request #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#discussion_r225494095 ## File path:

[GitHub] ihuzenko commented on a change in pull request #1488: DRILL-786: Allow CROSS JOIN syntax

2018-10-16 Thread GitBox
ihuzenko commented on a change in pull request #1488: DRILL-786: Allow CROSS JOIN syntax URL: https://github.com/apache/drill/pull/1488#discussion_r225487564 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java ## @@ -65,6

[GitHub] vdiravka commented on a change in pull request #1503: DRILL-6795: Upgrade Janino compiler from 2.7.6 to 3.0.9

2018-10-16 Thread GitBox
vdiravka commented on a change in pull request #1503: DRILL-6795: Upgrade Janino compiler from 2.7.6 to 3.0.9 URL: https://github.com/apache/drill/pull/1503#discussion_r225579834 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/ModifiedUnparser.java

[GitHub] vdiravka commented on a change in pull request #1503: DRILL-6795: Upgrade Janino compiler from 2.7.6 to 3.0.9

2018-10-16 Thread GitBox
vdiravka commented on a change in pull request #1503: DRILL-6795: Upgrade Janino compiler from 2.7.6 to 3.0.9 URL: https://github.com/apache/drill/pull/1503#discussion_r225515750 ## File path: pom.xml ## @@ -1366,6 +1366,11 @@ janino ${janino.version}

[GitHub] vdiravka commented on a change in pull request #1503: DRILL-6795: Upgrade Janino compiler from 2.7.6 to 3.0.9

2018-10-16 Thread GitBox
vdiravka commented on a change in pull request #1503: DRILL-6795: Upgrade Janino compiler from 2.7.6 to 3.0.9 URL: https://github.com/apache/drill/pull/1503#discussion_r225005654 ## File path: exec/java-exec/pom.xml ## @@ -349,6 +349,14 @@ joda-time 2.9

[GitHub] arina-ielchiieva opened a new pull request #1505: DRILL-6797: Fix UntypedNull handling for complex types

2018-10-16 Thread GitBox
arina-ielchiieva opened a new pull request #1505: DRILL-6797: Fix UntypedNull handling for complex types URL: https://github.com/apache/drill/pull/1505 Details in [DRILL-6797](https://issues.apache.org/jira/browse/DRILL-6797).

Re: [DISCUSSION] CI for Drill

2018-10-16 Thread Vitalii Diravka
Hi all, DRILL-6777 is merged to Apache Drill master branch. To set-up CircleCI builds for your Drill fork do the following steps: 1. SignUp into https://circleci.com/dashboard with your GitHub account. 2. Give permissions 3. Choose the organization (your GitHub account) 4. Choose the

Re: Topics for Drill Hackathon/Drill Developers Day - 2018!

2018-10-16 Thread Vitalii Diravka
Yes, I can edit and post suggestions in the document. Thank you! On Tue, Oct 16, 2018 at 11:50 PM Hanumath Rao Maduri wrote: > Hello Vitalli, > > I have given permissions to edit the document. Please let me know if it is > fine. > > Regards, > -Hanu > > On Tue, Oct 16, 2018 at 11:10 AM Vitalii

[GitHub] amansinha100 commented on a change in pull request #1466: DRILL-6381: Add support for index based planning and execution

2018-10-16 Thread GitBox
amansinha100 commented on a change in pull request #1466: DRILL-6381: Add support for index based planning and execution URL: https://github.com/apache/drill/pull/1466#discussion_r225740876 ## File path:

[jira] [Created] (DRILL-6797) Split function index extraction fails when result has no rows

2018-10-16 Thread Arina Ielchiieva (JIRA)
Arina Ielchiieva created DRILL-6797: --- Summary: Split function index extraction fails when result has no rows Key: DRILL-6797 URL: https://issues.apache.org/jira/browse/DRILL-6797 Project: Apache

[GitHub] sohami commented on issue #1502: DRILL-6785: DataClient is using RootAllocator in the bootstrap instea…

2018-10-16 Thread GitBox
sohami commented on issue #1502: DRILL-6785: DataClient is using RootAllocator in the bootstrap instea… URL: https://github.com/apache/drill/pull/1502#issuecomment-430293134 @arina-ielchiieva - There was no issues which was caused/found because of this. I happen to notice it while

[GitHub] vvysotskyi commented on a change in pull request #1503: DRILL-6795: Upgrade Janino compiler from 2.7.6 to 3.0.9

2018-10-16 Thread GitBox
vvysotskyi commented on a change in pull request #1503: DRILL-6795: Upgrade Janino compiler from 2.7.6 to 3.0.9 URL: https://github.com/apache/drill/pull/1503#discussion_r225607534 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/ModifiedUnparser.java

[GitHub] vvysotskyi commented on a change in pull request #1503: DRILL-6795: Upgrade Janino compiler from 2.7.6 to 3.0.9

2018-10-16 Thread GitBox
vvysotskyi commented on a change in pull request #1503: DRILL-6795: Upgrade Janino compiler from 2.7.6 to 3.0.9 URL: https://github.com/apache/drill/pull/1503#discussion_r225586948 ## File path: exec/java-exec/pom.xml ## @@ -349,6 +349,14 @@ joda-time 2.9

[GitHub] vvysotskyi commented on a change in pull request #1503: DRILL-6795: Upgrade Janino compiler from 2.7.6 to 3.0.9

2018-10-16 Thread GitBox
vvysotskyi commented on a change in pull request #1503: DRILL-6795: Upgrade Janino compiler from 2.7.6 to 3.0.9 URL: https://github.com/apache/drill/pull/1503#discussion_r225587554 ## File path: pom.xml ## @@ -1366,6 +1366,11 @@ janino ${janino.version}

[GitHub] arina-ielchiieva commented on issue #1502: DRILL-6785: DataClient is using RootAllocator in the bootstrap instea…

2018-10-16 Thread GitBox
arina-ielchiieva commented on issue #1502: DRILL-6785: DataClient is using RootAllocator in the bootstrap instea… URL: https://github.com/apache/drill/pull/1502#issuecomment-430300490 Sounds good, +1 This is an automated