[GitHub] drill issue #518: DRILL-4653.json - Malformed JSON should not stop the entir...

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/518 Ran some tests. The results look good. In particular, files with nested structures produced the correct results. Since it was the nested structure case that had me a bit worried, looks like the

[GitHub] drill issue #509: DRILL-4618: Fix hive function loader not correctly take ra...

Github user Ben-Zvi commented on the issue: https://github.com/apache/drill/pull/509 Tested and checked ... LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] drill issue #604: DRILL-4862: binary_string should use another buffer as out...

Github user gparai commented on the issue: https://github.com/apache/drill/pull/604 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill pull request #604: DRILL-4862: binary_string should use another buffer...

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/604#discussion_r82315506 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java --- @@ -1540,15 +1540,16 @@ public void eval() {

[GitHub] drill pull request #600: DRILL-4373: Drill and Hive have incompatible timest...

Github user bitblender commented on a diff in the pull request: https://github.com/apache/drill/pull/600#discussion_r82314071 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java --- @@ -45,4 +53,34 @@ public static int

[GitHub] drill pull request #496: Update for MapR profile

Github user pwong-mapr closed the pull request at: https://github.com/apache/drill/pull/496 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill issue #496: Update for MapR profile

Github user pwong-mapr commented on the issue: https://github.com/apache/drill/pull/496 Not sure why this PR is still open - go ahead and delete it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] drill issue #487: remove useless text

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/487 +1 (non-binding) A very simple change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] drill issue #478: DRILL-4581: Minor fixes to drill startup scripts for linux

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/478 Replaced by later commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] drill pull request #478: DRILL-4581: Minor fixes to drill startup scripts fo...

Github user paul-rogers closed the pull request at: https://github.com/apache/drill/pull/478 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #573: Drill 4858

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/573#discussion_r82305362 --- Diff: exec/java-exec/src/main/codegen/templates/TypeHelper.java --- @@ -68,8 +68,23 @@ public static JType getHolderType(JCodeModel model, MinorType

[GitHub] drill issue #573: Drill 4858

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/573 Unit tests? If this repeated maps have never been enabled, how do we know that the code actually works for this case? --- If your project is set up for it, you can reply to this email and have

[GitHub] drill pull request #593: DRILL-3178 csv reader should allow newlines inside ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/593#discussion_r82303401 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/TextReader.java --- @@ -231,33 +231,34 @@ private void

[GitHub] drill pull request #593: DRILL-3178 csv reader should allow newlines inside ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/593#discussion_r82303872 --- Diff: exec/java-exec/src/test/resources/store/text/WithQuotedCrLf.tbl --- @@ -0,0 +1,6 @@ +"a +1"|a|a +a|"a +2"|a +a|a|"a +3"

[GitHub] drill pull request #593: DRILL-3178 csv reader should allow newlines inside ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/593#discussion_r82304834 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/TextReader.java --- @@ -231,33 +231,34 @@ private void

[GitHub] drill pull request #593: DRILL-3178 csv reader should allow newlines inside ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/593#discussion_r82296690 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/TextInput.java --- @@ -88,6 +88,11 @@ private boolean

[GitHub] drill issue #595: DRILL-4203: Parquet File. Date is stored wrongly

Github user vdiravka commented on the issue: https://github.com/apache/drill/pull/595 Thanks @jaltekruse. @parthchandra Could you please take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] drill pull request #565: DRILL-4841: Use server event loop for web clients

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/565#discussion_r82266459 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -688,4 +802,142 @@ public DrillBuf getBuffer() {

[GitHub] drill pull request #565: DRILL-4841: Use server event loop for web clients

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/565#discussion_r82267594 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -688,4 +802,142 @@ public DrillBuf getBuffer() {

[GitHub] drill pull request #565: DRILL-4841: Use server event loop for web clients

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/565#discussion_r82267107 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -688,4 +802,142 @@ public DrillBuf getBuffer() {

[GitHub] drill pull request #565: DRILL-4841: Use server event loop for web clients

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/565#discussion_r82266904 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -688,4 +802,142 @@ public DrillBuf getBuffer() {

[GitHub] drill pull request #565: DRILL-4841: Use server event loop for web clients

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/565#discussion_r82267967 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -688,4 +802,142 @@ public DrillBuf getBuffer() {

[GitHub] drill pull request #565: DRILL-4841: Use server event loop for web clients

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/565#discussion_r82266574 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -688,4 +802,142 @@ public DrillBuf getBuffer() {

[GitHub] drill pull request #565: DRILL-4841: Use server event loop for web clients

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/565#discussion_r82269228 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillUserPrincipal.java --- @@ -118,8 +118,11 @@ public

[GitHub] drill pull request #565: DRILL-4841: Use server event loop for web clients

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/565#discussion_r82268707 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/AbstractDrillLoginService.java --- @@ -46,8 +46,11 @@ protected DrillClient

[GitHub] drill pull request #565: DRILL-4841: Use server event loop for web clients

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/565#discussion_r82295775 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -89,79 +88,175 @@ import

[GitHub] drill pull request #565: DRILL-4841: Use server event loop for web clients

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/565#discussion_r82265866 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -688,4 +802,142 @@ public DrillBuf getBuffer() {

[GitHub] drill pull request #565: DRILL-4841: Use server event loop for web clients

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/565#discussion_r82269525 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestDistributedFragmentRun.java --- @@ -41,7 +41,11 @@ public void

[GitHub] drill pull request #604: DRILL-4862: binary_string should use another buffer...

Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/604#discussion_r82294640 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java --- @@ -1540,15 +1540,16 @@ public void eval() { public

[GitHub] drill pull request #604: DRILL-4862: binary_string should use another buffer...

Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/604#discussion_r82293808 --- Diff: common/src/main/java/org/apache/drill/common/util/DrillStringUtils.java --- @@ -160,10 +160,9 @@ private static void appendByte(StringBuilder result,

[GitHub] drill issue #600: DRILL-4373: Drill and Hive have incompatible timestamp rep...

Github user vdiravka commented on the issue: https://github.com/apache/drill/pull/600 @bitblender Sorry about this. That was hidden `\u` symbols. Fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] drill pull request #604: DRILL-4862: binary_string should use another buffer...

Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/604#discussion_r82293523 --- Diff: common/src/main/java/org/apache/drill/common/util/DrillStringUtils.java --- @@ -160,10 +160,9 @@ private static void appendByte(StringBuilder result,

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r82291973 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveDrillNativeScanBatchCreator.java --- @@ -123,6 +123,7 @@ public

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r82292165 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java --- @@ -184,17 +201,15 @@ public static

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r82292241 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java --- @@ -107,6 +107,7 @@ public ScanBatch

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r82287507 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java --- @@ -184,17 +201,15 @@ public static

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r82290736 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveDrillNativeScanBatchCreator.java --- @@ -123,6 +123,7 @@ public

Re: [HANGOUT] Topics for 10/04/16

For the PR I didn't squash the changes into one single commit to make it easier to review, but let me know if you would prefer the changes or pull requests organized differently to speed up the review... On Thu, Oct 6, 2016 at 11:50 AM, Parth Chandra wrote: > I see, so it

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r82274813 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java --- @@ -184,17 +201,15 @@ public static

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r82273282 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java --- @@ -918,18 +916,22 @@ public void setMax(Object max) {

[GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly

Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/595#discussion_r82272848 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveDrillNativeScanBatchCreator.java --- @@ -123,6 +123,7 @@ public

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r82262083 --- Diff: exec/java-exec/src/main/resources/drill-module.conf --- @@ -194,10 +194,12 @@ drill.exec: { udf: { retry-attempts: 5,

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r82260717 --- Diff: exec/java-exec/src/main/resources/drill-module.conf --- @@ -45,7 +45,7 @@ drill.client: { supports-complex-types: true }

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r82251309 --- Diff: distribution/src/resources/drill-config.sh --- @@ -324,6 +324,21 @@ if [ -n "$DRILL_CLASSPATH" ]; then CP="$CP:$DRILL_CLASSPATH" fi

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r82252246 --- Diff: distribution/src/resources/sqlline.bat --- @@ -114,6 +114,10 @@ if "test%DRILL_LOG_DIR%" == "test" ( set DRILL_LOG_DIR=%DRILL_HOME%\log

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r82259602 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java --- @@ -378,38 +399,33 @@ private Path

Re: [HANGOUT] Topics for 10/04/16

I see, so it is not the prepare query where we see the improvement. I didn't realise that the BI tools can make so many information schema queries. I haven't been able to go thru the PR in detail. There is extensive refactoring that always makes it hard to tell the exact changes. (Make me