[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-27 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r103383633 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/AvgWidthMergedStatistic.java --- @@ -0,0 +1,135 @@ +/* + *

[GitHub] drill issue #757: DRILL-5290: Provide an option to build operator table once...

2017-02-27 Thread sudheeshkatkam
Github user sudheeshkatkam commented on the issue: https://github.com/apache/drill/pull/757 +1 Please squash commits, and open a ticket for the enhancement you mentioned. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-27 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r103371017 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/AvgWidthMergedStatistic.java --- @@ -0,0 +1,135 @@ +/* + *

[GitHub] drill pull request #765: Drill 5293: Change the seed of the hash function fo...

2017-02-27 Thread Ben-Zvi
GitHub user Ben-Zvi opened a pull request: https://github.com/apache/drill/pull/765 Drill 5293: Change the seed of the hash function for distribution The fix is to use a different _seed_ for the hash function in the cases the hash is computed for distribution (i.e., when calling

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-27 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r103367008 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/AbstractMergedStatistic.java --- @@ -0,0 +1,52 @@ +/* + *

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-27 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r103366767 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java --- @@ -283,4 +288,22 @@ public void close() throws Exception {

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-27 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r103366732 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java --- @@ -283,4 +288,22 @@ public void close() throws Exception {

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-27 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r103366521 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java --- @@ -245,6 +247,18 @@ public SchemaPlus getRootSchema() { }

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-27 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r103365674 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -390,4 +391,15 @@ String DYNAMIC_UDF_SUPPORT_ENABLED =

[GitHub] drill pull request #758: DRILL-5287: Provide option to skip updates of ephem...

2017-02-27 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/758#discussion_r103364711 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java --- @@ -280,8 +281,15 @@ public void interrupted(final

[GitHub] drill issue #712: DRILL-5167: Send escape character for metadata queries

2017-02-27 Thread vkorukanti
Github user vkorukanti commented on the issue: https://github.com/apache/drill/pull/712 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

2017-02-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/761#discussion_r103332364 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -392,22 +448,31 @@ private void

[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

2017-02-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/761#discussion_r103335045 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -1231,52 +1308,44 @@ private

[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

2017-02-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/761#discussion_r103332807 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -765,12 +838,12 @@ private void

[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

2017-02-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/761#discussion_r10813 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -948,50 +1027,50 @@ private void

[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

2017-02-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/761#discussion_r103335368 --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java --- @@ -238,6 +238,25 @@ public boolean copyFromSafe(int fromIndex, int

[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

2017-02-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/761#discussion_r103332576 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -392,22 +448,31 @@ private void

[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

2017-02-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/761#discussion_r103330903 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/SpillSet.java --- @@ -357,9 +393,13 @@ public SpillSet(FragmentContext

[GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort

2017-02-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/761#discussion_r103331438 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -219,7 +220,18 @@

Re: Time for 1.10 release

2017-02-27 Thread Laurent Goujon
Thanks for the heads up: I'll try to ping directly some committers to review my changes. For information, what's the official cutoff date? Laurent PS: it's too bad that people with expertise don't have time to review my patches, since some of them have been open for weeks or even months (e.g.

[GitHub] drill issue #762: DRILL-5114: Rationalize use of Logback logging in unit tes...

2017-02-27 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/762 Can't achieve different log levels for different appenders. To favor Lilith, cannot reduce the level for console. So, need to come up with an alternative solution. Closing again until that is

Re: Time for 1.10 release

2017-02-27 Thread Jinfeng Ni
Here are the current status for the pending PRs for 1.10. JIRAs have been merged into Apache master branches: DRILL-4280 DRILL-5275 DRILL-5260 DRILL-5273 DRILL-5257 DRILL-5255 DRILL-5274 JIRAs that are in "ready-to-commit" status: DRILL-5258 DRILL-5034 DRILL-4963

[GitHub] drill pull request #762: DRILL-5114: Rationalize use of Logback logging in u...

2017-02-27 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/762#discussion_r103325603 --- Diff: exec/java-exec/src/test/resources/logback-test.xml --- @@ -32,12 +32,13 @@ - + + ---

[GitHub] drill issue #763: DRILL-5208: Finding path to java executable should be dete...

2017-02-27 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/763 Adressed code review comments and rebased onto latest master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] drill pull request #757: DRILL-5290: Provide an option to build operator tab...

2017-02-27 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/757#discussion_r103285068 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -413,4 +413,8 @@ String DYNAMIC_UDF_SUPPORT_ENABLED =

[GitHub] drill pull request #520: DRILL-3510: Add ANSI_QUOTES option so that Drill's ...

2017-02-27 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/520#discussion_r103268387 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -695,6 +698,33 @@ public void runQuery(QueryType type, List

Re: Time for 1.10 release

2017-02-27 Thread Laurent Goujon
Hi Jinfeng, Thanks for volunteering: Please consider the following JIRAs (PRs already open): * DRILL-4994: Add back JDBC prepared statement for older servers * DRILL-4730: Update JDBC DatabaseMetaData implementation to use new Metadata APIs * DRILL-5301: Server metadata API * DRILL-5167: Send

[GitHub] drill pull request #764: DRILL-5301: Server metadata API

2017-02-27 Thread laurentgo
GitHub user laurentgo opened a pull request: https://github.com/apache/drill/pull/764 DRILL-5301: Server metadata API Add a Server metadata API to the User protocol, to query server support of various SQL features. Add support to the client (DrillClient) to query this

[jira] [Created] (DRILL-5301) Add server metadata API

2017-02-27 Thread Laurent Goujon (JIRA)
Laurent Goujon created DRILL-5301: - Summary: Add server metadata API Key: DRILL-5301 URL: https://issues.apache.org/jira/browse/DRILL-5301 Project: Apache Drill Issue Type: Improvement

Re: drill's calcite branch

2017-02-27 Thread Arina Yelchiyeva
Drill doesn't use Calcite directly since Drill Calcite has some commits specific to Drill. There are plans to migrate to the latest Calcite version [1] but there is no exact timeline. Kind regards Arina [1] https://issues.apache.org/jira/browse/DRILL-3993 On Mon, Feb 27, 2017 at 1:18 PM, weijie

Re: Excessive Logging Messages

2017-02-27 Thread Charles Givre
Hi Jinfeng, Thank you so much for your help. It turns out the problem was that I was working on another project and inadvertently copied the wrong slf4j binding into my classpath. Once I got rid of that, things returned to normal. Best, — C > On Feb 27, 2017, at 02:26, Jinfeng Ni

Re: [ANNOUNCE] New Committer: Arina Ielchiieva

2017-02-27 Thread Vitalii Diravka
Great news! Congrats Arina! Kind regards Vitalii On Mon, Feb 27, 2017 at 11:31 AM, Arina Yelchiyeva < arina.yelchiy...@gmail.com> wrote: > Thank you! > > On Mon, Feb 27, 2017 at 9:13 AM, yuliya Feldman > > wrote: > > > Congratulations Arina!!! > > > > From:

Re: drill's calcite branch

2017-02-27 Thread weijie tong
@Arina Yelchiyeva tks for your reply. what strategy does we choose to release the Calcite version? and why don't we use the Calcite project itself ? On Mon, Feb 27, 2017 at 5:30 PM, Arina Yelchiyeva < arina.yelchiy...@gmail.com> wrote: > Hi, > >

[jira] [Created] (DRILL-5300) SYSTEM ERROR: IllegalStateException: Memory was leaked by query while querying parquet files

2017-02-27 Thread Muhammad Gelbana (JIRA)
Muhammad Gelbana created DRILL-5300: --- Summary: SYSTEM ERROR: IllegalStateException: Memory was leaked by query while querying parquet files Key: DRILL-5300 URL: https://issues.apache.org/jira/browse/DRILL-5300

Re: drill's calcite branch

2017-02-27 Thread PHANI KUMAR YADAVILLI
Hi Team, Is there any documentation on creating a custom plugin for drill? Regards Phani kumar yadavilli On Mon, Feb 27, 2017 at 3:00 PM, Arina Yelchiyeva < arina.yelchiy...@gmail.com> wrote: > Hi, > > https://github.com/mapr/incubator-calcite/tree/DrillCalcite1.4.0 > > Kind regards > Arina >

Re: [ANNOUNCE] New Committer: Arina Ielchiieva

2017-02-27 Thread Arina Yelchiyeva
Thank you! On Mon, Feb 27, 2017 at 9:13 AM, yuliya Feldman wrote: > Congratulations Arina!!! > > From: Arina Yelchiyeva > To: dev@drill.apache.org > Sent: Sunday, February 26, 2017 5:23 AM > Subject: Re: [ANNOUNCE] New

Re: drill's calcite branch

2017-02-27 Thread Arina Yelchiyeva
Hi, https://github.com/mapr/incubator-calcite/tree/DrillCalcite1.4.0 Kind regards Arina On Mon, Feb 27, 2017 at 5:51 AM, weijie tong wrote: > hi Drills: > where can I find the calcite branch source code that drill are now self > maintaining ? >