Github user sohami commented on the issue:
https://github.com/apache/drill/pull/830
+1. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/830#discussion_r117395300
--- Diff: pom.xml ---
@@ -309,8 +309,8 @@
org.apache.maven.plugins
maven-compiler-plugin
- 1.7
-
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/830#discussion_r117387632
--- Diff: pom.xml ---
@@ -309,8 +309,8 @@
org.apache.maven.plugins
maven-compiler-plugin
- 1.7
-
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/830#discussion_r117382558
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/HeaderBuilder.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/830#discussion_r117381163
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/HeaderBuilder.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/830#discussion_r117381132
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/HeaderBuilder.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/830#discussion_r117382443
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/HeaderBuilder.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/830#discussion_r117381409
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/HeaderBuilder.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/830#discussion_r117381193
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/HeaderBuilder.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/833
Squashed commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/826#discussion_r117380486
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java
---
@@ -380,14 +384,21 @@ public void endRecord() throws
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/838#discussion_r117375636
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java ---
@@ -2178,6 +2178,8 @@ public DrillPBError parsePartialFrom(
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/838#discussion_r117375699
--- Diff: protocol/src/main/protobuf/UserBitShared.proto ---
@@ -74,16 +74,22 @@ message DrillPBError{
*/
RESOURCE = 7;
/*
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/832#discussion_r117358723
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -449,4 +449,19 @@
String PERSISTENT_TABLE_UMASK =
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/832#discussion_r117362498
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/validate/BatchValidator.java
---
@@ -0,0 +1,205 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/832#discussion_r117361619
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/validate/BatchValidator.java
---
@@ -0,0 +1,205 @@
+/*
+ * Licensed
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/830#discussion_r117173215
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/HeaderBuilder.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/830#discussion_r117173441
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/HeaderBuilder.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/830#discussion_r117174397
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/HeaderBuilder.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/830#discussion_r117169580
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/HeaderBuilder.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to
Paul Rogers created DRILL-5525:
--
Summary: Inconsistent, unhelpful semantics for batch, field schema
comparison
Key: DRILL-5525
URL: https://issues.apache.org/jira/browse/DRILL-5525
Project: Apache Drill
Paul Rogers created DRILL-5524:
--
Summary: Remove no-op projects from query plan
Key: DRILL-5524
URL: https://issues.apache.org/jira/browse/DRILL-5524
Project: Apache Drill
Issue Type:
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/833
Could you squash commits into one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/839
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/826#discussion_r117298449
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java
---
@@ -380,14 +384,21 @@ public void endRecord()
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/826#discussion_r117297653
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java
---
@@ -380,14 +384,21 @@ public void endRecord()
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/839
@paul-rogers
1. Renamed PR as you suggested to better convey changes idea. Thank you for
suggestion.
2. Included row count into batch size determination. Thus batch size will
be
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/842
@vvysotskyi since you are working on DRILL-4824, please review pull request
and confirm that issue will be fixed after DRILL-4824 is merged.
---
If your project is set up for it, you can
GitHub user arina-ielchiieva opened a pull request:
https://github.com/apache/drill/pull/842
DRILL-5523: Revert if condition in UnionAllRecordBatch changed in DRIâ¦
â¦LL-5419
If condition in UnionAllRecordBatch which was changed to correct one in
DRILL-5419 but this
Arina Ielchiieva created DRILL-5523:
---
Summary: Revert if condition in UnionAllRecordBatch changed in
DRILL-5419
Key: DRILL-5523
URL: https://issues.apache.org/jira/browse/DRILL-5523
Project: Apache
30 matches
Mail list logo
