[GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...

2017-06-23 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/858#discussion_r123866213 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TimeoutTrigger.java --- @@ -0,0 +1,105 @@ +/** + * Licensed to the Apache Software

[GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...

2017-06-23 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/858#discussion_r123866148 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java --- @@ -98,6 +102,32 @@ private void throwIfClosed() throws

[GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...

2017-06-23 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/858#discussion_r123866367 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TimeoutTrigger.java --- @@ -0,0 +1,105 @@ +/** + * Licensed to the Apache Software

[GitHub] drill issue #805: Drill-4139: Exception while trying to prune partition. jav...

2017-06-23 Thread jinfengni
Github user jinfengni commented on the issue: https://github.com/apache/drill/pull/805 Thanks for the reminder, @paul-rogers . Somehow, I overlooked this PR. I thought I have reviewed and merged a PR from @vvysotskyi . But looks like I confused this one with another one I merged.

[GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...

2017-06-23 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/858#discussion_r123865940 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java --- @@ -38,8 +44,12 @@ // methods for compatibility.) class

[GitHub] drill issue #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(int)

2017-06-23 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/858 @laurentgo I'm done with the refactoring. Please review. @parthchandra , since this will be the basis of exploring the cause for DRILL-5420 , perhaps you could do a review as well. --- If your

[GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...

2017-06-23 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/858#discussion_r123865572 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java --- @@ -64,13 +65,17 @@

[GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...

2017-06-23 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/858#discussion_r123865562 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java --- @@ -204,7 +276,7 @@ public boolean isClosed() {

[GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...

2017-06-23 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/858#discussion_r123865524 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java --- @@ -159,24 +230,25 @@ public void cleanUp() { public int

[GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...

2017-06-23 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/858#discussion_r123865494 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java --- @@ -38,8 +44,12 @@ // methods for compatibility.) class

[GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...

2017-06-23 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/858#discussion_r123865295 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java --- @@ -1384,7 +1402,7 @@ public void updateRowId( String columnLabel,

[GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...

2017-06-23 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/858#discussion_r123865256 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java --- @@ -125,7 +154,7 @@ protected void cancel() { // (Not

[GitHub] drill issue #855: DRILL-5590: Bugs in CSV field matching, null columns

2017-06-23 Thread sohami
Github user sohami commented on the issue: https://github.com/apache/drill/pull/855 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [ANNOUNCE] New PMC Chair of Apache Drill

2017-06-23 Thread Aman Sinha
Thank you all ! -Aman On Fri, Jun 23, 2017 at 3:59 PM, Paul Rogers wrote: > Congratulations Aman! > > And, thanks much to Parth, our outgoing chair, for his contributions as > PMC chair over the last year! > > - Paul > > > On Jun 23, 2017, at 12:48 PM, Aman Bawa

[jira] [Created] (DRILL-5605) Remove distrib-env.sh configuration file

2017-06-23 Thread Abhishek Girish (JIRA)
Abhishek Girish created DRILL-5605: -- Summary: Remove distrib-env.sh configuration file Key: DRILL-5605 URL: https://issues.apache.org/jira/browse/DRILL-5605 Project: Apache Drill Issue

Re: [ANNOUNCE] New PMC Chair of Apache Drill

2017-06-23 Thread Paul Rogers
Congratulations Aman! And, thanks much to Parth, our outgoing chair, for his contributions as PMC chair over the last year! - Paul > On Jun 23, 2017, at 12:48 PM, Aman Bawa wrote: > > Congratulations, Aman – well deserved! > > On 6/23/17, 12:46 PM, "Arina Yelchiyeva"

Re: [ANNOUNCE] New PMC Chair of Apache Drill

2017-06-23 Thread Aman Bawa
Congratulations, Aman – well deserved! On 6/23/17, 12:46 PM, "Arina Yelchiyeva" wrote: Congratulations, Aman! Kind regards Arina > On Jun 23, 2017, at 10:37 PM, Abhishek Girish wrote: > > Congratulations Aman!

Re: [ANNOUNCE] New PMC Chair of Apache Drill

2017-06-23 Thread Dechang Gu
Aman, Congrats! From: Parth Chandra Sent: Friday, June 23, 2017 12:06:23 PM To: dev@drill.apache.org Subject: [ANNOUNCE] New PMC Chair of Apache Drill Hello Drill developers, I'm very pleased to announce that the Drill PMC has voted to

Re: [ANNOUNCE] New PMC Chair of Apache Drill

2017-06-23 Thread Vitalii Diravka
Congratulations, Aman! Kind regards Vitalii On Sat, Jun 24, 2017 at 12:07 AM, AnilKumar B wrote: > Congratulations Aman. > > Thanks & Regards, > B Anil Kumar. > > On Fri, Jun 23, 2017 at 1:03 PM, Gautam Parai wrote: > > > Congratulations Aman! > > > > >

Re: [ANNOUNCE] New PMC Chair of Apache Drill

2017-06-23 Thread AnilKumar B
Congratulations Aman. Thanks & Regards, B Anil Kumar. On Fri, Jun 23, 2017 at 1:03 PM, Gautam Parai wrote: > Congratulations Aman! > > > Gautam > > > From: Jinfeng Ni > Sent: Friday, June 23, 2017 12:54:53 PM > To: dev >

Re: [ANNOUNCE] New PMC Chair of Apache Drill

2017-06-23 Thread Gautam Parai
Congratulations Aman! Gautam From: Jinfeng Ni Sent: Friday, June 23, 2017 12:54:53 PM To: dev Subject: Re: [ANNOUNCE] New PMC Chair of Apache Drill Congratulations, Aman! On Fri, Jun 23, 2017 at 12:54 PM, Kunal Khatua

Re: [ANNOUNCE] New PMC Chair of Apache Drill

2017-06-23 Thread Jinfeng Ni
Congratulations, Aman! On Fri, Jun 23, 2017 at 12:54 PM, Kunal Khatua wrote: > Congratulations ! > > -Original Message- > From: Arina Yelchiyeva [mailto:arina.yelchiy...@gmail.com] > Sent: Friday, June 23, 2017 12:47 PM > To: dev@drill.apache.org > Subject: Re:

RE: [ANNOUNCE] New PMC Chair of Apache Drill

2017-06-23 Thread Kunal Khatua
Congratulations ! -Original Message- From: Arina Yelchiyeva [mailto:arina.yelchiy...@gmail.com] Sent: Friday, June 23, 2017 12:47 PM To: dev@drill.apache.org Subject: Re: [ANNOUNCE] New PMC Chair of Apache Drill Congratulations, Aman! Kind regards Arina > On Jun 23, 2017, at 10:37

Re: [ANNOUNCE] New PMC Chair of Apache Drill

2017-06-23 Thread Arina Yelchiyeva
Congratulations, Aman! Kind regards Arina > On Jun 23, 2017, at 10:37 PM, Abhishek Girish wrote: > > Congratulations Aman! > >> On Fri, Jun 23, 2017 at 12:06 PM, Parth Chandra wrote: >> >> Hello Drill developers, >> >>I'm very pleased to announce

Re: [ANNOUNCE] New PMC Chair of Apache Drill

2017-06-23 Thread Abhishek Girish
Congratulations Aman! On Fri, Jun 23, 2017 at 12:06 PM, Parth Chandra wrote: > Hello Drill developers, > > I'm very pleased to announce that the Drill PMC has voted to elect Aman > Sinha > as the new PMC chair of Apache Drill. Please join me in congratulating > Aman! > >

[ANNOUNCE] New PMC Chair of Apache Drill

2017-06-23 Thread Parth Chandra
Hello Drill developers, I'm very pleased to announce that the Drill PMC has voted to elect Aman Sinha as the new PMC chair of Apache Drill. Please join me in congratulating Aman! Thanks, Parth

[GitHub] drill issue #729: Drill 1328: Support table statistics for Parquet

2017-06-23 Thread gparai
Github user gparai commented on the issue: https://github.com/apache/drill/pull/729 Thanks for the reminder @paul-rogers. Based on the last discussion with the reviewers and Drill community members, we would hold off on the PR because it also causes regressions in queries in TPC-H,

[GitHub] drill issue #831: DRILL-5432: Added pcap-format support

2017-06-23 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/831 Can we move this to contrib? I think we should get this one into the next release even as the rough edges (if any) are being smoothed out. --- If your project is set up for it, you can reply to

[jira] [Created] (DRILL-5604) Possible performance degradation with hash aggregate when number of distinct keys increase

2017-06-23 Thread Rahul Challapalli (JIRA)
Rahul Challapalli created DRILL-5604: Summary: Possible performance degradation with hash aggregate when number of distinct keys increase Key: DRILL-5604 URL: https://issues.apache.org/jira/browse/DRILL-5604

Re: [DISCUSS] Drill 1.11.0 release

2017-06-23 Thread Jinfeng Ni
+1 do Drill 1.11 release soon, and Arina as the new release manager. On Fri, Jun 23, 2017 at 9:49 AM, Aman Sinha wrote: > Sounds good, Arina and thanks for volunteering! I think it will be a good > experience for you doing the release. Reach out to past release

Re: Drill test cases failures after a fresh clone

2017-06-23 Thread Paul Rogers
Hi Muhammad, The tests have worked for me. That said, we do want them to work “out of the box” for everyone, so let’s see if we can track down the issues you are having. TestClassTransformation.testCompilationNoDebug is a timeout issue. Sometimes this just means that tests run slowly, perhaps

RE: Drill test cases failures after a fresh clone

2017-06-23 Thread Kunal Khatua
Have you been able to run the maven tests successfully before? Especially on the parent commit on which your PR is based? Ideally, if the repo is directly from github, the tests should run. It could also be environment settings. Here is what I have: Maven Details: Apache Maven 3.3.1

Re: [DISCUSS] Drill 1.11.0 release

2017-06-23 Thread Aman Sinha
Sounds good, Arina and thanks for volunteering! I think it will be a good experience for you doing the release. Reach out to past release managers for any help. In particular, make sure to use Parth's handy scripts that should make the job lot easier. -Aman On Fri, Jun 23, 2017 at 4:45 AM,

Re: [DISCUSS] Drill 1.11.0 release

2017-06-23 Thread Arina Yelchiyeva
If there are no objections, I'd like to volunteer. Kind regards Arina On Fri, Jun 23, 2017 at 1:20 AM, Parth Chandra wrote: > Hello Drillers, > > It's been three months since the last release and it is time to do the > next one. Does anyone want to volunteer to be the

Drill test cases failures after a fresh clone

2017-06-23 Thread Muhammad Gelbana
I intend to create a pull request, so I forked Drill on github and cloned the repository locally on my machine. I built the project by running *mvn clean install -DskipTests* Then I tried running the tests by running *mvn clean install* Then I started facing test failures. The first time, the

[GitHub] drill pull request #844: DRILL-5538: Create TopProject with validatedNodeTyp...

2017-06-23 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/844#discussion_r123726213 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/TopProjectVisitor.java --- @@ -0,0 +1,139 @@ +/* + *