Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/940#discussion_r138506769
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -54,11 +56,13 @@
import
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/940#discussion_r138506701
--- Diff:
common/src/test/java/org/apache/drill/categories/package-info.java ---
@@ -0,0 +1,23 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/940#discussion_r138505403
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSimpleExternalSort.java
---
@@ -148,10 +149,10 @@ public void
Takeo Ogawara created DRILL-5785:
Summary: Query Error on a large PCAP file
Key: DRILL-5785
URL: https://issues.apache.org/jira/browse/DRILL-5785
Project: Apache Drill
Issue Type: Bug
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/936
@arina-ielchiieva, thanks for the explanation. Drill's runtime framework
assumes that data is either:
1. ASCII (or, at least, single-byte character set based on ASCII), or
2. UTF-8
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/895
This PR was already merged by @arina-ielchiieva on 08/24
---
Github user sohami closed the pull request at:
https://github.com/apache/drill/pull/895
---
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/940#discussion_r138499857
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -54,11 +56,13 @@
import
Github user prasadns14 commented on the issue:
https://github.com/apache/drill/pull/939
@paul-rogers Can you please review the PR?
---
Vlad Rozov created DRILL-5784:
-
Summary: SYSTEM ERROR: IndexOutOfBoundsException: index: 512,
length: 4 (expected: range(0, 512))
Key: DRILL-5784
URL: https://issues.apache.org/jira/browse/DRILL-5784
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/940#discussion_r138497914
--- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionTest.java
---
@@ -57,7 +61,9 @@ public static void setUpConnection() throws SQLException {
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/940#discussion_r138497894
--- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionTest.java
---
@@ -57,7 +61,9 @@ public static void setUpConnection() throws SQLException {
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/938#discussion_r138495914
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java
---
@@ -158,19 +158,17 @@ public BatchHolder(int
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/938#discussion_r138495296
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTable.java
---
@@ -58,7 +59,7 @@
public int
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/938#discussion_r138495164
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
@@ -1178,20 +1273,38 @@ private void
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/938#discussion_r138494777
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
@@ -1178,20 +1273,38 @@ private void
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/938#discussion_r138492663
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
@@ -646,6 +687,46 @@ public AggOutcome
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/940#discussion_r138489633
--- Diff:
common/src/test/java/org/apache/drill/categories/package-info.java ---
@@ -0,0 +1,23 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/895
@sohami, please rebase on latest master and resolve conflicts.
---
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/940#discussion_r138473108
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSimpleExternalSort.java
---
@@ -148,10 +149,10 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/940#discussion_r138472376
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestCorruptParquetDateCorrection.java
---
@@ -59,6 +61,7 @@
*
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/940#discussion_r138472834
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -54,11 +56,13 @@
import
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/940#discussion_r138475152
--- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionTest.java
---
@@ -57,7 +61,9 @@ public static void setUpConnection() throws
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/940#discussion_r138466695
--- Diff:
common/src/test/java/org/apache/drill/categories/package-info.java ---
@@ -0,0 +1,23 @@
+/**
+ * Licensed to the Apache Software
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/940#discussion_r138475004
--- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionTest.java
---
@@ -57,7 +61,9 @@ public static void setUpConnection() throws
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/940
@paul-rogers This is an implementation of the Test Categories suggestion
you made on the dev list. It's ready for review.
---
GitHub user ilooner opened a pull request:
https://github.com/apache/drill/pull/940
DRILL-5752 Speed Up Unit Tests add Test Categories
This PR does the following.
**Increased Concurrency:** Previously tests only executed in 2 simultaneous
processes, now one process per
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/938#discussion_r138437442
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
@@ -646,6 +687,46 @@ public AggOutcome
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/905
@vvysotskyi , what I'm thinking is not just comparing the ratio of column
count vs ratio of row count.
Let's take a step back. This SwapHashJoinVisitor is trying to correct the
join
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/938#discussion_r138435187
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
@@ -382,19 +390,25 @@ private void
Timothy Farkas created DRILL-5783:
-
Summary: Make code generation in the TopN operator more modular
and test it
Key: DRILL-5783
URL: https://issues.apache.org/jira/browse/DRILL-5783
Project: Apache
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/938#discussion_r138433967
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
@@ -500,22 +516,45 @@ private void
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/905
@jinfengni thanks for looking into this. Completely agree with you that it
would be better to consider both row and column count.
Unfortunately, it does not help to fix this issue, since the
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/930#discussion_r138408349
--- Diff: common/src/test/resources/logback-test.xml ---
@@ -0,0 +1,92 @@
+
+
+
+
+
+
+
+true
+
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/930#discussion_r138407993
--- Diff: common/src/test/resources/logback-test.xml ---
@@ -0,0 +1,111 @@
+
+
+
+
+
+
+
+true
+
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/936
@paul-rogers, the unit tests just show which influence saffron property has
on Drill (since people in the community where asking how to enable support
UTF-8 in Drill), a long with this PR
Arina Ielchiieva created DRILL-5782:
---
Summary: Web UI: do not attempt build visualized plan when plan is
absent
Key: DRILL-5782
URL: https://issues.apache.org/jira/browse/DRILL-5782
Project: Apache
[
https://issues.apache.org/jira/browse/DRILL-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arina Ielchiieva resolved DRILL-5339.
-
Resolution: Fixed
Points 1-4 fixed in the scope of DRILL-5766.
> Web UI: flaws in query
[
https://issues.apache.org/jira/browse/DRILL-5338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arina Ielchiieva resolved DRILL-5338.
-
Resolution: Fixed
Fixed in the scope of DRILL-5766
> Web UI: add better visual
[
https://issues.apache.org/jira/browse/DRILL-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arina Ielchiieva resolved DRILL-5341.
-
Resolution: Fixed
Fixed in the scope of DRILL-5766
> Web UI: remove duplicating link to
[
https://issues.apache.org/jira/browse/DRILL-5346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arina Ielchiieva resolved DRILL-5346.
-
Resolution: Fixed
Fixed in the scope of DRILL-5766
> Web UI: remove link on user in
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/935
---
Volodymyr Vysotskyi created DRILL-5781:
--
Summary: Fix unit test failures to use tests config even if
default config is available
Key: DRILL-5781
URL: https://issues.apache.org/jira/browse/DRILL-5781
43 matches
Mail list logo
