[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140914589 --- Diff: contrib/native/client/src/clientlib/zkCluster.cpp --- @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140893808 --- Diff: contrib/native/client/src/include/drill/userProperties.hpp --- @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141215252 --- Diff: contrib/native/client/src/clientlib/channel.cpp --- @@ -0,0 +1,452 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140621499 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/ConnectionMultiListener.java --- @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140621635 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicClient.java --- @@ -179,6 +203,13 @@ void send(RpcOutcomeListener listener, T rpcType, SEND

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141215109 --- Diff: contrib/native/client/src/clientlib/channel.cpp --- @@ -0,0 +1,452 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140623048 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java --- @@ -102,19 +115,78 @@ // these are used for authentication

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141245539 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -65,108 +66,70 @@ struct ToRpcType: public

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140973654 --- Diff: contrib/native/client/src/clientlib/streamSocket.hpp --- @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140971420 --- Diff: contrib/native/client/src/clientlib/streamSocket.hpp --- @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140970043 --- Diff: contrib/native/client/src/clientlib/wincert.ipp --- @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140621394 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/ConnectionMultiListener.java --- @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140587424 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfig.java --- @@ -0,0 +1,325 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141218943 --- Diff: contrib/native/client/src/clientlib/channel.hpp --- @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140588134 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/TestSSLConfig.java --- @@ -91,10 +123,35 @@ public void testForTrustStore() throws Exception {

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141228991 --- Diff: contrib/native/client/src/include/drill/userProperties.hpp --- @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141247355 --- Diff: contrib/native/client/src/clientlib/wincert.ipp --- @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141245863 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -65,108 +66,70 @@ struct ToRpcType: public

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140593112 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/TestUserBitSSLServer.java --- @@ -0,0 +1,126 @@ +/* + * Licensed to

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141230974 --- Diff: contrib/native/client/src/clientlib/channel.cpp --- @@ -0,0 +1,452 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141215569 --- Diff: contrib/native/client/src/clientlib/channel.hpp --- @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140590439 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/TestUserBitSSL.java --- @@ -0,0 +1,338 @@ +/* + * Licensed to the

Assign a JIRA

2017-09-26 Thread Hanumath Rao Maduri
Hello All, I would like to work on this JIRA DRILL-5773. Can you please assign this JIRA to me. my user-name : hanu.ncr Thanks, -Hanu

[jira] [Created] (DRILL-5821) In the Drill web UI, display configured direct, heap memory

2017-09-26 Thread Paul Rogers (JIRA)
Paul Rogers created DRILL-5821: -- Summary: In the Drill web UI, display configured direct, heap memory Key: DRILL-5821 URL: https://issues.apache.org/jira/browse/DRILL-5821 Project: Apache Drill

[GitHub] drill issue #963: DRILL-5259: Allow listing a user-defined number of profile...

2017-09-26 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/963 @paul-rogers please bless this - Checks in place for non-numeric or out-of-range numeric inputs. - Auto fill if the max requested range exceeds the actual number of profiles available. User

[GitHub] drill pull request #964: DRILL-5755 Reduced default number of batches kept i...

2017-09-26 Thread ilooner
GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/964 DRILL-5755 Reduced default number of batches kept in memory by TopN You can merge this pull request into a Git repository by running: $ git pull https://github.com/ilooner/drill DRILL-5755

[GitHub] drill issue #914: DRILL-5657: Size-aware vector writer structure

2017-09-26 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/914 Added final development stage to this PR. This is a minor implementation tweak. The result set loader internals for maps held redundant map vectors. In the final vector container, each map must

[GitHub] drill issue #954: DRILL-5803: Show the hostname for each minor fragment in o...

2017-09-26 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/954 @paul-rogers Made the changes ---

[GitHub] drill pull request #962: DRILL-5820: Add support for libpam4j Pam Authentica...

2017-09-26 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/962#discussion_r141196893 --- Diff: distribution/src/resources/drill-override-example.conf --- @@ -133,6 +133,8 @@ drill.exec: { security.user.auth { enabled:

[GitHub] drill pull request #962: DRILL-5820: Add support for libpam4j Pam Authentica...

2017-09-26 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/962#discussion_r141198807 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/security/Pam4jUserAuthenticator.java --- @@ -0,0 +1,81 @@ +/* + * Licensed

[GitHub] drill pull request #962: DRILL-5820: Add support for libpam4j Pam Authentica...

2017-09-26 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/962#discussion_r141199041 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/security/PamUserAuthenticator.java --- @@ -59,7 +59,8 @@ public void

[GitHub] drill pull request #962: DRILL-5820: Add support for libpam4j Pam Authentica...

2017-09-26 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/962#discussion_r141198653 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/security/Pam4jUserAuthenticator.java --- @@ -0,0 +1,81 @@ +/* + * Licensed

[GitHub] drill pull request #962: DRILL-5820: Add support for libpam4j Pam Authentica...

2017-09-26 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/962#discussion_r141197203 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/security/Pam4jUserAuthenticator.java --- @@ -0,0 +1,81 @@ +/* + * Licensed

[GitHub] drill pull request #963: DRILL-5259: Allow listing a user-defined number of ...

2017-09-26 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/963#discussion_r141191837 --- Diff: exec/java-exec/src/main/resources/rest/profile/list.ftl --- @@ -37,7 +37,15 @@ No running queries. - Completed

[GitHub] drill pull request #963: DRILL-5259: Allow listing a user-defined number of ...

2017-09-26 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/963#discussion_r141192014 --- Diff: exec/java-exec/src/main/resources/rest/profile/list.ftl --- @@ -37,7 +37,15 @@ No running queries. - Completed

[GitHub] drill issue #932: DRILL-5758: Fix for repeated columns; enable managed sort ...

2017-09-26 Thread amansinha100
Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/932 Changes LGTM. +1 ---

[GitHub] drill pull request #932: DRILL-5758: Fix for repeated columns; enable manage...

2017-09-26 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/932#discussion_r141191139 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java --- @@ -74,53 +74,52 @@ public final

[GitHub] drill issue #963: DRILL-5259: Allow listing a user-defined number of profile...

2017-09-26 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/963 @paul-rogers Opened a new PR as I accidentally closed #953 . This is ready for review. ---

[GitHub] drill issue #953: DRILL-5259: Allow listing a user-defined number of profile...

2017-09-26 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/953 Closed the original PR accidentally. Have filed a new one #963 ---

[GitHub] drill pull request #963: DRILL-5259: Allow listing a user-defined number of ...

2017-09-26 Thread kkhatua
GitHub user kkhatua opened a pull request: https://github.com/apache/drill/pull/963 DRILL-5259: Allow listing a user-defined number of profiles Added an additional field in the UI allowing a user to specify the max number of profiles to display You can merge this pull request into

[GitHub] drill issue #962: DRILL-5820: Add support for libpam4j Pam Authenticator

2017-09-26 Thread sohami
Github user sohami commented on the issue: https://github.com/apache/drill/pull/962 @parthchandra - Please help to review ---

[GitHub] drill pull request #962: DRILL-5820: Add support for libpam4j Pam Authentica...

2017-09-26 Thread sohami
GitHub user sohami opened a pull request: https://github.com/apache/drill/pull/962 DRILL-5820: Add support for libpam4j Pam Authenticator You can merge this pull request into a Git repository by running: $ git pull https://github.com/sohami/drill DRILL-5820 Alternatively you

[GitHub] drill pull request #953: DRILL-5259: Allow listing a user-defined number of ...

2017-09-26 Thread kkhatua
Github user kkhatua closed the pull request at: https://github.com/apache/drill/pull/953 ---

[jira] [Created] (DRILL-5820) Add support for libpam4j Pam Authenticator

2017-09-26 Thread Sorabh Hamirwasia (JIRA)
Sorabh Hamirwasia created DRILL-5820: Summary: Add support for libpam4j Pam Authenticator Key: DRILL-5820 URL: https://issues.apache.org/jira/browse/DRILL-5820 Project: Apache Drill

[GitHub] drill issue #959: DRILL-5816: Hash function produces skewed results on Strin...

2017-09-26 Thread amansinha100
Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/959 lgtm. +1. @sohami could you pls check with @chunhui-shi if unit tests were added previously for DRILL-4237 (another skew issue)? If not, could you create a new JIRA to add such tests, which

Drill Views getting Connection Closed error after adding more columns

2017-09-26 Thread Sanchita Pandey
Hi , I have modified my existing drill View and added new columns. It includes few placeholder attributes also where I am passing ‘null’ as String(also tried with blank ‘’) but its impacting performance. Drill Views are getting connection timeout very frequently. If I remove additional and new

[GitHub] drill pull request #961: DRILL-5792: CONVERT_FROM_JSON on an empty file thro...

2017-09-26 Thread vdiravka
GitHub user vdiravka opened a pull request: https://github.com/apache/drill/pull/961 DRILL-5792: CONVERT_FROM_JSON on an empty file throws runtime exception Easyfix - using GenericAccessor for UntypedNullVector. You can merge this pull request into a Git repository by running:

[GitHub] drill issue #904: DRILL-5717: change some date time test cases with specific...

2017-09-26 Thread weijietong
Github user weijietong commented on the issue: https://github.com/apache/drill/pull/904 @vvysotskyi thanks for your patient review . As you pointed out , the timezone would not take effect when test cases run in parallel. I also tried the mock strategy. It will also fail in

Re: [EXT] Re: Food for thought about intra-document operation

2017-09-26 Thread Damien Profeta
Hello Aman, AsterixDb seems to follow the standard SQL with a few minor modifications and add functions to ease aggregations (array_count, array_avg…) That would tend to confirm at least that the support of unnest is a good idea to improve Drill. Best regards Damien ** On 09/25/2017

[GitHub] drill issue #959: DRILL-5816: Hash function produces skewed results on Strin...

2017-09-26 Thread sohami
Github user sohami commented on the issue: https://github.com/apache/drill/pull/959 @paul-rogers - I have added few tests and findings using hash32 and hash64 to compute the 32 bit hash codes in JIRA. ---

[GitHub] drill pull request #957: DRILL-5809 Fixed Option Storage Backward Compatibil...

2017-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/957 ---