Hi Arina,
Could we consider to include DRILL-5089 in 1.12.0? It is about lazy loading
schema for storage plugins. Could you or Paul take a look at the pull request
for this JIRA https://github.com/apache/drill/pull/1032? I think both of you
are familiar with this part.
Thanks,
Chunhui
___
GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/1032
DRILL-5089: Dynamically load schema of storage plugin only when needeâ¦
â¦d for every query
For each query, loading all storage plugins and loading all workspaces
under file system pl
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r150160362
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -96,6 +105,14 @@ private void throwIfClosed() throws
AlreadyClos
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/889
@amansinha100 thanks for sharing the information. Got your point. I think
your propose on
[CALCITE-1048](https://issues.apache.org/jira/browse/CALCITE-1048) is possible.
Since [CALCITE-794](http
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r150157923
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -96,6 +105,14 @@ private void throwIfClosed() throws
AlreadyClos
Github user prasadns14 commented on the issue:
https://github.com/apache/drill/pull/1021
@arina-ielchiieva, @paul-rogers
Reverted to the array approach, also added documentation.
---
GitHub user vrozov opened a pull request:
https://github.com/apache/drill/pull/1031
DRILL-5917: Ban org.json:json library in Drill
@arina-ielchiieva Please review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vrozov/drill DRILL-
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1028
@laurentgo - Thanks for the review. Updated PR based on comment.
---
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1014
Not sure the description here is entirely correct. Let's separate two
concepts: the plugin (code) and the plugin definition (the stuff in JSON.)
Plugin definitions are stored in ZK and re
Paul Rogers created DRILL-5950:
--
Summary: Allow JSON files to be splittable - for sequence of
objects format
Key: DRILL-5950
URL: https://issues.apache.org/jira/browse/DRILL-5950
Project: Apache Drill
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/1014
@arina-ielchiieva
- The parts addressing DRILL-4640 and DRILL-5166 LGTM
- I think the fix for DRILL-5771 LGTM but I would like write down what I
think is happening and confirm with you t
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r150131105
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -96,6 +105,14 @@ private void throwIfClosed() throws
AlreadyCl
Github user priteshm commented on the issue:
https://github.com/apache/drill/pull/1025
@amansinha100 can you review this change?
---
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r150127658
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -96,6 +105,14 @@ private void throwIfClosed() throws
AlreadyClos
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r150119338
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -96,6 +105,14 @@ private void throwIfClosed() throws
AlreadyCl
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/1028#discussion_r150118518
--- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.hpp ---
@@ -59,6 +59,12 @@ class SaslAuthenticatorImpl {
const char *getE
Paul Rogers created DRILL-5949:
--
Summary: JSON format options should be part of plugin config; not
session options
Key: DRILL-5949
URL: https://issues.apache.org/jira/browse/DRILL-5949
Project: Apache Dr
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r15009
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetComparison.java
---
@@ -255,4 +257,39 @@ private void verifyArray(String colLabel,
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r150097140
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSet.java ---
@@ -85,8 +85,7 @@
* new row set with the updated columns, then
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r150096444
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/file/JsonFileBuilder.java
---
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache So
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r150096261
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSet.java ---
@@ -85,8 +85,7 @@
* new row set with the updated columns, then mer
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r150087815
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaScanBatchCreator.java
---
@@ -0,0 +1,61 @@
+/**
+ * License
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r150087650
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaScanBatchCreator.java
---
@@ -0,0 +1,61 @@
+/**
+ * License
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r150087581
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaScanBatchCreator.java
---
@@ -0,0 +1,61 @@
+/**
+ * License
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r150088237
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaScanBatchCreator.java
---
@@ -0,0 +1,61 @@
+/**
+ * License
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r150082981
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaRecordReader.java
---
@@ -0,0 +1,178 @@
+/**
+ * Licensed t
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r150084039
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaRecordReader.java
---
@@ -0,0 +1,178 @@
+/**
+ * Licensed t
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r150086292
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaRecordReader.java
---
@@ -0,0 +1,178 @@
+/**
+ * Licensed t
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r150084784
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaRecordReader.java
---
@@ -0,0 +1,178 @@
+/**
+ * Licensed t
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r150081972
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaRecordReader.java
---
@@ -0,0 +1,178 @@
+/**
+ * Licensed t
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r150083104
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaRecordReader.java
---
@@ -0,0 +1,178 @@
+/**
+ * Licensed t
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r150086335
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaRecordReader.java
---
@@ -0,0 +1,178 @@
+/**
+ * Licensed t
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r150087367
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaRecordReader.java
---
@@ -0,0 +1,178 @@
+/**
+ * Licensed t
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r150084335
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaRecordReader.java
---
@@ -0,0 +1,178 @@
+/**
+ * Licensed t
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r150082711
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaRecordReader.java
---
@@ -0,0 +1,178 @@
+/**
+ * Licensed t
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r150083767
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaRecordReader.java
---
@@ -0,0 +1,178 @@
+/**
+ * Licensed t
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1029#discussion_r150086785
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -93,13 +96,35 @@ public ProfileInfo(D
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1029#discussion_r150085841
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -93,13 +96,35 @@ public ProfileInfo(D
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1029#discussion_r150086018
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -93,13 +96,35 @@ public ProfileInfo(D
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1021
Well, I don't have strong preference here, we can use array, as long as
Prasad makes it nicely documented as in your example rather then in one line.
```
String displayNames[] = {
Hello all,
I’m getting the following errors when I try to build Drill from source with the
tests. If I skip the mongodb test it builds fine, but I’m not sure what could
be causing this. Any suggestions?
— C
2017-11-09T15:13:25.047-0500 I NETWORK [conn2] end connection 127.0.0.1:58580
(1 con
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r150073673
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetComparison.java
---
@@ -255,4 +257,39 @@ private void verifyArray(String colLab
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r150072992
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/file/JsonFileBuilder.java
---
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apach
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r150073945
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSet.java ---
@@ -85,8 +85,7 @@
* new row set with the updated columns, then
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1021
@arina-ielchiieva, it helps to think about the source of the enum. This is
a Protobuf enum. The ordinal values cannot change; they are a contract between
sender and receiver. We can add new ones,
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r150047464
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -348,6 +354,21 @@ public void run() {
*/
}
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1029
Snapshot when testing with search filter for FAILED queries and navigating
to page 2 of that list. Information about the number of filtered items, etc is
also provided.
![image](https://user-ima
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1029
Snapshot when rendering the defaults (10 per page) from a pre-loaded set of
the latest 123 profiles
![image](https://user-images.githubusercontent.com/4335237/32621917-412a90ba-c536-11e7-9d51-832
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r150028303
--- Diff: contrib/storage-kafka/pom.xml ---
@@ -0,0 +1,130 @@
+
+
+http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r150029170
--- Diff: contrib/storage-kafka/pom.xml ---
@@ -0,0 +1,130 @@
+
+
+http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r150030044
--- Diff: contrib/storage-kafka/pom.xml ---
@@ -0,0 +1,130 @@
+
+
+http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";
Vlad created DRILL-5948:
---
Summary: The wrong number of batches is displayed
Key: DRILL-5948
URL: https://issues.apache.org/jira/browse/DRILL-5948
Project: Apache Drill
Issue Type: Bug
Affects Versi
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r150019576
--- Diff: contrib/storage-kafka/pom.xml ---
@@ -0,0 +1,130 @@
+
+
+http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";
Yes, they are already in master.
On Thu, Nov 9, 2017 at 6:05 PM, Charles Givre wrote:
> We’re including the Networking functions in this release right?
>
> > On Nov 9, 2017, at 11:04, Arina Yelchiyeva
> wrote:
> >
> > If changes will be done before cut off date, targeting mid November that
> it
We’re including the Networking functions in this release right?
> On Nov 9, 2017, at 11:04, Arina Yelchiyeva wrote:
>
> If changes will be done before cut off date, targeting mid November that it
> will be possible to include this Jira.
>
> On Thu, Nov 9, 2017 at 6:03 PM, Charles Givre wrote:
If changes will be done before cut off date, targeting mid November that it
will be possible to include this Jira.
On Thu, Nov 9, 2017 at 6:03 PM, Charles Givre wrote:
> Hi Arina,
> Can we include DRILL-4091 Support for additional GIS operations in version
> 1.12? In general the code looked pre
Hi Arina,
Can we include DRILL-4091 Support for additional GIS operations in version
1.12? In general the code looked pretty good. There was a unit test missing
which the developer submitted and some minor formatting issues which I’m still
waiting on.
Thanks,
—C
> On Nov 9, 2017, at 10:5
Current status:
Blocker:
DRILL-5917: Ban org.json:json library in Drill (developer - Vlad R., code
reviewer - ?) - in progress.
Targeted for 1.12 release:
DRILL-5337: OpenTSDB plugin (developer - Dmitriy & Vlad S., code reviewer -
Arina) - code review in final stage.
DRILL-4779: Kafka storage plu
Github user akumarb2010 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r150002516
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/DrillKafkaConfig.java
---
@@ -0,0 +1,31 @@
+/**
+ * Licensed to
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1021#discussion_r149997750
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileUtil.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1021#discussion_r149998367
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileUtil.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/904
@weijietong, thanks for the pull request, +1
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1020
+1, LGTM.
---
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1020#discussion_r149994673
--- Diff: exec/java-exec/src/main/resources/rest/metrics/metrics.ftl ---
@@ -138,21 +154,14 @@
});
};
-function upd
Github user priteshm commented on the issue:
https://github.com/apache/drill/pull/1014
@ilooner can you please review this?
---
Github user priteshm commented on the issue:
https://github.com/apache/drill/pull/1030
@ppadma can you review this?
---
Github user prasadns14 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1021#discussion_r149974787
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/QueryStateDisplayName.java
---
@@ -0,0 +1,35 @@
+/**
+ * License
Github user prasadns14 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1020#discussion_r149972346
--- Diff: exec/java-exec/src/main/resources/rest/metrics/metrics.ftl ---
@@ -138,21 +154,14 @@
});
};
-function updateOth
GitHub user arina-ielchiieva opened a pull request:
https://github.com/apache/drill/pull/1030
DRILL-5941: Skip header / footer improvements for Hive storage plugin
Overview:
1. When table has header / footer process input splits fo the same file in
one reader (bug fix for DRILL-
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1026
Thanks, +1, LGTM.
---
Github user weijietong commented on the issue:
https://github.com/apache/drill/pull/904
done
---
Github user vladimirtkach commented on the issue:
https://github.com/apache/drill/pull/1026
@arina-ielchiieva made code changes according to your comments.
---
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1026#discussion_r149903182
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonNonNumerics.java
---
@@ -0,0 +1,167 @@
+/*
+* Li
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1026#discussion_r149903705
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonNonNumerics.java
---
@@ -0,0 +1,167 @@
+/*
+* Li
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r149893459
--- Diff:
contrib/storage-kafka/src/test/java/org/apache/drill/exec/store/kafka/cluster/EmbeddedZKQuorum.java
---
@@ -0,0 +1,83 @@
+/**
---
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r149893582
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/avro/AvroRecordReader.java
---
@@ -343,4 +343,4 @@ public void close() {
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r149893057
--- Diff: contrib/storage-kafka/src/test/resources/logback-test.xml ---
@@ -0,0 +1,51 @@
+
--- End diff --
Please remove. Now we hav
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1020#discussion_r149891566
--- Diff: exec/java-exec/src/main/resources/rest/metrics/metrics.ftl ---
@@ -138,21 +154,14 @@
});
};
-function upd
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1021#discussion_r149889024
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/QueryStateDisplayName.java
---
@@ -0,0 +1,35 @@
+/**
+ * L
79 matches
Mail list logo