Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/914
Regarding the use of memory addresses. The only reason to do so is
performance. To show the benefit of using addresses, I reran the
`PerformanceTool` class to test the original code, the code
Github user prasadns14 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1033#discussion_r151614301
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestCTAS.java ---
@@ -313,6 +313,59 @@ public void createTableWithCustomUmask() throws
Github user prasadns14 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1033#discussion_r151613939
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestCTAS.java ---
@@ -313,6 +313,59 @@ public void createTableWithCustomUmask() throws
Github user prasadns14 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1033#discussion_r151613897
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java
---
@@ -83,7 +84,20 @@ public PhysicalPlan
Github user ppadma commented on the issue:
https://github.com/apache/drill/pull/1001
@priteshm @sachouche This PR needs to be updated on top of changes made for
DRILL-5899.
---
Github user priteshm commented on the issue:
https://github.com/apache/drill/pull/1001
@ppadma @paul-rogers I see that @sachouche addressed the comments in the
JIRA - is this one ready to merge?
---
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r151585383
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaSubScan.java
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r151587965
--- Diff:
contrib/storage-kafka/src/test/java/org/apache/drill/exec/store/kafka/MessageIteratorTest.java
---
@@ -0,0 +1,105 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r151585461
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaSubScan.java
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r151586477
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/decoders/MessageReaderFactory.java
---
@@ -0,0 +1,56 @@
+/*
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r151582174
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaSubScan.java
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r151584935
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/decoders/JsonMessageReader.java
---
@@ -0,0 +1,104 @@
+/*
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r151581827
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaRecordReader.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r151587030
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaGroupScan.java
---
@@ -0,0 +1,320 @@
+/*
+ * Licensed to
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r151586853
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaRecordReader.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r151585334
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaSubScan.java
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r151583591
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/decoders/MessageReaderFactory.java
---
@@ -0,0 +1,56 @@
+/*
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r151584428
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/decoders/MessageReader.java
---
@@ -0,0 +1,45 @@
+/*
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r151572304
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaGroupScan.java
---
@@ -0,0 +1,320 @@
+/*
+ * Licensed to
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r151584017
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/decoders/MessageReaderFactory.java
---
@@ -0,0 +1,56 @@
+/*
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r151581968
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaSubScan.java
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r151581581
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaStoragePlugin.java
---
@@ -0,0 +1,100 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r151585930
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaStoragePluginConfig.java
---
@@ -0,0 +1,79 @@
+/*
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r151588038
--- Diff:
contrib/storage-kafka/src/test/java/org/apache/drill/exec/store/kafka/MessageIteratorTest.java
---
@@ -0,0 +1,105 @@
+/*
+ * Licensed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r151585603
--- Diff:
contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaSubScan.java
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r151583298
--- Diff: contrib/storage-kafka/src/main/resources/drill-module.conf ---
@@ -0,0 +1,30 @@
+// Licensed to the Apache Software Foundation (ASF) under
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r151587745
--- Diff:
contrib/storage-kafka/src/test/java/org/apache/drill/exec/store/kafka/TestKafkaSuit.java
---
@@ -0,0 +1,102 @@
+/*
+ * Licensed to
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1027#discussion_r151587168
--- Diff:
contrib/storage-kafka/src/test/java/org/apache/drill/exec/store/kafka/cluster/EmbeddedZKQuorum.java
---
@@ -0,0 +1,83 @@
+/*
+ *
Github user priteshm commented on the issue:
https://github.com/apache/drill/pull/1041
@parthchandra or @adityakishore since you'll have made changes to these
files before, can you review the changes here?
---
GitHub user vrozov opened a pull request:
https://github.com/apache/drill/pull/1041
DRILL-5961: For long running queries (> 10 min) Drill may raise
FragmentSetupException for completed/cancelled fragments
You can merge this pull request into a Git repository by running:
$
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1037
---
Github user priteshm commented on the issue:
https://github.com/apache/drill/pull/1040
@arina-ielchiieva can you please review this?
---
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r151580948
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -96,6 +105,14 @@ private void throwIfClosed() throws
Kunal Khatua created DRILL-5973:
---
Summary: Support injections of a time-bound pause after which the
server resumes
Key: DRILL-5973
URL: https://issues.apache.org/jira/browse/DRILL-5973
Project: Apache
Github user superbstreak commented on the issue:
https://github.com/apache/drill/pull/1037
Thanks, @parthchandra !
---
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/944
Created a separate PR for this JIRA:
https://github.com/apache/drill/pull/1040
1) I have kept the initial commit with the new PR and added new changes as
separate commit.
2) Changes include
GitHub user sohami opened a pull request:
https://github.com/apache/drill/pull/1040
Drill 5425
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sohami/drill DRILL-5425
Alternatively you can review and apply these changes as the
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/1037
LGTM. (Yes, let's merge this in before 1.12.)
---
Github user superbstreak commented on the issue:
https://github.com/apache/drill/pull/1037
@parthchandra We should get this in for 1.12?
---
Github user superbstreak commented on a diff in the pull request:
https://github.com/apache/drill/pull/1037#discussion_r151515278
--- Diff: contrib/native/client/src/include/drill/userProperties.hpp ---
@@ -28,6 +28,18 @@ class DECLSPEC_DRILL_CLIENT DrillUserProperties{
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/1037#discussion_r151512282
--- Diff: contrib/native/client/src/include/drill/userProperties.hpp ---
@@ -28,6 +28,18 @@ class DECLSPEC_DRILL_CLIENT DrillUserProperties{
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/914
Just FYI, this (https://github.com/d-t-w/netty-buffers) seems to indicate
that some of Netty's internal fragmentation issues seem to have been addressed
since 4.0.37
---
Github user priteshm commented on the issue:
https://github.com/apache/drill/pull/1038
@parthchandra can you please review this?
---
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r151493351
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
---
@@ -175,6 +193,21 @@ public WorkspaceSchema
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1030
@ppadma pull request is updated to handle header / footer logic in
distributed environment. Comment with PR description in the beginning of the
pull request is updated. Please review when
45 matches
Mail list logo
