GitHub user parthchandra opened a pull request:
https://github.com/apache/drill/pull/1050
DRILL-5694: Do not allow queries to access paths outside the current â¦
Added check to prevent users from accessing a path outside the current
workspace. For backward compatibility this
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/1048#discussion_r152703332
--- Diff: common/pom.xml ---
@@ -63,12 +63,29 @@
org.msgpack
msgpack
0.6.6
+
--- End diff --
Removed
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1043
May be @arina-ielchiieva can help resolve squashing into one commit.
LGTM ... thanks for doing this!
+1
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1028
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1036
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1031
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1034
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1025
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1014
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1030
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1029
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1032
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1044
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1035
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1048#discussion_r152690825
--- Diff: common/pom.xml ---
@@ -63,12 +63,29 @@
org.msgpack
msgpack
0.6.6
+
--- End diff --
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/914
Addressed Karthik's comments, rebased on master, resolved conflicts, and
squashed all but the conflict resolution commit.
---
Timothy Farkas created DRILL-5989:
-
Summary: Run Smoke Tests On Travis
Key: DRILL-5989
URL: https://issues.apache.org/jira/browse/DRILL-5989
Project: Apache Drill
Issue Type: Improvement
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/1048
@arina-ielchiieva
---
GitHub user ilooner opened a pull request:
https://github.com/apache/drill/pull/1048
DRILL-5987: Use one version of javassist
There were two different versions of javassist being pulled in by
**msgpack** and **reflections**. This makes sure only one version is included.
You can
Paul Rogers created DRILL-5988:
--
Summary: Revise operator status for OperatorFixture
Key: DRILL-5988
URL: https://issues.apache.org/jira/browse/DRILL-5988
Project: Apache Drill
Issue Type:
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/914#discussion_r152664121
--- Diff: exec/memory/base/src/main/java/io/netty/buffer/DrillBuf.java ---
@@ -882,4 +882,71 @@ public void print(StringBuilder sb, int indent,
Verbosity
Timothy Farkas created DRILL-5987:
-
Summary: Two versions of javassist on the classpath
Key: DRILL-5987
URL: https://issues.apache.org/jira/browse/DRILL-5987
Project: Apache Drill
Issue
Github user cgivre commented on the issue:
https://github.com/apache/drill/pull/1043
I made the requested fixes, and attempted to squash the commits into one,
but failed on that last step. I actually renamed the js director
`ace-code-editor`, which seemed descriptive to me.
---
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/1030
+1
---
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1043
@cgivre
Just edited the last comment to remove the +1 [ Learnt that I should wait
till there is a response to my asks first! :) ] .
To summarize, here are my 3 asks:
1. Change the theme
GitHub user vdiravka opened a pull request:
https://github.com/apache/drill/pull/1047
DRILL-5970: DrillParquetReader always builds the schema with "OPTIONAâ¦
â¦L" dataMode columns instead of "REQUIRED" ones
- Added supporting of specifying the DataMode of data type in
GitHub user vvysotskyi opened a pull request:
https://github.com/apache/drill/pull/1046
DRILL-5986: Update jackson-databind version to 2.7.9.1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vvysotskyi/drill DRILL-5986
Volodymyr Vysotskyi created DRILL-5986:
--
Summary: Update jackson-databind version to 2.7.9.1
Key: DRILL-5986
URL: https://issues.apache.org/jira/browse/DRILL-5986
Project: Apache Drill
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1031
rebased to upstream/master and squashed commits.
---
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1033#discussion_r152582047
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java ---
@@ -311,6 +311,75 @@ public void
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1033#discussion_r152561351
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
---
@@ -382,6 +382,9 @@ public int
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1033#discussion_r152583668
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java ---
@@ -311,6 +311,75 @@ public void
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1033#discussion_r152583194
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java
---
@@ -78,47 +78,58 @@ public PhysicalPlan
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1033#discussion_r152580600
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestCTAS.java ---
@@ -254,6 +255,66 @@ public void createTableWithCustomUmask()
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1033#discussion_r152579484
--- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
@@ -215,11 +223,12 @@ SqlNode SqlDropView() :
/**
* Parses a
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1033#discussion_r152580204
--- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
@@ -172,26 +172,34 @@ SqlNodeList ParseRequiredFieldList(String relType) :
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/921
@dvjyothsna also please remove `e.printStackTrace();` from the code, I see
4 occurrences.
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/921
@paul-rogers is right, there is something wrong with the protos @dvjyothsna
has generated.
I took master branch and generated protos. No changes so these extra
changes we see are wrong.
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1040
@sohami could you please update pull request header to include Jira title?
It would be just easier to identify it among others. Thanks.
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1044
+1, LGTM.
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1031
I see some functional test failures but I don't think they are related, it
might be that your branch is not based on the latest master, so +1, LGTM.
@vrozov thanks for making the
sunny rajpal created DRILL-5985:
---
Summary: Drill return IndexOutOfBoundsException when column name
in the file doesnt match the exact case
Key: DRILL-5985
URL: https://issues.apache.org/jira/browse/DRILL-5985
42 matches
Mail list logo
