[GitHub] drill pull request #1101: DRILL-6032: Made the batch sizing for HashAgg more...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1101#discussion_r165566478 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java --- @@ -516,43 +501,48 @@ private void

[GitHub] drill pull request #1101: DRILL-6032: Made the batch sizing for HashAgg more...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1101#discussion_r165566070 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java --- @@ -956,21 +925,8 @@ private void

Build failed in Jenkins: drill-scm #932

See Changes: [bben-zvi] DRILL-4185: UNION ALL involving empty directory on any side of union all -- [...truncated 544.80 KB...] [INFO] Copying 3 resources [INFO] [INFO] ---

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r165552608 --- Diff: exec/memory/base/src/main/java/io/netty/buffer/DrillBuf.java --- @@ -703,7 +703,18 @@ protected void _setLong(int index, long value) {

[GitHub] drill pull request #1083: DRILL-4185: UNION ALL involving empty directory on...

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1083 ---

[GitHub] drill pull request #1101: DRILL-6032: Made the batch sizing for HashAgg more...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1101#discussion_r165532035 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java --- @@ -516,43 +501,48 @@ private void

[GitHub] drill pull request #1107: DRILL-6123: Limit batch size for Merge Join based ...

GitHub user ppadma opened a pull request: https://github.com/apache/drill/pull/1107 DRILL-6123: Limit batch size for Merge Join based on memory Merge join limits output batch size to 32K rows irrespective of row size. This can create large batches (in terms of memory), depending

[GitHub] drill pull request #1106: DRILL-6129: Fixed query failure due to nested colu...

GitHub user sachouche reopened a pull request: https://github.com/apache/drill/pull/1106 DRILL-6129: Fixed query failure due to nested column data type change Problem Description - - The Drillbit was able to successfully send batches containing different metadata (for nested

[GitHub] drill pull request #1106: DRILL-6129: Fixed query failure due to nested colu...

Github user sachouche closed the pull request at: https://github.com/apache/drill/pull/1106 ---

[GitHub] drill issue #1106: DRILL-6129: Fixed query failure due to nested column data...

Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1106 Thank you Aman and Paul for reviewing this JIRA. I have created a new JIRA [DRILL-6131](https://issues.apache.org/jira/browse/DRILL-6131) to track the new SchemaComparator utility for sharing

[jira] [Created] (DRILL-6131) Create SchemaComparator to unify various comparison in a single utility

salim achouche created DRILL-6131: - Summary: Create SchemaComparator to unify various comparison in a single utility Key: DRILL-6131 URL: https://issues.apache.org/jira/browse/DRILL-6131 Project:

[GitHub] drill pull request #1101: DRILL-6032: Made the batch sizing for HashAgg more...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1101#discussion_r165516121 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java --- @@ -215,6 +206,7 @@ public BatchHolder() {

[GitHub] drill pull request #1101: DRILL-6032: Made the batch sizing for HashAgg more...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1101#discussion_r165513161 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java --- @@ -255,7 +254,6 @@ private HashAggregator

Jenkins build is back to normal : drill-scm #931

See

[GitHub] drill issue #1106: DRILL-6129: Fixed query failure due to nested column data...

Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/1106 Seems ok to fix the RecordBatchLoader.isSameSchema() since it is missing the checks for nested columns. In order to do the consolidation that Paul suggested, you might want to open an

[GitHub] drill issue #1057: DRILL-5993 Add Generic Copiers With Append Methods

Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1057 @Ben-Zvi resolved conflicts. They were minor formatting conflicts. I will mark it as ready-to-commit again since there were no changes, please let me know if there are any issues. ---

[jira] [Created] (DRILL-6130) Fix NPE during physical plan submission for storage plugins

Arina Ielchiieva created DRILL-6130: --- Summary: Fix NPE during physical plan submission for storage plugins Key: DRILL-6130 URL: https://issues.apache.org/jira/browse/DRILL-6130 Project: Apache

[GitHub] drill issue #1106: DRILL-6129: Fixed query failure due to nested column data...

Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1106 Thanks @paul-rogers for the information; I went through the PR and noticed the following: - BatchSchema invokes MaterializedField.isEquivalent() - With my fix, both methods consider

In case you rebased yesterday (1/31) - A Forced push was done on the Apache master

In case you rebased off the master branch yesterday (Jan 31) -- Note that I performed a forced push on the master branch (to remove a spurious empty commit). This would cause an error in case you did rebase and try rebasing again - you may need to checkout the new master and cherry-pick the