[GitHub] drill pull request #1116: DRILL-6140: Correctly list Operators in Profiles P...

GitHub user kkhatua opened a pull request: https://github.com/apache/drill/pull/1116 DRILL-6140: Correctly list Operators in Profiles Page Operators listed in Profiles Page don't always correspond with operator specified in Physical Plan. This commit fixes that by using the

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166513062 --- Diff: contrib/storage-hive/hive-exec-shade/pom.xml --- @@ -39,23 +39,28 @@ log4j - commons-codec

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166508479 --- Diff: contrib/storage-hive/core/pom.xml --- @@ -58,6 +58,10 @@ commons-codec commons-codec +

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166508171 --- Diff: contrib/storage-hive/core/pom.xml --- @@ -101,6 +105,7 @@ org.apache.calcite calcite-core +

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166513403 --- Diff: contrib/storage-hive/hive-exec-shade/pom.xml --- @@ -39,23 +39,28 @@ log4j - commons-codec

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166510396 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java --- @@ -507,5 +510,52 @@ public static boolean

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166512235 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java --- @@ -507,5 +510,52 @@ public static boolean

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166513525 --- Diff: contrib/storage-hive/hive-exec-shade/pom.xml --- @@ -39,23 +39,28 @@ log4j - commons-codec

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166507937 --- Diff: common/pom.xml --- @@ -45,6 +45,7 @@ org.apache.calcite calcite-core + ${calcite.version} --- End diff

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166512379 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java --- @@ -507,5 +510,52 @@ public static boolean

[jira] [Created] (DRILL-6141) JOIN query that uses USING clause returns incorrect results

Khurram Faraaz created DRILL-6141: - Summary: JOIN query that uses USING clause returns incorrect results Key: DRILL-6141 URL: https://issues.apache.org/jira/browse/DRILL-6141 Project: Apache Drill

[GitHub] drill pull request #1057: DRILL-5993 Add Generic Copiers With Append Methods

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1057 ---

[GitHub] drill pull request #1102: DRILL-6119: The OpenTSDB storage plugin is not inc...

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1102 ---

[GitHub] drill issue #1101: DRILL-6032: Made the batch sizing for HashAgg more accura...

Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1101 Travis failure is unrelated ---

[jira] [Created] (DRILL-6140) Operators listed in Profiles Page doesn't always correspond with operator specified in Physical Plan

Kunal Khatua created DRILL-6140: --- Summary: Operators listed in Profiles Page doesn't always correspond with operator specified in Physical Plan Key: DRILL-6140 URL: https://issues.apache.org/jira/browse/DRILL-6140

[GitHub] drill issue #1112: DRILL-6114: Metadata revisions

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1112 Thanks @ppadma! Next we'll need a reviewer. @parthchandra or @arina-ielchiieva, is this something you can review? Once this one is good, I'll follow up with another that

[GitHub] drill issue #1101: DRILL-6032: Made the batch sizing for HashAgg more accura...

Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1101 @ppadma Responded to your comments. Please look at the last three commits for changes ---

[GitHub] drill pull request #1115: DRILL-6138: Move RecordBatchSizer to org.apache.dr...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1115#discussion_r166459971 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -260,7 +254,7 @@ public static ColumnSize

[GitHub] drill pull request #1115: DRILL-6138: Move RecordBatchSizer to org.apache.dr...

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/1115#discussion_r166454887 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -260,7 +254,7 @@ public static ColumnSize

[GitHub] drill pull request #1107: DRILL-6123: Limit batch size for Merge Join based ...

Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1107#discussion_r166448594 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -77,7 +77,7 @@ private ExecConstants() { public static final

[GitHub] drill pull request #1107: DRILL-6123: Limit batch size for Merge Join based ...

Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1107#discussion_r166450263 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java --- @@ -102,20 +105,78 @@ private final List

[GitHub] drill pull request #1115: DRILL-6138: Move RecordBatchSizer to org.apache.dr...

GitHub user ppadma opened a pull request: https://github.com/apache/drill/pull/1115 DRILL-6138: Move RecordBatchSizer to org.apache.drill.exec.record pac… …kage Also, changed columnSizes in RecordBatchSizer from list to map so we can lookup using field names.

[GitHub] drill pull request #1107: DRILL-6123: Limit batch size for Merge Join based ...

Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1107#discussion_r166427892 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java --- @@ -102,20 +105,78 @@ private final List

[jira] [Resolved] (DRILL-6070) Hash join with empty tables should not do casting of data types to INT

[ https://issues.apache.org/jira/browse/DRILL-6070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vitalii Diravka resolved DRILL-6070. Resolution: Resolved Assignee: Vitalii Diravka Fix Version/s: (was:

[GitHub] drill pull request #1101: DRILL-6032: Made the batch sizing for HashAgg more...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1101#discussion_r166411194 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java --- @@ -733,28 +780,32 @@ private void

[GitHub] drill pull request #1101: DRILL-6032: Made the batch sizing for HashAgg more...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1101#discussion_r166409878 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java --- @@ -226,7 +221,7 @@ public BatchHolder() {

Re: Google Hangouts: Lateral Join High Level Design Presentation

It looks like Volodymyr also had a topic: Decimal types support. He is starting with that. I am not sure if there is going to be sufficient time to cover 2 topics today... On Tue, Feb 6, 2018 at 10:00 AM, Timothy Farkas wrote: > Google Hangout Reminder. > >

Re: Google Hangouts: Lateral Join High Level Design Presentation

Google Hangout Reminder. https://hangouts.google.com/hangouts/_/event/ci4rdiju8bv04a64efj5fedd0lc From: Timothy Farkas Sent: Monday, February 5, 2018 12:35:22 PM To: dev@drill.apache.org; u...@drill.apache.org Subject: Google Hangouts: Lateral

[GitHub] drill pull request #1101: DRILL-6032: Made the batch sizing for HashAgg more...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1101#discussion_r166389076 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java --- @@ -65,6 +70,14 @@ public int

[GitHub] drill pull request #1101: DRILL-6032: Made the batch sizing for HashAgg more...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1101#discussion_r166388922 --- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java --- @@ -298,6 +298,11 @@ public int getPayloadByteCount(int valueCount) {

[GitHub] drill pull request #1107: DRILL-6123: Limit batch size for Merge Join based ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1107#discussion_r166384715 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinStatus.java --- @@ -101,8 +101,12 @@ public final void

[GitHub] drill pull request #1107: DRILL-6123: Limit batch size for Merge Join based ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1107#discussion_r166387630 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java --- @@ -102,20 +105,78 @@ private final List

[GitHub] drill pull request #1107: DRILL-6123: Limit batch size for Merge Join based ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1107#discussion_r166387073 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java --- @@ -102,20 +105,78 @@ private final List

[GitHub] drill pull request #1107: DRILL-6123: Limit batch size for Merge Join based ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1107#discussion_r166384067 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -77,7 +77,7 @@ private ExecConstants() { public static

[GitHub] drill pull request #1101: DRILL-6032: Made the batch sizing for HashAgg more...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1101#discussion_r166387829 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java --- @@ -140,6 +131,9 @@ private

[GitHub] drill issue #1112: DRILL-6114: Metadata revisions

Github user ppadma commented on the issue: https://github.com/apache/drill/pull/1112 @paul-rogers I ran the pre commit tests. No issues. Everything passed. Will do one more time once code reviews are done. ---

[GitHub] drill pull request #1104: DRILL-6118: Handle item star columns during projec...

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/1104#discussion_r166310161 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java --- @@ -596,10 +596,10 @@ private void

[GitHub] drill pull request #1114: Drill-6104: Added Logfile Reader

GitHub user cgivre opened a pull request: https://github.com/apache/drill/pull/1114 Drill-6104: Added Logfile Reader I would like to submit a format plugin that will enable Drill to read log files. Here is a link to the github repo which contains documentation:

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166246336 --- Diff: contrib/storage-hive/core/src/test/java/org/apache/drill/exec/impersonation/hive/TestSqlStdBasedAuthorization.java --- @@ -100,7 +103,9 @@

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166282137 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveMetadataProvider.java --- @@ -264,6 +265,10 @@ private HiveStats

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166247024 --- Diff: pom.xml --- @@ -884,13 +884,33 @@ io.netty netty-all + +

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166251399 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java --- @@ -507,5 +509,51 @@ public static boolean

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166198314 --- Diff: pom.xml --- @@ -884,13 +884,33 @@ io.netty netty-all + +

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166202560 --- Diff: contrib/storage-hive/core/src/test/java/org/apache/drill/exec/impersonation/hive/TestSqlStdBasedAuthorization.java --- @@ -100,7 +103,9 @@ private

[GitHub] drill pull request #1111: DRILL-5978: Upgrade Hive libraries to 2.1.1 versio...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/#discussion_r166213941 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java --- @@ -507,5 +509,51 @@ public static boolean