[jira] [Resolved] (DRILL-4909) Refinements to Drill web UI - Query profile page

2018-04-04 Thread Kunal Khatua (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-4909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kunal Khatua resolved DRILL-4909. - Resolution: Fixed > Refinements to Drill web UI - Query profile page >

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2018-04-04 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r179344792 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/MemoryUtils.java --- @@ -0,0 +1,199 @@ +/** --- End diff --

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2018-04-04 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r179321187 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VLAbstractEntryReader.java --- @@ -0,0 +1,214 @@

[GitHub] drill issue #1200: DRILL-143: Support CGROUPs resource management

2018-04-04 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1200 @Ben-Zvi / @paul-rogers I discovered that the path `/cgroup` is unique only to my installation of the package on CentOS. The standard path is `/sys/fs/cgroup`. So, I've made changes that

Re: Drill Java doc

2018-04-04 Thread Kunal Khatua
Agreed. We'll do it as part of the next release and try to get one for Drill-1.13.0 in the meanwhile. On 4/4/2018 2:33:47 PM, Vlad Rozov wrote: I'd suggest to make complete Java doc available as part of the release process. For example Hadoop API is available

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2018-04-04 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r179296715 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetRecordReader.java --- @@ -161,30 +162,25 @@ public

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2018-04-04 Thread sachouche
Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r179296101 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/MemoryUtils.java --- @@ -0,0 +1,199 @@ +/** --- End diff

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2018-04-04 Thread sachouche
Github user sachouche commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r179295602 --- Diff: exec/java-exec/pom.xml --- @@ -836,6 +836,14 @@ org.apache.maven.plugins maven-surefire-plugin +

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2018-04-04 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r179295162 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/MemoryUtils.java --- @@ -0,0 +1,199 @@ +/** --- End diff --

[GitHub] drill pull request #1060: DRILL-5846: Improve parquet performance for Flat D...

2018-04-04 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1060#discussion_r179293968 --- Diff: exec/java-exec/pom.xml --- @@ -836,6 +836,14 @@ org.apache.maven.plugins maven-surefire-plugin +

[GitHub] drill issue #1200: DRILL-143: Support CGROUPs resource management

2018-04-04 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1200 @paul-rogers very good point about the issue of the heartbeat thread competing with other Drillbit process threads for CPU. When writing up the documentation for this, we'll have to ensure that

[GitHub] drill pull request #1200: DRILL-143: Support CGROUPs resource management

2018-04-04 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1200#discussion_r179292376 --- Diff: distribution/src/resources/drillbit.sh --- @@ -127,6 +127,44 @@ check_before_start() fi } +check_after_start(){ +

Re: Drill Java doc

2018-04-04 Thread Vlad Rozov
I'd suggest to make complete Java doc available as part of the release process. For example Hadoop API is available https://hadoop.apache.org/docs/stable/api/index.html Thank you, Vlad On 4/4/18 07:28, Kunal Khatua wrote: Looks like it was done only for JDBC with release 1.2 .

[jira] [Created] (DRILL-6308) Exception handling - OOM

2018-04-04 Thread Khurram Faraaz (JIRA)
Khurram Faraaz created DRILL-6308: - Summary: Exception handling - OOM Key: DRILL-6308 URL: https://issues.apache.org/jira/browse/DRILL-6308 Project: Apache Drill Issue Type: Bug

[GitHub] drill pull request #1200: DRILL-143: Support CGROUPs resource management

2018-04-04 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1200#discussion_r179287166 --- Diff: distribution/src/resources/drillbit.sh --- @@ -127,6 +127,44 @@ check_before_start() fi } +check_after_start(){ +

[GitHub] drill pull request #1200: DRILL-143: Support CGROUPs resource management

2018-04-04 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1200#discussion_r179286598 --- Diff: distribution/src/resources/drillbit.sh --- @@ -127,6 +127,44 @@ check_before_start() fi } +check_after_start(){ +

[GitHub] drill issue #1199: DRILL-6303: Provide a button to copy the Drillbit's JStac...

2018-04-04 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1199 Nice work, @kkhatua! This seems very useful! ---

Re: "Death of Schema-on-Read"

2018-04-04 Thread Jinfeng Ni
I feel it's probably premature to cal it "death of schema-on-read" just based on one application case. For one product I have been working on recently, one use case is for IOT related application where data is sent from a variety of small devices (sensors, camera, etc). It would be a hard

[GitHub] drill issue #1199: DRILL-6303: Provide a button to copy the Drillbit's JStac...

2018-04-04 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1199 @arina-ielchiieva I've added 2 snapshots and tested in Chrome. **Mouse Over**, showing tooltip

Re: [DISCUSS] DrillBuf

2018-04-04 Thread Paul Rogers
Hi Vlad, Would be great to get insight from the original authors. Here ismy two cents as a late comer who made extensive use of the classes in question. Many of your questions are at the implementation level. It is worth looking at the question from two other perspectives: history and design.

[GitHub] drill pull request #1144: DRILL-6202: Deprecate usage of IndexOutOfBoundsExc...

2018-04-04 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1144#discussion_r179231151 --- Diff: src/main/resources/checkstyle-config.xml --- @@ -30,10 +30,15 @@ + --- End diff -- I commented out the

[GitHub] drill pull request #1144: DRILL-6202: Deprecate usage of IndexOutOfBoundsExc...

2018-04-04 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1144#discussion_r179229891 --- Diff: exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/BaseScalarWriter.java --- @@ -211,7 +211,7 @@ protected boolean

[GitHub] drill pull request #1144: DRILL-6202: Deprecate usage of IndexOutOfBoundsExc...

2018-04-04 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1144#discussion_r179226227 --- Diff: exec/memory/base/src/main/java/io/netty/buffer/DrillBuf.java --- @@ -777,23 +778,20 @@ public int getActualMemoryConsumed() { * @return A

[DISCUSS] DrillBuf

2018-04-04 Thread Vlad Rozov
I have several questions and concerns regarding DrillBuf usage, design and implementation. There is a limited documentation available for the subject (Java doc, https://github.com/apache/drill/blob/master/exec/memory/base/src/main/java/org/apache/drill/exec/memory/README.md and

Re: Drill Java doc

2018-04-04 Thread Kunal Khatua
Looks like it was done only for JDBC with release 1.2 . https://drill.apache.org/api/1.2/jdbc/ On 4/4/2018 7:23:08 AM, Vlad Rozov wrote: Is Drill Java doc hosted on http://drill.apache.org or any other site? Thank you, Vlad

[GitHub] drill pull request #1200: DRILL-143: Support CGROUPs resource management

2018-04-04 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1200#discussion_r179159323 --- Diff: distribution/src/resources/drillbit.sh --- @@ -154,6 +192,7 @@ start_bit ( ) nohup nice -n $DRILL_NICENESS "$DRILL_HOME/bin/runbit" exec

[GitHub] drill pull request #1200: DRILL-143: Support CGROUPs resource management

2018-04-04 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1200#discussion_r179158686 --- Diff: distribution/src/resources/drillbit.sh --- @@ -127,6 +127,44 @@ check_before_start() fi } +check_after_start(){ +

[GitHub] drill pull request #1200: DRILL-143: Support CGROUPs resource management

2018-04-04 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1200#discussion_r179158585 --- Diff: distribution/src/resources/drillbit.sh --- @@ -127,6 +127,44 @@ check_before_start() fi } +check_after_start(){ +

[GitHub] drill pull request #1200: DRILL-143: Support CGROUPs resource management

2018-04-04 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1200#discussion_r179158191 --- Diff: distribution/src/resources/drill-env.sh --- @@ -86,6 +86,12 @@ #export DRILL_PID_DIR=${DRILL_PID_DIR:-$DRILL_HOME} +# CGroup

Drill Java doc

2018-04-04 Thread Vlad Rozov
Is Drill Java doc hosted on http://drill.apache.org or any other site? Thank you, Vlad

[GitHub] drill pull request #1200: DRILL-143: Support CGROUPs resource management

2018-04-04 Thread kkhatua
Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1200#discussion_r179156839 --- Diff: distribution/src/resources/drillbit.sh --- @@ -127,6 +127,44 @@ check_before_start() fi } +check_after_start(){ +