[GitHub] weijietong commented on a change in pull request #1459: DRILL-6731: Move the BFs aggregating work from the Foreman to the RuntimeFi…

2018-09-26 Thread GitBox
weijietong commented on a change in pull request #1459: DRILL-6731: Move the BFs aggregating work from the Foreman to the RuntimeFi… URL: https://github.com/apache/drill/pull/1459#discussion_r220789399 ## File path:

Re: [DISCUSS] Drill Hackathon/Drill Developers Day - 2018!

2018-09-26 Thread Charles Givre
Parth, Dreary rainy DC doesn’t do it for you? Sent from my iPhone > On Sep 26, 2018, at 17:09, Parth Chandra wrote: > > Hopefully it's somewhere nice and sunny. :) > > I'm planning to attend. > > >> On Wed, Sep 26, 2018 at 9:44 AM Rexwell Minnis wrote: >> >> I'm interested in attending,

Re: [DISCUSS] Drill Hackathon/Drill Developers Day - 2018!

2018-09-26 Thread Parth Chandra
Hopefully it's somewhere nice and sunny. :) I'm planning to attend. On Wed, Sep 26, 2018 at 9:44 AM Rexwell Minnis wrote: > I'm interested in attending, where is the proposed locations for the > November event? > > On Tuesday, September 25, 2018, Charles Givre wrote: > > > HI there, > > I am

[GitHub] sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs aggregating work from the Foreman to the RuntimeFi…

2018-09-26 Thread GitBox
sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs aggregating work from the Foreman to the RuntimeFi… URL: https://github.com/apache/drill/pull/1459#discussion_r220256674 ## File path:

[GitHub] sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs aggregating work from the Foreman to the RuntimeFi…

2018-09-26 Thread GitBox
sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs aggregating work from the Foreman to the RuntimeFi… URL: https://github.com/apache/drill/pull/1459#discussion_r220710747 ## File path:

[GitHub] sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs aggregating work from the Foreman to the RuntimeFi…

2018-09-26 Thread GitBox
sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs aggregating work from the Foreman to the RuntimeFi… URL: https://github.com/apache/drill/pull/1459#discussion_r219931981 ## File path:

[GitHub] sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs aggregating work from the Foreman to the RuntimeFi…

2018-09-26 Thread GitBox
sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs aggregating work from the Foreman to the RuntimeFi… URL: https://github.com/apache/drill/pull/1459#discussion_r220710086 ## File path:

[GitHub] sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs aggregating work from the Foreman to the RuntimeFi…

2018-09-26 Thread GitBox
sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs aggregating work from the Foreman to the RuntimeFi… URL: https://github.com/apache/drill/pull/1459#discussion_r219938720 ## File path:

[GitHub] sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs aggregating work from the Foreman to the RuntimeFi…

2018-09-26 Thread GitBox
sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs aggregating work from the Foreman to the RuntimeFi… URL: https://github.com/apache/drill/pull/1459#discussion_r219931819 ## File path:

[GitHub] sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs aggregating work from the Foreman to the RuntimeFi…

2018-09-26 Thread GitBox
sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs aggregating work from the Foreman to the RuntimeFi… URL: https://github.com/apache/drill/pull/1459#discussion_r219983879 ## File path:

[GitHub] sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs aggregating work from the Foreman to the RuntimeFi…

2018-09-26 Thread GitBox
sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs aggregating work from the Foreman to the RuntimeFi… URL: https://github.com/apache/drill/pull/1459#discussion_r219939606 ## File path:

Re: storage plugin test case

2018-09-26 Thread Jean-Claude Cote
I see how the cluster.makeDataDir call will setup the configuration for a MsgpackFormatConfig. I'll update my test cases to use it. However there is another question related to this. If I don't modify the boostrap-storage-plugins.json then when I launch the drill-embeded it does not know of the

Re: storage plugin test case

2018-09-26 Thread Arina Yelchiyeva
Taking into the account that your code is in the contrib module, modifying boostrap-storage-plugins.json does not make any sense. If you need to add your own format in unit tests, as Vitalii pointed out, TestCsv is a good example for this. Kind regards, Arina On Wed, Sep 26, 2018 at 7:07 PM

Re: storage plugin test case

2018-09-26 Thread Jean-Claude Cote
I found the cause of the problem I had. It was not due to the fact that the classloader did not find the resource. It is that my new FormatPlugin was not registered into the drill\exec\java-exec\src\main\resources\bootstrap-storage-plugins.json cp: { type: "file", connection:

[GitHub] KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution

2018-09-26 Thread GitBox
KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution URL: https://github.com/apache/drill/pull/1455#discussion_r220581387 ## File path:

[GitHub] KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution

2018-09-26 Thread GitBox
KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution URL: https://github.com/apache/drill/pull/1455#discussion_r220578653 ## File path:

[GitHub] KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution

2018-09-26 Thread GitBox
KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution URL: https://github.com/apache/drill/pull/1455#discussion_r220601506 ## File path:

Re: [DISCUSS] Drill Hackathon/Drill Developers Day - 2018!

2018-09-26 Thread Rexwell Minnis
I'm interested in attending, where is the proposed locations for the November event? On Tuesday, September 25, 2018, Charles Givre wrote: > HI there, > I am interested in attending, but it may have to be virtual as I am based > in DC. I’d love to hear about (and possibly present) use cases of

[GitHub] vdiravka commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution

2018-09-26 Thread GitBox
vdiravka commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution URL: https://github.com/apache/drill/pull/1455#discussion_r220527920 ## File path:

[GitHub] vdiravka commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution

2018-09-26 Thread GitBox
vdiravka commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution URL: https://github.com/apache/drill/pull/1455#discussion_r220549291 ## File path:

[GitHub] vdiravka commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution

2018-09-26 Thread GitBox
vdiravka commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution URL: https://github.com/apache/drill/pull/1455#discussion_r220538028 ## File path:

[GitHub] vdiravka commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution

2018-09-26 Thread GitBox
vdiravka commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution URL: https://github.com/apache/drill/pull/1455#discussion_r220518550 ## File path:

[GitHub] vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-09-26 Thread GitBox
vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#issuecomment-424684441 If this fix just improves the performance without any consequences, then there is no need to disable it

[GitHub] vvysotskyi commented on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-09-26 Thread GitBox
vvysotskyi commented on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#issuecomment-424684441 If this fix just improves the performance without any consequences, then there is no need to disable it or

Re: storage plugin test case

2018-09-26 Thread Arina Yelchiyeva
This can also help: 1. create TEST resources folder where you'll copy your data. 2. use dirTestWatcher to copy data to the root / tmp / custom directory. 3. query the data: @Test public void t() { dirTestWatcher.copyResourceToRoot(Paths.get("complex_1.parquet")); queryBuilder().sql("select *

Re: storage plugin test case

2018-09-26 Thread Vitalii Diravka
Hi Jean-Claude BaseTestQuery is deprecated. Please use ClusterTest instead. See TestCsv.java for example. You can find more info about Drill Cluster-Fixture-Framework here: https://github.com/paul-rogers/drill/wiki/Cluster-Fixture-Framework On Wed, Sep 26, 2018 at 12:00 AM Jean-Claude Cote

[GitHub] lushuifeng commented on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-09-26 Thread GitBox
lushuifeng commented on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#issuecomment-424647113 @vvysotskyi other tests will be provided later. This change have been tested in out prod env for a month, no

[GitHub] vvysotskyi commented on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-09-26 Thread GitBox
vvysotskyi commented on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#issuecomment-424637766 @lushuifeng, thanks, looks great! But could you please also provide results for JDK and Janino compilers

[GitHub] chunhui-shi commented on a change in pull request #1466: DRILL-6381: Add support for index based planning and execution

2018-09-26 Thread GitBox
chunhui-shi commented on a change in pull request #1466: DRILL-6381: Add support for index based planning and execution URL: https://github.com/apache/drill/pull/1466#discussion_r220464735 ## File path:

[GitHub] lushuifeng commented on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-09-26 Thread GitBox
lushuifeng commented on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#issuecomment-424612233 @vvysotskyi Just setters are added, I think others should work as before.

[GitHub] vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-09-26 Thread GitBox
vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#issuecomment-424602274 @lushuifeng, thanks for the contribution! Could you please provide the time of execution of the

[GitHub] vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-09-26 Thread GitBox
vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#issuecomment-424602274 @lushuifeng, thanks for the contribution! Besides setters added to the generated code, are there

[GitHub] vvysotskyi commented on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

2018-09-26 Thread GitBox
vvysotskyi commented on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values URL: https://github.com/apache/drill/pull/1481#issuecomment-424602274 @lushuifeng, thanks for the contribution! Besides setters added to the generated code, are there any