GitHub user adityakishore opened a pull request:
https://github.com/apache/drill/pull/249
DRILL-4050: Add zip archives to the list of artifacts in verify_releaâ¦
â¦se.sh
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user adityakishore commented on the pull request:
https://github.com/apache/drill/pull/188#issuecomment-146310855
Thanks for the review.
Since we are most likely going to have another RC for 1.2, I am planning to
merge it with current master so that the test artifacts
GitHub user adityakishore opened a pull request:
https://github.com/apache/drill/pull/188
DRILL-3888: Build test jars for all Drill Modules
This patch moves the test jar configuration to the root pom and remove it
from individual module's pom.
You can merge this pull request
Github user adityakishore commented on the issue:
https://github.com/apache/drill/pull/443
The latest patch, 323849e48fed967d43108e5cf85ba150a50f073e, moves the
GuavaPatcher class to java-exec module and run the GuavaPatcher at Drillbit
start (before the Stopwatch class is loaded
Github user adityakishore commented on the pull request:
https://github.com/apache/drill/commit/323849e48fed967d43108e5cf85ba150a50f073e#commitcomment-17847479
In
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseStoragePluginConfig.java:
In
contrib
Github user adityakishore commented on the issue:
https://github.com/apache/drill/pull/443
The latest and hopefully the last version of the patch
(c2d9959e07f47a09a4a11c250f84f4874b7e1db4), modified the GuavaPatcher in a way
to make it non-catastrophic failure to not able to patch
Github user adityakishore commented on a diff in the pull request:
https://github.com/apache/drill/pull/443#discussion_r65127177
--- Diff:
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/config/HBasePersistentStore.java
---
@@ -175,7 +179,7 @@ public boolean
Github user adityakishore commented on a diff in the pull request:
https://github.com/apache/drill/pull/443#discussion_r65254026
--- Diff:
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseStoragePlugin.java
---
@@ -21,34 +21,36 @@
import
Github user adityakishore commented on the pull request:
https://github.com/apache/drill/pull/443
Addressed Jacques' comments on the previous patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user adityakishore commented on the issue:
https://github.com/apache/drill/pull/506
+1 LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user adityakishore commented on the pull request:
https://github.com/apache/drill/pull/443
Unfortunately we can't, please see
https://github.com/apache/drill/pull/443#issuecomment-200580166
---
If your project is set up for it, you can reply to this email and have your
reply
Github user adityakishore commented on the pull request:
https://github.com/apache/drill/pull/443#issuecomment-222385259
The latest patch introduces a separate class `HBaseConnectionManager` and
moves the (HBase) connection life-cycle management responsibility from
HBaseStoragePlugin
GitHub user adityakishore opened a pull request:
https://github.com/apache/drill/pull/525
DRILL-4727: Exclude netty from HBase Client's transitive dependencies
Excluded `netty-all` from the list of transitive dependencies pulled by
`hbase-client`.
You can merge this pull request
GitHub user adityakishore opened a pull request:
https://github.com/apache/drill/pull/528
DRILL-4727: [Addendum] Exclude netty from HBase Client's transitive dâ¦
â¦ependencies
Excluded `netty-all` from the list of transitive dependencies pulled by
`mapr-hbase` in `mapr
Github user adityakishore commented on a diff in the pull request:
https://github.com/apache/drill/pull/421#discussion_r55577997
--- Diff: exec/jdbc/pom.xml ---
@@ -134,6 +134,7 @@
org.apache.hadoop
hadoop-common
+ test
GitHub user adityakishore opened a pull request:
https://github.com/apache/drill/pull/418
DRILL-4491: FormatPluginOptionsDescriptor requires FormatPluginConfigâ¦
⦠fields to be public
You can merge this pull request into a Git repository by running:
$ git pull https
Github user adityakishore commented on the pull request:
https://github.com/apache/drill/pull/418#issuecomment-194097775
Until I looked at the code, I was under assumption that we are using
Jackson to extract the serializable properties. We can, and should, definitely
go that route
GitHub user adityakishore opened a pull request:
https://github.com/apache/drill/pull/421
DRILL-4493 - Fixed issues in various POMs with MapR profile
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adityakishore/drill DRILL-4493
GitHub user adityakishore opened a pull request:
https://github.com/apache/drill/pull/427
DRILL-4501: Complete MapOrListWriter for all supported data types
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adityakishore/drill
Github user adityakishore commented on the pull request:
https://github.com/apache/drill/pull/249#issuecomment-196542189
This enhanced version of the script allows integrated download and
verification of a Drill release. It can be used to verify both the main release
artifacts
Github user adityakishore commented on the pull request:
https://github.com/apache/drill/pull/443#issuecomment-203699506
The latest patch, 1684daa5a081e1ae7d6d66cb5ee5e2f88015fc53, takes care of
HBase connection life-cycle management within the plugin's life-cycle.
---
If your
Github user adityakishore commented on the pull request:
https://github.com/apache/drill/pull/443#issuecomment-207022155
@jacques-n I'll wait for your final review before I merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user adityakishore commented on a diff in the pull request:
https://github.com/apache/drill/pull/443#discussion_r59120474
--- Diff:
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseStoragePlugin.java
---
@@ -19,36 +19,75 @@
import
Github user adityakishore commented on the pull request:
https://github.com/apache/drill/pull/443#issuecomment-200580166
`jcl-over-slf4j` works as long as the application use only the surface
logging APIs.
Unfortunately, HBase uses some [internal
classes](https://github.com
Github user adityakishore commented on the pull request:
https://github.com/apache/drill/pull/443#issuecomment-200991092
I'll take a look at the plugin life-cycle model and see if we can tie HBase
connection life-cycle to it.
As far as I know HBase follows a per-user
Github user adityakishore commented on a diff in the pull request:
https://github.com/apache/drill/pull/443#discussion_r57376985
--- Diff:
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/config/HBasePersistentStore.java
---
@@ -25,36 +25,40 @@
import
Github user adityakishore commented on a diff in the pull request:
https://github.com/apache/drill/pull/443#discussion_r57384412
--- Diff:
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/config/HBasePersistentStore.java
---
@@ -25,36 +25,40 @@
import
Github user adityakishore commented on a diff in the pull request:
https://github.com/apache/drill/pull/476#discussion_r59603934
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemPluginImplementationProvider.java
---
@@ -0,0 +1,141
Github user adityakishore commented on the issue:
https://github.com/apache/drill/pull/556
LGTM.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user adityakishore opened a pull request:
https://github.com/apache/drill/pull/586
DRILL-4886: Merge maprdb format plugin source code
These commits add MapR Format Plugin to Drill code base.
The default build/test/packaging behavior for mapr-format-plugin module
GitHub user adityakishore opened a pull request:
https://github.com/apache/drill/pull/587
DRILL-4894: Fix unit test failure in 'storage-hive/core' module
Exclude 'hadoop-mapreduce-client-core' and 'hadoop-auth' as transitive
dependencies from 'hbase-server'
You can merge this pull
Github user adityakishore commented on the issue:
https://github.com/apache/drill/pull/587
I have verified that this does not alter the content of binary package.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user adityakishore commented on the issue:
https://github.com/apache/drill/pull/670
Could you please add couple of unit test to verify the plan?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user adityakishore commented on the issue:
https://github.com/apache/drill/pull/688
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user adityakishore commented on a diff in the pull request:
https://github.com/apache/drill/pull/677#discussion_r90932924
--- Diff:
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/MapRDBFormatPluginConfig.java
---
@@ -65,6 +68,15 @@ public void
Github user adityakishore commented on the issue:
https://github.com/apache/drill/pull/678
+1
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user adityakishore commented on a diff in the pull request:
https://github.com/apache/drill/pull/700#discussion_r93487747
--- Diff:
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java
---
@@ -124,6 +124,11 @@ public
Github user adityakishore commented on a diff in the pull request:
https://github.com/apache/drill/pull/700#discussion_r93486944
--- Diff:
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java
---
@@ -124,6 +124,11 @@ public
Github user adityakishore commented on a diff in the pull request:
https://github.com/apache/drill/pull/875#discussion_r127295586
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -112,7 +112,8 @@ drill.exec: {
retry: {
count: 7200
Github user adityakishore commented on a diff in the pull request:
https://github.com/apache/drill/pull/875#discussion_r127295205
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKSecureACLProvider.java
---
@@ -0,0 +1,71 @@
+/**
+ * Licensed
Github user adityakishore commented on the issue:
https://github.com/apache/drill/pull/1007
+1
---
41 matches
Mail list logo
