Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r102291655
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillFilterRelBase.java
---
@@ -113,6 +114,6 @@ public double getRows
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r102291099
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unpivot/UnpivotMapsRecordBatch.java
---
@@ -0,0 +1,276
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r102290203
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatchCreator.java
---
@@ -0,0 +1,39
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r102290224
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unpivot/UnpivotMapsBatchCreator.java
---
@@ -0,0 +1,40
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r102289330
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatch.java
---
@@ -0,0 +1,532
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r102286549
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatch.java
---
@@ -0,0 +1,532
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r101180535
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatch.java
---
@@ -0,0 +1,532
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r101176671
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatch.java
---
@@ -0,0 +1,532
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r101173499
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r101167425
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r101155927
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100869218
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatch.java
---
@@ -0,0 +1,532
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100709767
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100709733
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100709630
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100709564
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100709555
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100708749
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100708249
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100708181
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100708170
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100708172
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100707677
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100707129
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100706700
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100705997
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/InternalBatch.java
---
@@ -88,4 +91,7 @@ public void clear
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100705962
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/InternalBatch.java
---
@@ -54,6 +56,7 @@ public InternalBatch
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100703479
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/StatisticsAggregate.java
---
@@ -0,0 +1,73 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100455272
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java ---
@@ -283,4 +286,18 @@ public void close() throws Exception
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100452345
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java ---
@@ -61,6 +61,7 @@
// in fragment contexts
public class
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100448803
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java ---
@@ -77,6 +78,7 @@
private final SchemaTreeProvider
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100446883
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java ---
@@ -392,6 +402,11 @@ public String getQueryUserName
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100445708
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java ---
@@ -245,6 +245,16 @@ public SchemaPlus getRootSchema
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100421972
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/ContextInformation.java
---
@@ -28,12 +28,14 @@
private final String
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100420583
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -390,4 +391,15 @@
String DYNAMIC_UDF_SUPPORT_ENABLED
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100416219
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/NestedLoopJoinPrule.java
---
@@ -84,8 +88,14 @@ public void onMatch
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100414605
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillJoinRelBase.java
---
@@ -99,9 +105,40 @@ public RelOptCost computeSelfCost
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100414561
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/cost/DrillRelMdRowCount.java
---
@@ -17,32 +17,81
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100414466
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/cost/DrillRelMdSelectivity.java
---
@@ -0,0 +1,219
Github user gparai commented on the issue:
https://github.com/apache/drill/pull/702
Thanks for adding the testcase.
+1 LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/741#discussion_r99470421
--- Diff:
contrib/storage-mongo/src/test/java/org/apache/drill/exec/store/mongo/TestTableGenerator.java
---
@@ -58,7 +59,12 @@ public static void
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/741#discussion_r99470619
--- Diff: contrib/storage-mongo/src/test/resources/datatype.json ---
@@ -0,0 +1 @@
+[{"_id": {"$oid" : "582081d96b69060001fd89
GitHub user gparai opened a pull request:
https://github.com/apache/drill/pull/729
Drill 1328 r4
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gparai/drill Drill-1328-r4
Alternatively you can review and apply these changes
Github user gparai commented on the issue:
https://github.com/apache/drill/pull/714
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/714#discussion_r95721099
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/CompliantTextRecordReader.java
---
@@ -91,6 +96,9 @@ public boolean
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/702#discussion_r95719700
--- Diff:
contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoGroupScan.java
---
@@ -503,7 +505,9 @@ public ScanStats getScanStats
Github user gparai commented on the issue:
https://github.com/apache/drill/pull/655
Thanks for the explanation and the corresponding changes. LGTM.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/653#discussion_r88306537
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -495,31 +499,65 @@ private ParquetFileMetadata_v3
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/653#discussion_r88306202
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -495,31 +499,65 @@ private ParquetFileMetadata_v3
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/653#discussion_r88292269
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -495,31 +499,65 @@ private ParquetFileMetadata_v3
Github user gparai commented on the issue:
https://github.com/apache/drill/pull/610
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gparai closed the pull request at:
https://github.com/apache/drill/pull/640
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user gparai reopened a pull request:
https://github.com/apache/drill/pull/640
Merge pull request #2 from apache/master
Sync with apache master
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gparai/drill master
Github user gparai closed the pull request at:
https://github.com/apache/drill/pull/640
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user gparai opened a pull request:
https://github.com/apache/drill/pull/640
Merge pull request #2 from apache/master
Sync with apache master
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gparai/drill master
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/610#discussion_r85036776
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/BooleanType.java
---
@@ -0,0 +1,67 @@
+/**
+ * Licensed to the Apache
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/610#discussion_r85036858
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/BooleanType.java
---
@@ -0,0 +1,67 @@
+/**
+ * Licensed to the Apache
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/610#discussion_r85038037
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestSimpleCastFunctions.java
---
@@ -18,18 +18,108 @@
package org.apache.drill.exec.sql
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/610#discussion_r85036792
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/BooleanType.java
---
@@ -0,0 +1,67 @@
+/**
+ * Licensed to the Apache
GitHub user gparai opened a pull request:
https://github.com/apache/drill/pull/606
Drill-1328: Compute and use statistics in Drill
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gparai/drill Drill-1328-r2
Alternatively you can
Github user gparai commented on the issue:
https://github.com/apache/drill/pull/604
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/604#discussion_r82294640
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java
---
@@ -1540,15 +1540,16 @@ public void eval() {
public
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/604#discussion_r82293808
--- Diff:
common/src/main/java/org/apache/drill/common/util/DrillStringUtils.java ---
@@ -160,10 +160,9 @@ private static void appendByte(StringBuilder result
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/604#discussion_r82293523
--- Diff:
common/src/main/java/org/apache/drill/common/util/DrillStringUtils.java ---
@@ -160,10 +160,9 @@ private static void appendByte(StringBuilder result
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r81438806
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java
---
@@ -408,6 +411,12 @@ private LogicalExpression
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r81438289
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java
---
@@ -408,6 +411,12 @@ private LogicalExpression
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r81440134
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/AnsiToJoda.java
---
@@ -0,0 +1,58 @@
+/*
+* Licensed to the Apache Software
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r81438363
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/AnsiToJoda.java
---
@@ -0,0 +1,58 @@
+/*
+* Licensed to the Apache Software
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r81439112
--- Diff:
logical/src/main/java/org/apache/drill/common/expression/fn/JodaDateValidator.java
---
@@ -0,0 +1,213 @@
+/*
+* Licensed to the Apache
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r81440360
--- Diff:
logical/src/main/java/org/apache/drill/common/expression/fn/JodaDateValidator.java
---
@@ -0,0 +1,213 @@
+/*
+* Licensed to the Apache
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r81438265
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java
---
@@ -408,6 +411,12 @@ private LogicalExpression
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r81244826
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -864,6 +872,14 @@ public String getDigest
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r81242837
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -864,6 +872,14 @@ public String getDigest
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r81232963
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -864,6 +872,14 @@ public String getDigest
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r80612914
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -899,6 +907,16 @@ public FileGroupScan clone
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r80613372
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -926,16 +944,22 @@ public GroupScan applyLimit(long
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r80612967
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -899,6 +907,16 @@ public FileGroupScan clone
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/593#discussion_r79761762
--- Diff: exec/java-exec/src/test/resources/store/text/WithQuotedCrLf.tbl
---
@@ -0,0 +1,6 @@
+"a
+1"|a|a
+a|"a
+2"|
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/593#discussion_r79761498
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/TextInput.java
---
@@ -273,7 +278,7 @@ public final byte nextChar
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/593#discussion_r79761364
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/TextReader.java
---
@@ -231,33 +231,34 @@ private void parseQuotedValue
Github user gparai commented on the pull request:
https://github.com/apache/drill/commit/da5981da6d25dbe8dff1468589be1e381b7e0251#commitcomment-19105735
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/592#discussion_r79663027
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java
---
@@ -108,7 +126,7 @@ public String
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/592#discussion_r79687833
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java
---
@@ -78,17 +79,34 @@ public String
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/592#discussion_r79688118
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java
---
@@ -78,17 +79,34 @@ public String
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/592#discussion_r79689068
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -291,6 +291,9 @@
String ENABLE_BULK_LOAD_TABLE_LIST_KEY
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/592#discussion_r79664175
--- Diff:
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java ---
@@ -122,6 +122,7 @@ public void testLikeNotLike() throws Exception
GitHub user gparai opened a pull request:
https://github.com/apache/drill/pull/588
Added test cases
Added testcases to verify plans and run the same for the group-by and non
group-by cases.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user gparai commented on the issue:
https://github.com/apache/drill/pull/587
+1, unit tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r77429753
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -308,33 +312,57 @@ public BitToUserHandshake
getHandshakeResponse
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r77429640
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -308,33 +312,57 @@ public BitToUserHandshake
getHandshakeResponse
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r77429494
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -308,33 +312,57 @@ public BitToUserHandshake
getHandshakeResponse
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r77429451
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationMechanismFactory.java
---
@@ -0,0 +1,182 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r77429414
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/plain/PlainServer.java
---
@@ -0,0 +1,174 @@
+/**
+ * Licensed to the Apache
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r77403393
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/AuthenticationUtil.java
---
@@ -0,0 +1,157 @@
+/**
+ * Licensed to the Apache
GitHub user gparai opened a pull request:
https://github.com/apache/drill/pull/563
[DRILL-4795] Nested aggregate windowed query fails-IllegalStateException
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gparai/drill Drill-4795
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/552#discussion_r71934130
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestPartitionFilter.java ---
@@ -376,4 +376,14 @@ public void testPartitionFilterWithLike() throws
GitHub user gparai opened a pull request:
https://github.com/apache/drill/pull/552
[Drill-3710] New option for the IN LIST size to convert into join
Add option planner.in_subquery_threshold to control the size of the IN list
for converting to join
You can merge this pull request
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/534#discussion_r71816185
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java
---
@@ -90,6 +91,62 @@ public void validate(OptionValue v
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/534#discussion_r71012854
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
---
@@ -251,7 +254,12 @@ public void setOption(final
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/529#discussion_r70878774
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java ---
@@ -844,4 +844,37 @@ public void testStatisticalWindowFunctions
101 - 200 of 212 matches
Mail list logo
