[GitHub] drill pull request #911: - DRILL-5507 Made verbose info logging message debu...

2017-08-17 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/911#discussion_r133838389 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/schedule/BlockMapBuilder.java --- @@ -246,12 +249,16 @@ public EndpointByteMap

[GitHub] drill pull request #911: - DRILL-5507 Made verbose info logging message debu...

2017-08-17 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/911#discussion_r133838104 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/schedule/BlockMapBuilder.java --- @@ -228,6 +230,7 @@ public EndpointByteMap

[GitHub] drill pull request #930: DRILL-5761: Disable Lilith ClassicMultiplexSocketAp...

2017-09-13 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/930#discussion_r138722693 --- Diff: common/src/test/resources/logback-test.xml --- @@ -0,0 +1,92 @@ + + + + + + + +true

[GitHub] drill issue #926: DRILL-5269 Make DirectSubScan Jackson JSON deserializable

2017-09-13 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/926 rebased and squashed ---

[GitHub] drill issue #926: DRILL-5269 Make DirectSubScan Jackson JSON deserializable

2017-09-13 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/926 @paul-rogers Added unit test and adopted query to an existing parquet file. ---

[GitHub] drill issue #977: DRILL-5849: Add freemarker lib to dependencyManagement to ...

2017-10-06 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/977 The proposed changes simplify the dependency management, but do not change the dependency resolution, AFAIK. ---

[GitHub] drill issue #977: DRILL-5849: Add freemarker lib to dependencyManagement to ...

2017-10-07 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/977 @arina-ielchiieva I refer to java-exec and fmpp modules dependencies resolution. Both AFAIK should not be affected by the change, so I suppose it is another module that has a transitive dependency

[GitHub] drill pull request #991: DRILL-5876: Remove netty-tcnative dependency from j...

2017-10-14 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/991#discussion_r144697258 --- Diff: exec/java-exec/pom.xml --- @@ -701,18 +707,21 @@ - -kr.motd.maven -os-maven-plugin -1.5.0

[GitHub] drill pull request #991: DRILL-5876: Remove netty-tcnative dependency from j...

2017-10-13 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/991#discussion_r144659314 --- Diff: exec/java-exec/pom.xml --- @@ -701,18 +707,21 @@ - -kr.motd.maven -os-maven-plugin -1.5.0

[GitHub] drill pull request #985: DRILL-5862 Update project parent pom xml to the lat...

2017-10-16 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/985#discussion_r144937286 --- Diff: pom.xml --- @@ -15,7 +15,8 @@ org.apache apache -14 +18 --- End diff -- @paul-rogers

[GitHub] drill pull request #991: DRILL-5876: Remove netty-tcnative dependency from j...

2017-10-16 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/991#discussion_r145008784 --- Diff: exec/java-exec/pom.xml --- @@ -701,18 +707,21 @@ - -kr.motd.maven -os-maven-plugin -1.5.0

[GitHub] drill pull request #991: DRILL-5876: Remove netty-tcnative dependency from j...

2017-10-13 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/991#discussion_r144624216 --- Diff: exec/java-exec/pom.xml --- @@ -701,18 +707,21 @@ - -kr.motd.maven -os-maven-plugin -1.5.0

[GitHub] drill pull request #934: DRILL-3449 When Foreman node dies, the FragmentExec...

2017-09-09 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/934#discussion_r137941417 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentStatusReporter.java --- @@ -113,4 +120,14 @@ void fail(final UserException

[GitHub] drill issue #926: DRILL-5269 Make DirectSubScan Jackson JSON deserializable

2017-09-09 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/926 @paul-rogers I guess you refer to a system/integration test (execute the query provided in JIRA), not a unit test. ---

[GitHub] drill pull request #934: DRILL-3449 When Foreman node dies, the FragmentExec...

2017-09-06 Thread vrozov
GitHub user vrozov opened a pull request: https://github.com/apache/drill/pull/934 DRILL-3449 When Foreman node dies, the FragmentExecutor still tries to send status updates to Foreman You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] drill issue #934: DRILL-3449 When Foreman node dies, the FragmentExecutor st...

2017-09-07 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/934 @paul-rogers Please review ---

[GitHub] drill pull request #926: DRILL-5269 Make DirectSubScan Jackson JSON deserial...

2017-09-07 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/926#discussion_r137658224 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/RecordReader.java --- @@ -26,6 +26,9 @@ import

[GitHub] drill pull request #934: DRILL-3449 When Foreman node dies, the FragmentExec...

2017-09-09 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/934#discussion_r137941124 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentStatusReporter.java --- @@ -113,4 +120,14 @@ void fail(final UserException

[GitHub] drill pull request #930: DRILL-5761: Disable Lilith ClassicMultiplexSocketAp...

2017-09-12 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/930#discussion_r138407993 --- Diff: common/src/test/resources/logback-test.xml --- @@ -0,0 +1,111 @@ + + + + + + + +true

[GitHub] drill pull request #930: DRILL-5761: Disable Lilith ClassicMultiplexSocketAp...

2017-09-12 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/930#discussion_r138408349 --- Diff: common/src/test/resources/logback-test.xml --- @@ -0,0 +1,92 @@ + + + + + + + +true

[GitHub] drill pull request #913: - DRILL-5729 Fix Travis Build

2017-08-24 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/913#discussion_r135148431 --- Diff: .travis.yml --- @@ -13,8 +13,10 @@ # See the License for the specific language governing permissions and # limitations under the License

[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build

2017-08-24 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/913 @ilooner-mapr Do you know why it fails on the Trusty (new default)? Going back to using Precise is OK for a while, but my guess that it will eventually become obsolete. --- If your project is set up

[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build

2017-08-24 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/913 @ilooner-mapr I tested it on my branch and it works with the default jdk and without *sudo*. Add `MAVEN_OPTS="-Xms1G -Xmx1G"` before `mvn`. Can you remove leading dash from the comm

[GitHub] drill pull request #913: - DRILL-5729 Fix Travis Build

2017-08-24 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/913#discussion_r135143313 --- Diff: .travis.yml --- @@ -13,8 +13,10 @@ # See the License for the specific language governing permissions and # limitations under the License

[GitHub] drill pull request #913: - DRILL-5729 Fix Travis Build

2017-08-25 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/913#discussion_r135291374 --- Diff: .travis.yml --- @@ -13,8 +13,9 @@ # See the License for the specific language governing permissions and # limitations under the License

[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build

2017-08-25 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/913 @parthchandra LGTM. There are questions that I have related to how travis-ci build is configured, but they are for pre-existing settings and can be addressed in a follow up PR if necessary

[GitHub] drill pull request #930: DRILL-5761: Disable Lilith ClassicMultiplexSocketAp...

2017-09-04 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/930#discussion_r136835528 --- Diff: common/src/test/resources/logback.xml --- @@ -16,17 +16,22 @@ 1 true ${LILITH_HOSTNAME:-localhost} +

[GitHub] drill pull request #926: DRILL-5269 Make DirectSubScan Jackson JSON deserial...

2017-08-29 Thread vrozov
GitHub user vrozov opened a pull request: https://github.com/apache/drill/pull/926 DRILL-5269 Make DirectSubScan Jackson JSON deserializable @amansinha100 Please review You can merge this pull request into a Git repository by running: $ git pull https://github.com/vrozov/drill

[GitHub] drill pull request #965: DRILL-5811 reduced repeated log messages further.

2017-10-09 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/965#discussion_r14359 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/schedule/BlockMapBuilder.java --- @@ -104,12 +104,16 @@ public BlockMapReader(FileStatus

[GitHub] drill pull request #985: DRILL-5862 Update project parent pom xml to the lat...

2017-10-11 Thread vrozov
GitHub user vrozov opened a pull request: https://github.com/apache/drill/pull/985 DRILL-5862 Update project parent pom xml to the latest ASF version You can merge this pull request into a Git repository by running: $ git pull https://github.com/vrozov/drill DRILL-5862

[GitHub] drill pull request #985: DRILL-5862 Update project parent pom xml to the lat...

2017-10-12 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/985#discussion_r144339857 --- Diff: pom.xml --- @@ -15,7 +15,8 @@ org.apache apache -14 +18 + --- End diff -- Yes, to make

[GitHub] drill pull request #985: DRILL-5862 Update project parent pom xml to the lat...

2017-10-12 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/985#discussion_r144351062 --- Diff: pom.xml --- @@ -15,7 +15,8 @@ org.apache apache -14 +18 + --- End diff -- Try to add

[GitHub] drill pull request #991: DRILL-5876: Remove netty-tcnative dependency from j...

2017-10-17 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/991#discussion_r145289493 --- Diff: exec/java-exec/pom.xml --- @@ -693,6 +699,19 @@ + + openssl

[GitHub] drill pull request #991: DRILL-5876: Remove netty-tcnative dependency from j...

2017-10-17 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/991#discussion_r145291048 --- Diff: exec/java-exec/pom.xml --- @@ -22,7 +22,10 @@ 1.8-rev1 + --- End diff -- Please uncomment (should

[GitHub] drill pull request #1048: DRILL-5987: Use one version of javassist

2017-11-22 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1048#discussion_r152690825 --- Diff: common/pom.xml --- @@ -63,12 +63,29 @@ org.msgpack msgpack 0.6.6 + --- End diff

[GitHub] drill issue #1031: DRILL-5917: Ban org.json:json library in Drill

2017-11-22 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1031 rebased to upstream/master and squashed commits. ---

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

2017-11-29 Thread vrozov
GitHub user vrozov opened a pull request: https://github.com/apache/drill/pull/1058 DRILL-6002: Avoid memory copy from direct buffer to heap while spilling to local disk @paul-rogers Please review You can merge this pull request into a Git repository by running: $ git pull

[GitHub] drill pull request #1073: DRILL-5967: Fixed memory leak in OrderedPartitionS...

2017-12-18 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1073#discussion_r157605488 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/partitionsender/TestPartitionSender.java --- @@ -350,7 +350,7 @@ public void

[GitHub] drill pull request #1073: DRILL-5967: Fixed memory leak in OrderedPartitionS...

2017-12-18 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1073#discussion_r157605837 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionSenderCreator.java --- @@ -35,7 +35,5 @@ public RootExec

[GitHub] drill pull request #1073: DRILL-5967: Fixed memory leak in OrderedPartitionS...

2017-12-18 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1073#discussion_r157545737 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionSenderRootExec.java --- @@ -98,10 +100,12 @@ public int

[GitHub] drill pull request #1075: DRILL-6030: Managed sort should minimize number of...

2017-12-18 Thread vrozov
GitHub user vrozov opened a pull request: https://github.com/apache/drill/pull/1075 DRILL-6030: Managed sort should minimize number of batches in a k-way merge @paul-rogers Please review You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] drill issue #1073: DRILL-5967: Fixed memory leak in OrderedPartitionSender

2017-12-19 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1073 LGTM ---

[GitHub] drill pull request #1075: DRILL-6030: Managed sort should minimize number of...

2017-12-19 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1075#discussion_r157885846 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SortConfig.java --- @@ -84,7 +85,7 @@ public SortConfig(DrillConfig

[GitHub] drill issue #1075: DRILL-6030: Managed sort should minimize number of batche...

2017-12-19 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1075 The scenario when all batches can be merged in memory is covered by 'if (canUseMemoryMerge())` check in `SortImpl.java:399`. The affected code path applies only to cases where merge between spilled

[GitHub] drill issue #1070: DRILL-6004: Direct buffer bounds checking should be disab...

2017-12-12 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1070 @paul-rogers Please review ---

[GitHub] drill pull request #1070: DRILL-6004: Direct buffer bounds checking should b...

2017-12-12 Thread vrozov
GitHub user vrozov opened a pull request: https://github.com/apache/drill/pull/1070 DRILL-6004: Direct buffer bounds checking should be disabled by default You can merge this pull request into a Git repository by running: $ git pull https://github.com/vrozov/drill DRILL-6004

[GitHub] drill issue #1031: DRILL-5917: Ban org.json:json library in Drill

2017-11-17 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1031 @arina-ielchiieva Please test ---

[GitHub] drill issue #1031: DRILL-5917: Ban org.json:json library in Drill

2017-11-17 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1031 I already tested mapr and default profile locally. Once test pass on your cluster, let me know and I'll squash commits. ---

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

2017-11-10 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r150259975 --- Diff: pom.xml --- @@ -442,7 +442,7 @@ -Dorg.apache.drill.exec.server.Drillbit.system_options

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

2017-11-10 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r150322554 --- Diff: pom.xml --- @@ -442,7 +442,7 @@ -Dorg.apache.drill.exec.server.Drillbit.system_options

[GitHub] drill pull request #1025: DRILL-5936: Refactor MergingRecordBatch based on c...

2017-11-10 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1025#discussion_r150331389 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java --- @@ -795,6 +788,8 @@ private void

[GitHub] drill pull request #1025: DRILL-5936: Refactor MergingRecordBatch based on c...

2017-11-10 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1025#discussion_r150326663 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java --- @@ -177,11 +177,11 @@ public

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

2017-11-10 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r150348155 --- Diff: pom.xml --- @@ -442,7 +442,7 @@ -Dorg.apache.drill.exec.server.Drillbit.system_options

[GitHub] drill issue #1031: DRILL-5917: Ban org.json:json library in Drill

2017-11-13 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1031 @arina-ielchiieva Please attach the full log to JIRA. ---

[GitHub] drill issue #1031: DRILL-5917: Ban org.json:json library in Drill

2017-11-13 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1031 @arina-ielchiieva Please test with the latest commit. I changed mapr version back to 5.2.1, note that 2.7.0-mapr-1707 is compiled with 5.2.2 ---

[GitHub] drill pull request #1041: DRILL-5961: For long running queries (> 10 min) Dr...

2017-11-16 Thread vrozov
GitHub user vrozov opened a pull request: https://github.com/apache/drill/pull/1041 DRILL-5961: For long running queries (> 10 min) Drill may raise FragmentSetupException for completed/cancelled fragments You can merge this pull request into a Git repository by runn

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

2017-11-06 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r149230560 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -158,38 +165,49 @@ public DrillbitContext getContext

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

2017-11-06 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r149234360 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -158,38 +165,49 @@ public DrillbitContext getContext

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

2017-11-06 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r149232323 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -158,38 +165,49 @@ public DrillbitContext getContext

[GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin

2017-11-09 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1027#discussion_r150019576 --- Diff: contrib/storage-kafka/pom.xml --- @@ -0,0 +1,130 @@ + + +http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd

[GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin

2017-11-09 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1027#discussion_r150028303 --- Diff: contrib/storage-kafka/pom.xml --- @@ -0,0 +1,130 @@ + + +http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd

[GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin

2017-11-09 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1027#discussion_r150030044 --- Diff: contrib/storage-kafka/pom.xml --- @@ -0,0 +1,130 @@ + + +http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd

[GitHub] drill pull request #1027: DRILL-4779 : Kafka storage plugin

2017-11-09 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1027#discussion_r150029170 --- Diff: contrib/storage-kafka/pom.xml --- @@ -0,0 +1,130 @@ + + +http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd

[GitHub] drill pull request #1031: DRILL-5917: Ban org.json:json library in Drill

2017-11-09 Thread vrozov
GitHub user vrozov opened a pull request: https://github.com/apache/drill/pull/1031 DRILL-5917: Ban org.json:json library in Drill @arina-ielchiieva Please review You can merge this pull request into a Git repository by running: $ git pull https://github.com/vrozov/drill DRILL

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

2017-11-03 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r14668 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -158,38 +165,51 @@ public DrillbitContext getContext

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

2017-11-03 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r148889092 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -158,38 +165,51 @@ public DrillbitContext getContext

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

2017-12-02 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154499154 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorSerializer.java --- @@ -62,27 +72,65 @@ public Writer write(VectorAccessible va

[GitHub] drill pull request #1058: DRILL-6002: Avoid memory copy from direct buffer t...

2017-12-02 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1058#discussion_r154499915 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorSerializer.java --- @@ -40,20 +52,18 @@ */ public static class

[GitHub] drill pull request #1041: DRILL-5961: For long running queries (> 10 min) Dr...

2017-12-06 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1041#discussion_r155433860 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/WorkEventBus.java --- @@ -74,83 +70,42 @@ public void statusUpdate(final

[GitHub] drill pull request #1041: DRILL-5961: For long running queries (> 10 min) Dr...

2017-12-06 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1041#discussion_r155433245 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -277,7 +277,9 @@ public void startFragmentPendingRemote(final

[GitHub] drill issue #1012: DRILL-5911: Upgrade esri-geometry-api version to 2.0.0 to...

2017-10-28 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1012 OK. LGTM. ---

[GitHub] drill issue #1013: DRILL-5910: Logging exception when custom AuthenticatorFa...

2017-10-30 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1013 LGTM ---

[GitHub] drill pull request #1009: DRILL-5905: Exclude jdk-tools from project depende...

2017-10-24 Thread vrozov
GitHub user vrozov opened a pull request: https://github.com/apache/drill/pull/1009 DRILL-5905: Exclude jdk-tools from project dependencies You can merge this pull request into a Git repository by running: $ git pull https://github.com/vrozov/drill DRILL-5905 Alternatively

[GitHub] drill pull request #1004: DRILL-5876: Use openssl profile to include netty-t...

2017-10-20 Thread vrozov
GitHub user vrozov opened a pull request: https://github.com/apache/drill/pull/1004 DRILL-5876: Use openssl profile to include netty-tcnative dependency with the platform specific classifier You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] drill issue #991: DRILL-5876: Remove netty-tcnative dependency from java-exe...

2017-10-20 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/991 @parthchandra open PR #1004 ---

[GitHub] drill issue #1012: DRILL-5911: Upgrade esri-geometry-api version to 2.0.0 to...

2017-10-28 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1012 @vvysotskyi I refer to JSON format that ESRI supports by itself. ---

[GitHub] drill issue #1013: DRILL-5910: Add factory name to ClassNotFoundException me...

2017-10-28 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1013 @vladimirtkach Who is the target of the message? If it is Java developers, the message makes sense. If it is for drill users or devops, the message is useless. ---

[GitHub] drill issue #1013: DRILL-5910: Add factory name to ClassNotFoundException me...

2017-10-28 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1013 @arina-ielchiieva I guess just logging an exception does not help unless it targets Java developers. Consider logging a message that has information regarding which authentication provider can't

[GitHub] drill pull request #1238: DRILL-6281: Refactor TimedRunnable

2018-04-27 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1238#discussion_r184694930 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/TimedCallable.java --- @@ -0,0 +1,266 @@ +/* + * Licensed to the Apache Software

[GitHub] drill issue #1214: DRILL-6331: Revisit Hive Drill native parquet implementat...

2018-04-27 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1214 When moving files around please preserve the history of modifications done to the file. ---

[GitHub] drill pull request #1238: DRILL-6281: Refactor TimedRunnable

2018-04-27 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1238#discussion_r184691926 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/TimedCallable.java --- @@ -0,0 +1,258 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #1238: DRILL-6281: Refactor TimedRunnable

2018-04-27 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1238#discussion_r184724657 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/TimedCallable.java --- @@ -0,0 +1,266 @@ +/* + * Licensed to the Apache Software

[GitHub] drill issue #1237: DRILL-6348: Fixed code so that Unordered Receiver reports...

2018-04-27 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1237 IMO, it will be good to understand what other operators do as well. For example what Project or Filter operators do. Do they take ownership of incoming batches? And if they do, when is the ownership

[GitHub] drill pull request #1237: DRILL-6348: Fixed code so that Unordered Receiver ...

2018-04-27 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1237#discussion_r184804819 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java --- @@ -149,25 +149,32 @@ private

[GitHub] drill pull request #1224: DRILL-6321: Customize Drill's conformance. Allow s...

2018-05-01 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1224#discussion_r185351651 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillConformance.java --- @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #1225: DRILL-6272: Refactor dynamic UDFs and function ini...

2018-05-01 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1225#discussion_r185374827 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestCTTAS.java --- @@ -164,121 +166,113 @@ public void

[GitHub] drill pull request #1225: DRILL-6272: Refactor dynamic UDFs and function ini...

2018-05-01 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1225#discussion_r185353418 --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestTpchDistributedConcurrent.java --- @@ -177,7 +177,7 @@ public void run

[GitHub] drill pull request #1225: DRILL-6272: Refactor dynamic UDFs and function ini...

2018-05-01 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1225#discussion_r185375540 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestCTTAS.java --- @@ -498,47 +489,50 @@ public void

[GitHub] drill pull request #1225: DRILL-6272: Refactor dynamic UDFs and function ini...

2018-05-01 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1225#discussion_r185369981 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/coord/zk/TestZookeeperClient.java --- @@ -125,7 +125,7 @@ public void

[GitHub] drill pull request #1225: DRILL-6272: Refactor dynamic UDFs and function ini...

2018-05-01 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1225#discussion_r185374205 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestCTTAS.java --- @@ -164,121 +166,113 @@ public void

[GitHub] drill pull request #1225: DRILL-6272: Refactor dynamic UDFs and function ini...

2018-05-01 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1225#discussion_r185385028 --- Diff: exec/java-exec/src/test/resources/drill-udf/pom.xml --- @@ -0,0 +1,90 @@ + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi

[GitHub] drill pull request #1225: DRILL-6272: Refactor dynamic UDFs and function ini...

2018-05-01 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1225#discussion_r185383432 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/udf/dynamic/JarBuilder.java --- @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #1225: DRILL-6272: Refactor dynamic UDFs and function ini...

2018-05-02 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1225#discussion_r185497944 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/coord/zk/TestZookeeperClient.java --- @@ -125,7 +125,7 @@ public void

[GitHub] drill pull request #1225: DRILL-6272: Refactor dynamic UDFs and function ini...

2018-04-26 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1225#discussion_r184245358 --- Diff: pom.xml --- @@ -798,7 +798,7 @@ com.googlecode.jmockit jmockit - 1.3 + 1.7 --- End diff

[GitHub] drill pull request #1225: DRILL-6272: Refactor dynamic UDFs and function ini...

2018-04-26 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1225#discussion_r184411700 --- Diff: exec/java-exec/pom.xml --- @@ -593,6 +593,48 @@ netty-tcnative ${netty.tcnative.classifier

[GitHub] drill issue #1238: DRILL-6281: Refactor TimedRunnable

2018-04-26 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1238 The step is necessary to do RCA for DRILL-5908. There are way too many issues with the current implementation to list them in JIRA or PR and the major issue is the usage of homegrown solutions where

[GitHub] drill issue #1238: DRILL-6281: Refactor TimedRunnable

2018-04-26 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1238 I did not change how tasks (`Runnable` or `Callable`) behave and did not look into converting `Callable/Runnable` to a `ForkJoinTask`. Whether existing tasks can be scheduled recursively

[GitHub] drill issue #1238: DRILL-6281: Refactor TimedRunnable

2018-04-26 Thread vrozov
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1238 There is not enough info available to debug and/or troubleshoot DRILL-5908 and I prefer instead of trying to find bugs in homegrown solution replace it with Java out of the box functionality

[GitHub] drill pull request #1237: DRILL-6348: Fixed code so that Unordered Receiver ...

2018-04-26 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1237#discussion_r184590436 --- Diff: exec/memory/base/src/main/java/org/apache/drill/exec/memory/AllocationManager.java --- @@ -253,10 +261,12 @@ public boolean transferBalance(final

[GitHub] drill pull request #1237: DRILL-6348: Fixed code so that Unordered Receiver ...

2018-04-26 Thread vrozov
Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1237#discussion_r184596895 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RawFragmentBatch.java --- @@ -77,4 +83,46 @@ public long getByteCount() { public

  1   2   3   4   >