Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1190#discussion_r177300882
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -558,7 +558,7 @@ private ExecConstants
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1189
@vdiravka right, check the first link, the new `groupId` for
`com.codahale.metrics` is `io.dropwizard.metrics`, so all new versions will be
deployed using the new `groupId`.
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1185#discussion_r177499603
--- Diff: exec/jdbc-all/pom.xml ---
@@ -559,7 +559,7 @@
This is likely due to you adding new
dependencies to a java-exec
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1182
@parthchandra Please review
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1190#discussion_r177103076
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -558,7 +558,7 @@ private ExecConstants
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1182
There are two issues with enabling `apache-release` by default:
- it triggers creating source `apache-drill-...-src.tar.gz` and
`apache-drill-...-src.zip` archives.
- maven build for any sub
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1182#discussion_r178567909
--- Diff: pom.xml ---
@@ -66,6 +66,7 @@
4096
4096
+-Xdoclint:none
--- End diff --
@vdiravka Please see DRILL
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1144
It is not clear why get/set Byte/Char/Short/Int/Long/Float/Double do not
delegate to UDLE, while get/set Bytes delegates to UDLE and relies on netty
'AbstractByteBuf` for bounds checking. IMO
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1144
IMO, this PR or DRILL-6202 is not the best place to discuss boundary
checking as the PR and JIRA deals with `IndexOutOfBoundsException` but does not
change how DrillBuf, Vector or Operators ensure
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1195#discussion_r178953868
--- Diff: tools/fmpp/src/main/java/bsh/package-info.java ---
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1195#discussion_r178364790
--- Diff: tools/fmpp/src/main/java/bsh/EvalError.java ---
@@ -0,0 +1,28 @@
+/**
--- End diff --
Please do not use doc comment for the license.
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1195#discussion_r178365989
--- Diff: tools/fmpp/src/main/java/bsh/EvalError.java ---
@@ -0,0 +1,28 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1195#discussion_r178366218
--- Diff: tools/fmpp/pom.xml ---
@@ -57,6 +57,10 @@
commons-logging-api
commons-logging
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1196#discussion_r178376362
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java ---
@@ -212,19 +218,29 @@ private boolean areQueriesAndFragmentsEmpty
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1196#discussion_r178376213
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java ---
@@ -212,19 +218,29 @@ private boolean areQueriesAndFragmentsEmpty
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1196#discussion_r178375583
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java ---
@@ -86,6 +86,9 @@
private final StatusThread statusThread
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1105
@arina-ielchiieva Please review.
---
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1144
Is there a reason to delegate `get/setBytes` to `AbstractByteBuf`? If not,
this PR will be a preparation step to use `PlatformDependent` directly
bypassing Netty bounds checking.
---
GitHub user vrozov opened a pull request:
https://github.com/apache/drill/pull/1182
DRILL-6287: apache-release profile should be disabled by default
@parthchandra @dvjyothsna Please review
You can merge this pull request into a Git repository by running:
$ git pull https
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1177#discussion_r176260351
--- Diff: exec/java-exec/pom.xml ---
@@ -828,31 +828,9 @@
-
+
org.codehaus.mojo
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1177
@vdiravka Please clarify your concern regarding logback-classic. Without
the fix, logback-classic is not on the classpath during `exec:java` maven
plugin execution. This causes the following issue
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1177#discussion_r176262322
--- Diff: common/pom.xml ---
@@ -113,20 +113,10 @@
org.codehaus.mojo
exec-maven-plugin
-1.2.1
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1163
@arina-ielchiieva Addressed review comments. Please keep both commits (do
not squash) during the merge.
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1177#discussion_r176263130
--- Diff: exec/java-exec/pom.xml ---
@@ -828,31 +828,9 @@
-
+
org.codehaus.mojo
GitHub user vrozov opened a pull request:
https://github.com/apache/drill/pull/1185
DRILL-6288: Upgrade org.javassist:javassist and org.reflections:reflections
@vdiravka Please review
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user vrozov opened a pull request:
https://github.com/apache/drill/pull/1177
DRILL-6280: Cleanup execution of BuildTimeScan during maven build
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vrozov/drill DRILL-6280
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1177
@vdiravka Please review
---
GitHub user vrozov opened a pull request:
https://github.com/apache/drill/pull/1144
DRILL-6202: Deprecate usage of IndexOutOfBoundsException to re-alloc vectors
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vrozov/drill DRILL
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1144
@parthchandra Please take a look.
---
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1105
@ilooner What state is protected by `syncrhonized`? Why is it not
sufficient to use `volatile` and `AtomicReference`?
---
GitHub user vrozov opened a pull request:
https://github.com/apache/drill/pull/1148
DRILL-5994: enable configuring number of Jetty acceptors and selectors
(default to 1 acceptor and 2 selectors)
@arina-ielchiieva @ilooner @MitchelLabonte Please review
You can merge this pull
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1148#discussion_r171987801
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
---
@@ -154,35 +152,31 @@ public void start() throws Exception
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1148#discussion_r171989096
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
---
@@ -424,10 +418,11 @@ private ServerConnector
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/755
@kkhatua
1. The read locks are not exclusive (single writer/multiple readers). To
achieve the required functionality you need to introduce a different lock and
use write (or exclusive) lock.
2
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1148#discussion_r171988826
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
---
@@ -411,6 +404,7 @@ private ServerConnector createHttpsConnector
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1105#discussion_r170782805
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionSenderRootExec.java
---
@@ -62,7 +62,7 @@
private
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184154997
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/RawFragmentBatch.java
---
@@ -77,4 +83,46 @@ public long getByteCount() {
public
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184156922
--- Diff:
exec/memory/base/src/main/java/org/apache/drill/exec/memory/AllocationManager.java
---
@@ -253,10 +261,12 @@ public boolean transferBalance(final
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184159218
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -153,8 +153,10 @@ private
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184155724
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/RawFragmentBatch.java
---
@@ -77,4 +83,46 @@ public long getByteCount() {
public
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1189
LGTM
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1189#discussion_r184243564
--- Diff: logical/pom.xml ---
@@ -85,14 +85,12 @@
- com.codahale.metrics
+ io.dropwizard.metrics
--- End
301 - 342 of 342 matches
Mail list logo
