[GitHub] [drill] cgivre commented on a change in pull request #2069: DRILL-7723 - Add Excel Metadata as Implicit Fields

cgivre commented on a change in pull request #2069: URL: https://github.com/apache/drill/pull/2069#discussion_r439841135 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ## @@ -56,60 +61,70 @@ private static final

[GitHub] [drill] cgivre commented on a change in pull request #2069: DRILL-7723 - Add Excel Metadata as Implicit Fields

cgivre commented on a change in pull request #2069: URL: https://github.com/apache/drill/pull/2069#discussion_r439830508 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ## @@ -56,60 +61,70 @@ private static final

[GitHub] [drill] cgivre commented on a change in pull request #2069: DRILL-7723 - Add Excel Metadata as Implicit Fields

cgivre commented on a change in pull request #2069: URL: https://github.com/apache/drill/pull/2069#discussion_r439499328 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ## @@ -56,60 +61,70 @@ private static final

[GitHub] [drill] cgivre commented on a change in pull request #2069: DRILL-7723 - Add Excel Metadata as Implicit Fields

cgivre commented on a change in pull request #2069: URL: https://github.com/apache/drill/pull/2069#discussion_r430090264 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ## @@ -56,60 +61,70 @@ private static final

[GitHub] [drill] cgivre commented on a change in pull request #2069: DRILL-7723 - Add Excel Metadata as Implicit Fields

cgivre commented on a change in pull request #2069: URL: https://github.com/apache/drill/pull/2069#discussion_r429710656 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ## @@ -420,15 +510,57 @@ private void

[GitHub] [drill] cgivre commented on a change in pull request #2069: DRILL-7723 - Add Excel Metadata as Implicit Fields

cgivre commented on a change in pull request #2069: URL: https://github.com/apache/drill/pull/2069#discussion_r429710349 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ## @@ -420,15 +510,57 @@ private void

[GitHub] [drill] cgivre commented on a change in pull request #2069: DRILL-7723 - Add Excel Metadata as Implicit Fields

cgivre commented on a change in pull request #2069: URL: https://github.com/apache/drill/pull/2069#discussion_r429675715 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ## @@ -75,7 +83,9 @@ private Row currentRow;

[GitHub] [drill] cgivre commented on a change in pull request #2069: DRILL-7723 - Add Excel Metadata as Implicit Fields

cgivre commented on a change in pull request #2069: URL: https://github.com/apache/drill/pull/2069#discussion_r429675286 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ## @@ -75,7 +83,9 @@ private Row currentRow;

[GitHub] [drill] cgivre commented on a change in pull request #2069: DRILL-7723 - Add Excel Metadata as Implicit Fields

cgivre commented on a change in pull request #2069: URL: https://github.com/apache/drill/pull/2069#discussion_r429675060 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ## @@ -348,6 +405,27 @@ private boolean

[GitHub] [drill] cgivre commented on a change in pull request #2069: DRILL-7723 - Add Excel Metadata as Implicit Fields

cgivre commented on a change in pull request #2069: URL: https://github.com/apache/drill/pull/2069#discussion_r429672215 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ## @@ -147,10 +185,15 @@ private void

[GitHub] [drill] cgivre commented on a change in pull request #2069: DRILL-7723 - Add Excel Metadata as Implicit Fields

cgivre commented on a change in pull request #2069: URL: https://github.com/apache/drill/pull/2069#discussion_r429672084 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ## @@ -75,7 +83,9 @@ private Row currentRow;

[GitHub] [drill] cgivre commented on a change in pull request #2069: DRILL-7723 - Add Excel Metadata as Implicit Fields

cgivre commented on a change in pull request #2069: URL: https://github.com/apache/drill/pull/2069#discussion_r429672042 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ## @@ -420,15 +510,57 @@ private void

[GitHub] [drill] cgivre commented on a change in pull request #2069: DRILL-7723 - Add Excel Metadata as Implicit Fields

cgivre commented on a change in pull request #2069: URL: https://github.com/apache/drill/pull/2069#discussion_r429671379 ## File path: contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java ## @@ -112,6 +112,42 @@ public void

[GitHub] [drill] cgivre commented on a change in pull request #2069: DRILL-7723 - Add Excel Metadata as Implicit Fields

cgivre commented on a change in pull request #2069: URL: https://github.com/apache/drill/pull/2069#discussion_r429670873 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ## @@ -199,7 +245,7 @@ private void

[GitHub] [drill] cgivre commented on a change in pull request #2069: DRILL-7723 - Add Excel Metadata as Implicit Fields

cgivre commented on a change in pull request #2069: URL: https://github.com/apache/drill/pull/2069#discussion_r429670719 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ## @@ -75,7 +83,9 @@ private Row currentRow;

[GitHub] [drill] cgivre commented on a change in pull request #2069: DRILL-7723 - Add Excel Metadata as Implicit Fields

cgivre commented on a change in pull request #2069: URL: https://github.com/apache/drill/pull/2069#discussion_r429670630 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ## @@ -75,7 +83,9 @@ private Row currentRow;