amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature
URL: https://github.com/apache/drill/pull/1334#issuecomment-414392376
@sohami thanks for the detailed follow-up review and running the regression
tests with the PR (I assume with default setting of run-time pushdown
amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature
URL: https://github.com/apache/drill/pull/1334#issuecomment-409629930
@sohami pls see if your comments are addressed. @weijietong just FYI, the
ongoing 1.14.0 release is yet to be finished (it is in voting stage), so
amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature
URL: https://github.com/apache/drill/pull/1334#issuecomment-408948442
Since most of my comments have been addressed, I am +1. Thanks
@weijietong.
Once you address @sohami 's comments, the next steps would be:
amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature
URL: https://github.com/apache/drill/pull/1334#issuecomment-407121370
@weijietong thanks for your patience. I have submitted a final round of
review comments. Once you address them we can get the feature merged
amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature
URL: https://github.com/apache/drill/pull/1334#issuecomment-407117879
One high level comment: if a query is cancelled and there's in-flight
bloom-filter message from drillbit to foreman, or the broadcast message of the
amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature
URL: https://github.com/apache/drill/pull/1334#issuecomment-406929428
Hey @weijietong, sorry for the delay; I will send you my final comments by
tomorrow.
amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature
URL: https://github.com/apache/drill/pull/1334#issuecomment-403545024
@weijietong thanks for making these changes. I will do one final round of
review hopefully soon and let you know.
amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature
URL: https://github.com/apache/drill/pull/1334#issuecomment-402828959
@weijietong I have couple of design questions that are better discussed in
the JIRA, so I will add them there.. pls take a look. Thanks.
amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature
URL: https://github.com/apache/drill/pull/1334#issuecomment-401246375
@weijietong thanks for the PR. Yes, this is high on my list to review. I
am tied up until tomorrow but will review during the weekend.
