Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1106
Thank you Aman and Paul for reviewing this JIRA. I have created a new JIRA
[DRILL-6131](https://issues.apache.org/jira/browse/DRILL-6131) to track the new
SchemaComparator utility for sharing
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/1106
Seems ok to fix the RecordBatchLoader.isSameSchema() since it is missing
the checks for nested columns. In order to do the consolidation that Paul
suggested, you might want to open an
Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1106
Thanks @paul-rogers for the information; I went through the PR and noticed
the following:
- BatchSchema invokes MaterializedField.isEquivalent()
- With my fix, both methods consider
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1106
Note that a similar bug was recently fixed in (as I recall) the Merge
Receiver. As part of this fix, would be good to either:
1. Determine if we have more copies of this logic besides
Github user priteshm commented on the issue:
https://github.com/apache/drill/pull/1106
@amansinha100 can you please review it?
---
