[GitHub] drill issue #897: Drill-5703 Added Syntax Highlighting and Limited Autocompl...

Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/897 Thanks, @cgivre ! I don't have permissions to close the PR. Perhaps you can close it instead. ---

[GitHub] drill issue #897: Drill-5703 Added Syntax Highlighting and Limited Autocompl...

Github user cgivre commented on the issue: https://github.com/apache/drill/pull/897 Yes, it can be closed. Nice work on the syntax highlighting! > On Jan 29, 2018, at 16:46, Kunal Khatua wrote: > > @cgivre can we

[GitHub] drill issue #897: Drill-5703 Added Syntax Highlighting and Limited Autocompl...

Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/897 @cgivre can we close this PR if the #1043 met the objectives? ---

[GitHub] drill issue #897: Drill-5703 Added Syntax Highlighting and Limited Autocompl...

Github user cgivre commented on the issue: https://github.com/apache/drill/pull/897 @kkhatua I think the formatter is editable. Truthfully, my main goal is to implement JSON syntax highlighting on the plugin config pages. I've spent a decent amount of time debugging JSON because of

[GitHub] drill issue #897: Drill-5703 Added Syntax Highlighting and Limited Autocompl...

Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/897 @cgivre I might be digressing, but I'm wondering if the formatter is editable. So, for example, functions or keywords that are supported in Drill specifically could be highlighted correctly, while

[GitHub] drill issue #897: Drill-5703 Added Syntax Highlighting and Limited Autocompl...

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/897 I might be mistaken then. But that would make things worse. The UI will wait to return all the records from a query that could return a million records. @cgivre that is what I mean by

[GitHub] drill issue #897: Drill-5703 Added Syntax Highlighting and Limited Autocompl...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/897 @parthchandra I remember once I heard that number of rows sent to Web UI in Drill is limited. From the quick glance I did not see such limitation in code. May I assume it's not true? ---

[GitHub] drill issue #897: Drill-5703 Added Syntax Highlighting and Limited Autocompl...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/897 Well, I did not mean we should not enhance Web UI. Storage plugin page enhancement would be definitely a huge plus. It's just I have a feeling that we might consider splitting admin part and

[GitHub] drill issue #897: Drill-5703 Added Syntax Highlighting and Limited Autocompl...

Github user cgivre commented on the issue: https://github.com/apache/drill/pull/897 Hi Arina, I’d also like to add syntax highlighting to the storage plugin page as well. IMHO, it’s really easy to make a small mistake, missing a comma or quote or something, and it can be

[GitHub] drill issue #897: Drill-5703 Added Syntax Highlighting and Limited Autocompl...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/897 IMHO, Drill Web UI servers more as admin console where query profiles can be seen, storage plugins updated as well as system options etc. We might think of disabling Query page allowing

[GitHub] drill issue #897: Drill-5703 Added Syntax Highlighting and Limited Autocompl...

Github user cgivre commented on the issue: https://github.com/apache/drill/pull/897 @parthchandra What do you want to fix in the pagination? IMHO, the query page and the storage plugin editor both are in dire need of syntax highlighting. I was going to work on that next. In the

[GitHub] drill issue #897: Drill-5703 Added Syntax Highlighting and Limited Autocompl...

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/897 I also feel we need to fix the pagination of results before we make improvements to the editor. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] drill issue #897: Drill-5703 Added Syntax Highlighting and Limited Autocompl...

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/897 In general, I'm not in favor of including large javascript files into the code base, except where the JS might be getting deprecated or is not freely downloadable from the web. Alternatively, we