[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/950 ---

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-06 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r143246761 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/TestUserBitSSL.java --- @@ -201,6 +202,7 @@ public void testSSLQuery()

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r143152156 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/TestSSLConfig.java --- @@ -76,7 +76,7 @@ public void testMissingKeystorePassword()

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r143151998 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/TestUserBitSSL.java --- @@ -201,6 +202,7 @@ public void

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-05 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r143042574 --- Diff: contrib/native/client/src/clientlib/wincert.ipp --- @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-05 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142994068 --- Diff: contrib/native/client/src/clientlib/channel.hpp --- @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-05 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142993025 --- Diff: contrib/native/client/src/clientlib/wincert.ipp --- @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-05 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142862510 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/TestSSLConfig.java --- @@ -49,12 +64,19 @@ public void testMissingKeystorePassword()

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-05 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142861999 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/TestUserBitSSL.java --- @@ -223,9 +223,12 @@ public void

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142830326 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -250,7 +205,15 @@ void DrillClientImpl::doWriteToSocket(const char* dataPtr,

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142827719 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfigServer.java --- @@ -0,0 +1,331 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142827417 --- Diff: exec/java-exec/pom.xml --- @@ -589,6 +669,17 @@ + + + +kr.motd.maven +

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142827859 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/TestSSLConfig.java --- @@ -49,12 +64,19 @@ public void testMissingKeystorePassword() throws

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142827572 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfig.java --- @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142827694 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfigClient.java --- @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142827342 --- Diff: distribution/pom.xml --- @@ -97,8 +97,41 @@ org.apache.hbase hbase-client + + +

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142822245 --- Diff: contrib/native/client/readme.ssl --- @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142822091 --- Diff: contrib/native/client/readme.linux --- @@ -84,6 +84,21 @@ OR ln -svf libboost_filesystem.a libboost_filesystem-mt.a ln -svf

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142822382 --- Diff: contrib/native/client/src/clientlib/channel.hpp --- @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142821870 --- Diff: contrib/native/client/CMakeLists.txt --- @@ -93,7 +94,7 @@ else() #of boost. Arbirtarily, we choose the new namspace to be

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142821976 --- Diff: contrib/native/client/example/querySubmitter.cpp --- @@ -544,4 +573,4 @@ int main(int argc, char* argv[]) { } return 0;

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142825441 --- Diff: contrib/native/client/src/include/drill/drillConfig.hpp --- @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142822299 --- Diff: contrib/native/client/src/clientlib/CMakeLists.txt --- @@ -36,6 +40,7 @@ include_directories(${CMAKE_CURRENT_SOURCE_DIR}

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142825478 --- Diff: contrib/native/client/src/include/drill/drillConfig.hpp --- @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142821887 --- Diff: contrib/native/client/example/querySubmitter.cpp --- @@ -50,7 +49,14 @@ struct Option{ {"service_host", "Service host for Kerberos",

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142824514 --- Diff: contrib/native/client/src/clientlib/channel.hpp --- @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142822406 --- Diff: contrib/native/client/src/clientlib/channel.hpp --- @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142824494 --- Diff: contrib/native/client/src/clientlib/channel.hpp --- @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142821955 --- Diff: contrib/native/client/example/querySubmitter.cpp --- @@ -390,11 +404,26 @@ int main(int argc, char* argv[]) { if(auth.length()>0){

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142824662 --- Diff: contrib/native/client/src/clientlib/channel.hpp --- @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142825337 --- Diff: contrib/native/client/src/clientlib/wincert.ipp --- @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142822133 --- Diff: contrib/native/client/readme.ssl --- @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142821994 --- Diff: contrib/native/client/readme.linux --- @@ -84,6 +84,21 @@ OR ln -svf libboost_filesystem.a libboost_filesystem-mt.a ln -svf

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142821900 --- Diff: contrib/native/client/example/querySubmitter.cpp --- @@ -302,6 +310,12 @@ int main(int argc, char* argv[]) { std::string

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142824715 --- Diff: contrib/native/client/src/clientlib/channel.hpp --- @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142718970 --- Diff: contrib/native/client/readme.linux --- @@ -84,6 +84,21 @@ OR ln -svf libboost_filesystem.a libboost_filesystem-mt.a ln -svf

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142731277 --- Diff: contrib/native/client/src/clientlib/channel.cpp --- @@ -0,0 +1,448 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142739285 --- Diff: contrib/native/client/src/clientlib/wincert.ipp --- @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142719061 --- Diff: contrib/native/client/readme.linux --- @@ -84,6 +84,21 @@ OR ln -svf libboost_filesystem.a libboost_filesystem-mt.a ln -svf

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142721373 --- Diff: contrib/native/client/src/clientlib/CMakeLists.txt --- @@ -36,6 +40,7 @@ include_directories(${CMAKE_CURRENT_SOURCE_DIR}

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142734246 --- Diff: contrib/native/client/src/clientlib/channel.hpp --- @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142718781 --- Diff: contrib/native/client/example/querySubmitter.cpp --- @@ -544,4 +573,4 @@ int main(int argc, char* argv[]) { } return 0;

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142739836 --- Diff: contrib/native/client/src/include/drill/drillConfig.hpp --- @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142719411 --- Diff: contrib/native/client/readme.ssl --- @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142740210 --- Diff: contrib/native/client/src/include/drill/drillConfig.hpp --- @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142732709 --- Diff: contrib/native/client/src/clientlib/channel.hpp --- @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142729342 --- Diff: contrib/native/client/src/clientlib/channel.cpp --- @@ -0,0 +1,448 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142729078 --- Diff: contrib/native/client/src/clientlib/channel.cpp --- @@ -0,0 +1,448 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142735461 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -65,108 +56,72 @@ struct ToRpcType: public

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142727129 --- Diff: contrib/native/client/src/clientlib/channel.hpp --- @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142731548 --- Diff: contrib/native/client/src/clientlib/channel.cpp --- @@ -0,0 +1,448 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142733695 --- Diff: contrib/native/client/src/clientlib/channel.hpp --- @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142717986 --- Diff: contrib/native/client/example/querySubmitter.cpp --- @@ -50,7 +49,14 @@ struct Option{ {"service_host", "Service host for Kerberos",

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142736318 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -250,7 +205,15 @@ void DrillClientImpl::doWriteToSocket(const char* dataPtr,

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142727180 --- Diff: contrib/native/client/src/clientlib/channel.hpp --- @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142727549 --- Diff: contrib/native/client/src/clientlib/channel.hpp --- @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142719553 --- Diff: contrib/native/client/readme.ssl --- @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142728092 --- Diff: contrib/native/client/src/clientlib/channel.cpp --- @@ -0,0 +1,448 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142717783 --- Diff: contrib/native/client/CMakeLists.txt --- @@ -93,7 +94,7 @@ else() #of boost. Arbirtarily, we choose the new namspace to be

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142718085 --- Diff: contrib/native/client/example/querySubmitter.cpp --- @@ -302,6 +310,12 @@ int main(int argc, char* argv[]) { std::string

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142718173 --- Diff: contrib/native/client/example/querySubmitter.cpp --- @@ -390,11 +404,26 @@ int main(int argc, char* argv[]) { if(auth.length()>0){

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142728722 --- Diff: contrib/native/client/src/clientlib/channel.cpp --- @@ -0,0 +1,448 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142667318 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java --- @@ -132,38 +173,47 @@ public void

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142679480 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfigServer.java --- @@ -0,0 +1,331 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142683194 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/TestUserBitSSL.java --- @@ -0,0 +1,338 @@ +/* + * Licensed

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142681811 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/TestSSLConfig.java --- @@ -49,12 +64,19 @@ public void testMissingKeystorePassword()

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142678376 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfigClient.java --- @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142687176 --- Diff: distribution/pom.xml --- @@ -97,8 +97,41 @@ org.apache.hbase hbase-client + + +

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142674202 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfig.java --- @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-10-04 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r142691920 --- Diff: exec/java-exec/pom.xml --- @@ -589,6 +669,17 @@ + + + +kr.motd.maven +

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-28 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141728836 --- Diff: contrib/native/client/src/clientlib/channel.cpp --- @@ -0,0 +1,452 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-28 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141740253 --- Diff: contrib/native/client/src/clientlib/channel.hpp --- @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-28 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141726875 --- Diff: contrib/native/client/src/clientlib/channel.cpp --- @@ -0,0 +1,452 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-28 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141732868 --- Diff: contrib/native/client/src/clientlib/channel.hpp --- @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-28 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141676885 --- Diff: contrib/native/client/src/clientlib/wincert.ipp --- @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-28 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141676469 --- Diff: contrib/native/client/src/clientlib/zkCluster.cpp --- @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-28 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141677219 --- Diff: contrib/native/client/src/clientlib/wincert.ipp --- @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-28 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141725904 --- Diff: contrib/native/client/src/clientlib/channel.cpp --- @@ -0,0 +1,452 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-28 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141725643 --- Diff: contrib/native/client/src/clientlib/streamSocket.hpp --- @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-28 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141742537 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -65,108 +66,70 @@ struct ToRpcType: public

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-28 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141730279 --- Diff: contrib/native/client/src/clientlib/channel.hpp --- @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-28 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141742427 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -65,108 +66,70 @@ struct ToRpcType: public

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-28 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141676935 --- Diff: contrib/native/client/src/clientlib/wincert.ipp --- @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-28 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141474850 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/TestUserBitSSLServer.java --- @@ -0,0 +1,126 @@ +/* + * Licensed

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-28 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141670440 --- Diff: contrib/native/client/src/include/drill/userProperties.hpp --- @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-28 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141498641 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/ConnectionMultiListener.java --- @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-28 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141471056 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/TestSSLConfig.java --- @@ -91,10 +123,35 @@ public void testForTrustStore() throws

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140914589 --- Diff: contrib/native/client/src/clientlib/zkCluster.cpp --- @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140893808 --- Diff: contrib/native/client/src/include/drill/userProperties.hpp --- @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141215252 --- Diff: contrib/native/client/src/clientlib/channel.cpp --- @@ -0,0 +1,452 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140621499 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/ConnectionMultiListener.java --- @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140621635 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicClient.java --- @@ -179,6 +203,13 @@ void send(RpcOutcomeListener listener, T rpcType, SEND

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141215109 --- Diff: contrib/native/client/src/clientlib/channel.cpp --- @@ -0,0 +1,452 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140623048 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java --- @@ -102,19 +115,78 @@ // these are used for authentication

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r141245539 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -65,108 +66,70 @@ struct ToRpcType: public

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140973654 --- Diff: contrib/native/client/src/clientlib/streamSocket.hpp --- @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140971420 --- Diff: contrib/native/client/src/clientlib/streamSocket.hpp --- @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140970043 --- Diff: contrib/native/client/src/clientlib/wincert.ipp --- @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140621394 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/ConnectionMultiListener.java --- @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-26 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140587424 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfig.java --- @@ -0,0 +1,325 @@ +/* + * Licensed to the Apache Software

  1   2   >