Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[Jun Liu]

> Release Notes:
> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118

Sorry, the previous link seems invisible for non-committers, please check the 
following link for detailed release notes:
https://github.com/apache/incubator-dubbo/blob/2.6.2-release/CHANGES.md

> On 15 May 2018, at 11:49 AM, Jun Liu  wrote:
> 
> Hello Dubbo Community,
> 
> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.2.
> 
> The release candidates:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2/
> 
> Git tag for the release:
> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2
> 
> Hash for the release tag:
> afab04c53edab38d52275d2a198ea1aff7a4f41e
> 
> Release Notes:
> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
> 
> The artifacts have been signed with Key : 28681CB1, which can be found in the 
> keys file:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
> 
> The vote will be open for at least 72 hours or until necessary number of 
> votes are reached.
> 
> Please vote accordingly:
> 
> [ ] +1 approve 
> [ ] +0 no opinion 
> [ ] -1 disapprove with the reason
> 
> Thanks,
> The Apache Dubbo (Incubating) Team

Re: Signing Apache ICLA to help Dubbo finish IP clearance process

[王兵gmail]

你好，已经按照提示发了一个CLA邮件了



2018-05-14 16:06 GMT+08:00 Huxing Zhang :

> (Chinese after English)
>
> Hello,
>
> I am Huxing, I am committer and PMC member of Apache Dubbo(incubating).
>
> You have contributed to Dubbo in the past, but never signed either
> Apache ICLA or Alibaba CLA before. Please refer to [1][2] for more
> details.
>
> Since Dubbo has been donated to Apache Software Foundation, one
> required process is to ensure the intellectual property of each
> contribution has been correctly transferred to ASF. To help Dubbo to
> finish the
> process, would you please sign the ICLA for Dubbo? You can follow the
> guide [3].
>
> If you have any further questions, please drop me a message.
>
> Thanks in advance!
>
>
> ===
> 您好，
>
> 我是来自Dubbo团队的张乎兴，您之前给Dubbo贡献过代码，但是没有签署过贡献者许可协议，您可以从[1][2]中了解更多的内容。
>
> 目前Dubbo正在Apache基金会孵化，其中一项流程是对软件的知识产权进行清理，确保您之前贡献的代码正确的转移给Apache基金会，
> 在此烦请您协助Dubbo社区完成贡献者许可协议的签署工作，具体的步骤请参考文档[3]中提供的内容。
>
> 如果有任何问题，请通过邮件或者微信(ralf0131)联系我。
>
> 此致，
> 敬礼！
>
>
> [1] https://issues.apache.org/jira/browse/DUBBO-3
> [2] https://github.com/apache/incubator-dubbo/wiki/CLA-signing-status
> [3] https://github.com/apache/incubator-dubbo/wiki/CLA-signing-guide
>
> --
> Best Regards！
> Huxing
>

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[Huxing Zhang]

Hi,

[x] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason

Details:

* incubator in name
* Disclaimer exists
* sha512 chesum ok
* signature ok
* NOTICE and LICENSE exist in META-INF of jar files of binary release.
* Unit test passed on Java 8 + OSX

Other minor comments:
* The unarchived directory name for
dubbo-incubating-2.6.2-source-release.zip is 'dubbo-parent-2.6.2', may
be better to change to  "dubbo-incubating-2.6.2"
* The link[1] to release notes is not accessible, should be [2], and
it is inaccessible to non-committer, maybe it is better to attach them
to the voting thread.
* dubbo-parent seems took 23+ min in my local environment, I checked
the jstack and it looks like maven-checkstyle-plugin is scanning
directories..

[1] 
https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
[2] 
https://github.com/apache/incubator-dubbo/releases/tag/untagged-616b91e8d915fe71a17f

On Tue, May 15, 2018 at 11:49 AM, Jun Liu  wrote:
> Hello Dubbo Community,
>
> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.2.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2 
> /
>
> Git tag for the release:
> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2 
> 
>
> Hash for the release tag:
> afab04c53edab38d52275d2a198ea1aff7a4f41e
>
> Release Notes:
> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
>  
> 
>
> The artifacts have been signed with Key : 28681CB1, which can be found in the 
> keys file:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS 
> 
>
> The vote will be open for at least 72 hours or until necessary number of 
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo (Incubating) Team

-- 
Best Regards！
Huxing

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[Huxing Zhang]

On Tue, May 15, 2018 at 2:11 PM, Jun Liu  wrote:
>> Release Notes:
>> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
>
> Sorry, the previous link seems invisible for non-committers, please check the 
> following link for detailed release notes:
> https://github.com/apache/incubator-dubbo/blob/2.6.2-release/CHANGES.md

Since you pushed to the release branch, the hash for the release tag
should also be changed?

>
>> On 15 May 2018, at 11:49 AM, Jun Liu  wrote:
>>
>> Hello Dubbo Community,
>>
>> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.2.
>>
>> The release candidates:
>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2/
>>
>> Git tag for the release:
>> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2
>>
>> Hash for the release tag:
>> afab04c53edab38d52275d2a198ea1aff7a4f41e
>>
>> Release Notes:
>> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
>>
>> The artifacts have been signed with Key : 28681CB1, which can be found in 
>> the keys file:
>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>>
>> The vote will be open for at least 72 hours or until necessary number of 
>> votes are reached.
>>
>> Please vote accordingly:
>>
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove with the reason
>>
>> Thanks,
>> The Apache Dubbo (Incubating) Team
>

-- 
Best Regards！
Huxing

Re: GSoC student - Getting started.

[Lei Wei]

Hi, Raghu

Hope you are processing well on learning Dubbo. The Dubbo official
documents and what I share to you should be helpful for you. According to
the timeline of GSoC, we can go to the Coding step. Are you ready  :)

In order to have a good start, could you please provide a plan of your
coding? For example, where and how you will start, the key points you guess
in the project. Also you can share your understanding of Dubbo to us.

Below is some suggestion from me:
1. Setup dubbo environment on your machine. (Setup JDK, maven, IDE)
2. Run a Dubbo demo(provider, consumer, zookeeper)
3. Run a simple demo of extending Dubbo to learn Dubbo extending mechanism
4. Learn Protobuff
5. Write and run a Protobuff demo to implement serializing and deserializing
6. Extend Protobuff to Dubbo
7. code(), debug() and document()

Please keep in touch, and let us know if you have any questions. We will
try our best to help you.



Raghunandana Jayarama Reddy  于2018年5月3日周四
下午2:32写道：

> Hi Lei Wei,
>
> Thanks a lot for the inputs and suggestions. I’m going through the
> resources that you all have shared with me and getting acquainted.
>
> Looking forward to working & helping the community in whatever way I can!
>
> Best,
> Raghu
>
> On Wed, May 2, 2018 at 6:32 AM 雷威  wrote:
>
> > Hi, Reghu
> > I am a new developer from Dubbo community, from China. My name is Lei
> Wei.
> > First, congratulations to you, and in next months, I will work together
> > with you on the GSoC project. It's my honor to join this great project
> with
> > you, and hope we have a good Dubbo journey.
> >
> > The Dubbo official website already supply some documents in both Chinese
> > and English, It is a good start for you to learn Dubbo. Once you finished
> > it, you need some more detailed document about the key point of GSoC
> > project. As you may have found that most documents of Dubbo is in
> Chinese,
> > which is not friendly to you. The project is about extending Dubbo
> > serialization.
> > We will add a new implementation of serialization, and integrate it into
> > Dubbo to extend Dubbo. So you may need to have some understanding on
> > Dubbo's Extension mechanism, after you have the basic knowledge of Dubbo.
> >
> > I am preparing some documents for you, hope this can help you.
> > https://github.com/vangoleo/wiki/blob/master/dubbo/dubbo-spi-en.md
> >
> > In this document, you will learn what is the Dubbo SPI, and there is a
> > step-by-step sample to show you how to create a customize extension in
> > Dubbo.
> >
> > Another document is in progress, and it will dive into the source code of
> > Dubbo Extension mechanism. Once I finished it, I will share with you.
> >
> > Please let us know in case of any question or suggestion^_^
> >
> >
> >
> > 2018-04-28 9:22 GMT+08:00 Raghunandana Jayarama Reddy <
> > rjayarama...@cs.stonybrook.edu>:
> >
> > > Sure, I will do that Jun.
> > >
> > > Thanks for the inputs and resources.
> > >
> > > Best,
> > > Raghu
> > >
> > > On Fri, Apr 27, 2018 at 8:58 AM, jun liu  wrote:
> > >
> > > > Hi Reghu,
> > > >
> > > > I have checked the schedule of GSoC. We have nearly one month to get
> > > > familiar with dubbo. I am wondering if you can write down your
> > > > understanding of dubbo when learning, anything you interest, a simple
> > > > introduction of dubbo’s features, your experience of running dubbo
> from
> > > > zero, advantages comparing with other similar frameworks, etc. This
> can
> > > be
> > > > a good way for us to know your progress and problems in learning
> dubbo.
> > > >
> > > > On the other hand, one inconvenient side of dubbo you may also have
> > > > noticed, dubbo is lack of documents or blogs introducing it, english
> > docs
> > > > worser, i believe your blogs or papers can be a good supplementary.
> > > >
> > > > My own suggestions, feel free to make your own decisions based on
> your
> > > > pressures from study and your habits
> > > >
> > > > Best regards,
> > > > Jun
> > > >
> > > >
> > > > On 26 Apr 2018, at 4:01 PM, Raghunandana Jayarama Reddy <
> > > > rjayarama...@cs.stonybrook.edu> wrote:
> > > >
> > > > Hi Jun,
> > > >
> > > > Thanks for helping me with the resources. I shall start getting
> > familiar
> > > > with the architecture and SPI of Dubbo.
> > > >
> > > > Best,
> > > > Raghu
> > > >
> > > > On Wed, Apr 25, 2018 at 4:44 AM, jun liu 
> wrote:
> > > >
> > > >> Hey Raghu,
> > > >>
> > > >> I’ve to say that your proposal do impressed me a lot, very glad to
> see
> > > >> you come out from so many candidates. Let’s start the Dubbo journey
> > now.
> > > >>
> > > >> To achieve the goal, i think you should spend some time to get
> > familiar
> > > >> with Dubbo first: what is dubbo, the key features provided by dubbo,
> > > how it
> > > >> works, etc. As this project is related with serialization
> frameworks,
> > > you’d
> > > >> better give a thorough research on existing 

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[Justin Mclean]

Hi,

+1 (binding)

I checked:
- Incubating in name
- Signatures and hashes good
- DISCLAIMER exists
- LICENSE and NOTICE good
- A number of pom.xml and log4j.xml files haven’t had their headers changed to 
the standard ASF one and are still copyright Alibaba (about 14 files) e.g [4][5]
- A couple of .sh files are missing ASF headers in [6] also here [9] and here 
[10]
- No unexpected binary files in the release
- Can compile from source

I also checked the binary convenience release and it's all good re signatures, 
naming, disclaimer, licenses and notice.

Some very minor issues (and IMO except for the MD5 issue) can be fixed next 
release:
- Can you remove the MD5 hashes please they are not needed and don’t follow the 
current release policy. [1]
- The source unzips into an odd directory name "dubbo-parent-2.6.2”, 
“apache-dubbo-2.6.2” would be better.
- The code of conduct may need some small updates for instance I see 
"du...@googlegroups.com” mentioned.
- The README.md has links to information would be nice to include build 
instructions inside the README
- A few poms have some out of date information [2][3]
- The contributing document need a couple of minor updates (eg @author tags are 
not used at Apache)
- LICENSE includes " Copyright (c) 2001-2004 Caucho Technology, Inc” but some 
of the header have the date range 2001-2008
- Should these files be in the release? [7][8]
- Maven check style plugin is taking a long time when compiling (10+minutes) 
and runs out of memory on my machine. Disabling it (-Dcheckstyle.skip) reduced 
compile time to under a minute.

I’ve not checked if the compile source actually works (which is sort of 
important) so might be good if a few people check that when voting +1 :-)

Well done! It's not often I get to vote +1 on the first RC of a first release 
by a project.

Thanks,
Justin

1. https://www.apache.org/dev/release-distribution.html#sigs-and-sums
2. ./bom/pom.xml
3. ./dependencies-bom/pom.xml
4. ./dubbo-rpc/dubbo-rpc-rest/pom.xml
5. ./dubbo-common/src/test/resources/log4j.xml
6. 
dubbo-container/dubbo-container-api/src/main/resources/META-INF/assembly/bin/*.sh
7. dubbo-rpc/dubbo-rpc-default/dubbo.log
8. dubbo-rpc/dubbo-rpc-dubbo/dubbo.log
9. dubbo-test/dubbo-test-benchmark/src/main/resources/run.*
10. dubbo-test/dubbo-test-benchmark/src/test/resources/server/*.sh

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[jun liu]

Hi Justin,

> Hash for the release tag:
> afab04c53edab38d52275d2a198ea1aff7a4f41e

It’s included in the initial vote email.

> On 16 May 2018, at 10:44 AM, Justin Mclean  wrote:
> 
> HI,
> 
>> I don’t think we need to change the release tag hash. Tag ‘dubbo-2.6.2’ has 
>> never changed, so the source release, binary release and the release tag are 
>> still in consistent to each other.  Be aware that CHANGES.md only exists in 
>> the ‘2.6.2-release’ branch,  a branch we used for release purpose, it serves 
>> for the release process but not bounded. 
> 
> As tags are mutable in git it best to specify the hash in the release vote 
> email (ie afab04c).
> 
> Thanks,
> Justin

Re: Moving hessian-lite from Dubbo codebase to eco-system

[jun liu]

> What do the owner / maintainers of hessian-lite think about that? Is there 
> any need to fork their version?

Actually, the dubbo team is the official maintainer of hessian-lite, it’s 
always been published along side with dubbo. 

There are mainly 2 reasons for maintaining an additional hessian-lite instead 
of using the official caucho hessian:
1. As it’s name suggests, it’s a diminished version of the official one.
2. We think the hessian community is a little lack of activity: bugs and 
optimizations cannot be solved in time.

> Can you just use their released version?

Hessian-lite is in a large extend incompatible with the official caucho hessian 
now, so it’s impossible to remove the hessian-lite serialization. I suggest we 
also extend the latest version of the official caucho hessian as another choice 
of Serialization.

Best regards,
Jun

> On 11 May 2018, at 4:02 PM, Justin Mclean  wrote:
> 
> Hi,
> 
>> Now we are considering that moving it to Dubbo eco-system, which is
>> https://github/dubbo.
>> 
>> How do you think about this?
> 
> I don’t know the history here so the answer to these questions may be obvious 
> to someone eon the project. What do the owner / maintainers of hessian-lite 
> think about that? Is there any need to fork their version? Can you just use 
> their released version?
> 
> Thanks,
> Justin

Re: Moving hessian-lite from Dubbo codebase to eco-system

[Jun Liu]

> Now we are considering that moving it to Dubbo eco-system, which is
> https://github/dubbo.
> 
> How do you think about this?

I agree with moving hessian-lite to the dubbo eco-system. If we do that, we may 
need to upgrade the core dubbo version to 2.7.x to identify incompatible usage 
of dependencies.

> On 11 May 2018, at 3:57 PM, Yong Zhu  wrote:
> 
> Hi,
> 
> hessian-lite a customized version of the official hessian maintained inside
> Dubbo, and it's relatively stable, only upgrading for special bugfix.
> 
> It's version(3.2.2) is different from Dubbo(now 2.6.2), and their release
> paces are also different.
> 
> Now we are considering that moving it to Dubbo eco-system, which is
> https://github/dubbo.
> 
> How do you think about this?
> 
> Thanks.
> Jerrick

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[Justin Mclean]

HI,

> I don’t think we need to change the release tag hash. Tag ‘dubbo-2.6.2’ has 
> never changed, so the source release, binary release and the release tag are 
> still in consistent to each other.  Be aware that CHANGES.md only exists in 
> the ‘2.6.2-release’ branch,  a branch we used for release purpose, it serves 
> for the release process but not bounded. 

As tags are mutable in git it best to specify the hash in the release vote 
email (ie afab04c).

Thanks,
Justin

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[jun liu]

>>> Release Notes:
>>> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
>>>  
>>> 
>> 
>> Sorry, the previous link seems invisible for non-committers, please check 
>> the following link for detailed release notes:
>> https://github.com/apache/incubator-dubbo/blob/2.6.2-release/CHANGES.md 
>> 
> 
> Since you pushed to the release branch, the hash for the release tag
> should also be changed?

I don’t think we need to change the release tag hash. Tag ‘dubbo-2.6.2’ has 
never changed, so the source release, binary release and the release tag are 
still in consistent to each other.  Be aware that CHANGES.md only exists in the 
‘2.6.2-release’ branch,  a branch we used for release purpose, it serves for 
the release process but not bounded. 

Best regards,
Jun

> On 15 May 2018, at 3:38 PM, Huxing Zhang  wrote:
> 
> On Tue, May 15, 2018 at 2:11 PM, Jun Liu  > wrote:
>>> Release Notes:
>>> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
>>>  
>>> 
>> 
>> Sorry, the previous link seems invisible for non-committers, please check 
>> the following link for detailed release notes:
>> https://github.com/apache/incubator-dubbo/blob/2.6.2-release/CHANGES.md 
>> 
> 
> Since you pushed to the release branch, the hash for the release tag
> should also be changed?
> 
>> 
>>> On 15 May 2018, at 11:49 AM, Jun Liu  wrote:
>>> 
>>> Hello Dubbo Community,
>>> 
>>> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.2.
>>> 
>>> The release candidates:
>>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2/
>>> 
>>> Git tag for the release:
>>> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2
>>> 
>>> Hash for the release tag:
>>> afab04c53edab38d52275d2a198ea1aff7a4f41e
>>> 
>>> Release Notes:
>>> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
>>> 
>>> The artifacts have been signed with Key : 28681CB1, which can be found in 
>>> the keys file:
>>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>>> 
>>> The vote will be open for at least 72 hours or until necessary number of 
>>> votes are reached.
>>> 
>>> Please vote accordingly:
>>> 
>>> [ ] +1 approve
>>> [ ] +0 no opinion
>>> [ ] -1 disapprove with the reason
>>> 
>>> Thanks,
>>> The Apache Dubbo (Incubating) Team
>> 
> 
> -- 
> Best Regards！
> Huxing