Re: About the comments coverage of the code

2018-12-17 Thread Dave Fisher
Hi - Here is one of your mentors dropping in with comments. (1) I really like this thread! (2) Have any committers reached out to the users who had trouble with code comments to confirm these efforts will meet their concerns? (3) I’m not saying increased these efforts are wrong. I’ve not read

Re: [Call for talks] Dubbo Guangzhou meetup

2018-12-17 Thread Imteyaz Khan
No worries. Would there be english version of dubbo presentations(e.g. ppt)? On Tue, Dec 18, 2018 at 12:10 PM Huxing Zhang wrote: > Hi, > > On Tue, Dec 18, 2018 at 2:27 PM Imteyaz Khan > wrote: > > > > Will be there any web cast (live streaming of meetup) for those who may > not > > be able

Re: About the comments coverage of the code

2018-12-17 Thread Huxing Zhang
Hi, On Tue, Dec 18, 2018 at 2:15 PM yuhang xiu wrote: > > Hi, all > I have now divided the work according to the module, and have established > the issue, > their number is from https://github.com/apache/incubator-dubbo/issues/2991, > to issue 3002. > They have all been labeled with help wanted

Re: [Call for talks] Dubbo Guangzhou meetup

2018-12-17 Thread Huxing Zhang
Hi, On Tue, Dec 18, 2018 at 2:27 PM Imteyaz Khan wrote: > > Will be there any web cast (live streaming of meetup) for those who may not > be able to attend this meetup (As I will be one of those :) ) ? Yes, there is! Will put it on the mailing list when possible, and please also follow the

Re: [Call for talks] Dubbo Guangzhou meetup

2018-12-17 Thread Imteyaz Khan
Will be there any web cast (live streaming of meetup) for those who may not be able to attend this meetup (As I will be one of those :) ) ? On Tue, Dec 18, 2018 at 11:14 AM Eric Zhao wrote: > Hi, > > I'd like to share a talk about Sentinel [1], a powerful flow-control > component

Re: About the comments coverage of the code

2018-12-17 Thread yuhang xiu
Hi, all I have now divided the work according to the module, and have established the issue, their number is from https://github.com/apache/incubator-dubbo/issues/2991, to issue 3002. They have all been labeled with help wanted and good first issue. Let us see who is willing to complete these

Re: Telnet optimization suggest

2018-12-17 Thread Jason Joo
And is there other situations to deal with? group/version/etc... For now there is only different implementations in same application and looks good to deal with. best regards, Jason > On Dec 18, 2018, at 10:33, yeling wrote: > > Ok,I've created an issue. >

Re: [Call for talks] Dubbo Guangzhou meetup

2018-12-17 Thread Eric Zhao
Hi, I'd like to share a talk about Sentinel [1], a powerful flow-control component open-sourced by Alibaba, enabling resilience and reliability for microservices. ## Topic Sentinel: The flow sentinel of your services ## Abstract - Introduce main features and scenarios of Sentinel, including

Re: Telnet optimization suggest

2018-12-17 Thread yeling
Ok,I've created an issue. https://github.com/apache/incubator-dubbo/issues/2988 Ian Luo 于2018年12月17日周一 下午11:41写道: > Zhen, > > > > 1. When my interface implements multiple services, and all of them are > > exposed, using the Dubbo parameter group, at this time, under the telnet > > command, I

Re: A proposal for transfer dubbo-samples to github.com/apache

2018-12-17 Thread Huxing Zhang
+1. As Mark said in another thread, keeping them outside of Apache may result in rename of the project. They are both important projects to Dubbo. My suggestion is transfer them as early as possible. The later we do, the more work such as IP clearance will be needed to do. On Tue, Dec 18, 2018

Re: [Call for talks] Dubbo Guangzhou meetup

2018-12-17 Thread Minxuan Zhuang
I want to talk about the status of Dubbo, including new feature in dubbo 2.7 and a brand new dubbo admin. On Mon, Dec 17, 2018 at 11:44 PM Ian Luo wrote: > I am thinking about talking REST support in Dubbo in this meetup. I will > prepare slides and demo first. > > -Ian. > > On Thu, Dec 13,

Re: A proposal for transfer dubbo-samples to github.com/apache

2018-12-17 Thread Jerrick Zhu
That's great. Maybe we could start transferring other projects in dubbo ecosystem to apache, such as dubbo-rpc-native-thrift or dubbo-registry-nacos Any other thoughts? On Tue, Dec 11, 2018 at

Re: [Call for talks] Dubbo Guangzhou meetup

2018-12-17 Thread Ian Luo
I am thinking about talking REST support in Dubbo in this meetup. I will prepare slides and demo first. -Ian. On Thu, Dec 13, 2018 at 4:18 PM Huxing Zhang wrote: > Hi, > > I am pleased to announce that the Dubbo community are going to hold a > meetup in > Guangzhou on January 19th (Saturday),

Re: Telnet optimization suggest

2018-12-17 Thread Ian Luo
Zhen, > 1. When my interface implements multiple services, and all of them are > exposed, using the Dubbo parameter group, at this time, under the telnet > command, I can not choose the service I want to invoke. I am afraid I fully understand the problem. Could you pls. file an issue on GitHub

Re: Telnet optimization suggest

2018-12-17 Thread Ian Luo
Hi Zhen, For this particular override issue, I believe it's already been addressed. Would you mind to pull the latest code from the master branch and give it a try? Thanks, -Ian. On Mon, Dec 17, 2018 at 8:52 PM yuhang xiu wrote: > Welcome! > > Do u have some ideas about telnet? > > IMO, this

Re: Source code guide

2018-12-17 Thread 田 小波
Thanks to review this PR, I will update site_config/doc.js tomorrow. Thanks. Xiaobo > 在 2018年12月17日,下午11:26,Huxing Zhang 写道: > > Hi, > > The pull request looks good to me, I have merge the pr[1]. > > To make sure your docs appear in the sidebar of >

Re: Source code guide

2018-12-17 Thread Huxing Zhang
Hi, The pull request looks good to me, I have merge the pr[1]. To make sure your docs appear in the sidebar of http://dubbo.apache.org/zh-cn/docs/user/quick-start.html, would you please also update site_config/doc.js? If you check site_config/doc.js, you can see there is lots of examples. [1]

Re: Naming of non-ASF releases

2018-12-17 Thread Huxing Zhang
Hi, On Mon, Dec 17, 2018 at 10:44 PM Justin Mclean wrote: > > Hi, > > > Where did you get the list? > > http://central.maven.org/maven2/com/alibaba/ > > > Most of them are Apache Dubbo modules. > > I assumed some may be left over from the donation / old releases predating > apache donation but

Re: Apache dubbo website filter content (should we change)

2018-12-17 Thread Huxing Zhang
Hi, On Mon, Dec 17, 2018 at 5:24 PM Imteyaz Khan wrote: > > Just noticed as this is PR is release to dubbo-website, so was not sure > whether do I need to PR email to another group. Any guide will be > appreciated. The dev@ mailing list is the right place your email should go to. I have already

Re: Naming of non-ASF releases

2018-12-17 Thread Justin Mclean
Hi, > Where did you get the list? http://central.maven.org/maven2/com/alibaba/ > Most of them are Apache Dubbo modules. I assumed some may be left over from the donation / old releases predating apache donation but not 100% sure if that accounts for all of them. Thanks, Justin

Re: Naming of non-ASF releases

2018-12-17 Thread Huxing Zhang
Hi, Justin, Where did you get the list? Most of them are Apache Dubbo modules. On Mon, Dec 17, 2018 at 4:03 PM Justin Mclean wrote: > > HI, > > From Mark: > > On a related topic, if this component is remaining outside the ASF it > > will need to change its name. > > Looking up a couple of

Re: Telnet optimization suggest

2018-12-17 Thread yuhang xiu
Welcome! Do u have some ideas about telnet? IMO, this way is very good: list: [1] listUser(Integer id) [2] listUser(String name) When we use invoke, we can do like this: invoke 1 params There has a line number or id or sth else with one invokable method. This can make this clear. 李振

Re: Telnet optimization suggest

2018-12-17 Thread 李振
> > I will try to fix it。

Re: Telnet optimization suggest

2018-12-17 Thread yuhang xiu
Hi, about overloading, here is an issue to track: https://github.com/apache/incubator-dubbo/issues/2766 Regarding the group problem, it is currently impossible to execute a service under a specific group. This is a point that can be optimized. Would u have some ideas? yeling 于2018年12月17日周一

Telnet optimization suggest

2018-12-17 Thread yeling
Hi, When we use dubbo, we use telnet more or less. Some cases were found to be unavailable: 1. When my interface implements multiple services, and all of them are exposed, using the Dubbo parameter group, at this time, under the telnet command, I can not choose the service I want to invoke.

Re: Apache dubbo website filter content (should we change)

2018-12-17 Thread Imteyaz Khan
Just noticed as this is PR is release to dubbo-website, so was not sure whether do I need to PR email to another group. Any guide will be appreciated. On Fri, Dec 14, 2018 at 3:18 PM Imteyaz Khan wrote: > Hi, all > > I have raised the PR for dubbo website docs package name changes for the >

Naming of non-ASF releases

2018-12-17 Thread Justin Mclean
HI, From Mark: > On a related topic, if this component is remaining outside the ASF it > will need to change its name. Looking up a couple of directories I can see a large number of releases using the dubbo name: dubbo-bom/ dubbo-bootstrap/ dubbo-cluster/ dubbo-common/ dubbo-config/