Re: [incubator-dubbo] branch satansk-patch-1 created (now 5280e6c)

2019-01-29 Thread Huxing Zhang
Hi, Please do not push your personal branch to remote repository. Typically you need push to your forked repository and send a pull request. On Wed, Jan 30, 2019 at 3:20 PM wrote: > > This is an automated email from the ASF dual-hosted git repository. > > songkun pushed a change to branch

Re: [ANN] Welcome new committer: Kun Song

2019-01-29 Thread Xin Wang
Congratulations! Imteyaz Khan 于2019年1月30日周三 下午3:17写道: > Congratulations . > > On Wed, Jan 30, 2019 at 12:25 PM Mercy wrote: > > > Congratulations!  > > > > Kind regards, > > Mercy Ma > > > > 在 2019/1/30 上午10:01, Huxing Zhang 写道: > > > Hi Community, > > > > > > On behalf of the Dubbo PPMC, I

Re: [Discuss] About Clean Code Plan

2019-01-29 Thread Imteyaz Khan
Ian, Thanks for summarizing this for me. I personally very excited about this.  On Wed, Jan 30, 2019 at 12:33 PM Ian Luo wrote: > Jason, > > Agree, and pls. join us and keep an eye on this area for us :) > > Thanks, > -Ian. > > > On Tue, Jan 29, 2019 at 3:38 PM Jason Joo wrote: > > > Hi,

Re: [ANN] Welcome new committer: Kun Song

2019-01-29 Thread Imteyaz Khan
Congratulations . On Wed, Jan 30, 2019 at 12:25 PM Mercy wrote: > Congratulations!  > > Kind regards, > Mercy Ma > > 在 2019/1/30 上午10:01, Huxing Zhang 写道: > > Hi Community, > > > > On behalf of the Dubbo PPMC, I am pleased to announce that Kun Song, > > a.k.a. satansk[1], has been voted in as

Re: [Discuss] About Clean Code Plan

2019-01-29 Thread Ian Luo
Jason, Agree, and pls. join us and keep an eye on this area for us :) Thanks, -Ian. On Tue, Jan 29, 2019 at 3:38 PM Jason Joo wrote: > Hi, lan > > Agree with you. > > It's great for shorter, cleaner, more efficient logic optimizing. So I > suggest that modifications including grammar sugar

Re: [Discuss] About Clean Code Plan

2019-01-29 Thread Ian Luo
Imteyaz, Basically we are discussing whether and how to make an effort to make the code clean, and whether it's worth of a dedicated project, though we all understand it is a day-to-day requirement for all engineers in every single submit. Regards, -Ian. On Wed, Jan 30, 2019 at 12:09 AM Imteyaz

Re: [ANN] Welcome new committer: Kun Song

2019-01-29 Thread Mercy
Congratulations!  Kind regards, Mercy Ma 在 2019/1/30 上午10:01, Huxing Zhang 写道: Hi Community, On behalf of the Dubbo PPMC, I am pleased to announce that Kun Song, a.k.a. satansk[1], has been voted in as a new Dubbo committer. Please join me to say congratulations to him! Kun, would you

Re: [ANN] Welcome new committer: Kun Song

2019-01-29 Thread Ian Luo
Congratulations! On Wed, Jan 30, 2019 at 10:01 AM Huxing Zhang wrote: > Hi Community, > > On behalf of the Dubbo PPMC, I am pleased to announce that Kun Song, > a.k.a. satansk[1], has been voted in as a new Dubbo committer. > > Please join me to say congratulations to him! > > Kun, would you

Re: [Notification of V2.7.0] Status, TODOs, Possible Release Schedules.

2019-01-29 Thread Ian Luo
Sounds great. On Wed, Jan 30, 2019 at 1:15 PM Minxuan Zhuang wrote: > Dubbo ops is ready, I'll call for vote today > > On Wed, Jan 30, 2019 at 1:00 PM Huxing Zhang wrote: > > > Hi All, > > > > As 2.7.0 has just released. > > I am thinking that we can start the process of release > >

Re: contribute

2019-01-29 Thread Ian Luo
Haibin, ICLA is only required to the one who's to be dubbo committer. Right now what you need to do is simply going through the issue list on GitHub, pick one and start work on it. Once your works are recognized by the community, then you will be required to sign ICLA when you are nominated as a

Re: [Notification of V2.7.0] Status, TODOs, Possible Release Schedules.

2019-01-29 Thread Minxuan Zhuang
Dubbo ops is ready, I'll call for vote today On Wed, Jan 30, 2019 at 1:00 PM Huxing Zhang wrote: > Hi All, > > As 2.7.0 has just released. > I am thinking that we can start the process of release > dubbo-spring-boot-starter and dubbo-ops. > Mercy and Minxuan, can you share your plan on this? >

Re: [ANN] Welcome new committer: Kun Song

2019-01-29 Thread 李 晓杰
Congratulations and welcome to join us! 原始邮件 发件人: 华 钟明 收件人: dev@dubbo.apache.org 发送时间: 2019年1月30日(周三) 10:11 主题: Re: [ANN] Welcome new committer: Kun Song Congratulations, thank you for your contribution. Best Regards! Zhongming Hua 在 2019/1/30 上午10:08,“Taosheng,

Re: [ANN] Welcome new committer: Kun Song

2019-01-29 Thread 华 钟明
Congratulations, thank you for your contribution. Best Regards! Zhongming Hua 在 2019/1/30 上午10:08,“Taosheng, Wei” 写入: Congratulations

Re: [ANN] Welcome new committer: Kun Song

2019-01-29 Thread Taosheng, Wei
Congratulations and welcome :) -- Original -- From: Huxing Zhang Date: Wed,Jan 30,2019 10:01 AM To: dev Subject: Re: [ANN] Welcome new committer: Kun Song Hi Community, On behalf of the Dubbo PPMC, I am pleased to announce that Kun Song, a.k.a. satansk[1],

Re: discuss dubbo support opentracing

2019-01-29 Thread Xiaoguang Ma
Ok, I try to connect opentracing whether I can push this in opentracing repository or not Ma Xiaoguang Apache ShardingSphere maxiaoguang 于2019年1月30日周三 上午9:49写道: > Yes, zipkin and skywalking also support opentracing. > > > > Ma Xiaoguang > Apache ShardingSphere > >

[ANN] Welcome new committer: Kun Song

2019-01-29 Thread Huxing Zhang
Hi Community, On behalf of the Dubbo PPMC, I am pleased to announce that Kun Song, a.k.a. satansk[1], has been voted in as a new Dubbo committer. Please join me to say congratulations to him! Kun, would you please briefly introduce yourself to the community? [1] https://github.com/satansk --

Re: [Discuss] About Clean Code Plan

2019-01-29 Thread LiZhenNet
Good Idea, I will do it like this next time.

Re: [Discuss] About Clean Code Plan

2019-01-29 Thread Imteyaz Khan
sorry I was not following the thread actively so might have missed something. how are planning the clean code approach as module by module or will start with any new code modifications wise ? On Tuesday, January 29, 2019, LiZhenNet wrote: > +1 , > Grammar sugar can easily be fixed by using

Re: discuss dubbo support opentracing

2019-01-29 Thread Kun Song
Agree to put it in a specific repo, the main repo should be focused. > 在 2019年1月29日,下午10:34,Huxing Zhang 写道: > > Hi, > > On Tue, Jan 29, 2019 at 4:40 PM Xiaoguang Ma > wrote: >> >> I find a issue #3209 >

Re: discuss dubbo support opentracing

2019-01-29 Thread Huxing Zhang
Hi, On Tue, Jan 29, 2019 at 4:40 PM Xiaoguang Ma wrote: > > I find a issue #3209 > in > github. > I have some experience in opentracing. > So I want to do it. > I will provider a filter that implement org.apache.dubbo.rpc.Filter and use >

Re: discuss dubbo support opentracing

2019-01-29 Thread Ma Xiaoguang
Yes, zipkin and skywalking also support opentracing. Ma Xiaoguang Apache  ShardingSphere Signature is customized by Netease Mail Master On 01/29/2019 17:20, Yunkun Huang wrote: Currently there is a filter in brave to support integration with zipkin

Re: [ANNOUNCE] Apache Dubbo(incubating) 2.7.0 has been released

2019-01-29 Thread Taosheng, Wei
Congratulations :) It??s an exciting news! -- Original -- From: Huxing Zhang Date: Tue,Jan 29,2019 6:00 PM To: dev , Incubator General Subject: Re: [ANNOUNCE] Apache Dubbo(incubating) 2.7.0 has been released Hi community, The Apache Dubbo(incubating) team is

[ANNOUNCE] Apache Dubbo(incubating) 2.7.0 has been released

2019-01-29 Thread Huxing Zhang
Hi community, The Apache Dubbo(incubating) team is pleased to announce that the 2.7.0 has just been released. Both the source release[1] and the maven binary release[2] are available now, you can also find the detailed release notes in here[3]. 2.7.0 is a major milestone, when migration from

Re: discuss dubbo support opentracing

2019-01-29 Thread Yunkun Huang
Currently there is a filter in brave to support integration with zipkin https://github.com/openzipkin/brave/tree/master/instrumentation/dubbo-rpc But provide a integration with opentracing api directly, it may give more choice for users. On 2019/01/29 08:39:52, Xiaoguang Ma wrote: > I find a

Re: discuss dubbo support opentracing

2019-01-29 Thread Xiaoguang Ma
I find a issue #3209 in github. I have some experience in opentracing. So I want to do it. I will provider a filter that implement org.apache.dubbo.rpc.Filter and use opentracing api. Can i do it? Xiaoguang Ma from ShardingSphere Huxing

Re: discuss dubbo support opentracing

2019-01-29 Thread Huxing Zhang
Hi, Would you please elaborate what you want to discuss here? On Mon, Jan 28, 2019 at 5:46 PM Ma Xiaoguang wrote: -- Best Regards! Huxing

Re: [Notification of V2.7.0] Status, TODOs, Possible Release Schedules.

2019-01-29 Thread Huxing Zhang
Hi All, The 2.7.0 release just passed incubator vote. I am going to publish the maven artifacts. -- Best Regards! Huxing

Re: [Discuss] About Clean Code Plan

2019-01-29 Thread LiZhenNet
+1 , Grammar sugar can easily be fixed by using Idea's Analyze. What deserves attention is the duplicate code and logic optimization. Jason Joo 于2019年1月29日周二 下午3:38写道: > Hi, lan > > Agree with you. > > It's great for shorter, cleaner, more efficient logic optimizing. So I > suggest that