sorry I was not following the thread actively so might have missed something. how are planning the clean code approach as module by module or will start with any new code modifications wise ?
On Tuesday, January 29, 2019, LiZhenNet <[email protected]> wrote: > +1 , > Grammar sugar can easily be fixed by using Idea's Analyze. What deserves > attention is the duplicate code and logic optimization. > > > Jason Joo <[email protected]> 于2019年1月29日周二 下午3:38写道： > > > Hi, lan > > > > Agree with you. > > > > It's great for shorter, cleaner, more efficient logic optimizing. So I > > suggest that modifications including grammar sugar purposed for shorter, > > cleaner or more efficient are great but not just rewriting with another > > form. I surely will not object it, too. > > > > But pay attention to some features or new styles that will generate more > > objects. > > > > I think it would be more simple and easy we organize these as a kind of > > issue. Focused and small PRs are easy to review after all. > > > > best regards, > > > > Jason > > > > > On Jan 29, 2019, at 14:38, Ian Luo <[email protected]> wrote: > > > > > > Jason, > > > > > > Totally agree with you on this point. We should focus less on grammar > > sugar > > > but focus more on make the code clean, for say: divide long method into > > > shorter methods, better naming, or better doc, or even better design. > > > > > > But on the other hand, if someone from the community shows enthusiasm > for > > > updating code with new sugar, I will not object to the effort as long > as > > it > > > doesn't hurt readability, after all it is low hanging fruit :) > > > > > > What I propose is we should gather all possible ideas and group them in > > one > > > project on GitHub [1], like I said in my previous email. It is critical > > to > > > make the code clean as much as possible in my opinion. It deserves one > > > dedicated project to track all ideas. By doing this, the community can > > also > > > understand the current focuses are. > > > > > > So my question is, should we init a project focusing on clean code, > while > > > the purpose doesn't limit to grammar sugar? > > > > > > Regards, > > > -Ian. > > > > > > 1. https://github.com/apache/incubator-dubbo/projects > > > > > > On Tue, Jan 29, 2019 at 11:00 AM Jason Joo <[email protected]> wrote: > > > > > >> Hi, Huxing & LiZhen > > >> > > >> Things like diamond is something called grammar SUGAR. > > >> Tasted good for developers but the same on byte code. > > >> > > >> So in my opinion we should not take it as a kind of "policy correct". > > >> we can make the changes in the code of recent PRs but not for all the > > >> code. Think about there may be more sugars in future JVM. > > >> > > >> best regards, > > >> > > >> Jason > > >> > > >>> On Jan 29, 2019, at 10:42, yuhang xiu <[email protected]> wrote: > > >>> > > >>> Your pr has modified more than 30,000 lines of code, and most of them > > are > > >>> modifications of the entire file. > > >>> What is the meaning of your pr? Why do I need to keep it open? > > >>> > > >>> If you need to discuss, issues and mailing lists are good choices, > why > > do > > >>> you need to discuss pr? > > >>> > > >>> Who can review this pr[1] and tell me what this pr is going to do? > > >>> > > >>> [1] https://github.com/apache/incubator-dubbo/pull/3371 > > >>> > > >>> LiZhenNet <[email protected]> 于2019年1月29日周二 上午10:29写道： > > >>> > > >>>> Yes, we can create a project to manage it, and we can talk about it. > > >> like: > > >>>> Should we used Diamond Operator replace explicit type? Use Lambda? > > >>>> Let's discuss the two pull requests above instead of closed it > > >> immediately. > > >>>> > > >>>> > > >>>> > > >>>> > > >>>> > > >>>> Huxing Zhang <[email protected]> 于2019年1月29日周二 上午9:58写道： > > >>>> > > >>>>> Hi, > > >>>>> > > >>>>> Nice suggestion! > > >>>>> > > >>>>> Shall we can create a project to manage it? > > >>>>> > > >>>>> On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet <[email protected]> > > >>>> wrote: > > >>>>>> > > >>>>>> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of > > >>>> unused > > >>>>>> methods ,unused logic , nonstandard naming in the code. And there > > are > > >>>>> some > > >>>>>> code that can use the new features of java to make the code more > > >>>> concise > > >>>>>> and understandable. like Lambda , Diamond Operator and so on.These > > are > > >>>>> easy > > >>>>>> to find and fixed because of the tips of the idea .We should do it > > >>>> before > > >>>>>> completing the incubation. > > >>>>> > > >>>>> > > >>>>> > > >>>>> -- > > >>>>> Best Regards！ > > >>>>> Huxing > > >>>>> > > >>>> > > >> > > >> > > > > >
