Re: [ANN] Apache Dubbo as a Top-level project

[田 小波]

Congratulations !

Re: [VOTE] Apache Dubbo graduation to Top Level Project

[田 小波]

+1 to graduate.

Re: [DISCUSS] Graduate Apache Dubbo(incubating) as a Top Level Project

[田 小波]

Looking forward to Dubbo graduating from ASF incubator.

> 在 2019年3月30日，下午6:00，Huxing Zhang  写道：
> 
> Hi All,
> 
> It has been more than 1 year since Dubbo joins the ASF
> incubator(2018-02-16). During incubation I think Dubbo community has
> been growing in a fast and healthy way, and also learned a lot about how
> to collaborate in Apache way.
> 
> I think it is time to discuss the graduation as a Top level project for Dubbo.

Re: ConsistentHash LoadBalance中的解释：缺省只对第一个参数进行Hash运算是什么意思？

[田 小波]

Hi Kitito:

If the user chooses ConsistentHashLoadBalance, indicate the user wants to load 
balance 
through the runtime parameters and expects remote calls with the same parameter 
values 
to fall on the same server. After the introduction of IP, this load balancing 
strategy will be disrupted.

Thanks,
Xiaobo

> 在 2019年2月22日，下午3:19，徐靖峰  写道：
> 
> Hi, Jason
> 
> I know that the default logic of ConsistentHash LoadBalance is hashed by 
> parameters, and dubbo provide the configuration
> 
>   to config the hash 
> params
> 
>  to config virtual nodes
> 
> My opinion is Dubbo can extend the hash key, not only the request method 
> params. 
> 
> IP consistent hash is a such common requirement while Dubbo’s existing 
> extension don’t include it, there is no need to let the users extend by 
> themselves,
> 
> A little change for Consistent Hash LoadBalance will support such function.
> 
> Kitito
> 
>> 在 2019年2月22日，上午11:39，Jason Joo  写道：
>> 
>> hi, moe
>> 
>> I think what you mention is like "ip_hash" in NGINX or some other.
>> 
>> ConsistentHashLB is hashed by parameters because a same logic will just act 
>> the same under the same parameters (which we call it reenterability). Adding 
>> other parameters will break it.
>> 
>> While DUBBO provides the ability extending load balancers which makes it 
>> possible to implement kinds of balancers like ip_hash, app_version_hash or 
>> others.
>> 
>> best regards,
>> 
>> Jason
>> 
>>> On Feb 22, 2019, at 11:00, 徐靖峰  wrote:
>>> 
>>> Hi all
>>> 
>>> I don’t think that ConsistentHashLoadBalancer should only load balance by 
>>> the method param, maybe more configuration can provide to the user to 
>>> achieve more type of dynamic hash parameters, such as hash by the 
>>> requestIp, more request param.
>>> 
>>> 
>> 
> 
> 
> 

Re: ConsistentHash LoadBalance中的解释：缺省只对第一个参数进行Hash运算是什么意思？

[田 小波]

Hi,

我觉得这并不是一个 bug，ConsistentHashLoadBalance 只根据运行时参数值进行负载均衡。
如果两个接口的参数值相同，那么这两个远程调用会被分配到同一台机器上。当接口方法中
不存在参数时，我们也可认为他们的参数值是相同的，从源码的角度来说，它们都是空串。
因此在运行时，ConsistentHashLoadBalance 会将不存在参数的远程调用分配到同一个机器上。

translate by Google Translator:

I don't think this is a bug. ConsistentHashLoadBalance only load balances based 
on runtime parameter values.
If the parameter values of the two interfaces are the same, then the two remote 
calls are assigned to the same machine. In the interface method
When there are no parameters, we can also think that their parameter values are 
the same. From the source point of view, they are all empty strings.
So at runtime, ConsistentHashLoadBalance will assign remote calls with no 
parameters to the same machine.

> 在 2019年2月13日，下午8:20，Xianjun Ke  写道：
> 
> Good question. And about your last question, I have made some test in my
> local machine,
> it seems that there is a bug about the ConsistentHashLoadBalance when the
> method has
> no argument, pls refer this issue [1]
> 
> [1] https://github.com/apache/incubator-dubbo/issues/3468
> 
> 一直以来 <279377...@qq.com> 于2019年2月13日周三 下午3:41写道：
> 
>> ConsistentHash LoadBalance：一致性
>> Hash，相同参数的请求总是发到同一提供者。当某一台提供者挂时，原本发往该提供者的请求，基于虚拟节点，会平摊到其它提供者，不会引起剧烈变动。缺省只对第一个参数进行Hash运算。
>> 
>> 第一个参数指什么？？是每个接口中方法的第一个参数吗，如果是的话，如果方法没有参数是什么行为？请教，感谢！

Re: 缺省用160份虚拟节点，这个知识点在官网的文档中有解释吗？我想知道DUBBO中的虚拟节点是怎么回事。

[田 小波]

“虚拟节点”是“哈希一致性”算法中的知识点，建议先补充哈希一致性相关背景知识

> 在 2019年2月13日，下午4:36，一直以来 <279377...@qq.com> 写道：
> 
> 缺省用160份虚拟节点，如果要修改，请配置：
> 
> 

Re: Ordering in dubbo call

[田 小波]

Hi,

Hi All,
Could someone point me to any doc or material or with any information
which can help me to understand the ordering of invocation in dubbo and how
it works?

This article[1] analyzes Dubbo's calling process in detail, but unfortunately, 
this article is only available in Chinese.
For non-native Chinese speakers, please translate via Chrome or Google 
Translate.

[1] 
http://dubbo.apache.org/zh-cn/docs/source_code_guide/service-invoking-process.html

Regards,
Xiaobo

Re: dubbo-website PRs need to be reviewed.

[田 小波]

Hi Xiaojie,

I can try to review it

The main content of dubbo-website PR #239[1] is an article, this PR was 
submitted by me.
The article in PR analyzes Dubbo's calling process in detail, it is long and 
requires some patience review. Thank you.

dubbo-website PR #239 的主要内容是一篇文章，这个 PR 是我提交的。PR 中的文章详细分析了 Dubbo 
的调用过程，文章比较长，需要一些耐心 review。谢谢。

[1] https://github.com/apache/incubator-dubbo-website/pull/239

dubbo-website PRs need to be reviewed.

[田 小波]

Hi,

dubbo-website has some pull requests need to be reviewed.

Regard,
Xiaobo

Re: AbstractConfig中的toString()方法反射调用getter是否妥帖

[田 小波]

Hi,

This problem has been fixed in pull request 
#2759

在 2019年1月7日，上午11:00，Aaron mailto:lzwukey...@163.com>> 写道：

AbstractConfig类的toString()方法，为了输出显示，会反射调用getter方法。
而纯粹的getter方法当然没有问题，可AbstractConfig的实现类ReferenceBean继承了
Spring的FactoryBean接口，其方法getObject并不是纯粹的getter，其含有初始化逻辑。
虽然有initialized的字段用来防止重复初始化，但个人感觉这样仍有存疑，给调试工作也带来了一些意外。
个人建议，即使是为了日志、调试等显示工作，在referenceBean的输出中，加上一个obect:proxy$的字段也并不能提供
些许有效信息，所以建议，toString中可以显示忽略掉getObject()方法

Re: slow on pull request and issue

[田 小波]

> Maybe you can explain a bit more of what 996 is. :)

The following content from Baidu Encyclopedia：

The 996 working system refers to work at 9:00 on weekdays, off work at 9:00 pm, 
1 hour (or less) at noon and evening, totaling more than 10 hours, and working 
6 days a week.

Re: slow on pull request and issue

[田 小波]

Many people usually participate in the community in their spare time. 
Many companies have a long working time (996), which leads to the 
compression of their spare time. which ultimately leads to the low 
activity of Committers. This is also very helpless.

大家平时都是在下班后参与到社区中。不少公司工作时间比较长（996），
导致业余时间被压缩，最终导致 Committer 们的活跃度不高，这也是很无奈的事情。

Re: [Notification of Dubbo Admin] about to release the first version

[田 小波]

Hi:

It is recommended to add the Chinese version. Most users of Dubbo are in China, 
and the Chinese version will let domestic developers improve their favor for 
Dubbo.

Regards,
Xiaobo

Re: Dubbo Community page 404

[田 小波]

The dubbo-website project has recently had a lot of issues about dead link, so 
I wrote a simple crawler to check the official website and found 30 dead links. 
I created an issue #215[1] to track dead link problem.

dubbo-website 项目最近出现很多关于死链的 issue，所以我写了一个简单的爬虫对官网进行检查，目前并发现了30个死链。我建立了一个 issue 
[1]，用于跟踪死链问题。

[1] https://github.com/apache/incubator-dubbo-website/issues/215

Source code guide published

[田 小波]

Hi community:

The source code guide is published on the official website, and you can access 
it via this link[1].
The source code guide currently contains source code analysis for Dubbo SPI, 
Adaptive Extension, Service export, Service import, and cluster fault 
tolerance. There is currently no analysis of the Dubbo invoke process, which I 
will update later.
It is important to note that the source code guide was modified from my 
personal article. So it may seem that it is not professional enough. If there 
are any mistakes in the article, please feel free to mention the issue, or PR 
to correct it. Let us build the Dubbo community together, thank you.

源码导读系列文章目前已经在官网上发布了，你可以通过此链接[1]进行访问。源码导读目前包含 Dubbo SPI、Adaptive 
Extension、Service export、Service import、集群容错等模块的源码分析。除此之外，还缺少对 Dubbo 
调用过程的分析，我将在随后进行更新。
需要特别说明的是，源码导读系列文章是由我个人文章修改而来。因此看起来可能会显得不够专业，如果文章中有错误不妥之处，欢迎大家提 issue，或者 PR 
进行修正。让我们一起共建 Dubbo 社区，感谢。

[cid:ad4e9bb9-eb7c-4203-abf7-7890fe04fb05]

Regards,
Xiaobo

[1] http://dubbo.apache.org/zh-cn/docs/source_code_guide/dubbo-spi.html

Re: Source code guide

[田 小波]

> Rebuilt and published, source code guide is online now :)

Thanks very mush, I will write an email to introduce the source code guide.

Regards,
Xiaobo

Re: Source code guide

[田 小波]

Hi folks,

I have updated site_config/doc.js in PR 
#206<https://github.com/apache/incubator-dubbo-website/pull/206>, please help 
rebuild the website to make 'source code guide' appeared. Thanks !

Regards,
Xiaobo

在 2018年12月17日，下午11:35，田 小波 
mailto:tianxiaobo@outlook.com>> 写道：

Thanks to review this PR, I will update site_config/doc.js tomorrow.

Thanks.
Xiaobo

在 2018年12月17日，下午11:26，Huxing Zhang 
mailto:hux...@apache.org>> 写道：

Hi,

The pull request looks good to me, I have merge the pr[1].

To make sure your docs appear in the sidebar of
http://dubbo.apache.org/zh-cn/docs/user/quick-start.html, would you
please also update site_config/doc.js?

If you check site_config/doc.js, you can see there is lots of examples.

[1] https://github.com/apache/incubator-dubbo-website/pull/197

On Mon, Dec 10, 2018 at 2:21 PM 田 小波 
mailto:tianxiaobo@outlook.com>> wrote:

Hi community,

I just submitted my source analysis article to dubbo-website, the PR number is 
#197 [1], please help check.

[1] https://github.com/apache/incubator-dubbo-website/pull/197

Thanks!
Xiaobo

Re: [ANN] New PPMC member: Yuhang Xiu

[田 小波]

Congratulations !

Re: Source code guide

[田 小波]

Thanks to review this PR, I will update site_config/doc.js tomorrow.

Thanks.
Xiaobo

> 在 2018年12月17日，下午11:26，Huxing Zhang  写道：
> 
> Hi,
> 
> The pull request looks good to me, I have merge the pr[1].
> 
> To make sure your docs appear in the sidebar of
> http://dubbo.apache.org/zh-cn/docs/user/quick-start.html, would you
> please also update site_config/doc.js?
> 
> If you check site_config/doc.js, you can see there is lots of examples.
> 
> [1] https://github.com/apache/incubator-dubbo-website/pull/197
> 
> On Mon, Dec 10, 2018 at 2:21 PM 田 小波  wrote:
>> 
>> Hi community,
>> 
>> I just submitted my source analysis article to dubbo-website, the PR number 
>> is #197 [1], please help check.
>> 
>> [1] https://github.com/apache/incubator-dubbo-website/pull/197
>> 
>> Thanks!
>> Xiaobo
>> 
>> 在 2018年12月10日，上午11:55，雷舜宇 
>> mailto:shunyuma...@gmail.com>> 写道：
>> 
>> I said that I am currently doing the service-completed comments completion
>> work. If there is a problem, I will exchange this on the mailing list.
>> 
>> 田 小波 mailto:tianxiaobo@outlook.com>> 
>> 于2018年12月10日周一 上午10:03写道：
>> 
>> OK, I will submit a PR tomorrow.
>> 
>> 在 2018年12月9日，下午4:50，Ian Luo mailto:ian@gmail.com>> 写道：
>> 
>> I will take a look, and talk to you on pull request.
>> 
>> -Ian.
>> 
>> On Fri, Dec 7, 2018 at 6:11 PM 田 小波 
>> mailto:tianxiaobo@outlook.com>> wrote:
>> 
>> Ian:
>> I will make some simple changes to these articles and submit them to
>> dubbo-website. Limited to personal abilities, if there are any mistakes
>> in
>> the article, please help to modify and improve.
>> 
>> 我会对这些文章做一些简单的修改，然后将这些文章提交给
>> dubbo-website。限于个人能力，如果文章中有错误不妥之处，还请大家帮忙修改和完善。
>> 
>> Thanks!
>> Xiaobo
>> 
>> Pls. go ahead to submit your articles:
>> 
>> Then we can involve other peoples in the community to join the effort.
>> 
>> What do you think?
>> 
>> Thanks,
>> -Ian.
>> 
>> 
>> 
>> 
> 
> 
> -- 
> Best Regards！
> Huxing

Source code guide

[田 小波]

Hi community,

I just submitted my source analysis article to dubbo-website, the PR number is 
#197 [1], please help check.

[1] https://github.com/apache/incubator-dubbo-website/pull/197

Thanks!
Xiaobo

在 2018年12月10日，上午11:55，雷舜宇 mailto:shunyuma...@gmail.com>> 
写道：

I said that I am currently doing the service-completed comments completion
work. If there is a problem, I will exchange this on the mailing list.

田 小波 mailto:tianxiaobo@outlook.com>> 
于2018年12月10日周一 上午10:03写道：

OK, I will submit a PR tomorrow.

在 2018年12月9日，下午4:50，Ian Luo mailto:ian@gmail.com>> 写道：

I will take a look, and talk to you on pull request.

-Ian.

On Fri, Dec 7, 2018 at 6:11 PM 田 小波 
mailto:tianxiaobo@outlook.com>> wrote:

Ian:
I will make some simple changes to these articles and submit them to
dubbo-website. Limited to personal abilities, if there are any mistakes
in
the article, please help to modify and improve.

我会对这些文章做一些简单的修改，然后将这些文章提交给
dubbo-website。限于个人能力，如果文章中有错误不妥之处，还请大家帮忙修改和完善。

Thanks!
Xiaobo

Pls. go ahead to submit your articles:

Then we can involve other peoples in the community to join the effort.

What do you think?

Thanks,
-Ian.

Re: About the comments coverage of the code

[田 小波]

OK, I will submit a PR tomorrow.

> 在 2018年12月9日，下午4:50，Ian Luo  写道：
> 
> I will take a look, and talk to you on pull request.
> 
> -Ian.
> 
> On Fri, Dec 7, 2018 at 6:11 PM 田 小波  wrote:
> 
>> Ian:
>> I will make some simple changes to these articles and submit them to
>> dubbo-website. Limited to personal abilities, if there are any mistakes in
>> the article, please help to modify and improve.
>> 
>> 我会对这些文章做一些简单的修改，然后将这些文章提交给 dubbo-website。限于个人能力，如果文章中有错误不妥之处，还请大家帮忙修改和完善。
>> 
>> Thanks!
>> Xiaobo
>> 
>>> Pls. go ahead to submit your articles:
>>> 
>>> Then we can involve other peoples in the community to join the effort.
>>> 
>>> What do you think?
>>> 
>>> Thanks,
>>> -Ian.
>> 

Re: About the comments coverage of the code

[田 小波]

Ian:
I will make some simple changes to these articles and submit them to 
dubbo-website. Limited to personal abilities, if there are any mistakes in the 
article, please help to modify and improve.

我会对这些文章做一些简单的修改，然后将这些文章提交给 dubbo-website。限于个人能力，如果文章中有错误不妥之处，还请大家帮忙修改和完善。

Thanks!
Xiaobo

> Pls. go ahead to submit your articles:
> 
> Then we can involve other peoples in the community to join the effort.
> 
> What do you think?
> 
> Thanks,
> -Ian.

Re: Dubbo Community page 404

[田 小波]

We may have regular health checks for the official website through web 
crawlers, so that 404 pages can be processed in time.

我们或许可以通过网络爬虫定期对官网进行健康检测，这样可以及时处理404页面。

Regards,
Xiaobo

在 2018年12月7日，上午11:17，Huxing Zhang mailto:hux...@apache.org>> 
写道：

On Fri, Dec 7, 2018 at 11:14 AM YunKun Huang 
mailto:hyun...@apache.org>> wrote:

I believe the root cause is we don't have default route rule for website.

If one article doesn't have Chinese version, it should show english version.
Same for only Chinese version article.

If that is the case, this is a known issue.
I think we can display to default page saying that currently the page
does not exist and we'd like you to help it out, with some guide on
how they can help on  it.


On 2018/12/07 02:35:18, Huxing Zhang 
mailto:hux...@apache.org>> wrote:
Hi,

Thanks for reporting, it is appreciated if you can help to fix it :)
On Thu, Dec 6, 2018 at 5:36 PM 凝雨 mailto:ningbe...@163.com>> 
wrote:

Hi community,


This page in the community[1]  access returns 404, Please check.



[1].http://dubbo.apache.org/zh-cn/blog/dubbo-meetup-beijing-may-12th-2018.html


Best regards,
ningyu



--
Best Regards！
Huxing




--
Best Regards！
Huxing

Re: About the comments coverage of the code

[田 小波]

Hi Ian:

There is already an article[1] on the Dubbo architecture in Dubbo's official 
documentation. Maybe I can write an article about "how to read Dubbo code" 
according to my own experience.

Dubbo 官方文档中已经有一篇对 Dubbo 架构介绍的文章，或许我可以根据我自己的经历写一篇如何阅读 Dubbo 源码的文章。

[1] http://dubbo.apache.org/zh-cn/docs/dev/design.html

在 2018年12月6日，下午2:02，Ian Luo mailto:ian@gmail.com>> 写道：

Xiaobo,

I think this is a good proposal. Pls. create a new section 'source code
guide' under docs, and let's build it together.

Thanks,
-Ian.

Re: About the comments coverage of the code

[田 小波]

Hi community,

I noticed that people in the WeChat group said that Dubbo's comments are too 
few and unfriendly to beginners. I just wrote some source analysis articles 
about Dubbo in the past. I have a lot of comments and analysis on the Dubbo 
source in the article. I think these articles can help beginners learn Dubbo. 
The list of articles is as follows:

时间  文章
2018-10-01  Dubbo 源码分析 - SPI 
机制
2018-10-13  Dubbo 源码分析 - 
自适应拓展原理
2018-10-31  Dubbo 源码分析 - 
服务导出
2018-11-12  Dubbo 源码分析 - 
服务引用
2018-11-17  Dubbo 源码分析 - 集群容错之 
Directory
2018-11-20  Dubbo 源码分析 - 集群容错之 
Router
2018-11-24  Dubbo 源码分析 - 集群容错之 
Cluster
2018-11-29  Dubbo 源码分析 - 集群容错之 
LoadBalance
未完成 Dubbo 源码分析 - 并发模型
未完成 Dubbo 源码分析 - 编解码

If you are interested, you can review it. If you feel good, I can submit these 
articles to dubbo-website. If you feel that writing is not good, you are 
welcome to give some advice.

我注意到有人在微信群里说 Dubbo 的注释太少，对初学者不友好。我正好在过去一段时间内写了一些关于 Dubbo 的源码分析文章，我在文章中对 Dubbo 
源码进行了大量的注释和分析，我觉得这些文章可以帮助初学者学习 Dubbo。大家如果有兴趣，可以进行 review。如果觉得还不错，我可以将这些文章提交给 
dubbo-website。如果觉得写的不好，也欢迎多多指教。

Regards
Xiaobo

在 2018年12月5日，下午1:56，Ian Luo  写道：

What I suggest is to revisit and enhance the existing javadoc/comments
before consider to add more:
1. Enhance JavaDoc for all API. For this part, we may need some helps from
native speakers
2. Revisit the current existing comments, and make it easier to understand

Just my two cents,
-Ian.

On Tue, Dec 4, 2018 at 5:10 PM yuhang xiu  wrote:

Recently dubbo held an offline meetup. When discussing with many
participants, many people have suggested that dubbo has very few comments.

Comments are very important for us to understand the code. If our comments
are few, it is very unfriendly for new developers.

I created a new issue[1] to track this. We need more developers to
contribute notes. I will continue to follow up on this matter.

[1] https://github.com/apache/incubator-dubbo/issues/2884

Re: [ANNOUNCE] Apache Dubbo(incubating) 2.6.5 has been released

[田 小波]

Hi, the release note contains some spelling error. As follow:

[cid:9EB94120-F31C-4B31-9077-01BF76021B3E]

The "Reactor" should be modified to “Refactor".

在 2018年11月23日，下午3:28，yuhang xiu mailto:carry...@gmail.com>> 
写道：

Nice work.
Let us move on.

victory mailto:vict...@apache.org>> 于2018年11月23日周五 下午3:23写道：

Hi, community,

I am pleased to announce that the 2.6.5 version has just been released.
Both the source release[1] and the maven binary release[2] are available
now, you can also find the detailed release notes in here[3] or quickly
check the important changes I list below:

Enhancements / Features：
- Reactor the generation rule for @Service Bean name
[#2235](https://github.com/apache/incubator-dubbo/issues/2235)
- Introduce a new Spring ApplicationEvent for ServiceBean exporting
[#2251](https://github.com/apache/incubator-dubbo/issues/2251)
- [Enhancement] the algorithm of load issue on Windows.
[#1641](https://github.com/apache/incubator-dubbo/issues/1641)
- add javadoc to dubbo-all module good first issue.
[#2600](https://github.com/apache/incubator-dubbo/issues/2600)
- [Enhancement] Reactor the generation rule for @Service Bean name
type/enhancement
[#2235](https://github.com/apache/incubator-dubbo/issues/2235)
- Optimize LeastActiveLoadBalance and add weight test case.
[#2540](https://github.com/apache/incubator-dubbo/issues/2540)
- Smooth Round Robin selection.
[#2578](https://github.com/apache/incubator-dubbo/issues/2578)
[#2647](https://github.com/apache/incubator-dubbo/pull/2647)
- [Enhancement] Resolve the placeholders for sub-properties.
[#2297](https://github.com/apache/incubator-dubbo/issues/2297)
- Add ability to turn off SPI auto injection, special support for
generic Object type injection.
[#2681](https://github.com/apache/incubator-dubbo/pull/2681)

Bugfixes：
- @Service(register=false) is not work.
[#2063](https://github.com/apache/incubator-dubbo/issues/2063)
- Our customized serialization id exceeds the maximum limit, now it
cannot work on 2.6.2 anymore.
[#1903](https://github.com/apache/incubator-dubbo/issues/1903)
- Consumer throws RpcException after RegistryDirectory notify in high
QPS. [#2016](https://github.com/apache/incubator-dubbo/issues/2016)
- Annotation @Reference can't support to export a service with a sync
one and an async one .
[#2194](https://github.com/apache/incubator-dubbo/issues/2194)
-
`org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor#generateReferenceBeanCacheKey`
has a bug. [#2522](https://github.com/apache/incubator-dubbo/issues/2522)
- 2.6.x Spring Event & Bugfix.
[#2256](https://github.com/apache/incubator-dubbo/issues/2256)
- Fix incorrect descriptions for dubbo-serialization module.
[#2665](https://github.com/apache/incubator-dubbo/issues/2665)
- A empty directory
dubbo-config/dubbo-config-spring/src/test/resources/work after package
source tgz. [#2560](https://github.com/apache/incubator-dubbo/issues/2560)
- Fixed 2.6.x branch a minor issue with doConnect not using
getConnectTimeout() in NettyClient.  (*No issue*).
[#2622](https://github.com/apache/incubator-dubbo/pull/2622)
- Bean name of @service annotated class does not resolve placeholder.
[#1755](https://github.com/apache/incubator-dubbo/issues/1755)



Normally, you can smoothly upgrade to the new version from any version
before 2.6.5 without having to do too many changes to your apps and without
having to worry about any incompatible problems.
If you have any usage questions, or have problems when upgrading or find
any problems about enhancements included in this release, please don’t
hesitate to let us know by sending feedback to this mailing list or filing
an issue on github[4].

1. https://dist.apache.org/repos/dist/release/incubator/dubbo/2.6.5/

2. http://central.maven.org/maven2/com/alibaba/
3. https://github.com/apache/incubator-dubbo/releases
4. https://github.com/apache/incubator-dubbo/issues


Best Regard!
cvictory

Re: Fix issue 2425 and bring a new contributor

[田 小波]

Maybe domestic developers are not used to discuss by mailing list, most of them 
prefer QQ and WeChat group. The mailing list is a new thing for most the 
developers, they may not do know what is it, and how to use.

> 在 2018年11月23日，上午11:58，yuhang xiu  写道：
> 
> Hi huxing,
> 
> Some people are less willing to be interrupted by some mails.
> Some people think that github is enough. Currently they have not
> participated in the dubbo community, so I personally understand that they
> still can't understand the value of the mailing list.
> 
> My personal plan is to get involved in the community first, and then bring
> them here.
> 
> By the way, pr[1] has already been submitted to github, and I am very glad
> that our discussion in a few days is fruitful. For him, this must be a new
> experience.
> 
> [1] https://github.com/apache/incubator-dubbo/pull/2822
> 
> Thx
> 
> Huxing Zhang  于2018年11月23日周五 上午11:39写道：
> 
>> On Fri, Nov 23, 2018 at 11:32 AM yuhang xiu  wrote:
>>> 
>>> Hi, community
>>> 
>>> Recently I tried to distribute some simple issue fixes to newcomers who
>>> have not contributed to dubbo to cultivate their passion for
>> participating
>>> in the dubbo community.
>>> 
>>> I have passed a newcomer and handed him the issue of issue 2425,
>> discussed
>>> the solution with him and directed him to the fork repository and submit
>>> the pr.
>>> 
>>> Some of them don't have a deep understanding of dubbo, but they like
>> dubbo
>>> and are willing to participate in open source work. I have organized a
>>> group of several people at the moment. This is good news, I will collect
>>> some relatively simple issues in the future and encourage them to fix
>> them.
>>> On issue 2425, we will soon receive a new PR from a new contributor.
>> 
>> Good to hear that!
>> 
>>> 
>>> Another unhealthy news is that I have not yet convinced them to
>> participate
>>> in the discussion of the mailing list. :(
>>> But I will never give up. :)
>> 
>> May I ask why they are not coming to mailing list?
>> I'd like to help if you can give more background information.
>> 
>>> 
>>> If we can pass the issue 2425 pr, I will definitely introduce this new
>>> contributor on the mailing list, I think that would be a good opportunity
>>> for him to participate in the discussion of the mailing list. :)
>>> 
>>> Thx.
>> 
>> 
>> 
>> --
>> Best Regards！
>> Huxing
>> 

Re: a problem about developer guide

[田 小波]

Hi, I clicked most of the pages under the Demos category，they all work well in 
my computer. You may can open the link on other computer or mobile to check 
this problem.

> 在 2018年11月20日，下午10:32，华 钟明  写道：
> 
> Address: http://dubbo.apache.org/en-us/docs/dev/build.html
> For example, click Demos to expand the secondary menu.
> 
> 在 2018/11/20 下午8:07，“jun liu” 写入:
> 
>CrazyHZM,
> 
>> I want to reflect a problem, the User doc secondary directory in dubbo's 
>> developer guide is not responding.
> 
>Thanks for the feedback, but I failed to locate the problem you are 
> mentioning, would you mind to provide a specific address?
> 
>Best regards,
>Jun
> 
>> On Nov 20, 2018, at 5:22 PM, 华 钟明  wrote:
>> 
>> Hi:
>>  I want to reflect a problem, the User doc secondary directory in 
>> dubbo's developer guide is not responding.
>> 
>> Great work!
>> 
>> CrazyHZM
> 
> 

Bug feedback

[田 小波]

I find a potential problem, it will result in ReferenceBean refers service more 
than once when debugging or printing ReferenceBean. And make some strange error 
to confuse code reader. I can reappear this problem, and I have submitted a PR 
(#2754) to fix it (CI 
processing is very slow, please help to check.). please visit 
http://t.cn/EAhta27 to get more detail about the problem.

Pull Request #176

[田 小波]

Hi,

I have updated docs about the delay exposure, please check it when you have 
free time.

Best wishes
-Xiaobo

Re: pull request 2686

[田 小波]

OK. I will read it carefully on this weekend.

-xiaobo

> 在 2018年11月2日，上午11:30，Ian Luo  写道：
> 
> Then Xiaobo, I am looking forward to merging your another pull request for
> doc update :). You should start to look into website project [1]. Pls. read
> its README to understand how to build it.
> 
> Thanks,
> -Ian.
> 
> 1. https://github.com/apache/incubator-dubbo-website
> 
> On Fri, Nov 2, 2018 at 11:15 AM 田 小波  wrote:
> 
>> OK. I got it.
>> 
>>> 在 2018年11月2日，上午11:10，jun liu  写道：
>>> 
>>>> Nice! if needed, May I help to update the doc about delay exposure when
>> PR-2686 is released at next release or later.
>>> 
>>> That would be great. Docs are the part I forget to mention. You can
>> submit a PR to the dubbo-website project hosted here:
>>> https://github.com/apache/incubator-dubbo-website
>>> 
>>> Best regards,
>>> Jun
>>> 
>>>> On Nov 2, 2018, at 10:49 AM, 田 小波  wrote:
>>>> 
>>>> Nice! if needed, May I help to update the doc about delay exposure when
>> PR-2686 is released at next release or later.
>>>> 
>>>> 在 2018年11月2日，上午10:07，Ian Luo > ian@gmail.com>> 写道：
>>>> 
>>>> To make sure I understand the change affect right, is the following and
>> the corresponding action right (for spring supports application listener)?
>>>> Export always being executed after Spring Context initialized properly
>> despite the delay value, and the delay times after that is:
>>>> * delay=null, no delay
>>>> * delay=0, no delay
>>>> * delay=-1 or delay=-5000, no delay
>>>> * delay=5000, delay for 5s.
>>>> 
>>>> Correct, this is what I understand too.
>>>> 
>>>> On Fri, Nov 2, 2018 at 9:51 AM jun liu > ken.lj...@gmail.com>> wrote:
>>>>> To conclude, Dubbo should start to expose services until spring context
>>>>> gets refreshed, no matter delay or no-delay is configured.
>>>> 
>>>> +1, agree with this logic as the default for the export process.
>>>> 
>>>>> Unfortunately in
>>>>> order to keep backward compatibility, considering not all spring
>> versions
>>>>> support context refresh callback, we have to start to expose services
>> after
>>>>> properties set if we find application listener is not supported, and
>> hope
>>>>> Dubbo service can be exposed normally.
>>>> 
>>>> At first, I tend to remove the compatibility purpose snippet, because
>> spring versions without application listener support seems to be v2.0.0 or
>> earlier which must have been announced EOL long ago and may have few users.
>> But since the critical export process will never be triggered if removed, I
>> think it’s ok to continue keep it.
>>>> 
>>>> To make sure I understand the change affect right, is the following and
>> the corresponding action right (for spring supports application listener)?
>>>> 
>>>> Export always being executed after Spring Context initialized properly
>> despite the delay value, and the delay times after that is:
>>>> * delay=null, no delay
>>>> * delay=0, no delay
>>>> * delay=-1 or delay=-5000, no delay
>>>> * delay=5000, delay for 5s.
>>>> 
>>>> Best regards,
>>>> Jun
>>>> 
>>>>> On Nov 1, 2018, at 10:39 AM, Ian Luo > ian@gmail.com>> wrote:
>>>>> 
>>>>>> 当代码修改后，由于 afterPropertiesSet 不再对 delay 进行校验。导致当 delay > 0，且
>>>>> supportedApplicationListener = true 时，export 会被 onApplicationEvent
>> 调用，而不是
>>>>> afterPropertiesSet。这会造成服务被延迟到 Spring 容器就绪后的 delay
>>>>> 毫秒暴露，而不是像之前被延迟到afterPropertiesSet 调用 export 后的 delay 毫秒暴露。
>>>>> 
>>>>> I think this behavior is expected. The reason is, the best timing for
>> Dubbo
>>>>> to count down delay for exposing service is when Spring container is
>> ready,
>>>>> then this timing should be the moment when spring context gets
>> refreshed,
>>>>> since at this moment, all beans are settled, and are ready for wiring
>> in
>>>>> their dependencies. If it happens earlier, say, at the moment after
>>>>> properties set, then Dubbo may fail to expose service because it
>> depends on
>>>>> other spring bean.
>>>>> 
>>>>> To conclude, Dubbo should start to expos

Re: pull request 2686

[田 小波]

OK. I got it.

> 在 2018年11月2日，上午11:10，jun liu  写道：
> 
>> Nice! if needed, May I help to update the doc about delay exposure when 
>> PR-2686 is released at next release or later.
> 
> That would be great. Docs are the part I forget to mention. You can submit a 
> PR to the dubbo-website project hosted here:
> https://github.com/apache/incubator-dubbo-website
> 
> Best regards,
> Jun
> 
>> On Nov 2, 2018, at 10:49 AM, 田 小波  wrote:
>> 
>> Nice! if needed, May I help to update the doc about delay exposure when 
>> PR-2686 is released at next release or later.
>> 
>> 在 2018年11月2日，上午10:07，Ian Luo mailto:ian@gmail.com>> 
>> 写道：
>> 
>> To make sure I understand the change affect right, is the following and the 
>> corresponding action right (for spring supports application listener)?
>> Export always being executed after Spring Context initialized properly 
>> despite the delay value, and the delay times after that is:
>> * delay=null, no delay
>> * delay=0, no delay
>> * delay=-1 or delay=-5000, no delay
>> * delay=5000, delay for 5s.
>> 
>> Correct, this is what I understand too.
>> 
>> On Fri, Nov 2, 2018 at 9:51 AM jun liu 
>> mailto:ken.lj...@gmail.com>> wrote:
>>> To conclude, Dubbo should start to expose services until spring context
>>> gets refreshed, no matter delay or no-delay is configured.
>> 
>> +1, agree with this logic as the default for the export process.
>> 
>>> Unfortunately in
>>> order to keep backward compatibility, considering not all spring versions
>>> support context refresh callback, we have to start to expose services after
>>> properties set if we find application listener is not supported, and hope
>>> Dubbo service can be exposed normally.
>> 
>> At first, I tend to remove the compatibility purpose snippet, because spring 
>> versions without application listener support seems to be v2.0.0 or earlier 
>> which must have been announced EOL long ago and may have few users. But 
>> since the critical export process will never be triggered if removed, I 
>> think it’s ok to continue keep it.
>> 
>> To make sure I understand the change affect right, is the following and the 
>> corresponding action right (for spring supports application listener)?
>> 
>> Export always being executed after Spring Context initialized properly 
>> despite the delay value, and the delay times after that is:
>> * delay=null, no delay
>> * delay=0, no delay
>> * delay=-1 or delay=-5000, no delay
>> * delay=5000, delay for 5s.
>> 
>> Best regards,
>> Jun
>> 
>>> On Nov 1, 2018, at 10:39 AM, Ian Luo 
>>> mailto:ian@gmail.com>> wrote:
>>> 
>>>> 当代码修改后，由于 afterPropertiesSet 不再对 delay 进行校验。导致当 delay > 0，且
>>> supportedApplicationListener = true 时，export 会被 onApplicationEvent 调用，而不是
>>> afterPropertiesSet。这会造成服务被延迟到 Spring 容器就绪后的 delay
>>> 毫秒暴露，而不是像之前被延迟到afterPropertiesSet 调用 export 后的 delay 毫秒暴露。
>>> 
>>> I think this behavior is expected. The reason is, the best timing for Dubbo
>>> to count down delay for exposing service is when Spring container is ready,
>>> then this timing should be the moment when spring context gets refreshed,
>>> since at this moment, all beans are settled, and are ready for wiring in
>>> their dependencies. If it happens earlier, say, at the moment after
>>> properties set, then Dubbo may fail to expose service because it depends on
>>> other spring bean.
>>> 
>>> To conclude, Dubbo should start to expose services until spring context
>>> gets refreshed, no matter delay or no-delay is configured. Unfortunately in
>>> order to keep backward compatibility, considering not all spring versions
>>> support context refresh callback, we have to start to expose services after
>>> properties set if we find application listener is not supported, and hope
>>> Dubbo service can be exposed normally.
>>> 
>>> I hope this can clarify the behavior.
>>> 
>>> -Ian.
>>> 
>>> 
>>> 
>>> On Thu, Nov 1, 2018 at 10:03 AM Zonghai Shang 
>>> mailto:y...@apache.org>> wrote:
>>> 
>>>> Hi,
>>>> 
>>>>> 我重新看了代码和文档，发现确实存在一个延迟暴露的问题。这里先列举 Dubbo 的延迟暴露策略：
>>>>> delay = null 或 delay = -1 ：延迟到 Spring 容器就绪后暴露服务，由 onApplicationEvent 调用
>>>> export 暴露服务
>>>>> delay > 0 ：延迟指定毫秒后暴露服务，时间从 afterPropertiesSet 调用 export
>>>> 时算起，此时由 afterPropertiesSet 调用 e

Re: pull request 2686

[田 小波]

Last night, I thought deeply the timing of Dubbo expose service. And I also 
think It is more reasonable to expose service after Spring ready.

-xiaobo

在 2018年11月1日，上午11:12，Ian Luo mailto:ian@gmail.com>> 写道：

pls. always loop in dev@dubbo.apache.org<mailto:dev@dubbo.apache.org> to 
discuss :)

On Thu, Nov 1, 2018 at 11:07 AM 田 小波 
mailto:tianxiaobo@outlook.com>> wrote:
Last night, I thought deeply the timing of Dubbo expose service. I think It is 
more reasonable to expose service after Spring ready.

-xiaobo

在 2018年11月1日，上午10:39，Ian Luo mailto:ian@gmail.com>> 写道：

> 当代码修改后，由于 afterPropertiesSet 不再对 delay 进行校验。导致当 delay > 0，且
supportedApplicationListener = true 时，export 会被 onApplicationEvent 调用，而不是
afterPropertiesSet。这会造成服务被延迟到 Spring 容器就绪后的 delay
毫秒暴露，而不是像之前被延迟到afterPropertiesSet 调用 export 后的 delay 毫秒暴露。

I think this behavior is expected. The reason is, the best timing for Dubbo to 
count down delay for exposing service is when Spring container is ready, then 
this timing should be the moment when spring context gets refreshed, since at 
this moment, all beans are settled, and are ready for wiring in their 
dependencies. If it happens earlier, say, at the moment after properties set, 
then Dubbo may fail to expose service because it depends on other spring bean.

To conclude, Dubbo should start to expose services until spring context gets 
refreshed, no matter delay or no-delay is configured. Unfortunately in order to 
keep backward compatibility, considering not all spring versions support 
context refresh callback, we have to start to expose services after properties 
set if we find application listener is not supported, and hope Dubbo service 
can be exposed normally.

I hope this can clarify the behavior.

-Ian.



On Thu, Nov 1, 2018 at 10:03 AM Zonghai Shang 
mailto:y...@apache.org>> wrote:
Hi,

> 我重新看了代码和文档，发现确实存在一个延迟暴露的问题。这里先列举 Dubbo 的延迟暴露策略：
> delay = null 或 delay = -1 ：延迟到 Spring 容器就绪后暴露服务，由 onApplicationEvent 调用
export 暴露服务
> delay > 0 ：延迟指定毫秒后暴露服务，时间从 afterPropertiesSet 调用 export
时算起，此时由 afterPropertiesSet 调用 export暴露服务

> 当代码修改后，由于 afterPropertiesSet 不再对 delay 进行校验。导致当 delay > 0，且
supportedApplicationListener = true 时，export 会被 onApplicationEvent 调用，而不是
afterPropertiesSet。这会造成服务被延迟到 Spring 容器就绪后的 delay
毫秒暴露，而不是像之前被延迟到afterPropertiesSet 调用 export 后的 delay 毫秒暴露。

> 这是我目前所发现的问题，不知道和你说的是不是同一个。

Yes, you are right.

yiji

田 小波 mailto:tianxiaobo@outlook.com>> 
于2018年11月1日周四 上午1:25写道：

> Hi,
>
> 我重新看了代码和文档，发现确实存在一个延迟暴露的问题。这里先列举 Dubbo 的延迟暴露策略：
>
> delay = null 或 delay = -1 ：延迟到 Spring 容器就绪后暴露服务，由 onApplicationEvent 调用
> export 暴露服务
> delay > 0 ：延迟指定毫秒后暴露服务，时间从 afterPropertiesSet 调用 export
> 时算起，此时由 afterPropertiesSet 调用 export 暴露服务
>
> 当代码修改后，由于 afterPropertiesSet 不再对 delay 进行校验。导致当 delay > 0，且
> supportedApplicationListener = true 时，export 会被 onApplicationEvent 调用，而不是
> afterPropertiesSet。这会造成服务被延迟到 Spring 容器就绪后的 delay
> 毫秒暴露，而不是像之前被延迟到afterPropertiesSet 调用 export 后的 delay 毫秒暴露。
>
> 这是我目前所发现的问题，不知道和你说的是不是同一个。
>
> - xiaobo
>
> 在 2018年10月31日，下午10:43，Zonghai Shang mailto:y...@apache.org>> 
> 写道：
>
> Hi,
>
> 我认为这种修改会造成延迟暴露的bug。
> 如果要在容器启动10秒后才进行服务暴露怎么办？
> 原始意图delay= 1表示10秒后执行。
>
> I think this modification will cause a delay in the exposure of the bug.
> What if you want to expose the service 10 seconds after the spring
> container started ?
> The original intention delay = 1 represents execution after 10
> seconds.
>
> public synchronized void export() {
> if (delay != null && delay > 0) {
>// should be delay, eg: 1 seconds
> delayExportExecutor.schedule(new Runnable() {
> @Override
> public void run() {
> doExport();
> }
> }, delay, TimeUnit.MILLISECONDS);
> } else {
>     doExport();
> }
> }
>
> yiji
>
> Ian Luo mailto:ian@gmail.com>> 于2018年10月31日周三 下午5:50写道：
>
>> good good study, day day up. Looking forward to your contribution :)
>>
>> On Wed, Oct 31, 2018 at 4:43 PM 田 小波 
>> mailto:tianxiaobo@outlook.com>> wrote:
>>
>> > Yes, in fact, It is a plan. I'm learning Dubbo code by writing blogs
>> way,
>> > It can make me understand Dubbo code deeply. So, I need to finish my
>> blogs
>> > first before doing other thing.
>> >
>> > 在 2018年10月31日，下午3:11，Ian Luo mailto:ian@gmail.com>> 
>> > 写道：
>> >
>> > sounds like a plan :)
>> >
>> > Thanks,
>> > -Ian.
>> >
>> > On Wed, Oct 31, 2018 at 2:53 PM 田 小波 
>> > mailto:tianxiaobo@outlook.com>>
>> wrote:
>> >
>> >> OK. I will read these articles carefully and think about how to