Re: ConsistentHash LoadBalance中的解释:缺省只对第一个参数进行Hash运算是什么意思?

2019-02-23 Thread LiZhenNet
Hi, jingfeng I feel that the more complex features can be extended by the user, Dubbo only provide the basic functions . 徐靖峰 于2019年2月22日周五 下午8:58写道: > Hi Xiaobo and Jason > > Sorry for that I give an inappropriate example — IP_HASH. My origin > proposal was that maybe the HASH KEY is not only

Re: ConsistentHash LoadBalance中的解释:缺省只对第一个参数进行Hash运算是什么意思?

2019-02-22 Thread 徐靖峰
Hi Xiaobo and Jason Sorry for that I give an inappropriate example — IP_HASH. My origin proposal was that maybe the HASH KEY is not only can be method param. Not a serious problem. > 在 2019年2月22日,下午6:24,Jason Joo 写道: > > Hi, Kitito > > I get your thought. > And the "IP" in our opinion is

Re: ConsistentHash LoadBalance中的解释:缺省只对第一个参数进行Hash运算是什么意思?

2019-02-22 Thread Jason Joo
Hi, Kitito I get your thought. And the "IP" in our opinion is it a kind of addition (ip + parameters) or can be used alone (only ip)? Though IP + parameters may leads to unbalanced load between providers but i think it maybe still make sense according to the concept of ConsistentHash, while

Re: ConsistentHash LoadBalance中的解释:缺省只对第一个参数进行Hash运算是什么意思?

2019-02-21 Thread 田 小波
Hi Kitito: If the user chooses ConsistentHashLoadBalance, indicate the user wants to load balance through the runtime parameters and expects remote calls with the same parameter values to fall on the same server. After the introduction of IP, this load balancing strategy will be disrupted.

Re: ConsistentHash LoadBalance中的解释:缺省只对第一个参数进行Hash运算是什么意思?

2019-02-21 Thread 徐靖峰
Hi, Jason I know that the default logic of ConsistentHash LoadBalance is hashed by parameters, and dubbo provide the configuration to config the hash params to config virtual nodes My opinion is Dubbo can extend the hash key, not only the request method params. IP consistent hash is a

Re: ConsistentHash LoadBalance中的解释:缺省只对第一个参数进行Hash运算是什么意思?

2019-02-21 Thread Jason Joo
hi, moe I think what you mention is like "ip_hash" in NGINX or some other. ConsistentHashLB is hashed by parameters because a same logic will just act the same under the same parameters (which we call it reenterability). Adding other parameters will break it. While DUBBO provides the ability

Re: ConsistentHash LoadBalance中的解释:缺省只对第一个参数进行Hash运算是什么意思?

2019-02-21 Thread 徐靖峰
Hi all I don’t think that ConsistentHashLoadBalancer should only load balance by the method param, maybe more configuration can provide to the user to achieve more type of dynamic hash parameters, such as hash by the requestIp, more request param.

Re: ConsistentHash LoadBalance中的解释:缺省只对第一个参数进行Hash运算是什么意思?

2019-02-18 Thread Ian Luo
+1. I agree with Xiaobo and Jason. -Ian. On Thu, Feb 14, 2019 at 9:29 AM Jason Joo wrote: > +1 > > Methods with no arguments or little possible values of arguments should > not be applied `ConsistentHashLoadBalance`. Or requests can not be smoothly > distributed when nodes change. > > best

Re: ConsistentHash LoadBalance中的解释:缺省只对第一个参数进行Hash运算是什么意思?

2019-02-13 Thread Jason Joo
+1 Methods with no arguments or little possible values of arguments should not be applied `ConsistentHashLoadBalance`. Or requests can not be smoothly distributed when nodes change. best regards, Jason > On Feb 13, 2019, at 22:30, 田 小波 wrote: > > 数

Re: ConsistentHash LoadBalance中的解释:缺省只对第一个参数进行Hash运算是什么意思?

2019-02-13 Thread 田 小波
Hi, 我觉得这并不是一个 bug,ConsistentHashLoadBalance 只根据运行时参数值进行负载均衡。 如果两个接口的参数值相同,那么这两个远程调用会被分配到同一台机器上。当接口方法中 不存在参数时,我们也可认为他们的参数值是相同的,从源码的角度来说,它们都是空串。 因此在运行时,ConsistentHashLoadBalance 会将不存在参数的远程调用分配到同一个机器上。 translate by Google Translator: I don't think this is a bug. ConsistentHashLoadBalance only load

Re: ConsistentHash LoadBalance中的解释:缺省只对第一个参数进行Hash运算是什么意思?

2019-02-13 Thread Xianjun Ke
Good question. And about your last question, I have made some test in my local machine, it seems that there is a bug about the ConsistentHashLoadBalance when the method has no argument, pls refer this issue [1] [1] https://github.com/apache/incubator-dubbo/issues/3468 一直以来 <279377...@qq.com>