Re: Increase the schedule frequency of HeartbeatTask.

2018-10-18 Thread Ian Luo
I am on it. I may have time slot available tomorrow. On Thu, Oct 18, 2018 at 7:25 PM yuhang xiu wrote: > Hi, everyone > > I have already completed this work. Currently pr is here: > https://github.com/apache/incubator-dubbo/pull/2658 > > Anyone willing to review it? > > Ian Luo 于2018年10月16日周二

Re: Increase the schedule frequency of HeartbeatTask.

2018-10-18 Thread jun liu
Great job! I’d like to give it a review once I finished the metadata refactoring part. Best regards, Jun > On Oct 18, 2018, at 7:25 PM, yuhang xiu wrote: > > Hi, everyone > > I have already completed this work. Currently pr is here: > https://github.com/apache/incubator-dubbo/pull/2658 > >

Re: Increase the schedule frequency of HeartbeatTask.

2018-10-18 Thread yuhang xiu
Hi, everyone I have already completed this work. Currently pr is here: https://github.com/apache/incubator-dubbo/pull/2658 Anyone willing to review it? Ian Luo 于2018年10月16日周二 下午2:38写道: > sounds great. > > On Tue, Oct 16, 2018 at 2:20 PM yuhang xiu wrote: > > > Hi, Ian! > > > > Not yet, I am

Re: Increase the schedule frequency of HeartbeatTask.

2018-10-16 Thread Ian Luo
sounds great. On Tue, Oct 16, 2018 at 2:20 PM yuhang xiu wrote: > Hi, Ian! > > Not yet, I am starting this work. When I am done, I will send an email > immediately. > > Ian Luo 于2018年10月16日周二 下午2:15写道: > > > good proposal, we should definitely switch to HashWheelTimer to make the > > timer

Re: Increase the schedule frequency of HeartbeatTask.

2018-10-16 Thread yuhang xiu
Hi, Ian! Not yet, I am starting this work. When I am done, I will send an email immediately. Ian Luo 于2018年10月16日周二 下午2:15写道: > good proposal, we should definitely switch to HashWheelTimer to make the > timer execute in more fair/timely manner. > > Is there any pull request ready for review? >

Re: Increase the schedule frequency of HeartbeatTask.

2018-10-16 Thread Ian Luo
good proposal, we should definitely switch to HashWheelTimer to make the timer execute in more fair/timely manner. Is there any pull request ready for review? Thanks, -Ian. On Thu, Oct 11, 2018 at 10:41 AM yuhang xiu wrote: > Hi, community > > I recently saw an issue[1] from @chickenlj about

Increase the schedule frequency of HeartbeatTask.

2018-10-10 Thread yuhang xiu
Hi, community I recently saw an issue[1] from @chickenlj about the frequency of heartbeat detection. Due to the very low frequency of our heartbeat detection, some idle channels may not send heartbeats in time. I will start working on this issue in the near future, as follows: 1. Use