Re: [discuss] What about splitting the kafka Connector into kafka 0.8 and 0.9?

2018-04-04 Thread vino yang
Hi Chris, I rechecked the old mails between you and me. I misunderstand your message. I thought you will create the annotation. In fact, you have created the annotation. I will do this work soon, hold on. Vino yang. Thanks. 2018-04-04 19:32 GMT+08:00 vino yang : > Hi

Re: [discuss] What about splitting the kafka Connector into kafka 0.8 and 0.9?

2018-04-04 Thread Christofer Dutz
Hi all, reporting back from my easter holidays :-) Today I had to help a customer with getting a POC working that uses PLC4X and Edgent. Unfortunately it seems that in order to use the kafka connector I can only use 0.x versions of Kafka. When connecting to 1.x versions I get stack-overflows

Re: [discuss] What about splitting the kafka Connector into kafka 0.8 and 0.9?

2018-04-04 Thread Christofer Dutz
Hi, so I updated the libs locally, built and re-ran the example with this version and it now worked without any problems. Chris Am 04.04.18, 12:58 schrieb "Christofer Dutz" : Hi all, reporting back from my easter holidays :-) Today I had to

Re: [discuss] What about splitting the kafka Connector into kafka 0.8 and 0.9?

2018-04-04 Thread vino yang
Hi Chris, I have not done this. And I would upgrade it soon. Vino yang Thanks! 2018-04-04 19:23 GMT+08:00 Christofer Dutz : > Hi, > > so I updated the libs locally, built and re-ran the example with this > version and it now worked without any problems. > > Chris > >

Re: [discuss] What about splitting the kafka Connector into kafka 0.8 and 0.9?

2018-04-04 Thread Christofer Dutz
Hi Vino, Yeah ... but I did it without an ASF header ... that's why the build was failing for 23 days ( (I am really ashamed about that) I tried updating the two Kafka dependencies to the 1.1.0 verison (and to Scala 2.12) and that worked without any noticeable problems. Chris Am 04.04.18,

Re: Re: [discuss] What about splitting the kafka Connector into kafka 0.8 and 0.9?

2018-04-04 Thread Vino yang
Hi Chris, Take it easy, I think the compile failure may not affect a lot. I am glad to hear that higher Kafka client can be backward compatible well. Vino yang Thanks. On 2018-04-04 23:21 , Christofer Dutz Wrote: Hi Vino, Yeah ... but I did it without an ASF header ... that's why the build

Re: [discuss] What about splitting the kafka Connector into kafka 0.8 and 0.9?

2018-04-04 Thread Christofer Dutz
G ... I just noticed that my last commit broke the build and no one complained for 23 days ( I Just fixed that (hopefully) ... Chris Am 20.03.18, 10:33 schrieb "Christofer Dutz" : Ok, So I just added a new Annotation type to the Kafka module.