Re: Review Request 38882: FALCON-1495: In instance status list, show all runs for instances when requested by user

2016-01-04 Thread Ajay Yadava
apache.org/r/38882/#comment173243> Use StringUtils.isNotBlank scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java (line 343) <https://reviews.apache.org/r/38882/#comment173245> Please remove todo and raise a JIRA if required. - Ajay Yadava On Dec.

[jira] [Commented] (FALCON-1714) EntityNotRegisteredException when process with no input/output feed is scheduled

2016-01-04 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082330#comment-15082330 ] Ajay Yadava commented on FALCON-1714: - Thanks [~peeyushb], [~sowmyaramesh] & [~bvell

[jira] [Commented] (FALCON-1495) In instance status list, show all runs for instances when requested by user

2016-01-04 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082306#comment-15082306 ] Ajay Yadava commented on FALCON-1495: - [~nperiwal] Added some more review comments. > In insta

[jira] [Commented] (FALCON-1697) Stabilization of scenarios which are based on instances lifecycle

2016-01-04 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081137#comment-15081137 ] Ajay Yadava commented on FALCON-1697: - Committed to master. Commit id: 1e3dcb7 Thanks for your

[jira] [Commented] (FALCON-1697) Stabilization of scenarios which are based on instances lifecycle

2016-01-04 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081135#comment-15081135 ] Ajay Yadava commented on FALCON-1697: - Committed to 0.9 branch. Commit id: d7fa39f > Stabilizat

[jira] [Commented] (FALCON-1697) Stabilization of scenarios which are based on instances lifecycle

2016-01-04 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081146#comment-15081146 ] Ajay Yadava commented on FALCON-1697: - [~pisaychuk] Even though I have committed this can you please

[jira] [Commented] (FALCON-1697) Stabilization of scenarios which are based on instances lifecycle

2016-01-04 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081144#comment-15081144 ] Ajay Yadava commented on FALCON-1697: - Sorry [~pragya.mittal] I was committing this issue and didn't

[jira] [Commented] (FALCON-1584) Falcon allows invalid hadoop queue name for schedulable feed entities

2016-01-04 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082518#comment-15082518 ] Ajay Yadava commented on FALCON-1584: - [~me.venkatr] Is this change not required for Processes also

Re: Review Request 41601: Add CLI option to display captured replication metrics

2016-01-04 Thread Ajay Yadava
cument the relevant relationships and how to query in plain english here. - Ajay Yadava On Dec. 24, 2015, 7:58 a.m., Peeyush Bishnoi wrote: > > --- > This is an automatically ge

[jira] [Commented] (FALCON-1674) Fix the mapping of InstanceState status to workflow Status in InstancesResult

2016-01-04 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082525#comment-15082525 ] Ajay Yadava commented on FALCON-1674: - Thanks [~pallavi.rao]. > Fix the mapping of InstanceSt

[jira] [Commented] (FALCON-1721) Checkstyle module should have falcon-main as parent

2016-01-04 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082512#comment-15082512 ] Ajay Yadava commented on FALCON-1721: - [~shwethags] Can you please put it on Review board

[jira] [Updated] (FALCON-1714) EntityNotRegisteredException when process with no input/output feed is scheduled

2016-01-04 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Yadava updated FALCON-1714: Attachment: FALCON-1714.patch > EntityNotRegisteredException when process with no input/out

Re: Review Request 41747: [FALCON-1698] New tests for ProcessSetupTest, ClusterSetupTest, UI test fixes

2016-01-04 Thread Ajay Yadava
> On Jan. 4, 2016, 10:48 a.m., Ajay Yadava wrote: > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/EntityPage.java, > > line 409 > > <https://reviews.apache.org/r/41747/diff/1/?file=1176922#file1176922line409> > > >

Review Request 41885: EntityNotRegisteredException when process with no input/output feed is scheduled

2016-01-04 Thread Ajay Yadava
/ Testing --- Thanks, Ajay Yadava

Re: Review Request 41885: EntityNotRegisteredException when process with no input/output feed is scheduled

2016-01-04 Thread Ajay Yadava
tomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41885/#review112585 --- On Jan. 4, 2016, 2:47 p.m., Ajay Yadava wrote: > > -

[jira] [Commented] (FALCON-1710) dependency API sets totalResults as 0 by default

2016-01-04 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081447#comment-15081447 ] Ajay Yadava commented on FALCON-1710: - [~Praveen] Although the status has been changed to Patch

[jira] [Commented] (FALCON-1648) Submit cluster entity without temp and working location fails.

2016-01-04 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081487#comment-15081487 ] Ajay Yadava commented on FALCON-1648: - [~bvellanki] As per your previous comment I am assuming

Re: Review Request 41852: Standardization of error handling in falcon Server

2016-01-04 Thread Ajay Yadava
inition" Before uploading the patch you can check for all the checkstyle issues using the following command - mvn clean install -Ptest-patch,hadoop-2 - Ajay Yadava On Jan. 2, 2016, 5:12 p.m., Praveen Adlakha wrote: > > ---

[jira] [Resolved] (FALCON-1648) Submit cluster entity without temp and working location fails.

2016-01-04 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Yadava resolved FALCON-1648. - Resolution: Fixed Fixed as part of FALCON-1648. > Submit cluster entity without t

[jira] [Commented] (FALCON-1566) Add test for SLA monitoring API

2016-01-04 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081496#comment-15081496 ] Ajay Yadava commented on FALCON-1566: - [~pragya.mittal] There are some comments on review board

[jira] [Commented] (FALCON-1712) Falcon operations not happening if entity name is longer than 255 characters.

2015-12-31 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15075894#comment-15075894 ] Ajay Yadava commented on FALCON-1712: - Great! Thanks for volunteering, will add you

[jira] [Assigned] (FALCON-1714) EntityNotRegisteredException when process with no input/output feed is scheduled

2015-12-31 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Yadava reassigned FALCON-1714: --- Assignee: Ajay Yadava > EntityNotRegisteredException when process with no input/output f

[jira] [Updated] (FALCON-1712) Falcon operations not happening if entity name is longer than 255 characters.

2015-12-31 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Yadava updated FALCON-1712: Assignee: Deepak Barr > Falcon operations not happening if entity name is longer than

[jira] [Commented] (FALCON-1712) Falcon operations not happening if entity name is longer than 255 characters.

2015-12-31 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15075895#comment-15075895 ] Ajay Yadava commented on FALCON-1712: - Done. Welcome to Apache Falcon! > Falcon operati

[jira] [Commented] (FALCON-1701) HiveDr, ClusterSetupTest, MirrorSummaryTest fixes provided by Murali Ramasami

2015-12-29 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074152#comment-15074152 ] Ajay Yadava commented on FALCON-1701: - Welcome to Falcon [~murali.msse] and thanks for providing

[jira] [Commented] (FALCON-1700) Add new test cases to HiveDr. Provided by Paul Isaychuk and Murali Ramasami.

2015-12-29 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074164#comment-15074164 ] Ajay Yadava commented on FALCON-1700: - Sure [~pisaychuk]. Will mention both names in the commit

[jira] [Commented] (FALCON-1701) HiveDr, ClusterSetupTest, MirrorSummaryTest fixes provided by Murali Ramasami

2015-12-29 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074150#comment-15074150 ] Ajay Yadava commented on FALCON-1701: - Thanks [~pisaychuk] I have added [~murali.msse

[jira] [Updated] (FALCON-1701) HiveDr, ClusterSetupTest, MirrorSummaryTest fixes provided by Murali Ramasami

2015-12-29 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Yadava updated FALCON-1701: Assignee: Murali Ramasami (was: Paul Isaychuk) > HiveDr, ClusterSetupTest, MirrorSummaryT

[jira] [Updated] (FALCON-1700) Add new test cases to HiveDRTest

2015-12-29 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Yadava updated FALCON-1700: Summary: Add new test cases to HiveDRTest (was: Add new test cases to HiveDr. Provided by Paul

[jira] [Commented] (FALCON-1700) Add new test cases to HiveDRTest

2015-12-29 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074166#comment-15074166 ] Ajay Yadava commented on FALCON-1700: - +1. Will commit shortly. > Add new test cases to HiveDRT

[jira] [Commented] (FALCON-1704) Standardization of error handling in falcon Client

2015-12-29 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074210#comment-15074210 ] Ajay Yadava commented on FALCON-1704: - Currently there is no standard way for server to send error

[jira] [Commented] (FALCON-1565) Listing API non-intuitive response if time > endTime

2015-12-29 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074215#comment-15074215 ] Ajay Yadava commented on FALCON-1565: - (y) > Listing API non-intuitive response if time > e

[jira] [Updated] (FALCON-1705) Standardization of error handling in falcon Server

2015-12-29 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Yadava updated FALCON-1705: Issue Type: Sub-task (was: Bug) Parent: FALCON-1706 > Standardization of error handl

[jira] [Created] (FALCON-1706) Robust Error Handling for REST API & Client

2015-12-29 Thread Ajay Yadava (JIRA)
Ajay Yadava created FALCON-1706: --- Summary: Robust Error Handling for REST API & Client Key: FALCON-1706 URL: https://issues.apache.org/jira/browse/FALCON-1706 Project: Falcon Issue

Re: Review Request 41749: [FALCON-1701] HiveDr, ClusterSetupTest, MirrorSummaryTest fixes provided by Murali Ramasami

2015-12-29 Thread Ajay Yadava
e tracking system. Can you please refer Apache JIRA instead or edit the comment? falcon-regression/merlin/src/test/resources/HdfsRecipe/hive-disaster-recovery-template.xml (line 42) <https://reviews.apache.org/r/41749/#comment172542> Is the notification functionality tested somewhere in

[jira] [Commented] (FALCON-1702) Exception thrown by workflow status listeners on success notification

2015-12-29 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074256#comment-15074256 ] Ajay Yadava commented on FALCON-1702: - +1. Will commit shortly. > Exception thrown by workf

[jira] [Updated] (FALCON-1565) Listing API non-intuitive response if time > endTime

2015-12-29 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Yadava updated FALCON-1565: Attachment: FALCON-1565-v4.patch There were some checkstyle issues which I fixed while committing

[jira] [Updated] (FALCON-1701) HiveDr, ClusterSetupTest, MirrorSummaryTest fixes

2015-12-29 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Yadava updated FALCON-1701: Summary: HiveDr, ClusterSetupTest, MirrorSummaryTest fixes (was: HiveDr, ClusterSetupTest

[jira] [Created] (FALCON-1707) Code Refactoring for Falcon Client

2015-12-29 Thread Ajay Yadava (JIRA)
Ajay Yadava created FALCON-1707: --- Summary: Code Refactoring for Falcon Client Key: FALCON-1707 URL: https://issues.apache.org/jira/browse/FALCON-1707 Project: Falcon Issue Type: Sub-task

[jira] [Updated] (FALCON-1704) Standardization of error handling in falcon Client

2015-12-29 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Yadava updated FALCON-1704: Issue Type: Sub-task (was: Bug) Parent: FALCON-1706 > Standardization of error handl

Re: Review Request 41587: Listing API non-intuitive response if time > endTime

2015-12-29 Thread Ajay Yadava
method. I believe you introduced this in > > order to supply FeedInstanceResult to appropriate methods. > > > > It would be better to refactor the code to supply the appropriate class > > in order methods too. > > Ajay Yadava wrote: > I had an offline discussion wi

Re: Review Request 41587: Listing API non-intuitive response if time > endTime

2015-12-29 Thread Ajay Yadava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41587/#review112211 --- Ship it! Ship It! - Ajay Yadava On Dec. 29, 2015, 3:36 p.m

Re: Review Request 41767: FALCON-1702 Exception thrown by workflow status listeners on success notification

2015-12-29 Thread Ajay Yadava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41767/#review112216 --- Ship it! Ship It! - Ajay Yadava On Dec. 29, 2015, 9:12 a.m

[jira] [Assigned] (FALCON-1707) Code Refactoring for Falcon Client

2015-12-29 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Yadava reassigned FALCON-1707: --- Assignee: Ajay Yadava > Code Refactoring for Falcon Cli

[jira] [Commented] (FALCON-1706) Robust Error Handling for REST API & Client

2015-12-29 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074214#comment-15074214 ] Ajay Yadava commented on FALCON-1706: - Currently there is no standard way for server to send error

[jira] [Commented] (FALCON-1696) Falcon build failing in checkstyle module

2015-12-29 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073642#comment-15073642 ] Ajay Yadava commented on FALCON-1696: - Looks like we were typing at the same time. Please go ahead

[jira] [Commented] (FALCON-1687) Creating archetype for falcon pipelines

2015-12-29 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073647#comment-15073647 ] Ajay Yadava commented on FALCON-1687: - I think the purpose of this JIRA is not very clear

Re: Review Request 41587: Listing API non-intuitive response if time > endTime

2015-12-29 Thread Ajay Yadava
method. I believe you introduced this in > > order to supply FeedInstanceResult to appropriate methods. > > > > It would be better to refactor the code to supply the appropriate class > > in order methods too. > > Ajay Yadava wrote: > I had an offline discussion wi

Re: Review Request 41587: Listing API non-intuitive response if time > endTime

2015-12-29 Thread Ajay Yadava
method. I believe you introduced this in > > order to supply FeedInstanceResult to appropriate methods. > > > > It would be better to refactor the code to supply the appropriate class > > in order methods too. > > Ajay Yadava wrote: > I had an offline discussion wi

Re: Review Request 41587: Listing API non-intuitive response if time > endTime

2015-12-29 Thread Ajay Yadava
- Ajay --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41587/#review111437 --- On Dec. 28, 2015, 2:07 p.m., Praveen Adlakha wrote: > >

[jira] [Commented] (FALCON-1696) Falcon build failing in checkstyle module

2015-12-29 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073635#comment-15073635 ] Ajay Yadava commented on FALCON-1696: - +1 to unblock the local builds immediately. > Falcon bu

Re: Review Request 41766: Falcon build failing in checkstyle module

2015-12-29 Thread Ajay Yadava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41766/#review112135 --- Ship it! Ship It! - Ajay Yadava On Dec. 29, 2015, 7:04 a.m

[jira] [Commented] (FALCON-1696) Falcon build failing in checkstyle module

2015-12-29 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073640#comment-15073640 ] Ajay Yadava commented on FALCON-1696: - Will commit it shortly as many developers are facing issue

[jira] [Commented] (FALCON-1703) Falcon docs module not generating html files

2015-12-29 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073855#comment-15073855 ] Ajay Yadava commented on FALCON-1703: - +1. Will commit shortly. > Falcon docs module not generat

[jira] [Comment Edited] (FALCON-1601) Make Falcon StateStore more secure by not disclosing imp params in startup.props

2015-12-28 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072720#comment-15072720 ] Ajay Yadava edited comment on FALCON-1601 at 12/28/15 1:30 PM: --- Since

[jira] [Commented] (FALCON-1601) Make Falcon StateStore more secure by not disclosing imp params in startup.props

2015-12-28 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072720#comment-15072720 ] Ajay Yadava commented on FALCON-1601: - Since storing credentials in plain text is a security risk

[jira] [Commented] (FALCON-1694) Status API shows params along with instance status

2015-12-28 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072696#comment-15072696 ] Ajay Yadava commented on FALCON-1694: - +1. Will commit shortly > Status API shows params al

[jira] [Commented] (FALCON-1695) Bunch of test fixes for falcon-regression

2015-12-28 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073483#comment-15073483 ] Ajay Yadava commented on FALCON-1695: - Thanks [~pisaychuk], really appreciate it! > Bunch of t

[jira] [Commented] (FALCON-1670) Testing of the xml files from example folder in distributed mode

2015-12-28 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073498#comment-15073498 ] Ajay Yadava commented on FALCON-1670: - While we are on the topic of examples I think one more thing

[jira] [Commented] (FALCON-1565) Listing API non-intuitive response if time > endTime

2015-12-28 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073514#comment-15073514 ] Ajay Yadava commented on FALCON-1565: - Can you please paste the output(only output) in case

[jira] [Comment Edited] (FALCON-1700) Add new test cases to HiveDr. Provided by Paul Isaychuk and Murali Ramasami.

2015-12-28 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073487#comment-15073487 ] Ajay Yadava edited comment on FALCON-1700 at 12/29/15 4:59 AM: --- Hi

[jira] [Commented] (FALCON-1700) Add new test cases to HiveDr. Provided by Paul Isaychuk and Murali Ramasami.

2015-12-28 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073487#comment-15073487 ] Ajay Yadava commented on FALCON-1700: - Hi [~pisaychuk] Should this be assigned to Murali Ramasami. I

[jira] [Issue Comment Deleted] (FALCON-1565) Listing API non-intuitive response if time > endTime

2015-12-28 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Yadava updated FALCON-1565: Comment: was deleted (was: The error messages look good now. ) > Listing API non-intuit

Re: Review Request 41587: Listing API non-intuitive response if time > endTime

2015-12-28 Thread Ajay Yadava
> On Dec. 21, 2015, 5:06 a.m., Pallavi Rao wrote: > > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 949 > > > > > > Let us not introduce a new method. I believe you introduced this in > >

[jira] [Commented] (FALCON-1565) Listing API non-intuitive response if time > endTime

2015-12-28 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073510#comment-15073510 ] Ajay Yadava commented on FALCON-1565: - The error messages look good now. > Listing API non-intuit

[jira] [Commented] (FALCON-1565) Listing API non-intuitive response if time > endTime

2015-12-28 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073509#comment-15073509 ] Ajay Yadava commented on FALCON-1565: - The error messages look good now. > Listing API

[jira] [Commented] (FALCON-1701) HiveDr, ClusterSetupTest, MirrorSummaryTest fixes provided by Murali Ramasami

2015-12-28 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073488#comment-15073488 ] Ajay Yadava commented on FALCON-1701: - Hi [~pisaychuk] Should this be assigned to Murali Ramasami? I

[jira] [Commented] (FALCON-1670) Testing of the xml files from example folder in distributed mode

2015-12-28 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073496#comment-15073496 ] Ajay Yadava commented on FALCON-1670: - If the same entity xmls work for both distributed and embedded

Re: Review Request 41587: Listing API non-intuitive response if time > endTime

2015-12-28 Thread Ajay Yadava
comments? - Ajay Yadava On Dec. 28, 2015, 2:07 p.m., Praveen Adlakha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

[jira] [Commented] (FALCON-1565) Listing API non-intuitive response if time > endTime

2015-12-28 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073518#comment-15073518 ] Ajay Yadava commented on FALCON-1565: - I think the approach requires a little bit of description. I

[jira] [Commented] (FALCON-1695) New tests, test fixes and improvements provided by Paul Isaychuk and Murali Ramasami

2015-12-24 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071380#comment-15071380 ] Ajay Yadava commented on FALCON-1695: - Hi [~pisaychuk], It seems like several patches have been

Re: Review Request 41545: Cascading delete in case of Native Scheduler

2015-12-24 Thread Ajay Yadava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41545/#review111856 --- Ship it! Ship It! - Ajay Yadava On Dec. 24, 2015, 12:03 p.m

[jira] [Commented] (FALCON-1640) Cascading Delete for instances in Native Scheduler

2015-12-24 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070943#comment-15070943 ] Ajay Yadava commented on FALCON-1640: - +1. Will commit shortly. > Cascading Delete for instan

[jira] [Commented] (FALCON-1601) Make Falcon StateStore more secure by not disclosing imp params in startup.props

2015-12-23 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069430#comment-15069430 ] Ajay Yadava commented on FALCON-1601: - Thanks for the patch [~pavan kumar] I have left some comments

Re: Review Request 41605: Make statestore credentials more secure and separate out statestore properties

2015-12-23 Thread Ajay Yadava
tps://reviews.apache.org/r/41605/#comment172025> Shouldn't this be 600 so that users can actually update the credentials also? This is what is followed by postgres as well. http://www.postgresql.org/docs/8.1/static/libpq-pgpass.html - Ajay Yadava On Dec. 21, 2015, 12:58 p.m.,

[jira] [Commented] (FALCON-1601) Make Falcon StateStore more secure by not disclosing imp params in startup.props

2015-12-23 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069439#comment-15069439 ] Ajay Yadava commented on FALCON-1601: - Just to record my opinion explicitly, I am slightly inclined

Re: Review Request 41545: Cascading delete in case of Native Scheduler

2015-12-23 Thread Ajay Yadava
(line 398) <https://reviews.apache.org/r/41545/#comment172036> nit: order is actual first, expected second. Otherwise it will give confusing error message in case of failures. - Ajay Yadava On Dec. 18, 2015, 1 p.m., pavan kumar ko

Re: Review Request 41545: Cascading delete in case of Native Scheduler

2015-12-23 Thread Ajay Yadava
will be deleted, why it is required etc. in deleteEntity method of state store interface. This will be extremely helpful for others to understand the code and it's expected behaviour. - Ajay Yadava On Dec. 18, 2015, 1 p.m., pavan kumar kolamuri wrote

[jira] [Commented] (FALCON-1640) Cascading Delete for instances in Native Scheduler

2015-12-23 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069449#comment-15069449 ] Ajay Yadava commented on FALCON-1640: - Ideally I would prefer that the database maintains the entire

[jira] [Commented] (FALCON-1640) Cascading Delete for instances in Native Scheduler

2015-12-23 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069473#comment-15069473 ] Ajay Yadava commented on FALCON-1640: - Thanks for clarifying [~pallavi.rao], I also suspected same

[jira] [Commented] (FALCON-1686) Support for reprocessing

2015-12-23 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069538#comment-15069538 ] Ajay Yadava commented on FALCON-1686: - I think this is the use case which I was talking about. You

[jira] [Comment Edited] (FALCON-1686) Support for reprocessing

2015-12-23 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069538#comment-15069538 ] Ajay Yadava edited comment on FALCON-1686 at 12/23/15 11:45 AM

Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting added for Falcon instance vertex in GraphDB

2015-12-23 Thread Ajay Yadava
then it's fine but it will be helpful to call out the change explicitly so that users are aware. Peeyush wants to try some more approaches, will get back on this after that. - Ajay Yadava On Dec. 18, 2015, 6:48 a.m., Peeyush Bishnoi wrote

Re: Review Request 41605: Make statestore credentials more secure and separate out statestore properties

2015-12-23 Thread Ajay Yadava
here or making default to MySQL? My hypothesis behind this suggestion is that InMemoryStateStore is useful only in development/testing scenarios but in production scenarios this may cause issues. - Ajay Yadava

[jira] [Commented] (FALCON-1686) Support for reprocessing

2015-12-22 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15068646#comment-15068646 ] Ajay Yadava commented on FALCON-1686: - {quote} in order to *reprocess* data after a code change

[jira] [Commented] (FALCON-1683) Inconsistent behavior when user tries to switch schedulers

2015-12-22 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069110#comment-15069110 ] Ajay Yadava commented on FALCON-1683: - +1. Will commit shortly. > Inconsistent behavior when u

[jira] [Updated] (FALCON-1681) Improve logging for idempotent behaviour while scheduling entities.

2015-12-22 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Yadava updated FALCON-1681: Attachment: FALCON-1681-v1.patch Patch after addressing the nit. > Improve logging for idempot

Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting added for Falcon instance vertex in GraphDB

2015-12-22 Thread Ajay Yadava
> On Dec. 21, 2015, 10:26 a.m., Ajay Yadava wrote: > > It seems that you are changing the same column to now contain nominal time, > > won't that be a backward incompatible change? I was thinking more on lines > > of adding nominal time also rather than changing t

[jira] [Commented] (FALCON-991) consolidate get coord actions in OozieWorkflowEngine

2015-12-22 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069111#comment-15069111 ] Ajay Yadava commented on FALCON-991: [~pavan kumar] This was pending on me, I had some discussions

[jira] [Commented] (FALCON-1680) Error message is not intuitive when entity schedule fails

2015-12-22 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069108#comment-15069108 ] Ajay Yadava commented on FALCON-1680: - +1. Will commit shortly. > Error message is not intuit

[jira] [Commented] (FALCON-1681) Improve logging for idempotent behaviour while scheduling entities.

2015-12-22 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069117#comment-15069117 ] Ajay Yadava commented on FALCON-1681: - +1. Will commit shortly. > Improve logging for idempot

[jira] [Commented] (FALCON-1681) Improve logging for idempotent behaviour while scheduling entities.

2015-12-22 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069118#comment-15069118 ] Ajay Yadava commented on FALCON-1681: - I will address the nit pointed by [~sandeep.samudrala], while

[jira] [Commented] (FALCON-1686) Support for reprocessing

2015-12-21 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067508#comment-15067508 ] Ajay Yadava commented on FALCON-1686: - This is a genuine issue and we have also experienced the need

[jira] [Commented] (FALCON-1565) Listing API non-intuitive response if time > endTime

2015-12-20 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15066090#comment-15066090 ] Ajay Yadava commented on FALCON-1565: - [~Praveen] The command that you have used for status

[jira] [Updated] (FALCON-1636) Add Rerun API In Falcon Native Scheduler

2015-12-18 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Yadava updated FALCON-1636: Fix Version/s: 0.9 > Add Rerun API In Falcon Native Schedu

[jira] [Commented] (FALCON-1636) Add Rerun API In Falcon Native Scheduler

2015-12-18 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063744#comment-15063744 ] Ajay Yadava commented on FALCON-1636: - Will commit this right away to unblock testing for native

[jira] [Updated] (FALCON-1636) Add Rerun API In Falcon Native Scheduler

2015-12-18 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Yadava updated FALCON-1636: Attachment: FALCON-1636-v5.patch Last patch was based on the patch command. Attaching the git

[jira] [Commented] (FALCON-1674) Fix the mapping of InstanceState status to workflow Status in InstancesResult

2015-12-18 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063737#comment-15063737 ] Ajay Yadava commented on FALCON-1674: - Since there are some differences, we should also document all

[jira] [Commented] (FALCON-1636) Add Rerun API In Falcon Native Scheduler

2015-12-18 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063743#comment-15063743 ] Ajay Yadava commented on FALCON-1636: - +1. FALCON-1674 has been added to address the remaining nits

Re: Review Request 41401: Rerun API for Falcon Native Scheduler

2015-12-18 Thread Ajay Yadava
> On Dec. 18, 2015, 8:01 a.m., Ajay Yadava wrote: > > After an offline discussion with @pavan kumar kolamuri, here are some key > > points which I am not sure are the best way to do it. > > > > 1. A new WorkflowStatus has been added, since we are changing only

<    1   2   3   4   5   6   7   8   9   10   >