I downloaded the entire Felix code base for this commit. I then attempted
to build iPojo with "mvn clean install" and got the following error:
[ERROR] Failed to execute goal
org.codehaus.mojo:ianal-maven-plugin:1.0-alpha-1:verify-legal-files
(default) on project org.apache.felix.ipojo.metadata:
Hi all
First as you can see in PR there were only made changes in manipulator
project.
Proposed changes allow to use maven-ipojo-plugin when building modules with
jdk11+.
Besides after latest changes the same version now works on jdk8 and jdk11+
with no problems.
Speaking to me all what i was
[
https://issues.apache.org/jira/browse/FELIX-6511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Rankin updated FELIX-6511:
External issue URL: https://github.com/apache/felix-dev/pull/131
> Felix SCR ComponentRegistry
Chris Rankin created FELIX-6511:
---
Summary: Felix SCR ComponentRegistry leaves Timer thread running
on deactivation.
Key: FELIX-6511
URL: https://issues.apache.org/jira/browse/FELIX-6511
Project: Felix
Thanks Alexander - I'll try that.
It turned out that my initial problem was that I was using OpenJDK 17 for
the build. When I changed to JDK 8 that error disappeared. But I still
can't get through the whole iPojo build because of the tests. I suspect
that the tests are made for Linux and I'm on
[
https://issues.apache.org/jira/browse/FELIX-6511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Rankin updated FELIX-6511:
Description:
Shutting down the SCR does not cancel the {{changeCountTimer}} thread running
inside
[
https://issues.apache.org/jira/browse/FELIX-6511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Rankin updated FELIX-6511:
Description:
Shutting down the SCR does not cancel the {{changeCountTimer}} thread running
inside
I am on Windows - hope it is possible to build iPojo on Windows.
/Bengt
Den fre 11 mars 2022 kl 10:19 skrev Bengt Rodehav :
> I downloaded the entire Felix code base for this commit. I then attempted
> to build iPojo with "mvn clean install" and got the following error:
>
> [ERROR] Failed to
chrisr3 opened a new pull request #131:
URL: https://github.com/apache/felix-dev/pull/131
Cancel the `changeCountTimer`. Also name its thread "SCR Component Registry"
rather than leaving it as "Timer-0".
--
This is an automated message from the Apache Git Service.
To respond to the
Ok. I see looks like a problem when using jdk higher than 11 when building.
Btw building with openJdk11 - is working
I'll chek this problem later.
сб, 12 мар. 2022 г. в 00:16, Bengt Rodehav :
> OK - I managed to build the important parts. However, using OpenJDK 17, I
> get the following build
tjwatson commented on a change in pull request #131:
URL: https://github.com/apache/felix-dev/pull/131#discussion_r824782058
##
File path: scr/src/main/java/org/apache/felix/scr/impl/ComponentRegistry.java
##
@@ -732,7 +732,7 @@ public void updateChangeCount()
OK - I managed to build the important parts. However, using OpenJDK 17, I
get the following build error:
[ERROR] Failed to execute goal
org.apache.felix:maven-ipojo-plugin:1.12.2-SNAPSHOT:ipojo-bundle (default)
on project filetransfer-service: Execution default of goal
tjwatson merged pull request #131:
URL: https://github.com/apache/felix-dev/pull/131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chrisr3 commented on a change in pull request #131:
URL: https://github.com/apache/felix-dev/pull/131#discussion_r824754243
##
File path: scr/src/main/java/org/apache/felix/scr/impl/ComponentRegistry.java
##
@@ -732,7 +732,7 @@ public void updateChangeCount()
tjwatson commented on a change in pull request #131:
URL: https://github.com/apache/felix-dev/pull/131#discussion_r824905612
##
File path: scr/src/main/java/org/apache/felix/scr/impl/ComponentRegistry.java
##
@@ -774,4 +774,11 @@ public void run()
}
}
I think yeah. But there were changes not only in adm version, there were
changes wich caused class manipulations to satisfy compiler requirements.
If nothing will change there in future, then asm version upgrade will be
enough i think.
пт, 11 мар. 2022 г., 19:03 Bengt Rodehav :
> That was quick!
laeubi commented on a change in pull request #131:
URL: https://github.com/apache/felix-dev/pull/131#discussion_r824893610
##
File path: scr/src/main/java/org/apache/felix/scr/impl/ComponentRegistry.java
##
@@ -774,4 +774,11 @@ public void run()
}
}
I have updated PR branch - increased asm - version for manipulator.
I have tested build on OpenJDK 17 - it was successful.
Have a try to test it.
Regards, Alexander
сб, 12 мар. 2022 г. в 00:35, Bengt Rodehav :
> OK - thanks. Please let me know when you have something you'd like me to
> test.
>
That was quick!
I tried it and it works. I guess asm 9.2.0 supports up to and including JDK
18 - right? So in the future, just to keep iPojo compatible with new
versions of Java, will it suffice to just update the version of asm?
/Bengt
Den fre 11 mars 2022 kl 16:27 skrev Александр Шаклеин :
>
[
https://issues.apache.org/jira/browse/FELIX-6511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tom Watson updated FELIX-6511:
--
Fix Version/s: scr-2.2.2
> Felix SCR ComponentRegistry leaves Timer thread running on deactivation.
>
tjwatson commented on a change in pull request #131:
URL: https://github.com/apache/felix-dev/pull/131#discussion_r824723254
##
File path: scr/src/main/java/org/apache/felix/scr/impl/ComponentRegistry.java
##
@@ -732,7 +732,7 @@ public void updateChangeCount()
chrisr3 commented on a change in pull request #131:
URL: https://github.com/apache/felix-dev/pull/131#discussion_r824754243
##
File path: scr/src/main/java/org/apache/felix/scr/impl/ComponentRegistry.java
##
@@ -732,7 +732,7 @@ public void updateChangeCount()
OK - thanks. Please let me know when you have something you'd like me to
test.
/Bengt
Den fre 11 mars 2022 kl 15:32 skrev Александр Шаклеин :
> Ok. I see looks like a problem when using jdk higher than 11 when building.
> Btw building with openJdk11 - is working
> I'll chek this problem later.
chrisr3 commented on a change in pull request #131:
URL: https://github.com/apache/felix-dev/pull/131#discussion_r824768423
##
File path: scr/src/main/java/org/apache/felix/scr/impl/ComponentRegistry.java
##
@@ -732,7 +732,7 @@ public void updateChangeCount()
Great! Will anyone include this in a new iPojo release soon?
/Bengt
Den fre 11 mars 2022 kl 17:11 skrev Александр Шаклеин :
> I think yeah. But there were changes not only in adm version, there were
> changes wich caused class manipulations to satisfy compiler requirements.
> If nothing will
[
https://issues.apache.org/jira/browse/FELIX-6511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tom Watson resolved FELIX-6511.
---
Assignee: Tom Watson
Resolution: Fixed
> Felix SCR ComponentRegistry leaves Timer thread
26 matches
Mail list logo
