[GitHub] [felix-dev] amitjoy opened a new pull request, #192: Imported OSGi HTTP Package Optionally

2023-01-26 Thread via GitHub
amitjoy opened a new pull request, #192: URL: https://github.com/apache/felix-dev/pull/192 fixes [FELIX-6565](https://issues.apache.org/jira/browse/FELIX-6565) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [felix-dev] amitjoy commented on pull request #192: Updated to use HTTP optionally in HealthCheck

2023-01-27 Thread via GitHub
amitjoy commented on PR #192: URL: https://github.com/apache/felix-dev/pull/192#issuecomment-1406520354 I just added a new commit to update to HTTP whiteboard. There was no runtime issue to use the old pattern of using `HttpService` to register the servlets, but dependency to `HttpService`

[GitHub] [felix-dev] amitjoy commented on pull request #192: Updated to use HTTP optionally in HealthCheck

2023-01-27 Thread via GitHub
amitjoy commented on PR #192: URL: https://github.com/apache/felix-dev/pull/192#issuecomment-1406536455 @ghenzler @cziegeler Could you kindly have a look at it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [felix-dev] amitjoy commented on pull request #192: Updated to use HTTP optionally in HealthCheck

2023-01-27 Thread via GitHub
amitjoy commented on PR #192: URL: https://github.com/apache/felix-dev/pull/192#issuecomment-1406537927 @jbonofre Thanks a lot for assigning yourself for the review 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [felix-dev] JochenHiller commented on a diff in pull request #192: Updated to use HTTP optionally in HealthCheck

2023-01-27 Thread via GitHub
JochenHiller commented on code in PR #192: URL: https://github.com/apache/felix-dev/pull/192#discussion_r1089011866 ## healthcheck/core/src/main/java/org/apache/felix/hc/core/impl/servlet/HealthCheckExecutorServlet.java: ## @@ -162,7 +164,10 @@ void setDescription(String d) {

[GitHub] [felix-dev] amitjoy commented on a diff in pull request #192: Updated to use HTTP optionally in HealthCheck

2023-01-27 Thread via GitHub
amitjoy commented on code in PR #192: URL: https://github.com/apache/felix-dev/pull/192#discussion_r1089029567 ## healthcheck/core/src/main/java/org/apache/felix/hc/core/impl/servlet/HealthCheckExecutorServlet.java: ## @@ -162,7 +164,10 @@ void setDescription(String d) { Re

[GitHub] [felix-dev] amitjoy commented on a diff in pull request #192: Updated to use HTTP optionally in HealthCheck

2023-01-27 Thread via GitHub
amitjoy commented on code in PR #192: URL: https://github.com/apache/felix-dev/pull/192#discussion_r1089029908 ## healthcheck/core/src/main/java/org/apache/felix/hc/core/impl/servlet/HealthCheckExecutorServlet.java: ## @@ -215,29 +219,24 @@ protected final void activate(final H

[GitHub] [felix-dev] amitjoy commented on a diff in pull request #192: Updated to use HTTP optionally in HealthCheck

2023-01-27 Thread via GitHub
amitjoy commented on code in PR #192: URL: https://github.com/apache/felix-dev/pull/192#discussion_r1089030958 ## healthcheck/core/src/main/java/org/apache/felix/hc/core/impl/servlet/HealthCheckExecutorServlet.java: ## @@ -215,29 +219,24 @@ protected final void activate(final H

[GitHub] [felix-dev] JochenHiller commented on pull request #192: Updated to use HTTP optionally in HealthCheck

2023-01-27 Thread via GitHub
JochenHiller commented on PR #192: URL: https://github.com/apache/felix-dev/pull/192#issuecomment-1406626705 Latest changes from @amitjoy LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [felix-dev] pkriens commented on pull request #190: Fixed use case when bundle start level will be set within an bundle activator, test case FrameworkStartLevelImplTest

2023-01-31 Thread via GitHub
pkriens commented on PR #190: URL: https://github.com/apache/felix-dev/pull/190#issuecomment-1410498843 @tjwatson @karlpauls @cziegeler Would it be possible to take this PR? The log error message is not warranted here imho. In very large system, when this happens, it creates an avalan

[GitHub] [felix-dev] tjwatson commented on pull request #190: Fixed use case when bundle start level will be set within an bundle activator, test case FrameworkStartLevelImplTest

2023-01-31 Thread via GitHub
tjwatson commented on PR #190: URL: https://github.com/apache/felix-dev/pull/190#issuecomment-1410617396 @karlpauls or @cziegeler should review the framework code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [felix-dev] pkriens commented on pull request #190: Fixed use case when bundle start level will be set within an bundle activator, test case FrameworkStartLevelImplTest

2023-02-01 Thread via GitHub
pkriens commented on PR #190: URL: https://github.com/apache/felix-dev/pull/190#issuecomment-1411873681 > @karlpauls or @cziegeler should review the framework code. Any idea how to motivate them? :-) I could offer a beer but my (beloved) travel restrictions keep me out of their hoods

[GitHub] [felix-dev] cziegeler commented on pull request #190: Fixed use case when bundle start level will be set within an bundle activator, test case FrameworkStartLevelImplTest

2023-02-01 Thread via GitHub
cziegeler commented on PR #190: URL: https://github.com/apache/felix-dev/pull/190#issuecomment-1411981213 I'll try to stay away from touching the framework code and leave it up to @karlpauls . I'm sure he'll have a look as soon as he has time -- This is an automated message from the Apach

[GitHub] [felix-dev] glimmerveen commented on pull request #194: Update Felix Log to latest org.osgi.service.log version (FELIX-6593)

2023-02-13 Thread via GitHub
glimmerveen commented on PR #194: URL: https://github.com/apache/felix-dev/pull/194#issuecomment-1428712663 I ran into an issue when updating a project's dependency to osgi.core to 8.0.0, that also used LogService. It appears that when org.osgi.service.log was moved from Compendium to Core

[GitHub] [felix-dev] amitjoy commented on pull request #192: Updated to use HTTP optionally in HealthCheck

2023-02-17 Thread via GitHub
amitjoy commented on PR #192: URL: https://github.com/apache/felix-dev/pull/192#issuecomment-1434437223 @jbonofre if you have time, could you kindly have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [felix-dev] glimmerveen commented on pull request #194: Update Felix Log to latest org.osgi.service.log version (FELIX-6593)

2023-02-20 Thread via GitHub
glimmerveen commented on PR #194: URL: https://github.com/apache/felix-dev/pull/194#issuecomment-1437519756 @rotty3000 , I saw in the git history you incorporated a change related to OSGi Log version 1.5. Could you have a look at this PR, as I think this is needed to support at runtime code

[GitHub] [felix-dev] rotty3000 merged pull request #194: Update Felix Log to latest org.osgi.service.log version (FELIX-6593)

2023-02-21 Thread via GitHub
rotty3000 merged PR #194: URL: https://github.com/apache/felix-dev/pull/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] glimmerveen commented on pull request #194: Update Felix Log to latest org.osgi.service.log version (FELIX-6593)

2023-02-21 Thread via GitHub
glimmerveen commented on PR #194: URL: https://github.com/apache/felix-dev/pull/194#issuecomment-1438719692 Thank you Raymond for looking into this PR and merging it! Assuming there is no other work pending for this module, would it be possible to cut a 1.3.0 release of log?

[GitHub] [felix-dev] amitjoy commented on pull request #192: Updated to use HTTP optionally in HealthCheck

2023-02-27 Thread via GitHub
amitjoy commented on PR #192: URL: https://github.com/apache/felix-dev/pull/192#issuecomment-1445963609 @jbonofre Could you kindly have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [felix-dev] cziegeler merged pull request #191: Bump snakeyaml from 1.26 to 1.32 in /converter/serializer

2023-03-01 Thread via GitHub
cziegeler merged PR #191: URL: https://github.com/apache/felix-dev/pull/191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] cziegeler merged pull request #189: Bump junit from 4.13 to 4.13.1 in /eventadmin/impl

2023-03-01 Thread via GitHub
cziegeler merged PR #189: URL: https://github.com/apache/felix-dev/pull/189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] cziegeler merged pull request #188: Bump junit from 4.13 to 4.13.1 in /configadmin-plugins/interpolation

2023-03-01 Thread via GitHub
cziegeler merged PR #188: URL: https://github.com/apache/felix-dev/pull/188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] dependabot[bot] opened a new pull request, #196: Bump junit from 4.12 to 4.13.1 in /systemready

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #196: URL: https://github.com/apache/felix-dev/pull/196 Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases";>junit's releases. JUnit 4.13

[GitHub] [felix-dev] dependabot[bot] opened a new pull request, #198: Bump junit from 4.12 to 4.13.1 in /scr

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #198: URL: https://github.com/apache/felix-dev/pull/198 Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases";>junit's releases. JUnit 4.13

[GitHub] [felix-dev] dependabot[bot] opened a new pull request, #197: Bump junit from 4.12 to 4.13.1 in /utils

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #197: URL: https://github.com/apache/felix-dev/pull/197 Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases";>junit's releases. JUnit 4.13

[GitHub] [felix-dev] cziegeler merged pull request #187: Bump junit from 4.13 to 4.13.1 in /webconsole

2023-03-01 Thread via GitHub
cziegeler merged PR #187: URL: https://github.com/apache/felix-dev/pull/187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] dependabot[bot] opened a new pull request, #199: Bump logback-classic from 1.0.13 to 1.2.0 in /rootcause

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #199: URL: https://github.com/apache/felix-dev/pull/199 Bumps logback-classic from 1.0.13 to 1.2.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ch.qos.logback:logba

[GitHub] [felix-dev] dependabot[bot] opened a new pull request, #200: Bump junit from 4.12 to 4.13.1 in /rootcause

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #200: URL: https://github.com/apache/felix-dev/pull/200 Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases";>junit's releases. JUnit 4.13

[GitHub] [felix-dev] cziegeler merged pull request #185: Bump junit from 4.12 to 4.13.1 in /gogo/gogo-parent

2023-03-01 Thread via GitHub
cziegeler merged PR #185: URL: https://github.com/apache/felix-dev/pull/185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] cziegeler merged pull request #200: Bump junit from 4.12 to 4.13.1 in /rootcause

2023-03-01 Thread via GitHub
cziegeler merged PR #200: URL: https://github.com/apache/felix-dev/pull/200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] dependabot[bot] opened a new pull request, #201: Bump junit from 4.12 to 4.13.1 in /metatype

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #201: URL: https://github.com/apache/felix-dev/pull/201 Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases";>junit's releases. JUnit 4.13

[GitHub] [felix-dev] cziegeler merged pull request #198: Bump junit from 4.12 to 4.13.1 in /scr

2023-03-01 Thread via GitHub
cziegeler merged PR #198: URL: https://github.com/apache/felix-dev/pull/198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] dependabot[bot] opened a new pull request, #202: Bump junit from 4.12 to 4.13.1 in /jaas

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #202: URL: https://github.com/apache/felix-dev/pull/202 Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases";>junit's releases. JUnit 4.13

[GitHub] [felix-dev] dependabot[bot] opened a new pull request, #203: Bump junit from 4.11 to 4.13.1 in /resolver

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #203: URL: https://github.com/apache/felix-dev/pull/203 Bumps [junit](https://github.com/junit-team/junit4) from 4.11 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases";>junit's releases. JUnit 4.13

[GitHub] [felix-dev] cziegeler merged pull request #202: Bump junit from 4.12 to 4.13.1 in /jaas

2023-03-01 Thread via GitHub
cziegeler merged PR #202: URL: https://github.com/apache/felix-dev/pull/202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] dependabot[bot] opened a new pull request, #204: Bump junit from 4.12 to 4.13.1 in /framework

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #204: URL: https://github.com/apache/felix-dev/pull/204 Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases";>junit's releases. JUnit 4.13

[GitHub] [felix-dev] cziegeler merged pull request #203: Bump junit from 4.11 to 4.13.1 in /resolver

2023-03-01 Thread via GitHub
cziegeler merged PR #203: URL: https://github.com/apache/felix-dev/pull/203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] cziegeler merged pull request #204: Bump junit from 4.12 to 4.13.1 in /framework

2023-03-01 Thread via GitHub
cziegeler merged PR #204: URL: https://github.com/apache/felix-dev/pull/204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] dependabot[bot] opened a new pull request, #205: Bump junit from 4.13 to 4.13.1 in /fileinstall

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #205: URL: https://github.com/apache/felix-dev/pull/205 Bumps [junit](https://github.com/junit-team/junit4) from 4.13 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases";>junit's releases. JUnit 4.13

[GitHub] [felix-dev] dependabot[bot] opened a new pull request, #206: Bump junit from 4.12 to 4.13.1 in /coordinator

2023-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #206: URL: https://github.com/apache/felix-dev/pull/206 Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases";>junit's releases. JUnit 4.13

[GitHub] [felix-dev] cziegeler merged pull request #186: Bump bcprov-jdk15on from 1.64 to 1.67 in /deploymentadmin/itest

2023-03-01 Thread via GitHub
cziegeler merged PR #186: URL: https://github.com/apache/felix-dev/pull/186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] cziegeler merged pull request #197: Bump junit from 4.12 to 4.13.1 in /utils

2023-03-01 Thread via GitHub
cziegeler merged PR #197: URL: https://github.com/apache/felix-dev/pull/197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] cziegeler merged pull request #196: Bump junit from 4.12 to 4.13.1 in /systemready

2023-03-01 Thread via GitHub
cziegeler merged PR #196: URL: https://github.com/apache/felix-dev/pull/196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] cziegeler merged pull request #206: Bump junit from 4.12 to 4.13.1 in /coordinator

2023-03-01 Thread via GitHub
cziegeler merged PR #206: URL: https://github.com/apache/felix-dev/pull/206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] cziegeler merged pull request #205: Bump junit from 4.13 to 4.13.1 in /fileinstall

2023-03-01 Thread via GitHub
cziegeler merged PR #205: URL: https://github.com/apache/felix-dev/pull/205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] cziegeler merged pull request #199: Bump logback-classic from 1.0.13 to 1.2.0 in /rootcause

2023-03-01 Thread via GitHub
cziegeler merged PR #199: URL: https://github.com/apache/felix-dev/pull/199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] cziegeler merged pull request #201: Bump junit from 4.12 to 4.13.1 in /metatype

2023-03-01 Thread via GitHub
cziegeler merged PR #201: URL: https://github.com/apache/felix-dev/pull/201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] gnodet merged pull request #195: [FELIX-6597] IllegalAccess when using reflection on public methods

2023-03-07 Thread via GitHub
gnodet merged PR #195: URL: https://github.com/apache/felix-dev/pull/195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.or

[GitHub] [felix-antora-site] pekdemira opened a new pull request, #5: Update index.adoc for a broken link

2023-03-09 Thread via GitHub
pekdemira opened a new pull request, #5: URL: https://github.com/apache/felix-antora-site/pull/5 Update the broken link to the OSGi Specifications page at https://docs.osgi.org/specification/ -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [felix-dev] dependabot[bot] opened a new pull request, #207: Bump snakeyaml from 1.32 to 2.0 in /converter/serializer

2023-03-09 Thread via GitHub
dependabot[bot] opened a new pull request, #207: URL: https://github.com/apache/felix-dev/pull/207 Bumps [snakeyaml](https://bitbucket.org/snakeyaml/snakeyaml) from 1.32 to 2.0. Commits https://bitbucket.org/snakeyaml/snakeyaml/commits/c98ffba9cd065d1ead94c9ec580d8b5a5966c9d3";

[GitHub] [felix-atomos] HannesWell commented on a diff in pull request #70: add handling for running build on Windows

2023-03-23 Thread via GitHub
HannesWell commented on code in PR #70: URL: https://github.com/apache/felix-atomos/pull/70#discussion_r1145887674 ## atomos.utils/atomos.utils.substrate.impl/src/main/java/org/apache/felix/atomos/utils/substrate/impl/NativeImageArgumentsImpl.java: ## @@ -121,7 +121,7 @@ public

[GitHub] [felix-atomos] fipro78 commented on a diff in pull request #70: add handling for running build on Windows

2023-03-23 Thread via GitHub
fipro78 commented on code in PR #70: URL: https://github.com/apache/felix-atomos/pull/70#discussion_r1145899360 ## atomos.utils/atomos.utils.substrate.impl/src/main/java/org/apache/felix/atomos/utils/substrate/impl/NativeImageArgumentsImpl.java: ## @@ -121,7 +121,7 @@ public Lis

[GitHub] [felix-atomos] fipro78 commented on a diff in pull request #70: add handling for running build on Windows

2023-03-23 Thread via GitHub
fipro78 commented on code in PR #70: URL: https://github.com/apache/felix-atomos/pull/70#discussion_r1145929755 ## atomos.utils/atomos.utils.substrate.impl/src/main/java/org/apache/felix/atomos/utils/substrate/impl/NativeImageArgumentsImpl.java: ## @@ -121,7 +121,7 @@ public Lis

[GitHub] [felix-dev] hboutemy opened a new pull request, #208: FELIX-6602 sort resources and exported packages

2023-03-24 Thread via GitHub
hboutemy opened a new pull request, #208: URL: https://github.com/apache/felix-dev/pull/208 fixes https://issues.apache.org/jira/browse/FELIX-6602 tested on a few projects (mybatis-3, activemq-artemis), using disorderfs to make sure that these 2 changes fix last remaining issues --

[GitHub] [felix-dev] karlpauls merged pull request #193: FELIX-6591: Deallocate Conditions and Permissions when bundles unloaded.

2023-04-14 Thread via GitHub
karlpauls merged PR #193: URL: https://github.com/apache/felix-dev/pull/193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] karlpauls commented on pull request #193: FELIX-6591: Deallocate Conditions and Permissions when bundles unloaded.

2023-04-14 Thread via GitHub
karlpauls commented on PR #193: URL: https://github.com/apache/felix-dev/pull/193#issuecomment-1509276293 LGTM - thanks a lot for the patch @chrisr3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [felix-dev] hboutemy commented on pull request #208: FELIX-6602 sort resources and exported packages

2023-04-15 Thread via GitHub
hboutemy commented on PR #208: URL: https://github.com/apache/felix-dev/pull/208#issuecomment-1510098160 @jbonofre any problem to merge and release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [felix-dev] jbonofre commented on pull request #208: FELIX-6602 sort resources and exported packages

2023-04-16 Thread via GitHub
jbonofre commented on PR #208: URL: https://github.com/apache/felix-dev/pull/208#issuecomment-1510139364 No problem, I will do that. Sorry for the delay. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [felix-dev] hboutemy commented on pull request #208: FELIX-6602 sort resources and exported packages

2023-04-16 Thread via GitHub
hboutemy commented on PR #208: URL: https://github.com/apache/felix-dev/pull/208#issuecomment-1510753066 no worries, I hope this one will really be the last for Reproducible Builds, after FELIX-6304 (5.1.1), FELIX-6404 (5.1.3), FELIX-6495 (5.1.4), FELIX-6496 (5.1.5) -- This is an automat

[GitHub] [felix-dev] chrisr3 commented on pull request #193: FELIX-6591: Deallocate Conditions and Permissions when bundles unloaded.

2023-04-17 Thread via GitHub
chrisr3 commented on PR #193: URL: https://github.com/apache/felix-dev/pull/193#issuecomment-1510907174 > LGTM - thanks a lot for the patch @chrisr3 No problem. Do you have any idea when the next version of Felix Security will be released please? -- This is an automated message fro

[GitHub] [felix-dev] karlpauls commented on pull request #193: FELIX-6591: Deallocate Conditions and Permissions when bundles unloaded.

2023-04-17 Thread via GitHub
karlpauls commented on PR #193: URL: https://github.com/apache/felix-dev/pull/193#issuecomment-1510973808 @chrisr3 - I'm planning to cut a release this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [felix-dev] dependabot[bot] opened a new pull request, #209: Bump jetty-server from 11.0.13 to 11.0.14 in /http/jetty

2023-04-18 Thread via GitHub
dependabot[bot] opened a new pull request, #209: URL: https://github.com/apache/felix-dev/pull/209 Bumps [jetty-server](https://github.com/eclipse/jetty.project) from 11.0.13 to 11.0.14. Release notes Sourced from https://github.com/eclipse/jetty.project/releases";>jetty-server's

[GitHub] [felix-dev] hboutemy commented on pull request #208: FELIX-6602 sort resources and exported packages

2023-05-02 Thread via GitHub
hboutemy commented on PR #208: URL: https://github.com/apache/felix-dev/pull/208#issuecomment-1532503856 Hi @jbonofre , any time to merge and release, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [felix] harrison-tarr closed pull request #136: Add better support for backslashes in read

2023-05-09 Thread via GitHub
harrison-tarr closed pull request #136: Add better support for backslashes in read URL: https://github.com/apache/felix/pull/136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [felix-dev] dependabot[bot] closed pull request #209: Bump jetty-server from 11.0.13 to 11.0.14 in /http/jetty

2023-05-13 Thread via GitHub
dependabot[bot] closed pull request #209: Bump jetty-server from 11.0.13 to 11.0.14 in /http/jetty URL: https://github.com/apache/felix-dev/pull/209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [felix-dev] dependabot[bot] commented on pull request #209: Bump jetty-server from 11.0.13 to 11.0.14 in /http/jetty

2023-05-13 Thread via GitHub
dependabot[bot] commented on PR #209: URL: https://github.com/apache/felix-dev/pull/209#issuecomment-1546584536 Looks like org.eclipse.jetty:jetty-server is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [felix-dev] hboutemy commented on pull request #208: FELIX-6602 sort resources and exported packages

2023-05-14 Thread via GitHub
hboutemy commented on PR #208: URL: https://github.com/apache/felix-dev/pull/208#issuecomment-1546926103 @jbonofre please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [felix-dev] jbonofre commented on pull request #208: FELIX-6602 sort resources and exported packages

2023-05-14 Thread via GitHub
jbonofre commented on PR #208: URL: https://github.com/apache/felix-dev/pull/208#issuecomment-1546932208 Yes. Sorry I forgot. I will move forward on this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [felix-dev] jbonofre merged pull request #208: FELIX-6602 sort resources and exported packages

2023-05-14 Thread via GitHub
jbonofre merged PR #208: URL: https://github.com/apache/felix-dev/pull/208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.

[GitHub] [felix-dev] hboutemy commented on pull request #208: FELIX-6602 sort resources and exported packages

2023-05-14 Thread via GitHub
hboutemy commented on PR #208: URL: https://github.com/apache/felix-dev/pull/208#issuecomment-1547225715 thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [felix-dev] kwin commented on pull request #210: FELIX-6607 consider service ranking for conflicting web console plugins

2023-05-15 Thread via GitHub
kwin commented on PR #210: URL: https://github.com/apache/felix-dev/pull/210#issuecomment-1547625818 @cziegeler @karlpauls Can you have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [felix-dev] kwin opened a new pull request, #211: FELIX-6610 expose request logging properties through metatype

2023-05-16 Thread via GitHub
kwin opened a new pull request, #211: URL: https://github.com/apache/felix-dev/pull/211 Allow to configure SLF4J logger name through new property "org.apache.felix.http.requestlog.osgi.logger.name". Remove unused property "org.apache.felix.http.requestlog.osgi.level" -- This is an automa

[GitHub] [felix-dev] cziegeler merged pull request #211: FELIX-6610 expose request logging properties through metatype

2023-06-04 Thread via GitHub
cziegeler merged PR #211: URL: https://github.com/apache/felix-dev/pull/211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] cziegeler merged pull request #210: FELIX-6607 consider service ranking for conflicting web console plugins

2023-06-04 Thread via GitHub
cziegeler merged PR #210: URL: https://github.com/apache/felix-dev/pull/210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] sagarmiglani opened a new pull request, #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites

2023-06-21 Thread via GitHub
sagarmiglani opened a new pull request, #212: URL: https://github.com/apache/felix-dev/pull/212 This pull request addresses the issue of an empty value being saved when a list property has no value (FELIX-6614). The proposed solution is to filter out the request query parameters that have e

[GitHub] [felix-dev] kwin commented on a diff in pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites

2023-06-21 Thread via GitHub
kwin commented on code in PR #212: URL: https://github.com/apache/felix-dev/pull/212#discussion_r1236747502 ## webconsole/src/main/resources/res/ui/config.js: ## @@ -674,7 +690,7 @@ $(document).ready(function() { $.ajax({ type : 'POST'

[GitHub] [felix-dev] kwin commented on a diff in pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites

2023-06-21 Thread via GitHub
kwin commented on code in PR #212: URL: https://github.com/apache/felix-dev/pull/212#discussion_r1236748770 ## webconsole/src/main/resources/res/ui/config.js: ## @@ -674,7 +690,7 @@ $(document).ready(function() { $.ajax({ type : 'POST'

[GitHub] [felix-dev] sagarmiglani commented on a diff in pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites

2023-06-22 Thread via GitHub
sagarmiglani commented on code in PR #212: URL: https://github.com/apache/felix-dev/pull/212#discussion_r1238096004 ## webconsole/src/main/resources/res/ui/config.js: ## @@ -674,7 +690,7 @@ $(document).ready(function() { $.ajax({ type

[GitHub] [felix-dev] kwin commented on a diff in pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites

2023-07-05 Thread via GitHub
kwin commented on code in PR #212: URL: https://github.com/apache/felix-dev/pull/212#discussion_r1253967553 ## webconsole/src/main/resources/res/ui/config.js: ## @@ -348,6 +349,25 @@ function printConfigurationInfo( /* Element */ parent, obj ) var spanCounter = 0; +/* Elem

[GitHub] [felix-dev] cziegeler commented on pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites

2023-07-05 Thread via GitHub
cziegeler commented on PR #212: URL: https://github.com/apache/felix-dev/pull/212#issuecomment-1623035482 The new "add" button is now displayed for every list property. Shouldn't it only be displayed if there is no value yet? ![new](https://github.com/apache/felix-dev/assets/3958409/b93d

[GitHub] [felix-dev] kwin commented on pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites

2023-07-05 Thread via GitHub
kwin commented on PR #212: URL: https://github.com/apache/felix-dev/pull/212#issuecomment-1623035491 @cziegeler Can you have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [felix-dev] kwin commented on pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites

2023-07-05 Thread via GitHub
kwin commented on PR #212: URL: https://github.com/apache/felix-dev/pull/212#issuecomment-1623038983 I think the best UX would be - one delete button per item - one add button per list - possibility to reorder (maybe leveraging https://jqueryui.com/draggable/#sortable) The "

[GitHub] [felix-dev] cziegeler commented on pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites

2023-07-05 Thread via GitHub
cziegeler commented on PR #212: URL: https://github.com/apache/felix-dev/pull/212#issuecomment-1623091773 Let's not put too many changes into this single issue. The most important part is to avoid saving the empty value. So I suggest, we keep the add/delete buttons after each field. And if

[GitHub] [felix-dev] glimmerveen opened a new pull request, #213: [Health Check] SFL4j 2.x compatibility

2023-07-09 Thread via GitHub
glimmerveen opened a new pull request, #213: URL: https://github.com/apache/felix-dev/pull/213 Currently Felix Health Check cannot be used in a runtime where SLF4j 2.x is deployed. I traced this to Health Check's API dependency on the `org.slf4j.helpers.MessageFormatter`. This PR replaces t

[GitHub] [felix-dev] kwin commented on pull request #213: [Health Check] SFL4j 2.x compatibility

2023-07-09 Thread via GitHub
kwin commented on PR #213: URL: https://github.com/apache/felix-dev/pull/213#issuecomment-1627763686 There is still ongoing discussions whether that is a mistake or a deliberate decision from SLF4J v2 in https://jira.qos.ch/browse/SLF4J-579. -- This is an automated message from the Apache

[GitHub] [felix-dev] glimmerveen commented on pull request #213: [Health Check] SFL4j 2.x compatibility

2023-07-09 Thread via GitHub
glimmerveen commented on PR #213: URL: https://github.com/apache/felix-dev/pull/213#issuecomment-1627771049 > There is still ongoing discussions whether that is a mistake or a deliberate decision from SLF4J v2 in https://jira.qos.ch/browse/SLF4J-579. I was not aware of this discussion

[GitHub] [felix-dev] glimmerveen commented on pull request #213: [Health Check] SFL4j 2.x compatibility

2023-07-09 Thread via GitHub
glimmerveen commented on PR #213: URL: https://github.com/apache/felix-dev/pull/213#issuecomment-1627780247 > I was doubting whether the types in the helpers package were intended to be used by users. I see that this question was also raised within the JIRA comments under the issue you refe

[GitHub] [felix-dev] sagarmiglani commented on pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites

2023-07-13 Thread via GitHub
sagarmiglani commented on PR #212: URL: https://github.com/apache/felix-dev/pull/212#issuecomment-1633810655 > The new "add" button is now displayed for every list property. Shouldn't it only be displayed if there is no value yet? @cziegeler Thank you for reviewing, I made this dec

[GitHub] [felix-dev] kwin commented on pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites

2023-07-13 Thread via GitHub
kwin commented on PR #212: URL: https://github.com/apache/felix-dev/pull/212#issuecomment-1633837561 I think this comment referred only to the topmost add icon (not bound to an item, compare with the screenshot). -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [felix-dev] sagarmiglani commented on pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites

2023-07-17 Thread via GitHub
sagarmiglani commented on PR #212: URL: https://github.com/apache/felix-dev/pull/212#issuecomment-1637585391 @kwin I am also referring to the topmost add icon. Here is the comparison: |Scenario|Present scenario|Proposed solution| |---|---|---| |1|**When there is not value in a

[GitHub] [felix-dev] kwin commented on pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites

2023-07-17 Thread via GitHub
kwin commented on PR #212: URL: https://github.com/apache/felix-dev/pull/212#issuecomment-1637624924 @sagarmiglani Thanks for the clarification, makes sense to me. But as I am not a committer you would need @cziegeler's approval and merge. -- This is an automated message from the Apache G

[GitHub] [felix-dev] cziegeler commented on pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites

2023-07-17 Thread via GitHub
cziegeler commented on PR #212: URL: https://github.com/apache/felix-dev/pull/212#issuecomment-1638029753 @sagarmiglani Thanks for the comparison. I think the item where we have different opinions is row 4 - while I agree that it would be consistent to allow to add a value to the first row,

[GitHub] [felix-antora-site] fredgan opened a new pull request, #6: Update index.adoc Link URL

2023-07-19 Thread via GitHub
fredgan opened a new pull request, #6: URL: https://github.com/apache/felix-antora-site/pull/6 The original link url http://www.osgi.org/Specifications/HomePage is 404, the new url should be https://docs.osgi.org/specification/ -- This is an automated message from the Apache Git Service.

[GitHub] [felix-antora-site] cziegeler merged pull request #6: Update index.adoc Link URL

2023-07-19 Thread via GitHub
cziegeler merged PR #6: URL: https://github.com/apache/felix-antora-site/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.ap

[GitHub] [felix-dev] cziegeler merged pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites

2023-07-19 Thread via GitHub
cziegeler merged PR #212: URL: https://github.com/apache/felix-dev/pull/212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] cziegeler merged pull request #207: Bump snakeyaml from 1.32 to 2.0 in /converter/serializer

2023-07-19 Thread via GitHub
cziegeler merged PR #207: URL: https://github.com/apache/felix-dev/pull/207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] dependabot[bot] opened a new pull request, #215: Bump org.codehaus.plexus:plexus-archiver from 3.6.0 to 4.8.0 in /tools/osgicheck-maven-plugin

2023-07-25 Thread via GitHub
dependabot[bot] opened a new pull request, #215: URL: https://github.com/apache/felix-dev/pull/215 Bumps [org.codehaus.plexus:plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 3.6.0 to 4.8.0. Release notes Sourced from https://github.com/codehaus-plexus/ple

[GitHub] [felix-dev] dependabot[bot] opened a new pull request, #216: Bump org.codehaus.plexus:plexus-archiver from 3.6.0 to 4.8.0 in /tools/maven-bundle-plugin

2023-07-25 Thread via GitHub
dependabot[bot] opened a new pull request, #216: URL: https://github.com/apache/felix-dev/pull/216 Bumps [org.codehaus.plexus:plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 3.6.0 to 4.8.0. Release notes Sourced from https://github.com/codehaus-plexus/ple

[GitHub] [felix-dev] cziegeler merged pull request #215: Bump org.codehaus.plexus:plexus-archiver from 3.6.0 to 4.8.0 in /tools/osgicheck-maven-plugin

2023-07-26 Thread via GitHub
cziegeler merged PR #215: URL: https://github.com/apache/felix-dev/pull/215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

[GitHub] [felix-dev] cziegeler merged pull request #216: Bump org.codehaus.plexus:plexus-archiver from 3.6.0 to 4.8.0 in /tools/maven-bundle-plugin

2023-07-26 Thread via GitHub
cziegeler merged PR #216: URL: https://github.com/apache/felix-dev/pull/216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache

  1   2   3   4   5   6   7   8   9   10   >