Re: Checkstyle for Fineract source code

2020-05-21 Thread Michael Vorburger
.xml >>>> (just move it up before line 51, before the commented out block of all the >>>> rules which are still to be done). >>>> >>>> It's best to go about such things gradually and incrementally, please >>>> send us a first PR *only* mak

Re: Checkstyle for Fineract source code

2020-05-20 Thread Ed Cable
hich are still to be done). >>> >>> It's best to go about such things gradually and incrementally, please >>> send us a first PR *only* making this change. >>> >>> >>>> We have a significant number of enhancements based off of

Re: Checkstyle for Fineract source code

2020-05-20 Thread Manthan Surkar
;>> getting the above completed would help us contribute back. >>> >> >> Great! Looking forward. >> >> >>> I've not followed 1.3/1.4, so if these changes were already made, that's >>> great. >>> >>> Please let us

Re: Checkstyle for Fineract source code

2020-05-20 Thread Ed Cable
Looking forward. > > >> I've not followed 1.3/1.4, so if these changes were already made, that's >> great. >> >> Please let us know how my team can best help. >> > > We eagerly await your first Pull Request re. ConstantName! And then more > after that? ;-) &g

Re: Checkstyle for Fineract source code

2020-01-23 Thread Awasum Yannick
se changes were already made, that's great. > > Please let us know how my team can best help. > > > Best Regards, > > Richard > > > On Sat, Jan 11, 2020 at 2:28 AM Michael Vorburger > wrote: > >> Hello, >> >> I've started with https://issues

Re: Checkstyle for Fineract source code

2020-01-22 Thread Michael Vorburger
w my team can best help. > We eagerly await your first Pull Request re. ConstantName! And then more after that? ;-) > Best Regards, > > Richard > > > On Sat, Jan 11, 2020 at 2:28 AM Michael Vorburger > wrote: > >> Hello, >> >> I've star

Re: Checkstyle for Fineract source code

2020-01-14 Thread Richard Billeci
CT-821 re. > adopting Checkstyle for Fineract source code. > > Would anyone be interested in helping with this effort? > > Best, > M. > ___ > Michael Vorburger > http://www.vorburger.ch >

Re: Checkstyle for Fineract source code

2020-01-12 Thread Yemdjih Kaze Nasser
llo, >>> >>> I've started with https://issues.apache.org/jira/browse/FINERACT-821 >>> re. adopting Checkstyle for Fineract source code. >>> >>> Would anyone be interested in helping with this effort? >>> >>> Best, >>> M. >>> ___ >>> Michael Vorburger >>> http://www.vorburger.ch >>> >>

Re: Checkstyle for Fineract source code

2020-01-12 Thread Yemdjih Kaze Nasser
I'm interested in this, I will make some investigations and push some changes On Sat, 11 Jan 2020 at 02:28, Michael Vorburger wrote: > Hello, > > I've started with https://issues.apache.org/jira/browse/FINERACT-821 re. > adopting Checkstyle for Fineract source code. >

Checkstyle for Fineract source code

2020-01-10 Thread Michael Vorburger
Hello, I've started with https://issues.apache.org/jira/browse/FINERACT-821 re. adopting Checkstyle for Fineract source code. Would anyone be interested in helping with this effort? Best, M. ___ Michael Vorburger http://www.vorburger.ch