Re: Getting started on Fineract CN

[Markus Geiss]

Hey Phil,

given all repos got pushed as is, I guess one of the first tasks is to
rename
all packages and projects to fit into the Apache layout.

If you just want to get started now, you need to call

  ./gradelw publishToMavenLocal (assuming a *nix OS)

for every project. You should be able to adjust and run the
initial setup script found at the demo-server.

Cheers

Markus

.::Yagni likes a DRY KISS::.

On Sun, Feb 25, 2018 at 10:18 PM Phil Steitz  wrote:

> I would like to start contributing to CN.  I have cloned all of the
> repos and thought it would be a good first step to build the
> demo-server.  The readme for that component says that as a
> precondition, "All Mifos I/O projects must be published to your
> local Maven repository."  I assume that now means some subset of all
> of the fineract-cn components.   But in build.gradle, I see
> references to mifos components.  Do I maybe need to just replace
> these with the fineract-cn versions and install these locally using
> "gradle publisToMavenLocal" from each of these repos?
>
> I am happy to provide doco and config patches as I get this working
> if I can get pointed in the right direction.   Thanks in advance!
>
> Phil
>
>

Re: GSoC 2018: Fineract CN SMS & Email Notifications

[Piyadassi Shakya]

Hi Awasum
 I followed your points yet again I am facing the same error and it says
package.json not found.



With Regards
Piyadassi


On Mon, Feb 26, 2018 at 6:34 AM, Viswa Ramamoorthy <
viswaramamoor...@yahoo.com.invalid> wrote:

>  First error - cannot connect to tcp://localhost:61616 - is ActiveMQ
> related. Is activeMQ running in localhost? You can related to ActiveMQ setup
> Second error indicates that the microservices are looking for Netflix
> Eureka server to register to. I do not see any mention of Eureka server
> setup in the readme of Fineract CN demo server. However, if you setup a
> Eureka server that running at localhost 8761 port (note default port is
> 8761), it would work.
>
> On ‎Sunday‎, ‎February‎ ‎25‎, ‎2018‎ ‎04‎:‎31‎:‎19‎ ‎PM‎ ‎EST, Acha
> Bill  wrote:
>
>  In running the demo server, java -Ddemoserver.provision=true -jar
> demo-server-0.1.0-BUILD-SNAPSHOT.jar
> I get these errors from different services:
>
> [DefaultMessageListenerContainer-1] ERROR o.s.j.l.
> DefaultMessageListenerContainer - Could not refresh JMS Connection for
> destination 'identity-v1' - retrying using FixedBackOff{interval=5000,
> currentAttempts=0, maxAttempts=unlimited}. Cause: Error while attempting to
> retrieve a connection from the pool; nested exception is
> javax.jms.JMSException: Could not connect to broker URL:
> tcp://localhost:61616. Reason: java.net.ConnectException: Connection
> refused (Connection refused)
>
>
> And finally terminates with:
>
> Time: 1,456.026
> There was 1 failure:
> 1) startDevServer(io.mifos.dev.ServiceRunner)
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at io.mifos.dev.ServiceRunner.provisionApp(ServiceRunner.java:484)
> at io.mifos.dev.ServiceRunner.provisionAppsViaSeshatForTenan
> t(ServiceRunner.java:442)
> at io.mifos.dev.ServiceRunner.provisionAppsViaSeshat(
> ServiceRunner.java:358)
> at io.mifos.dev.ServiceRunner.startDevServer(ServiceRunner.
> java:260)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(
> NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(
> DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(
> FrameworkMethod.java:50)
> at org.junit.internal.runners.model.ReflectiveCallable.run(
> ReflectiveCallable.java:12)
> at org.junit.runners.model.FrameworkMethod.invokeExplosively(
> FrameworkMethod.java:47)
> at org.junit.internal.runners.statements.InvokeMethod.
> evaluate(InvokeMethod.java:17)
> at org.junit.internal.runners.statements.RunBefores.
> evaluate(RunBefores.java:26)
> at org.springframework.test.context.junit4.statements.
> RunBeforeTestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.
> java:75)
> at org.junit.internal.runners.statements.RunAfters.evaluate(
> RunAfters.java:27)
> at org.springframework.test.context.junit4.statements.
> RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:86)
> at org.springframework.test.context.junit4.statements.
> SpringRepeat.evaluate(SpringRepeat.java:84)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at org.springframework.test.context.junit4.
> SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:252)
> at org.springframework.test.context.junit4.
> SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:94)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(
> ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(
> ParentRunner.java:268)
> at org.springframework.test.context.junit4.statements.
> RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
> at org.springframework.test.context.junit4.statements.
> RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70)
> at org.junit.rules.ExternalResource$1.evaluate(
> ExternalResource.java:48)
> at org.junit.rules.ExternalResource$1.evaluate(
> ExternalResource.java:48)
> at org.junit.rules.ExternalResource$1.evaluate(
> ExternalResource.java:48)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.springframework.test.context.junit4.
> SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:191)
> at 

GSoC 2018: Fineract CN SMS & Email Notifications

[Arthur Marques]

Hi,

My name is Arthur Marques and I am a Ph.D student in software engineering
at the University of British Columbia. The Fineract project caught my
attention and I'm interested in applying to it for this GSoC.

As I saw other students discussing the project, I would like to know if it
is possible for more than one student application to the same project.

Also, I've two questions related to the build scripts:


   - I found that there is a missing project required in the build scripts
   namely *cheques*. After I manually added it to my Workspace, I was able
   to build the demo-sever. Is this project indeed required? If so, can I
   submit a PR to the demo-server repo adding the missing project?
   - There are slight shell differences between the Unix and the MacOS
   shell scripts and I had to manually edit the scripts for the MacOS
   environment. Can I submit a PR with the scripts for MacOS?


Regards,
Arthur Marques

Re: GSoC 2018: Fineract CN SMS & Email Notifications

[Viswa Ramamoorthy]

 First error - cannot connect to tcp://localhost:61616 - is ActiveMQ related. 
Is activeMQ running in localhost? You can related to ActiveMQ setup
Second error indicates that the microservices are looking for Netflix Eureka 
server to register to. I do not see any mention of Eureka server setup in the 
readme of Fineract CN demo server. However, if you setup a Eureka server that 
running at localhost 8761 port (note default port is 8761), it would work.

On ‎Sunday‎, ‎February‎ ‎25‎, ‎2018‎ ‎04‎:‎31‎:‎19‎ ‎PM‎ ‎EST, Acha Bill 
 wrote:  
 
 In running the demo server, java -Ddemoserver.provision=true -jar 
demo-server-0.1.0-BUILD-SNAPSHOT.jar
I get these errors from different services:

[DefaultMessageListenerContainer-1] ERROR 
o.s.j.l.DefaultMessageListenerContainer - Could not refresh JMS Connection for 
destination 'identity-v1' - retrying using FixedBackOff{interval=5000, 
currentAttempts=0, maxAttempts=unlimited}. Cause: Error while attempting to 
retrieve a connection from the pool; nested exception is 
javax.jms.JMSException: Could not connect to broker URL: tcp://localhost:61616. 
Reason: java.net.ConnectException: Connection refused (Connection refused)


And finally terminates with:

Time: 1,456.026
There was 1 failure:
1) startDevServer(io.mifos.dev.ServiceRunner)
java.lang.AssertionError
        at org.junit.Assert.fail(Assert.java:86)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at org.junit.Assert.assertTrue(Assert.java:52)
        at io.mifos.dev.ServiceRunner.provisionApp(ServiceRunner.java:484)
        at 
io.mifos.dev.ServiceRunner.provisionAppsViaSeshatForTenant(ServiceRunner.java:442)
        at 
io.mifos.dev.ServiceRunner.provisionAppsViaSeshat(ServiceRunner.java:358)
        at io.mifos.dev.ServiceRunner.startDevServer(ServiceRunner.java:260)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
        at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
        at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
        at 
org.springframework.test.context.junit4.statements.RunBeforeTestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.java:75)
        at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
        at 
org.springframework.test.context.junit4.statements.RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:86)
        at 
org.springframework.test.context.junit4.statements.SpringRepeat.evaluate(SpringRepeat.java:84)
        at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
        at 
org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:252)
        at 
org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:94)
        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
        at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
        at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
        at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
        at 
org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
        at 
org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70)
        at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
        at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
        at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
        at org.junit.rules.RunRules.evaluate(RunRules.java:20)
        at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
        at 
org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:191)
        at org.junit.runners.Suite.runChild(Suite.java:128)
        at org.junit.runners.Suite.runChild(Suite.java:27)
        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
        at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
        at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
        at 

Re: GSoC 2018: Fineract CN SMS & Email Notifications

[Acha Bill]

In running the demo server, java -Ddemoserver.provision=true -jar 
demo-server-0.1.0-BUILD-SNAPSHOT.jar
I get these errors from different services:

[DefaultMessageListenerContainer-1] ERROR 
o.s.j.l.DefaultMessageListenerContainer - Could not refresh JMS Connection for 
destination 'identity-v1' - retrying using FixedBackOff{interval=5000, 
currentAttempts=0, maxAttempts=unlimited}. Cause: Error while attempting to 
retrieve a connection from the pool; nested exception is 
javax.jms.JMSException: Could not connect to broker URL: tcp://localhost:61616. 
Reason: java.net.ConnectException: Connection refused (Connection refused)


And finally terminates with:

Time: 1,456.026
There was 1 failure:
1) startDevServer(io.mifos.dev.ServiceRunner)
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at io.mifos.dev.ServiceRunner.provisionApp(ServiceRunner.java:484)
at 
io.mifos.dev.ServiceRunner.provisionAppsViaSeshatForTenant(ServiceRunner.java:442)
at 
io.mifos.dev.ServiceRunner.provisionAppsViaSeshat(ServiceRunner.java:358)
at io.mifos.dev.ServiceRunner.startDevServer(ServiceRunner.java:260)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at 
org.springframework.test.context.junit4.statements.RunBeforeTestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.java:75)
at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at 
org.springframework.test.context.junit4.statements.RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:86)
at 
org.springframework.test.context.junit4.statements.SpringRepeat.evaluate(SpringRepeat.java:84)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at 
org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:252)
at 
org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:94)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at 
org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
at 
org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at 
org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:191)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
at org.junit.runner.JUnitCore.runMain(JUnitCore.java:77)
at org.junit.runner.JUnitCore.main(JUnitCore.java:36)
at io.mifos.dev.DemoServer.main(DemoServer.java:27)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 

Getting started on Fineract CN

[Phil Steitz]

I would like to start contributing to CN.  I have cloned all of the
repos and thought it would be a good first step to build the
demo-server.  The readme for that component says that as a
precondition, "All Mifos I/O projects must be published to your
local Maven repository."  I assume that now means some subset of all
of the fineract-cn components.   But in build.gradle, I see
references to mifos components.  Do I maybe need to just replace
these with the fineract-cn versions and install these locally using
"gradle publisToMavenLocal" from each of these repos?

I am happy to provide doco and config patches as I get this working
if I can get pointed in the right direction.   Thanks in advance!

Phil

Re: GSoC 2018: Fineract CN SMS & Email Notifications

[Acha Bill]

Login credentials for fims web app not working.

Tenant: playground
Username: operator
Password: init1@l

https://cwiki.apache.org/confluence/display/FINERACT/How+to+build+Fineract+CN

> On Feb 24, 2018, at 6:50 AM, Isaac Kamga  wrote:
> 
> Hi Bill,
> 
> That's a good step for a student who wants to work on Fineract CN during
> GSoC 2018
> 
> On the same How to build Fineract CN
> 
> page, there are test credentials for tenant, user and password.
> 
> Did you also correct the initial setup script as was asked you by Awasum
> Yannick ? It'll be helpful for you to share it with the wider community.
> 
> Cheers,
> Isaac Kamga.
> 
> 
> 
> On Sat, Feb 24, 2018 at 1:29 AM, Acha Bill  wrote:
> 
>> Hello Isaac, Awasum,
>> 
>> I’ve successfully built the codebase and running the fims app and demo
>> server.
>> Are there any default/test login credentials for the web app?
>> 
>> 
>>> On Feb 22, 2018, at 8:45 AM, Awasum Yannick  wrote:
>>> 
>>> Hey,
>>> 
>>> From here:
>>> https://github.com/apache/fineract-cn-demo-server/tree/develop/scripts,
>>> 
>>> You can see a windows folder, It contains scripts for windows. I dont
>> know
>>> how upto date it is but you can test and give us feedback and if you
>> like,
>>> fix the script if there are errors the same approach highlighted above.
>>> 
>>> Thanks.
>>> 
>>> On Thu, Feb 22, 2018 at 8:19 AM, Piyadassi Shakya <
>> shakyapiyada...@gmail.com
 wrote:
>>> 
 Hi  Awasum
 
 Does this initial-setup.sh works for windows as well as I had been
 executing initial-setup.bat till now.
 
 
 With Regards
 Piyadassi
 
 
 On Thu, Feb 22, 2018 at 12:57 PM, Awasum Yannick <
>> yannickawa...@gmail.com>
 wrote:
 
> ​Hi Bill, Piyadassi,
> 
> The build instructions here :
> https://cwiki.apache.org/confluence/display/FINERACT/
> How+to+build+Fineract+CN
>  How+to+build+Fineract+CN>
> are a little bit outdated.
> 
> What you can do is to update the How To Build Wiki according to your
> research/findings on running Fineract CN.
> 
> An approach you might use is as follows:
> 
> 1.) Refactor/Rewrite a new script base on the initial build script
>> found
> here:
> https://github.com/apache/fineract-cn-demo-server/blob/
> develop/scripts/Unix/initial-setup.sh
> so that it now pulls from Fineract CN repos instead of Mifos IO (Old
>> name
> for the new Architecture, the CN project, Recently donated).
> Here are the new repositories under Apache Infra:
> https://github.com/search?p=3=org%3Aapache+fineract+cn;
 type=Repositories
> 
> 2.) Run and make sure the project builds on your machine. Maybe this
> dependency graph for the Microservices will help you write the the
 script(
> to know which repo to clone before the other). From my small research,
 here
> is the dependency graph inorder: start with: lang, api, cassandra,
 mariadb,
> async, command, test, crypto, anubis, service-starter, identity,
> permitted-feign-client, accounting, customer, provisioner, rhythm,
 office,
> portfolio, deposit-account-management, cheques, teller, payroll, group,
> reporting.
> Try that and let me know if I miss something.
> 
> 3.) You can now update the Wiki page on How to Build Fineract CN
> 
> Not to forget step 0, is for you to have the right prerequisites: Java,
> Spring, Spring boot , annotations and abit familiarity with Spring
>> Cloud.
> Also you need to understand about Microservices and Design Principles
>> in
> the context of Fineract CN. You can start here:
> https://cwiki.apache.org/confluence/display/FINERACT/
> Composing+a+Release+out+of+Microservices
> , https://cwiki.apache.org/confluence/pages/viewpage.
> action?pageId=73634331
> 
> Martin Fowler also has some good articles on the topic, You can begin
 here:
> https://martinfowler.com/articles/microservices.html
> 
> The above might look like alot of work but trust me, when you do the
>> hard
> work, it always pays in ways you can never imagine.
> 
> So keep working and asking questions if you get into issues.
> 
> Thanks,
> Awasum Yannick
> 
> 
> On Thu, Feb 22, 2018 at 5:42 AM, Isaac Kamga <
>> isaac.ka...@skylabase.com>
> wrote:
> 
>> Hi Piyadassi,
>> 
>> The 4th step points you to the initial-setup.sh bash script now
 residing
> on
>> https://github.com/apache/fineract-cn-demo-server/tree/
>> develop/scripts/Unix.
>> That's the script which anyone intending to clone Apache Fineract CN
>> repositories should execute.
>> 
>> At Your Service,
>> Isaac Kamga.
>> 
>> On Thu, Feb 22, 

Releasing Apache Fineract 1.1 WAS [Fwd: Intergration test]

[Ed Cable]

Fineract committers,

Now that the PRs have been submitted for all the outstanding critical bug
fixes and integration test failures, can we please review, merge, and get
the release prepped and call for the vote!

As you know the community has waiting on this for quite some time now and
I"d like to get this shipped and shift focuses to Fineract 1.2

Thanks!

Ed
-- Forwarded message --
From: Ed Cable 
Date: Sun, Feb 18, 2018 at 4:49 AM
Subject: Re: Intergration test
To: Dev 
Cc: Vishwas Babu A J , Nazeer Hussain
Shaik , Kumaranath Fernando <
kumaranathferna...@gmail.com>, Avik Ganguly ,
Nikhil Pawar , Santosh Math <
sant...@confluxtechnologies.com>


Great!

Committers, can you please review?

Nazeer, with this fix and Steve's for the notification, I think we're ready
to move forward. Can you initiate the next steps in the release process?

Thanks,

Ed

On Sat, Feb 17, 2018 at 11:20 AM, Kumaranath Fernando <
kumaranathferna...@gmail.com> wrote:

> Hi Ed!
>
> I've just sent a PR 
> correcting the integration test failures.
>
> Regards,
> Kumaranath Fernando
>
> On Fri, Feb 16, 2018 at 6:14 PM, Ed Cable  wrote:
>
>> Thanks for the feedback Vishwas. Kumaranath, hopefully you have enough to
>> go by now and can make those changes. I believe Steve fixed our other
>> outstanding issue so once we can get these integration tests to pass we'll
>> be ready to call for a vote on the release.
>>
>> Ed
>>
>> On Wed, Feb 14, 2018 at 1:06 PM,  wrote:
>>
>>> The approach of sleeping for a fixed time does not work well in general
>>> as Integration test cases must pass on any environment. Depending on random
>>> sleep values would mean that there is always a probability that the test
>>> can fail if the system is slow / has other CPU intensive processes running
>>> etc.
>>>
>>> Ideally , you would handle such scenarios more gracefully . Have the
>>> test check if the file you are referring to is created , if not sleep for
>>> an interval and check again etc.
>>>
>>> Please make this change and send out a pull request
>>>
>>> Regards,
>>> Vishwas
>>>
>>> On Feb 14, 2018, at 9:39 AM, Kumaranath Fernando <
>>> kumaranathferna...@gmail.com> wrote:
>>>
>>> I've tested the develop branch and it's most likely because the result
>>> excel file takes a bit of time to be created, after the file is created I'm
>>> trying to read a value of a column.
>>> Since the file is not created by the time FileInputStream reads the
>>> file, you get a FileNotException.
>>>
>>> You could fix this issue by increasing the number of milliseconds 1
>>> on Thread.sleep() line in the respective tests.Ping me if this resolves the
>>> issue and I'll send PR.
>>>
>>> Vishwas/Nazeer awaiting your confirmation!.
>>>
>>> Regards,
>>> Kumaranath Fernando
>>>
>>>
>>> On Wed, Feb 14, 2018 at 10:59 AM, vishwas >> om> wrote:
>>>
 Hi Kumaranath,

 You should be able to reproduce this issue if you fetch the latest
 fineract code in a seperate workspace.

 If the remember correctly, the crux of the issue seemed be be that
 files you were referring to in the test cases , i.e
 fineract-provider/src/integrationtest/resources/bulkimport/importhandler/officer
 are not present and all these tests cases throw a file not found exception.

 Regards,
 Vishwas



 > On Feb 13, 2018, at 6:43 PM, Kumaranath Fernando <
 kumaranathferna...@gmail.com> wrote:
 >
 > Hi Nazeer!
 >
 > Could you please send in the stack traces for investigation.
 >
 > Regards,
 > Kumaranath Fernando
 >
 > On Wed, Feb 14, 2018 at 12:43 AM, Ed Cable > wrote:
 >
 >> Please keep the community posted and try to address as quickly as
 you can
 >> we have one other issue we're fixing and then once these integration
 tests
 >> pass, we can call for a vote to ship the release.
 >>
 >> Ed
 >>
 >> On Tue, Feb 13, 2018 at 6:02 AM, Kumaranath Fernando <
 >> kumaranathferna...@gmail.com> wrote:
 >>
 >>> Hello Ed!
 >>>
 >>> Sure. I'll take a look at it!
 >>>
 >>> Regards,
 >>> Kumaranath Fernando
 >>>
 >>> On Tue, Feb 13, 2018 at 11:40 AM, Ed Cable 
 wrote:
 >>>
  Kumaranath,
 
  Could you please look into these failing integration tests? It's
 one of
  the last items we need to address before we can release.
 
  Thanks,
 
  Ed
 
  On Sat, Feb 10, 2018 at 3:15 AM, Nazeer Hussain Shaik <
  nazeerhussain.sh...@gmail.com> wrote:
 
 > Hi Vishwas,
 >