Re: Apache Fineract CN API Documentation

2018-09-04 Thread Isaac Kamga
nd and I have some time today or tomorrow to help and review > > if you all are busy. Let me know > > > > Thanks. > > Awasum > > > > On Thu, Jul 5, 2018 at 4:26 PM Isaac Kamga > wrote: > > > >> Hello there, > >> > >> Trust th

Re: Apache Fineract CN API Documentation

2018-09-03 Thread Awasum Yannick
w > if you all are busy. Let me know > > Thanks. > Awasum > > On Thu, Jul 5, 2018 at 4:26 PM Isaac Kamga wrote: > >> Hello there, >> >> Trust that this email finds you in good health. >> >> I just hosted the Apache Fineract CN API documentation >&g

Re: Apache Fineract CN API Documentation

2018-08-18 Thread Awasum Yannick
llo there, > > Trust that this email finds you in good health. > > I just hosted the Apache Fineract CN API documentation > <http://smartfinance.tech/fineract-cn-api-docs/> which I've been working > on > so Fineracters can view and give some feedback. This will be qu

Re: Apache Fineract CN API Documentation

2018-07-12 Thread James Dailey
gt; <https://www.facebook.com/pactmart> > www.pactmart.com | Freelancing made easy. > > > *“Talk is cheap, show me the code.” *- *Linus Torvalds* > > > > On 5 July 2018 at 19:26, Isaac Kamga wrote: > > > Hello there, > > > > Trust that this e

Re: Apache Fineract CN API Documentation

2018-07-06 Thread Ebenezer Graham
*“Talk is cheap, show me the code.” *- *Linus Torvalds* On 5 July 2018 at 19:26, Isaac Kamga wrote: > Hello there, > > Trust that this email finds you in good health. > > I just hosted the Apache Fineract CN API documentation > <http://smartfinance.tech/fineract-cn

Re: Apache Fineract CN API Documentation

2018-07-06 Thread Ruphine Kengne
On 5 July 2018 at 16:26, Isaac Kamga wrote: > Hello there, > > Trust that this email finds you in good health. > > I just hosted the Apache Fineract CN API documentation > <http://smartfinance.tech/fineract-cn-api-docs/> which I've been working > on > so Fineract

Re: Apache Fineract CN API Documentation

2018-07-05 Thread Isaac Kamga
Hello there, Trust that this email finds you in good health. I just hosted the Apache Fineract CN API documentation <http://smartfinance.tech/fineract-cn-api-docs/> which I've been working on so Fineracters can view and give some feedback. This will be quite helpful for GSoC s

Re: Apache Fineract CN API Documentation

2018-06-28 Thread Isaac Kamga
Hi James, Thanks for your email. Yes, I think the API documentation can be an important part of the Apache Fineract CN project. The document <https://cwiki.apache.org/confluence/display/FINERACT/Apache+Fineract+CN+API+Documentation> I wrote which you quoted above helps anyone genera

Re: Apache Fineract CN API Documentation

2018-06-28 Thread Isaac Kamga
Hello Myrle, Thanks a million for pointing these out. I've updated the Pull request [1] to the fineract-cn-customer repository based on your feedbackI await your review. I added the token, tenant and user to the MockMvc call and also removed the prefix "/customer/v1" from the url's of the en

Re: Apache Fineract CN API Documentation

2018-05-30 Thread Steve Conrad
hread I am trying to follow. Thank you for all the > > work > > > you're putting in, and to Myrle for being a mentor on this work. Seems > > > like it is leading to something really important for the project. > > > > > > I wonder if this < >

Re: Apache Fineract CN API Documentation

2018-05-30 Thread Myrle Krantz
One more note: Isaac, if Seetha wants to help out on this, it would make a lot of sense to create branches in the apache repositories. That way any of us can merge her PR's. I suggest naming the branch FINCN-6. Best Regards, Myrle On Wed, May 30, 2018 at 5:43 PM, Myrle Krantz wrote: > Seetha,

Re: Apache Fineract CN API Documentation

2018-05-30 Thread Myrle Krantz
Seetha, Thank you very much for the offer of help. But if you've looked at Isaac's branch (1) and have concrete ideas on how to do it better, feel free to jump in with suggestions or PRs right away. If you're not sure how to participate, then perhaps wait a little bit longer until Isaac has his

Re: Apache Fineract CN API Documentation

2018-05-30 Thread Myrle Krantz
On Mon, May 28, 2018 at 12:47 PM, Isaac Kamga wrote: > > I've pushed changes to the *PoCFromIsaac* branch of fineract-cn-customer > for > review. Thank you. This is so much easier than guessing. >> Currently my guess is that yo

Re: Apache Fineract CN API Documentation

2018-05-28 Thread Isaac Kamga
The documentation module is still an open question for me. But not > >> because of asynchronous vs synchronous calls. > >> > >> > Thanks for shedding more light on how this works. When I saw how > "easy" > >> it > >> > was to do API calls, I asked m

Re: Apache Fineract CN API Documentation

2018-05-26 Thread Seetha Hegde
- This is a thread I am trying to follow. Thank you for all the >> work >> > you're putting in, and to Myrle for being a mentor on this work. Seems >> > like it is leading to something really important for the project. >> > >> > I wonder if this &

Re: Apache Fineract CN API Documentation

2018-05-26 Thread Ed Cable
nk you for all the > work > > you're putting in, and to Myrle for being a mentor on this work. Seems > > like it is leading to something really important for the project. > > > > I wonder if this < > > > https://cwiki.apache.org/confluence/display/FINERA

Re: Apache Fineract CN API Documentation

2018-05-26 Thread Myrle Krantz
to follow. Thank you for all the work > you're putting in, and to Myrle for being a mentor on this work. Seems > like it is leading to something really important for the project. > > I wonder if this < > https://cwiki.apache.org/confluence/display/FINERACT/Apache+Fineract+

Re: Apache Fineract CN API Documentation

2018-05-26 Thread Myrle Krantz
calls, I asked myself how one could get to intercept >> > information such as the status of a response. Building a new test harness >> > that works with mockmvc can be a daunting task. I hope I can count on >> your >> > help when I run into frustrations. >> >> I'll

Re: Apache Fineract CN API Documentation

2018-05-25 Thread James Dailey
s. When I saw how "easy" > > it > > > was to do API calls, I asked myself how one could get to intercept > > > information such as the status of a response. Building a new test > harness > > > that works with mockmvc can be a daunting task. I hope I can c

Re: Apache Fineract CN API Documentation

2018-05-24 Thread Isaac Kamga
gt; > help when I run into frustrations. > > I'll do what I can, but I don't know mockmvc. I've never used it, > partly because of this problem. > > > So far, I created this document > > <https://cwiki.apache.org/confluence/display/FINERACT/Apache > +Fineract+

Re: Apache Fineract CN API Documentation

2018-05-01 Thread Myrle Krantz
a new test harness > that works with mockmvc can be a daunting task. I hope I can count on your > help when I run into frustrations. I'll do what I can, but I don't know mockmvc. I've never used it, partly because of this problem. > So far, I created this document > <h

Re: Apache Fineract CN API Documentation

2018-05-01 Thread Isaac Kamga
ceed with segregating tests aimed at generating documentation. > > As far as the documentation that is generated by the process, it's > actually just the same information as in the test, but in a different > form. IMO it doesn't make sense to check that in. It's enough

Re: Apache Fineract CN API Documentation

2018-04-30 Thread Myrle Krantz
folder ) given that we don't want .adoc file > and such checked into the repository. > > I await your thoughts on this. > > [1] https://github.com/apache/fineract-cn-customer/pull/7 > [2] > https://cwiki.apache.org/confluence/display/FINERACT/Apache+Fineract+CN+API+Docume

Re: Apache Fineract CN API Documentation

2018-04-27 Thread Isaac Kamga
y. I await your thoughts on this. [1] https://github.com/apache/fineract-cn-customer/pull/7 [2] https://cwiki.apache.org/confluence/display/FINERACT/Apache+Fineract+CN+API+Documentation On Wed, Apr 25, 2018 at 6:09 PM, Isaac Kamga wrote: > Hello Myrle, > > I've done some tinkering

Re: Apache Fineract CN API Documentation

2018-04-25 Thread Isaac Kamga
Hello Myrle, I've done some tinkering and Spring REST Docs can indeed get the snippets generated for documentation in the component-test module. At least, that ensures that there's no need for an architectural change and the service module doesn't depend on the component-test module as Markus advi

Re: Apache Fineract CN API Documentation

2018-04-25 Thread Isaac Kamga
Hi Myrle, Thanks for your elaborate feedback and corrections. On Wed, Apr 25, 2018 at 9:10 AM, Myrle Krantz wrote: > Hey Isaac, > > I've looked at your changes in customer and I've found several > problems with them: > > 1.) You've copied all the component tests out of the component test > modu

Re: Apache Fineract CN API Documentation

2018-04-25 Thread Myrle Krantz
Hey Isaac, I've looked at your changes in customer and I've found several problems with them: 1.) You've copied all the component tests out of the component test module into the service module. This means that identical tests will have to be maintained in two places. Because people aren't very

Apache Fineract CN API Documentation

2018-04-23 Thread Isaac Kamga
Hello everyone, Trust that you're doing great and congratulations to our recently selected GSoC 2018 students. As you may have observed from Gitbox notifications, I have used the MockMvc flavour of Spring Rest Docs to document the APIs for most Finera