[jira] [Commented] (FINERACT-7) Repayment Schedule after waive fee not correct

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795343#comment-15795343
 ] 

ASF GitHub Bot commented on FINERACT-7:
---

Github user abdulazizali77 commented on the issue:

https://github.com/apache/incubator-fineract/pull/256
  
@nazeer1100126 Hi, sorry i didnt run the integration test before. I did 
give the integration tests a run with and without the changes and it seems i 
get identical failures on ClientLoanIntegrationTest (and other tests).
I will ascertain whether the two modified methods in the PR are called 
during any of the integration tests. From first glance however 
testLoanScheduleWithInterestRecalculation_WITH_REST_SAME_AS_REPAYMENT_INTEREST_COMPOUND_NONE_STRATEGY_REDUCE_EMI_WITH_INSTALLMENT_CHARGE
 doesnt seem to be calling Loan.generateInstallmentLoanCharges nor 
LoanCharge.updateInstallmentCharges. (possibly i am wrong)



> Repayment Schedule after waive fee not correct
> --
>
> Key: FINERACT-7
> URL: https://issues.apache.org/jira/browse/FINERACT-7
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Dayna Harp
>Assignee: Markus Geiss
> Attachments: 1.jpg, 2.jpg, 3.jpg
>
>
> https://mifosforge.jira.com/browse/MIFOSX-2495
> After waive installment fee the repayment schedule generated is not proper
> 1. Create Installment fee for a loan as 100-Flat-Regular. 
> 2. Create loan product with following datasets and attache above installment 
> fee to that.
> Terms vary based on loan cycle :  FALSE
> Principal:10,000   ( Min: , Max : )
> Number of Repayments: 12   ( Min: , Max
> Repay Every:  1  Months
> Nominal Interest Rate:1   ( Min: , Max  Per month
> Minimum days between disbursal and first repayment date   
> Amortization  Equal installments
> Interest Method   Declining Balance
> Interest Calculation Period   Daily
> Repayment StrategyOverdue/Due Fee/Int,Principal
> Account moves out of NPA only after all arrears have been cleared?No
> Days in year  Actual
> Days in month Actual
> Principal Threshold (%) for Last Instalment   0
> Allow fixing of the installment amountNo
> Interest Recalculation
> Recalculate Interest  Yes
> Advance payments adjustment type  Reduce number of installments
> Pre-closure interest calculation rule Calculate till pre closure date
> Interest recalculation compounding on None
> Frequency for recalculate Outstanding Principal   Daily
> Frequency Interval for recalculation  1
> Frequency Date for recalculation  01-Jan-15
> Is Arrears recognization based on original schedule:No.
> 3. Submit new loan application on 01 October 2015. Approve and disburse loan 
> on same date.
> 4. Click on waive charge and select for 1st repayment.
> 5. Repayment schedule generated after waive charge is not proper
> >Waive charge is happening not for first installment instead for other 
> >installment it is happening.
> 6. For first repayment the due is getting displayed.
> Attachments here: https://mifosforge.jira.com/browse/MIFOSX-2495



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-7) Repayment Schedule after waive fee not correct

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15772367#comment-15772367
 ] 

ASF GitHub Bot commented on FINERACT-7:
---

Github user nazeer1100126 commented on the issue:

https://github.com/apache/incubator-fineract/pull/256
  
@abdulazizali77 I am seeing following integration test failure with these 
changes 
ClientLoanIntegrationTest.testLoanScheduleWithInterestRecalculation_WITH_REST_SAME_AS_REPAYMENT_INTEREST_COMPOUND_NONE_STRATEGY_REDUCE_EMI_WITH_INSTALLMENT_CHARGE()
Have you run integration tests before sending this PR?


> Repayment Schedule after waive fee not correct
> --
>
> Key: FINERACT-7
> URL: https://issues.apache.org/jira/browse/FINERACT-7
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Dayna Harp
>Assignee: Markus Geiss
> Attachments: 1.jpg, 2.jpg, 3.jpg
>
>
> https://mifosforge.jira.com/browse/MIFOSX-2495
> After waive installment fee the repayment schedule generated is not proper
> 1. Create Installment fee for a loan as 100-Flat-Regular. 
> 2. Create loan product with following datasets and attache above installment 
> fee to that.
> Terms vary based on loan cycle :  FALSE
> Principal:10,000   ( Min: , Max : )
> Number of Repayments: 12   ( Min: , Max
> Repay Every:  1  Months
> Nominal Interest Rate:1   ( Min: , Max  Per month
> Minimum days between disbursal and first repayment date   
> Amortization  Equal installments
> Interest Method   Declining Balance
> Interest Calculation Period   Daily
> Repayment StrategyOverdue/Due Fee/Int,Principal
> Account moves out of NPA only after all arrears have been cleared?No
> Days in year  Actual
> Days in month Actual
> Principal Threshold (%) for Last Instalment   0
> Allow fixing of the installment amountNo
> Interest Recalculation
> Recalculate Interest  Yes
> Advance payments adjustment type  Reduce number of installments
> Pre-closure interest calculation rule Calculate till pre closure date
> Interest recalculation compounding on None
> Frequency for recalculate Outstanding Principal   Daily
> Frequency Interval for recalculation  1
> Frequency Date for recalculation  01-Jan-15
> Is Arrears recognization based on original schedule:No.
> 3. Submit new loan application on 01 October 2015. Approve and disburse loan 
> on same date.
> 4. Click on waive charge and select for 1st repayment.
> 5. Repayment schedule generated after waive charge is not proper
> >Waive charge is happening not for first installment instead for other 
> >installment it is happening.
> 6. For first repayment the due is getting displayed.
> Attachments here: https://mifosforge.jira.com/browse/MIFOSX-2495



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-7) Repayment Schedule after waive fee not correct

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15753549#comment-15753549
 ] 

ASF GitHub Bot commented on FINERACT-7:
---

Github user nazeer1100126 commented on the issue:

https://github.com/apache/incubator-fineract/pull/256
  
@abdulazizali77 we will accept PR(s) with a single commit to maintain 
cleaner history. Can you please send PR with a single commit.


> Repayment Schedule after waive fee not correct
> --
>
> Key: FINERACT-7
> URL: https://issues.apache.org/jira/browse/FINERACT-7
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Dayna Harp
>Assignee: Markus Geiss
> Attachments: 1.jpg, 2.jpg, 3.jpg
>
>
> https://mifosforge.jira.com/browse/MIFOSX-2495
> After waive installment fee the repayment schedule generated is not proper
> 1. Create Installment fee for a loan as 100-Flat-Regular. 
> 2. Create loan product with following datasets and attache above installment 
> fee to that.
> Terms vary based on loan cycle :  FALSE
> Principal:10,000   ( Min: , Max : )
> Number of Repayments: 12   ( Min: , Max
> Repay Every:  1  Months
> Nominal Interest Rate:1   ( Min: , Max  Per month
> Minimum days between disbursal and first repayment date   
> Amortization  Equal installments
> Interest Method   Declining Balance
> Interest Calculation Period   Daily
> Repayment StrategyOverdue/Due Fee/Int,Principal
> Account moves out of NPA only after all arrears have been cleared?No
> Days in year  Actual
> Days in month Actual
> Principal Threshold (%) for Last Instalment   0
> Allow fixing of the installment amountNo
> Interest Recalculation
> Recalculate Interest  Yes
> Advance payments adjustment type  Reduce number of installments
> Pre-closure interest calculation rule Calculate till pre closure date
> Interest recalculation compounding on None
> Frequency for recalculate Outstanding Principal   Daily
> Frequency Interval for recalculation  1
> Frequency Date for recalculation  01-Jan-15
> Is Arrears recognization based on original schedule:No.
> 3. Submit new loan application on 01 October 2015. Approve and disburse loan 
> on same date.
> 4. Click on waive charge and select for 1st repayment.
> 5. Repayment schedule generated after waive charge is not proper
> >Waive charge is happening not for first installment instead for other 
> >installment it is happening.
> 6. For first repayment the due is getting displayed.
> Attachments here: https://mifosforge.jira.com/browse/MIFOSX-2495



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-7) Repayment Schedule after waive fee not correct

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751133#comment-15751133
 ] 

ASF GitHub Bot commented on FINERACT-7:
---

Github user abdulazizali77 commented on a diff in the pull request:

https://github.com/apache/incubator-fineract/pull/256#discussion_r92592186
  
--- Diff: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanCharge.java
 ---
@@ -494,17 +494,29 @@ private void updateInstallmentCharges() {
 this.loanInstallmentCharge.addAll(chargePerInstallments);
 } else {
 int index = 0;
-final LoanInstallmentCharge[] loanChargePerInstallments = new 
LoanInstallmentCharge[chargePerInstallments.size()];
-final LoanInstallmentCharge[] loanChargePerInstallmentArray = 
chargePerInstallments.toArray(loanChargePerInstallments);
-for (final LoanInstallmentCharge chargePerInstallment : 
this.loanInstallmentCharge) {
+//FINERACT-7: NB: this is really overkill and slow, without 
changing the Sets and or Entities this is the most
+//locally safe way to fix this issue
+ArrayList oldChargeInstallments = new 
ArrayList();
+ArrayList newChargeInstallments = new 
ArrayList();
+
+oldChargeInstallments.addAll(this.loanInstallmentCharge);
+newChargeInstallments.addAll(chargePerInstallments);
+Collections.sort(oldChargeInstallments);
+Collections.sort(newChargeInstallments);
+final LoanInstallmentCharge[] loanChargePerInstallmentArray = 
chargePerInstallments.toArray(new 
LoanInstallmentCharge[chargePerInstallments.size()]);
--- End diff --

Youre right, have modified the interface accordingly


> Repayment Schedule after waive fee not correct
> --
>
> Key: FINERACT-7
> URL: https://issues.apache.org/jira/browse/FINERACT-7
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Dayna Harp
>Assignee: Markus Geiss
> Attachments: 1.jpg, 2.jpg, 3.jpg
>
>
> https://mifosforge.jira.com/browse/MIFOSX-2495
> After waive installment fee the repayment schedule generated is not proper
> 1. Create Installment fee for a loan as 100-Flat-Regular. 
> 2. Create loan product with following datasets and attache above installment 
> fee to that.
> Terms vary based on loan cycle :  FALSE
> Principal:10,000   ( Min: , Max : )
> Number of Repayments: 12   ( Min: , Max
> Repay Every:  1  Months
> Nominal Interest Rate:1   ( Min: , Max  Per month
> Minimum days between disbursal and first repayment date   
> Amortization  Equal installments
> Interest Method   Declining Balance
> Interest Calculation Period   Daily
> Repayment StrategyOverdue/Due Fee/Int,Principal
> Account moves out of NPA only after all arrears have been cleared?No
> Days in year  Actual
> Days in month Actual
> Principal Threshold (%) for Last Instalment   0
> Allow fixing of the installment amountNo
> Interest Recalculation
> Recalculate Interest  Yes
> Advance payments adjustment type  Reduce number of installments
> Pre-closure interest calculation rule Calculate till pre closure date
> Interest recalculation compounding on None
> Frequency for recalculate Outstanding Principal   Daily
> Frequency Interval for recalculation  1
> Frequency Date for recalculation  01-Jan-15
> Is Arrears recognization based on original schedule:No.
> 3. Submit new loan application on 01 October 2015. Approve and disburse loan 
> on same date.
> 4. Click on waive charge and select for 1st repayment.
> 5. Repayment schedule generated after waive charge is not proper
> >Waive charge is happening not for first installment instead for other 
> >installment it is happening.
> 6. For first repayment the due is getting displayed.
> Attachments here: https://mifosforge.jira.com/browse/MIFOSX-2495



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-7) Repayment Schedule after waive fee not correct

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725022#comment-15725022
 ] 

ASF GitHub Bot commented on FINERACT-7:
---

GitHub user abdulazizali77 opened a pull request:

https://github.com/apache/incubator-fineract/pull/256

FINERACT-7: Sort loanInstallmentCharges before updating

Less than ideal fix (sorting overhead), but most topically contained. 
Potentially we should change the Sets to Lists, and or redefine the Entities, 
but that would affect too many things.

Have left a potentially iffy corner case in updateInstallmentCharges as is.

Additionally there is a pre-existing defect where a PersistenceException 
caused by an FK constraint is raised when all of the charges are waived. Have 
not investigated, potentially there is an existing bug.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/abdulazizali77/incubator-fineract FINERACT-7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/256.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #256


commit ebea611024d237e5388d5ba987a1798321fbd58f
Author: abdulazizali77 
Date:   2016-12-06T10:09:03Z

FINERACT-7: Make LoanInstallmentCharge and LoanRepaymentSchedule sortable

commit 515a4a28c8a945f35229e7f60098f010091baee3
Author: abdulazizali77 
Date:   2016-12-06T10:10:14Z

FINERACT-7: Sort old loanInstallmentCharges and new lic before updating




> Repayment Schedule after waive fee not correct
> --
>
> Key: FINERACT-7
> URL: https://issues.apache.org/jira/browse/FINERACT-7
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Dayna Harp
>Assignee: Markus Geiss
> Attachments: 1.jpg, 2.jpg, 3.jpg
>
>
> https://mifosforge.jira.com/browse/MIFOSX-2495
> After waive installment fee the repayment schedule generated is not proper
> 1. Create Installment fee for a loan as 100-Flat-Regular. 
> 2. Create loan product with following datasets and attache above installment 
> fee to that.
> Terms vary based on loan cycle :  FALSE
> Principal:10,000   ( Min: , Max : )
> Number of Repayments: 12   ( Min: , Max
> Repay Every:  1  Months
> Nominal Interest Rate:1   ( Min: , Max  Per month
> Minimum days between disbursal and first repayment date   
> Amortization  Equal installments
> Interest Method   Declining Balance
> Interest Calculation Period   Daily
> Repayment StrategyOverdue/Due Fee/Int,Principal
> Account moves out of NPA only after all arrears have been cleared?No
> Days in year  Actual
> Days in month Actual
> Principal Threshold (%) for Last Instalment   0
> Allow fixing of the installment amountNo
> Interest Recalculation
> Recalculate Interest  Yes
> Advance payments adjustment type  Reduce number of installments
> Pre-closure interest calculation rule Calculate till pre closure date
> Interest recalculation compounding on None
> Frequency for recalculate Outstanding Principal   Daily
> Frequency Interval for recalculation  1
> Frequency Date for recalculation  01-Jan-15
> Is Arrears recognization based on original schedule:No.
> 3. Submit new loan application on 01 October 2015. Approve and disburse loan 
> on same date.
> 4. Click on waive charge and select for 1st repayment.
> 5. Repayment schedule generated after waive charge is not proper
> >Waive charge is happening not for first installment instead for other 
> >installment it is happening.
> 6. For first repayment the due is getting displayed.
> Attachments here: https://mifosforge.jira.com/browse/MIFOSX-2495



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-7) Repayment Schedule after waive fee not correct

[Abdul Aziz Ali (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707888#comment-15707888
 ] 

Abdul Aziz Ali commented on FINERACT-7:
---

still reproducible.
Waived charges seem to change everytime a monthly fee is waived

> Repayment Schedule after waive fee not correct
> --
>
> Key: FINERACT-7
> URL: https://issues.apache.org/jira/browse/FINERACT-7
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Dayna Harp
>Assignee: Markus Geiss
>
> https://mifosforge.jira.com/browse/MIFOSX-2495
> After waive installment fee the repayment schedule generated is not proper
> 1. Create Installment fee for a loan as 100-Flat-Regular. 
> 2. Create loan product with following datasets and attache above installment 
> fee to that.
> Terms vary based on loan cycle :  FALSE
> Principal:10,000   ( Min: , Max : )
> Number of Repayments: 12   ( Min: , Max
> Repay Every:  1  Months
> Nominal Interest Rate:1   ( Min: , Max  Per month
> Minimum days between disbursal and first repayment date   
> Amortization  Equal installments
> Interest Method   Declining Balance
> Interest Calculation Period   Daily
> Repayment StrategyOverdue/Due Fee/Int,Principal
> Account moves out of NPA only after all arrears have been cleared?No
> Days in year  Actual
> Days in month Actual
> Principal Threshold (%) for Last Instalment   0
> Allow fixing of the installment amountNo
> Interest Recalculation
> Recalculate Interest  Yes
> Advance payments adjustment type  Reduce number of installments
> Pre-closure interest calculation rule Calculate till pre closure date
> Interest recalculation compounding on None
> Frequency for recalculate Outstanding Principal   Daily
> Frequency Interval for recalculation  1
> Frequency Date for recalculation  01-Jan-15
> Is Arrears recognization based on original schedule:No.
> 3. Submit new loan application on 01 October 2015. Approve and disburse loan 
> on same date.
> 4. Click on waive charge and select for 1st repayment.
> 5. Repayment schedule generated after waive charge is not proper
> >Waive charge is happening not for first installment instead for other 
> >installment it is happening.
> 6. For first repayment the due is getting displayed.
> Attachments here: https://mifosforge.jira.com/browse/MIFOSX-2495



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)